Skip to content

[Impeller] limit mipmap generation #165357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Mar 18, 2025
Merged

[Impeller] limit mipmap generation #165357

auto-submit merged 1 commit into from
Mar 18, 2025

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Mar 18, 2025 •
edited
Loading

Fixes #161283

When generating mipmaps, as soon as we hit a dimension (x,y) of 1, stop generating mipmaps. This is done by changing the mip computation to use min instead of max - but also adds a short circuit too.

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Mar 18, 2025
@jonahwilliams jonahwilliams requested a review from gaaclarke March 18, 2025 00:08
gaaclarke
gaaclarke approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 18, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Mar 18, 2025
Merged via the queue into flutter:master with commit 6328b7e Mar 18, 2025
169 of 170 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
8b872eb
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
2d481bf
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
abe4b00
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
acef186
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
1ecc030
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
e2c6913
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
ff38cf1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
9b29de3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
5962077
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
8ba7833
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
717609c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
1c57ef7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
c99a966
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
d25e312
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
9c92b16
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
ed8f095
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
24232dc
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
b813bda
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
95c10be
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
214cc2d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
0958af5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
608b780
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
dd519ad
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
acb3dce
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
c9087c4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
acff72c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
90d08a8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
63993b8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
bf12ec9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
d47af09
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
c6340d3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
9766efe
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
e03430a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
d91f908
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
f77022b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
37a577e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
1322059
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
6328b7e [Impeller] limit mipmap generation (flutter/flutter#165357)
a2559ea
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@romanejaquez
[Impeller] limit mipmap generation (flutter#165357)
a837d92 
Fixes flutter#161283

When generating mipmaps, as soon as we hit a dimension (x,y) of 1, stop
generating mipmaps. This is done by changing the mip computation to use
min instead of max - but also adds a short circuit too.
This was referenced Aug 15, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaaclarke gaaclarke gaaclarke approved these changes

Assignees

No one assigned

Labels

e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Impeller] re-enable runtime mipmap generation on Adreno GPU.

2 participants

@jonahwilliams @gaaclarke