Skip to content

Revert "[skwasm] Dynamic Threading (#164748)" #165350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Mar 18, 2025
Merged

Revert "[skwasm] Dynamic Threading (#164748)" #165350

auto-submit merged 1 commit into from
Mar 18, 2025

Conversation

@eyebrowsoffire
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire commented Mar 17, 2025

This reverts commit b2a4a05.

This has been causing issues when rolling to flutter/packages repo. See #165347.

@eyebrowsoffire
Revert "[skwasm] Dynamic Threading (flutter#164748)"
04652f9 
This reverts commit b2a4a05.

This has been causing issues when rolling to flutter/packages repo.
See flutter#165347.
@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 17, 2025

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. platform-web Web applications specifically labels Mar 17, 2025
camsim99
camsim99 approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eyebrowsoffire eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 17, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Mar 17, 2025
Merged via the queue into flutter:master with commit 1d954f4 Mar 18, 2025
170 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 18, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 20, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 20, 2025
@engine-flutter-autoroll
1d954f4 Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutte…
92061ab 
…r#165350)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
1d954f4 Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutte…
361cf63 
…r#165350)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
1d954f4 Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutte…
a4f9a40 
…r#165350)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
1d954f4 Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutte…
0f2ae85 
…r#165350)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
1d954f4 Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutte…
2802c11 
…r#165350)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
1d954f4 Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutte…
a99eaf2 
…r#165350)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
1d954f4 Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutte…
1536e27 
…r#165350)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
1d954f4 Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutte…
27f92cc 
…r#165350)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
1d954f4 Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutte…
636924c 
…r#165350)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
1d954f4 Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutte…
2a9fe00 
…r#165350)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
1d954f4 Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutte…
0895aed 
…r#165350)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
1d954f4 Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutte…
ae2b636 
…r#165350)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
1d954f4 Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutte…
cc2b028 
…r#165350)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
1d954f4 Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutte…
c5980bb 
…r#165350)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
1d954f4 Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutte…
79188f0 
…r#165350)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
1d954f4 Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutte…
b1c9cc3 
…r#165350)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
1d954f4 Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutte…
d1ff32e 
…r#165350)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
1d954f4 Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutte…
6933e65 
…r#165350)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
1d954f4 Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutte…
b2fb57a 
…r#165350)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
1d954f4 Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutte…
82c3a41 
…r#165350)
stuartmorgan-g pushed a commit to flutter/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
Manual roll Flutter from b16430b to 1d954f4 (114 revisions) (#8922)
a1b1cf1 
Manual roll Flutter from b16430b to 1d954f4 (114 revisions)

Manual roll requested by [email protected]

flutter/flutter@b16430b...1d954f4

2025-03-17 [email protected] Revert "[skwasm] Dynamic Threading
(#164748)" (flutter/flutter#165350)
2025-03-17 [email protected] Roll Skia from fa669e2e6d12
to 52130e5c3b34 (4 revisions) (flutter/flutter#165348)
2025-03-17 [email protected]
`OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal`
rebuilds. (flutter/flutter#165331)
2025-03-17 [email protected] [web][a11y]Delete
_childContainerElement (flutter/flutter#163662)
2025-03-17 [email protected] Roll Skia from e45207898e60
to fa669e2e6d12 (8 revisions) (flutter/flutter#165342)
2025-03-17 [email protected] Add documentation for Java test
filtering to plugins test document (flutter/flutter#165314)
2025-03-17 [email protected] Roll Fuchsia Linux SDK from
SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313)
2025-03-17 [email protected] Roll Dart SDK from
9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310)
2025-03-17 [email protected] feat(Tooltip): replace the height parameter
with constraints (flutter/flutter#163314)
2025-03-17 [email protected] Fix arrowHeadColor breaks differentiation
between states (flutter/flutter#165178)
2025-03-17 [email protected] Removes
assumption that basis scalar and rounded_scalar match
(flutter/flutter#165166)
2025-03-17 [email protected] Roll Skia from 69cf4c2c5db8
to e45207898e60 (1 revision) (flutter/flutter#165300)
2025-03-17 [email protected] Refactor: Move
sliders value indicator shape to seperate file (flutter/flutter#162858)
2025-03-17 [email protected] Roll Skia from 3931c31032c7
to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288)
2025-03-17 [email protected] Delete
`docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258)
2025-03-16 [email protected] Roll Skia from 3413a02d6fc8
to 3931c31032c7 (1 revision) (flutter/flutter#165277)
2025-03-16 [email protected] Roll Fuchsia Linux SDK from
LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275)
2025-03-16 [email protected] Roll Dart SDK from
067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269)
2025-03-16 [email protected] Roll Skia from f124daeb564d
to 3413a02d6fc8 (1 revision) (flutter/flutter#165263)
2025-03-15 [email protected] Roll Dart SDK from
40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262)
2025-03-15 [email protected] Roll Fuchsia Linux SDK from
efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252)
2025-03-15 [email protected] Roll Dart SDK from
f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250)
2025-03-15 [email protected] Roll Dart SDK from
8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246)
2025-03-15 [email protected] Roll Skia from 4568e766ed0a
to f124daeb564d (1 revision) (flutter/flutter#165245)
2025-03-15 [email protected] Revert "Prevent
explicit roles from merging (#164732)" (flutter/flutter#165222)
2025-03-15 [email protected] Roll Skia from bac6e76abfc7
to 4568e766ed0a (5 revisions) (flutter/flutter#165241)
2025-03-14 [email protected] Roll Dart SDK from
a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227)
2025-03-14 [email protected] Roll Skia from 98b6922deecf
to bac6e76abfc7 (5 revisions) (flutter/flutter#165225)
2025-03-14 [email protected] Point ktlint AS
docs to the `.editorconfig` that is actually used by ci, instead of
making a copy in the README (flutter/flutter#165213)
2025-03-14 [email protected] Add remaining dart fixes for Color
deprecations when importing painting.dart (flutter/flutter#162609)
2025-03-14 [email protected] [Accessibility]
Add required semantics flags (flutter/flutter#164585)
2025-03-14 [email protected] Roll Skia from f4467ff38f1f
to 98b6922deecf (5 revisions) (flutter/flutter#165215)
2025-03-14 [email protected] Convert `BaseFlutterTask` From Groovy
to Kotlin (flutter/flutter#163148)
2025-03-14 [email protected]
`OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034)
2025-03-14 [email protected] Remove redundant `useMaterial3: true`
(flutter/flutter#163376)
2025-03-14 [email protected] Roll Packages from
9cc6f37 to ff7724c (1 revision) (flutter/flutter#165197)
2025-03-14 [email protected] Changelog updates
from 3.29.2 (flutter/flutter#165194)
2025-03-14 [email protected] Roll Dart SDK from
576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191)
2025-03-14 [email protected] Roll Dart SDK from
ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180)
2025-03-14 [email protected] Roll Fuchsia Linux SDK from
qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175)
2025-03-14 [email protected] [Impeller] Enable mediatek on API
34+. (flutter/flutter#165156)
2025-03-14 [email protected] Roll Dart SDK from
cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159)
2025-03-13 [email protected] [FGP conversion]
Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143)
2025-03-13 [email protected] Prevent explicit
roles from merging (flutter/flutter#164732)
...
vashworth pushed a commit to vashworth/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll @vashworth
Manual roll Flutter from b16430b to 1d954f4 (114 revisions) (flutter#…
88d5013 
…8922)

Manual roll Flutter from b16430b to 1d954f4 (114 revisions)

Manual roll requested by [email protected]

flutter/flutter@b16430b...1d954f4

2025-03-17 [email protected] Revert "[skwasm] Dynamic Threading
(#164748)" (flutter/flutter#165350)
2025-03-17 [email protected] Roll Skia from fa669e2e6d12
to 52130e5c3b34 (4 revisions) (flutter/flutter#165348)
2025-03-17 [email protected]
`OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal`
rebuilds. (flutter/flutter#165331)
2025-03-17 [email protected] [web][a11y]Delete
_childContainerElement (flutter/flutter#163662)
2025-03-17 [email protected] Roll Skia from e45207898e60
to fa669e2e6d12 (8 revisions) (flutter/flutter#165342)
2025-03-17 [email protected] Add documentation for Java test
filtering to plugins test document (flutter/flutter#165314)
2025-03-17 [email protected] Roll Fuchsia Linux SDK from
SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313)
2025-03-17 [email protected] Roll Dart SDK from
9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310)
2025-03-17 [email protected] feat(Tooltip): replace the height parameter
with constraints (flutter/flutter#163314)
2025-03-17 [email protected] Fix arrowHeadColor breaks differentiation
between states (flutter/flutter#165178)
2025-03-17 [email protected] Removes
assumption that basis scalar and rounded_scalar match
(flutter/flutter#165166)
2025-03-17 [email protected] Roll Skia from 69cf4c2c5db8
to e45207898e60 (1 revision) (flutter/flutter#165300)
2025-03-17 [email protected] Refactor: Move
sliders value indicator shape to seperate file (flutter/flutter#162858)
2025-03-17 [email protected] Roll Skia from 3931c31032c7
to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288)
2025-03-17 [email protected] Delete
`docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258)
2025-03-16 [email protected] Roll Skia from 3413a02d6fc8
to 3931c31032c7 (1 revision) (flutter/flutter#165277)
2025-03-16 [email protected] Roll Fuchsia Linux SDK from
LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275)
2025-03-16 [email protected] Roll Dart SDK from
067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269)
2025-03-16 [email protected] Roll Skia from f124daeb564d
to 3413a02d6fc8 (1 revision) (flutter/flutter#165263)
2025-03-15 [email protected] Roll Dart SDK from
40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262)
2025-03-15 [email protected] Roll Fuchsia Linux SDK from
efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252)
2025-03-15 [email protected] Roll Dart SDK from
f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250)
2025-03-15 [email protected] Roll Dart SDK from
8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246)
2025-03-15 [email protected] Roll Skia from 4568e766ed0a
to f124daeb564d (1 revision) (flutter/flutter#165245)
2025-03-15 [email protected] Revert "Prevent
explicit roles from merging (#164732)" (flutter/flutter#165222)
2025-03-15 [email protected] Roll Skia from bac6e76abfc7
to 4568e766ed0a (5 revisions) (flutter/flutter#165241)
2025-03-14 [email protected] Roll Dart SDK from
a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227)
2025-03-14 [email protected] Roll Skia from 98b6922deecf
to bac6e76abfc7 (5 revisions) (flutter/flutter#165225)
2025-03-14 [email protected] Point ktlint AS
docs to the `.editorconfig` that is actually used by ci, instead of
making a copy in the README (flutter/flutter#165213)
2025-03-14 [email protected] Add remaining dart fixes for Color
deprecations when importing painting.dart (flutter/flutter#162609)
2025-03-14 [email protected] [Accessibility]
Add required semantics flags (flutter/flutter#164585)
2025-03-14 [email protected] Roll Skia from f4467ff38f1f
to 98b6922deecf (5 revisions) (flutter/flutter#165215)
2025-03-14 [email protected] Convert `BaseFlutterTask` From Groovy
to Kotlin (flutter/flutter#163148)
2025-03-14 [email protected]
`OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034)
2025-03-14 [email protected] Remove redundant `useMaterial3: true`
(flutter/flutter#163376)
2025-03-14 [email protected] Roll Packages from
9cc6f37 to ff7724c (1 revision) (flutter/flutter#165197)
2025-03-14 [email protected] Changelog updates
from 3.29.2 (flutter/flutter#165194)
2025-03-14 [email protected] Roll Dart SDK from
576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191)
2025-03-14 [email protected] Roll Dart SDK from
ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180)
2025-03-14 [email protected] Roll Fuchsia Linux SDK from
qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175)
2025-03-14 [email protected] [Impeller] Enable mediatek on API
34+. (flutter/flutter#165156)
2025-03-14 [email protected] Roll Dart SDK from
cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159)
2025-03-13 [email protected] [FGP conversion]
Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143)
2025-03-13 [email protected] Prevent explicit
roles from merging (flutter/flutter#164732)
...
eyebrowsoffire added a commit to eyebrowsoffire/flutter that referenced this pull request Apr 2, 2025
@eyebrowsoffire
Reland "[skwasm] Dynamic Threading"
2095101 
This is a reland of flutter#164748, which was
reverted here: flutter#165350

It was reverted due to some issues in the flutter packages roller: flutter#165347

The unit test in flutter/packages was modified to be more deterministic and less affected by minor timing differences: flutter/packages#8920

So this is basically being relanded without any significant changes, since the downstream tests have been fixed.
@eyebrowsoffire eyebrowsoffire mentioned this pull request Apr 2, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Apr 2, 2025
@eyebrowsoffire
Reland "[skwasm] Dynamic Threading" (#166454)
34ea67b 
This is a reland of #164748,
which was reverted here: #165350

It was reverted due to some issues in the flutter packages roller:
#165347

The unit test in flutter/packages was modified to be more deterministic
and less affected by minor timing differences:
flutter/packages#8920

So this is basically being relanded without any significant changes,
since the downstream tests have been fixed.
eyebrowsoffire added a commit to eyebrowsoffire/flutter that referenced this pull request Apr 5, 2025
@eyebrowsoffire
Reland "[skwasm] Dynamic Threading"
d551517 
This is a reland of flutter#164748, which was
reverted here: flutter#165350

It was reverted due to some issues in the flutter packages roller: flutter#165347

The unit test in flutter/packages was modified to be more deterministic and less affected by minor timing differences: flutter/packages#8920

So this is basically being relanded without any significant changes, since the downstream tests have been fixed.
CodixNinja pushed a commit to CodixNinja/packages that referenced this pull request May 15, 2025
@engine-flutter-autoroll
Manual roll Flutter from b16430b2fd57 to 1d954f4e96bd (114 revisions)…
b6536bc 
… (#8922)

Manual roll Flutter from b16430b2fd57 to 1d954f4e96bd (114 revisions)

Manual roll requested by [email protected]

flutter/flutter@b16430b...1d954f4

2025-03-17 [email protected] Revert "[skwasm] Dynamic Threading
(#164748)" (flutter/flutter#165350)
2025-03-17 [email protected] Roll Skia from fa669e2e6d12
to 52130e5c3b34 (4 revisions) (flutter/flutter#165348)
2025-03-17 [email protected]
`OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal`
rebuilds. (flutter/flutter#165331)
2025-03-17 [email protected] [web][a11y]Delete
_childContainerElement (flutter/flutter#163662)
2025-03-17 [email protected] Roll Skia from e45207898e60
to fa669e2e6d12 (8 revisions) (flutter/flutter#165342)
2025-03-17 [email protected] Add documentation for Java test
filtering to plugins test document (flutter/flutter#165314)
2025-03-17 [email protected] Roll Fuchsia Linux SDK from
SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313)
2025-03-17 [email protected] Roll Dart SDK from
9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310)
2025-03-17 [email protected] feat(Tooltip): replace the height parameter
with constraints (flutter/flutter#163314)
2025-03-17 [email protected] Fix arrowHeadColor breaks differentiation
between states (flutter/flutter#165178)
2025-03-17 [email protected] Removes
assumption that basis scalar and rounded_scalar match
(flutter/flutter#165166)
2025-03-17 [email protected] Roll Skia from 69cf4c2c5db8
to e45207898e60 (1 revision) (flutter/flutter#165300)
2025-03-17 [email protected] Refactor: Move
sliders value indicator shape to seperate file (flutter/flutter#162858)
2025-03-17 [email protected] Roll Skia from 3931c31032c7
to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288)
2025-03-17 [email protected] Delete
`docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258)
2025-03-16 [email protected] Roll Skia from 3413a02d6fc8
to 3931c31032c7 (1 revision) (flutter/flutter#165277)
2025-03-16 [email protected] Roll Fuchsia Linux SDK from
LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275)
2025-03-16 [email protected] Roll Dart SDK from
067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269)
2025-03-16 [email protected] Roll Skia from f124daeb564d
to 3413a02d6fc8 (1 revision) (flutter/flutter#165263)
2025-03-15 [email protected] Roll Dart SDK from
40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262)
2025-03-15 [email protected] Roll Fuchsia Linux SDK from
efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252)
2025-03-15 [email protected] Roll Dart SDK from
f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250)
2025-03-15 [email protected] Roll Dart SDK from
8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246)
2025-03-15 [email protected] Roll Skia from 4568e766ed0a
to f124daeb564d (1 revision) (flutter/flutter#165245)
2025-03-15 [email protected] Revert "Prevent
explicit roles from merging (#164732)" (flutter/flutter#165222)
2025-03-15 [email protected] Roll Skia from bac6e76abfc7
to 4568e766ed0a (5 revisions) (flutter/flutter#165241)
2025-03-14 [email protected] Roll Dart SDK from
a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227)
2025-03-14 [email protected] Roll Skia from 98b6922deecf
to bac6e76abfc7 (5 revisions) (flutter/flutter#165225)
2025-03-14 [email protected] Point ktlint AS
docs to the `.editorconfig` that is actually used by ci, instead of
making a copy in the README (flutter/flutter#165213)
2025-03-14 [email protected] Add remaining dart fixes for Color
deprecations when importing painting.dart (flutter/flutter#162609)
2025-03-14 [email protected] [Accessibility]
Add required semantics flags (flutter/flutter#164585)
2025-03-14 [email protected] Roll Skia from f4467ff38f1f
to 98b6922deecf (5 revisions) (flutter/flutter#165215)
2025-03-14 [email protected] Convert `BaseFlutterTask` From Groovy
to Kotlin (flutter/flutter#163148)
2025-03-14 [email protected]
`OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034)
2025-03-14 [email protected] Remove redundant `useMaterial3: true`
(flutter/flutter#163376)
2025-03-14 [email protected] Roll Packages from
bdb9c96 to d632936 (1 revision) (flutter/flutter#165197)
2025-03-14 [email protected] Changelog updates
from 3.29.2 (flutter/flutter#165194)
2025-03-14 [email protected] Roll Dart SDK from
576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191)
2025-03-14 [email protected] Roll Dart SDK from
ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180)
2025-03-14 [email protected] Roll Fuchsia Linux SDK from
qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175)
2025-03-14 [email protected] [Impeller] Enable mediatek on API
34+. (flutter/flutter#165156)
2025-03-14 [email protected] Roll Dart SDK from
cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159)
2025-03-13 [email protected] [FGP conversion]
Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143)
2025-03-13 [email protected] Prevent explicit
roles from merging (flutter/flutter#164732)
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
1d954f4 Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutte…
a62b7f3 
…r#165350)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
1d954f4 Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutte…
bd95a15 
…r#165350)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
1d954f4 Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutte…
d614f23 
…r#165350)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Manual roll Flutter from b16430b to 1d954f4 (114 revisions) (flutter#…
a06362c 
…8922)

Manual roll Flutter from b16430b to 1d954f4 (114 revisions)

Manual roll requested by [email protected]

flutter/flutter@b16430b...1d954f4

2025-03-17 [email protected] Revert "[skwasm] Dynamic Threading
(#164748)" (flutter/flutter#165350)
2025-03-17 [email protected] Roll Skia from fa669e2e6d12
to 52130e5c3b34 (4 revisions) (flutter/flutter#165348)
2025-03-17 [email protected]
`OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal`
rebuilds. (flutter/flutter#165331)
2025-03-17 [email protected] [web][a11y]Delete
_childContainerElement (flutter/flutter#163662)
2025-03-17 [email protected] Roll Skia from e45207898e60
to fa669e2e6d12 (8 revisions) (flutter/flutter#165342)
2025-03-17 [email protected] Add documentation for Java test
filtering to plugins test document (flutter/flutter#165314)
2025-03-17 [email protected] Roll Fuchsia Linux SDK from
SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313)
2025-03-17 [email protected] Roll Dart SDK from
9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310)
2025-03-17 [email protected] feat(Tooltip): replace the height parameter
with constraints (flutter/flutter#163314)
2025-03-17 [email protected] Fix arrowHeadColor breaks differentiation
between states (flutter/flutter#165178)
2025-03-17 [email protected] Removes
assumption that basis scalar and rounded_scalar match
(flutter/flutter#165166)
2025-03-17 [email protected] Roll Skia from 69cf4c2c5db8
to e45207898e60 (1 revision) (flutter/flutter#165300)
2025-03-17 [email protected] Refactor: Move
sliders value indicator shape to seperate file (flutter/flutter#162858)
2025-03-17 [email protected] Roll Skia from 3931c31032c7
to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288)
2025-03-17 [email protected] Delete
`docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258)
2025-03-16 [email protected] Roll Skia from 3413a02d6fc8
to 3931c31032c7 (1 revision) (flutter/flutter#165277)
2025-03-16 [email protected] Roll Fuchsia Linux SDK from
LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275)
2025-03-16 [email protected] Roll Dart SDK from
067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269)
2025-03-16 [email protected] Roll Skia from f124daeb564d
to 3413a02d6fc8 (1 revision) (flutter/flutter#165263)
2025-03-15 [email protected] Roll Dart SDK from
40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262)
2025-03-15 [email protected] Roll Fuchsia Linux SDK from
efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252)
2025-03-15 [email protected] Roll Dart SDK from
f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250)
2025-03-15 [email protected] Roll Dart SDK from
8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246)
2025-03-15 [email protected] Roll Skia from 4568e766ed0a
to f124daeb564d (1 revision) (flutter/flutter#165245)
2025-03-15 [email protected] Revert "Prevent
explicit roles from merging (#164732)" (flutter/flutter#165222)
2025-03-15 [email protected] Roll Skia from bac6e76abfc7
to 4568e766ed0a (5 revisions) (flutter/flutter#165241)
2025-03-14 [email protected] Roll Dart SDK from
a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227)
2025-03-14 [email protected] Roll Skia from 98b6922deecf
to bac6e76abfc7 (5 revisions) (flutter/flutter#165225)
2025-03-14 [email protected] Point ktlint AS
docs to the `.editorconfig` that is actually used by ci, instead of
making a copy in the README (flutter/flutter#165213)
2025-03-14 [email protected] Add remaining dart fixes for Color
deprecations when importing painting.dart (flutter/flutter#162609)
2025-03-14 [email protected] [Accessibility]
Add required semantics flags (flutter/flutter#164585)
2025-03-14 [email protected] Roll Skia from f4467ff38f1f
to 98b6922deecf (5 revisions) (flutter/flutter#165215)
2025-03-14 [email protected] Convert `BaseFlutterTask` From Groovy
to Kotlin (flutter/flutter#163148)
2025-03-14 [email protected]
`OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034)
2025-03-14 [email protected] Remove redundant `useMaterial3: true`
(flutter/flutter#163376)
2025-03-14 [email protected] Roll Packages from
9cc6f37 to ff7724c (1 revision) (flutter/flutter#165197)
2025-03-14 [email protected] Changelog updates
from 3.29.2 (flutter/flutter#165194)
2025-03-14 [email protected] Roll Dart SDK from
576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191)
2025-03-14 [email protected] Roll Dart SDK from
ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180)
2025-03-14 [email protected] Roll Fuchsia Linux SDK from
qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175)
2025-03-14 [email protected] [Impeller] Enable mediatek on API
34+. (flutter/flutter#165156)
2025-03-14 [email protected] Roll Dart SDK from
cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159)
2025-03-13 [email protected] [FGP conversion]
Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143)
2025-03-13 [email protected] Prevent explicit
roles from merging (flutter/flutter#164732)
...
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
@eyebrowsoffire
Reland "[skwasm] Dynamic Threading" (flutter#166454)
43ca43a 
This is a reland of flutter#164748,
which was reverted here: flutter#165350

It was reverted due to some issues in the flutter packages roller:
flutter#165347

The unit test in flutter/packages was modified to be more deterministic
and less affected by minor timing differences:
flutter/packages#8920

So this is basically being relanded without any significant changes,
since the downstream tests have been fixed.
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Manual roll Flutter from b16430b to 1d954f4 (114 revisions) (flutter#…
19d634b 
…8922)

Manual roll Flutter from b16430b to 1d954f4 (114 revisions)

Manual roll requested by [email protected]

flutter/flutter@b16430b...1d954f4

2025-03-17 [email protected] Revert "[skwasm] Dynamic Threading
(#164748)" (flutter/flutter#165350)
2025-03-17 [email protected] Roll Skia from fa669e2e6d12
to 52130e5c3b34 (4 revisions) (flutter/flutter#165348)
2025-03-17 [email protected]
`OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal`
rebuilds. (flutter/flutter#165331)
2025-03-17 [email protected] [web][a11y]Delete
_childContainerElement (flutter/flutter#163662)
2025-03-17 [email protected] Roll Skia from e45207898e60
to fa669e2e6d12 (8 revisions) (flutter/flutter#165342)
2025-03-17 [email protected] Add documentation for Java test
filtering to plugins test document (flutter/flutter#165314)
2025-03-17 [email protected] Roll Fuchsia Linux SDK from
SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313)
2025-03-17 [email protected] Roll Dart SDK from
9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310)
2025-03-17 [email protected] feat(Tooltip): replace the height parameter
with constraints (flutter/flutter#163314)
2025-03-17 [email protected] Fix arrowHeadColor breaks differentiation
between states (flutter/flutter#165178)
2025-03-17 [email protected] Removes
assumption that basis scalar and rounded_scalar match
(flutter/flutter#165166)
2025-03-17 [email protected] Roll Skia from 69cf4c2c5db8
to e45207898e60 (1 revision) (flutter/flutter#165300)
2025-03-17 [email protected] Refactor: Move
sliders value indicator shape to seperate file (flutter/flutter#162858)
2025-03-17 [email protected] Roll Skia from 3931c31032c7
to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288)
2025-03-17 [email protected] Delete
`docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258)
2025-03-16 [email protected] Roll Skia from 3413a02d6fc8
to 3931c31032c7 (1 revision) (flutter/flutter#165277)
2025-03-16 [email protected] Roll Fuchsia Linux SDK from
LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275)
2025-03-16 [email protected] Roll Dart SDK from
067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269)
2025-03-16 [email protected] Roll Skia from f124daeb564d
to 3413a02d6fc8 (1 revision) (flutter/flutter#165263)
2025-03-15 [email protected] Roll Dart SDK from
40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262)
2025-03-15 [email protected] Roll Fuchsia Linux SDK from
efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252)
2025-03-15 [email protected] Roll Dart SDK from
f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250)
2025-03-15 [email protected] Roll Dart SDK from
8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246)
2025-03-15 [email protected] Roll Skia from 4568e766ed0a
to f124daeb564d (1 revision) (flutter/flutter#165245)
2025-03-15 [email protected] Revert "Prevent
explicit roles from merging (#164732)" (flutter/flutter#165222)
2025-03-15 [email protected] Roll Skia from bac6e76abfc7
to 4568e766ed0a (5 revisions) (flutter/flutter#165241)
2025-03-14 [email protected] Roll Dart SDK from
a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227)
2025-03-14 [email protected] Roll Skia from 98b6922deecf
to bac6e76abfc7 (5 revisions) (flutter/flutter#165225)
2025-03-14 [email protected] Point ktlint AS
docs to the `.editorconfig` that is actually used by ci, instead of
making a copy in the README (flutter/flutter#165213)
2025-03-14 [email protected] Add remaining dart fixes for Color
deprecations when importing painting.dart (flutter/flutter#162609)
2025-03-14 [email protected] [Accessibility]
Add required semantics flags (flutter/flutter#164585)
2025-03-14 [email protected] Roll Skia from f4467ff38f1f
to 98b6922deecf (5 revisions) (flutter/flutter#165215)
2025-03-14 [email protected] Convert `BaseFlutterTask` From Groovy
to Kotlin (flutter/flutter#163148)
2025-03-14 [email protected]
`OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034)
2025-03-14 [email protected] Remove redundant `useMaterial3: true`
(flutter/flutter#163376)
2025-03-14 [email protected] Roll Packages from
9cc6f37 to ff7724c (1 revision) (flutter/flutter#165197)
2025-03-14 [email protected] Changelog updates
from 3.29.2 (flutter/flutter#165194)
2025-03-14 [email protected] Roll Dart SDK from
576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191)
2025-03-14 [email protected] Roll Dart SDK from
ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180)
2025-03-14 [email protected] Roll Fuchsia Linux SDK from
qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175)
2025-03-14 [email protected] [Impeller] Enable mediatek on API
34+. (flutter/flutter#165156)
2025-03-14 [email protected] Roll Dart SDK from
cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159)
2025-03-13 [email protected] [FGP conversion]
Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143)
2025-03-13 [email protected] Prevent explicit
roles from merging (flutter/flutter#164732)
...
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@eyebrowsoffire @romanejaquez
Revert "[skwasm] Dynamic Threading (flutter#164748)" (flutter#165350)
f8ceb55 
This reverts commit b2a4a05.

This has been causing issues when rolling to flutter/packages repo. See
flutter#165347.
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@eyebrowsoffire @romanejaquez
Reland "[skwasm] Dynamic Threading" (flutter#166454)
617aec3 
This is a reland of flutter#164748,
which was reverted here: flutter#165350

It was reverted due to some issues in the flutter packages roller:
flutter#165347

The unit test in flutter/packages was modified to be more deterministic
and less affected by minor timing differences:
flutter/packages#8920

So this is basically being relanded without any significant changes,
since the downstream tests have been fixed.
@eyebrowsoffire eyebrowsoffire deleted the skwasm_dynamic_threading_revert branch December 12, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camsim99 camsim99 camsim99 approved these changes

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels. platform-web Web applications specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eyebrowsoffire @camsim99