-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Fix CODEOWNERS after monorepo merge #165217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I wonder if you could have removed the "/" from the start of the lines and gotten the same effect. |
|
@jtmcdole Sadly that wouldn't work, see the description above:
|
jmagman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @loic-sharma!
jtmcdole
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub's CODEOWNERS feature [picks the first file it finds in the root, `.github/`, or `docs/` directory](https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#codeowners-file-location). GitHub does not support nested CODEOWNERS files. For example, this PR updates the embedder API but did not request reviews from the embedder API reviewers: flutter#164577 To fix this, this merges all `CODEOWNERS` files to the root of the repo. cc @cbracken @chinmaygarde @jmagman as you are added as CODEOWNERS.
GitHub's CODEOWNERS feature [picks the first file it finds in the root, `.github/`, or `docs/` directory](https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#codeowners-file-location). GitHub does not support nested CODEOWNERS files. For example, this PR updates the embedder API but did not request reviews from the embedder API reviewers: flutter#164577 To fix this, this merges all `CODEOWNERS` files to the root of the repo. cc @cbracken @chinmaygarde @jmagman as you are added as CODEOWNERS.

GitHub's CODEOWNERS feature picks the first file it finds in the root,
.github/, ordocs/directory. GitHub does not support nested CODEOWNERS files.For example, this PR updates the embedder API but did not request reviews from the embedder API reviewers: #164577
To fix this, this merges all
CODEOWNERSfiles to the root of the repo.cc @cbracken @chinmaygarde @jmagman as you are added as CODEOWNERS.