Skip to content

[Impeller] Return an empty contents in Paint::CreateContents if a runtime effect sampler is invalid #165165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Mar 18, 2025
Merged

[Impeller] Return an empty contents in Paint::CreateContents if a runtime effect sampler is invalid #165165

auto-submit merged 3 commits into from
Mar 18, 2025

Conversation

@jason-simmons
Copy link
Member

@jason-simmons jason-simmons commented Mar 14, 2025

Callers of Paint::CreateContents expect that the result is not null.

See #165119

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Mar 14, 2025
jonahwilliams
jonahwilliams approved these changes Mar 14, 2025
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jason-simmons
[Impeller] Return an empty contents in Paint::CreateContents if a run…
e1a6b93 
…time effect sampler is invalid

Callers of Paint::CreateContents expect that the result is not null.

See flutter#165119
@jason-simmons
disable validation log in test
0dc740c
@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 18, 2025

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #165165 at sha 40691c4

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Mar 18, 2025
@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 18, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Mar 18, 2025
Merged via the queue into flutter:master with commit 5f0b94f Mar 18, 2025
172 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
683d545 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
8e80f4f 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
78d6866 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
d9d8f3e 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
5460f7c 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
dc5a51a 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
915e609 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
b6be6e3 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
2a2e79a 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
110a71c 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
b875446 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
0f06d6c 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
28394bb 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
c5d366e 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
f27cb05 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
dbe4f6f 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
88f6600 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
536f78e 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
e031ad2 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
c0bb032 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
e3f69af 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
cf1df9b 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
a2cc3c7 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
465f59c 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
7ccb8d7 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
cb4caec 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
347349c 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
05ada73 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
64402cf 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
cc9b5b3 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
5d32b9e 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
f874fab 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
35d83f5 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
f194309 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
f6facee 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
5d5908c 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
4afddf1 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
5f0b94f [Impeller] Return an empty contents in Paint::CreateContents …
fac8f9f 
…if a runtime effect sampler is invalid (flutter/flutter#165165)
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@jason-simmons @romanejaquez
[Impeller] Return an empty contents in Paint::CreateContents if a run…
3ed0147 
…time effect sampler is invalid (flutter#165165)

Callers of Paint::CreateContents expect that the result is not null.

See flutter#165119
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels. will affect goldens Changes to golden files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jason-simmons @jonahwilliams