Skip to content

[tools, web] Make sure to copy the dump-info file if dump-info is used #165013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Mar 11, 2025
Merged

[tools, web] Make sure to copy the dump-info file if dump-info is used #165013

auto-submit merged 2 commits into from
Mar 11, 2025

Conversation

@kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Mar 11, 2025

Also fixed the wording of the dump-info build flag

@kevmoo
[tools, web] Make sure to copy the dump-info file if dump-info is used
67b4896 
Also fixed the wording of the dump-info build flag
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 11, 2025
kevmoo
kevmoo commented Mar 11, 2025
View reviewed changes
packages/flutter_tools/test/general.shard/build_system/targets/web_test.dart

await WebReleaseBundle(<WebCompilerConfig>[const JsCompilerConfig()]).build(environment);
await WebReleaseBundle(<WebCompilerConfig>[
const JsCompilerConfig(dumpInfo: true),
Copy link
Contributor Author

@kevmoo kevmoo Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seemed...easier to just tweak the default test here.

happy to copy-paste if wanted

yjbanov
yjbanov approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 11, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Mar 11, 2025
Merged via the queue into flutter:master with commit 292496f Mar 11, 2025
134 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 11, 2025
@kevmoo kevmoo deleted the web_fix_dump_info_output branch March 11, 2025 23:37
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
21e4d49 
…o is used (flutter/flutter#165013)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
0ec9480 
…o is used (flutter/flutter#165013)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
d336f60 
…o is used (flutter/flutter#165013)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
c9b90c3 
…o is used (flutter/flutter#165013)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
b87f04b 
…o is used (flutter/flutter#165013)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
2060f35 
…o is used (flutter/flutter#165013)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
5a94645 
…o is used (flutter/flutter#165013)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
1179f88 
…o is used (flutter/flutter#165013)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
30aceea 
…o is used (flutter/flutter#165013)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
ef5fb77 
…o is used (flutter/flutter#165013)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
40fe6e7 
…o is used (flutter/flutter#165013)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
94fa620 
…o is used (flutter/flutter#165013)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
201882b 
…o is used (flutter/flutter#165013)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
7246d55 
…o is used (flutter/flutter#165013)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 17, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
07060c9 
…o is used (flutter/flutter#165013)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 20, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
82a9b80 
…o is used (flutter/flutter#165013)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
27721eb 
…o is used (flutter/flutter#165013)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
a3a94ad 
…o is used (flutter/flutter#165013)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
923fab6 
…o is used (flutter/flutter#165013)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
10508df 
…o is used (flutter/flutter#165013)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
c88db6c 
…o is used (flutter/flutter#165013)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
820066e 
…o is used (flutter/flutter#165013)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
7df7503 
…o is used (flutter/flutter#165013)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
45f6eed 
…o is used (flutter/flutter#165013)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
f647f19 
…o is used (flutter/flutter#165013)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
3a5c4b5 
…o is used (flutter/flutter#165013)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
68bf3e5 
…o is used (flutter/flutter#165013)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
d1a68a3 
…o is used (flutter/flutter#165013)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
0ca02ef 
…o is used (flutter/flutter#165013)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
8611da4 
…o is used (flutter/flutter#165013)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
a69fbe8 
…o is used (flutter/flutter#165013)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
f437a3f 
…o is used (flutter/flutter#165013)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
8f28210 
…o is used (flutter/flutter#165013)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
4ff689f 
…o is used (flutter/flutter#165013)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
89ed6cb 
…o is used (flutter/flutter#165013)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
a3761ce 
…o is used (flutter/flutter#165013)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
34848c9 
…o is used (flutter/flutter#165013)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
292496f [tools, web] Make sure to copy the dump-info file if dump-inf…
7d536df 
…o is used (flutter/flutter#165013)
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@kevmoo @romanejaquez
[tools, web] Make sure to copy the dump-info file if dump-info is used (
2cce55d 
flutter#165013)

Also fixed the wording of the dump-info build flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yjbanov yjbanov yjbanov approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kevmoo @yjbanov