Skip to content

Consolidate GTK mocks #164890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hbatagelo merged 3 commits into from
Mar 11, 2025
Merged

Consolidate GTK mocks #164890

hbatagelo merged 3 commits into from
Mar 11, 2025

Conversation

@robert-ancell
Copy link
Contributor

@robert-ancell robert-ancell commented Mar 10, 2025

This was split across three files, consolidate into one.

@robert-ancell
Consolidate GTK mocks
a54a84d 
This was split across three files, consolidate into one.
@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. platform-linux Building on or for Linux specifically a: desktop Running on desktop labels Mar 10, 2025
hbatagelo
hbatagelo requested changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@hbatagelo hbatagelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The only thing left is renaming the header guards for mock_gtk.h.

@robert-ancell robert-ancell requested a review from hbatagelo March 10, 2025 21:52
@hbatagelo hbatagelo enabled auto-merge March 11, 2025 13:06
@hbatagelo hbatagelo added this pull request to the merge queue Mar 11, 2025
Merged via the queue into flutter:master with commit 39dc571 Mar 11, 2025
170 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
e172afc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
686cb1b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
5bbae99
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
ff00731
This was referenced Mar 11, 2025
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
ac05c44
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
e872e78
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
a49b2f3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
5bff406
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
7ce3e59
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
56dc992
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
5f37f00
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
88a40fc
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 17, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
d0ff030
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 20, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
f62a05c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
e2f5358
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
289fc94
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
6b23001
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
93c40c9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
b8f1730
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
062763e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
1e78ecd
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
017ff37
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
dc74f68
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
adcc47f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
227e987
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
c32ee7d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
06d7c9a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
2365a23
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
fd6e366
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
accf062
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
9712b6b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
4b4bc4a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
d1d226c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
1967f10
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
501c9b8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
39dc571 Consolidate GTK mocks (flutter/flutter#164890)
1ce42e1
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@robert-ancell @hbatagelo @romanejaquez
Consolidate GTK mocks (flutter#164890)
bf6836e 
This was split across three files, consolidate into one.

---------

Co-authored-by: Harlen Batagelo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hbatagelo hbatagelo hbatagelo approved these changes

@mattkae mattkae Awaiting requested review from mattkae

Assignees

No one assigned

Labels

a: desktop Running on desktop a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. platform-linux Building on or for Linux specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robert-ancell @hbatagelo