-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Make LLDB check a warning instead of a failure #164828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| if (srcRoot == null) { | ||
| throw MissingDefineException(kSdkRoot, name); | ||
| environment.logger.printError('Failed to find $srcRoot'); | ||
| return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change this one? It looks like the unpack ios target throws a missing define exception for this case too:
flutter/packages/flutter_tools/lib/src/build_system/targets/ios.dart
Lines 265 to 268 in cd433d4
| final String? sdkRoot = environment.defines[kSdkRoot]; | |
| if (sdkRoot == null) { | |
| throw MissingDefineException(kSdkRoot, name); | |
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be safe. Basically, if this target fails, we don't want it to stop the build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I would keep the exceptions for things that are unexpected and indicate a bug in our logic that we should investigate. I don't feel strongly though, feel free to keep as is.
| throwsToolExit( | ||
| message: 'Debugging Flutter on new iOS versions requires an LLDB Init File.', | ||
| ), | ||
| buffer.toString(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Silly nit: could push the .toString() to capturedConsolePrint's implementation. This might be nice if we end up using capturedConsolePrint in more locations in the future. I don't feel strongly, feel free to skip
We added LLDB file in flutter#164344. This adjusts it so if the LLDB file is missing it gives a warning rather than an error that fails the build. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
We added LLDB file in #164344. This adjusts it so if the LLDB file is missing it gives a warning rather than an error that fails the build.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.