Skip to content

[Impeller] add capability check for extended range formats. #164817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Mar 8, 2025
Merged

[Impeller] add capability check for extended range formats. #164817

auto-submit merged 2 commits into from
Mar 8, 2025

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Mar 7, 2025

Fixes #164794

We support devices that do not support XR formats. If we try to decode to an XR format this will fail at runtime.

@jonahwilliams jonahwilliams requested a review from gaaclarke March 7, 2025 21:07
gaaclarke
gaaclarke approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 7, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 7, 2025

autosubmit label was removed for flutter/flutter/164817, because - The status or check suite Windows windows_host_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 7, 2025
@github-actions github-actions bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Mar 7, 2025
@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 8, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Mar 8, 2025
Merged via the queue into flutter:master with commit a7e276a Mar 8, 2025
177 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 8, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2025
@engine-flutter-autoroll
a7e276a [Impeller] add capability check for extended range formats. (f…
e10ae3c 
…lutter/flutter#164817)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2025
@engine-flutter-autoroll
a7e276a [Impeller] add capability check for extended range formats. (f…
c2cb5f4 
…lutter/flutter#164817)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2025
@engine-flutter-autoroll
a7e276a [Impeller] add capability check for extended range formats. (f…
58a92ff 
…lutter/flutter#164817)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2025
@engine-flutter-autoroll
a7e276a [Impeller] add capability check for extended range formats. (f…
8e95def 
…lutter/flutter#164817)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2025
@engine-flutter-autoroll
a7e276a [Impeller] add capability check for extended range formats. (f…
ec2a24e 
…lutter/flutter#164817)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2025
@engine-flutter-autoroll
a7e276a [Impeller] add capability check for extended range formats. (f…
6111ec0 
…lutter/flutter#164817)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2025
@engine-flutter-autoroll
a7e276a [Impeller] add capability check for extended range formats. (f…
1758f9c 
…lutter/flutter#164817)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2025
Merged
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Mar 10, 2025
@engine-flutter-autoroll
Roll Flutter from 6b93cf9 to b16430b (21 revisions) (#8845)
c392bfe 
flutter/flutter@6b93cf9...b16430b

2025-03-10 [email protected] [macOS] Enable Impeller by default on macOS. (flutter/flutter#164572)
2025-03-10 [email protected] Roll Packages from 4c5a7ed to 464cea5 (5 revisions) (flutter/flutter#164904)
2025-03-10 [email protected] Roll Skia from f17d37ee0ac6 to 4ac86f17f2d4 (1 revision) (flutter/flutter#164893)
2025-03-10 [email protected] Roll Skia from 0f53870c7449 to f17d37ee0ac6 (1 revision) (flutter/flutter#164887)
2025-03-09 [email protected] Roll Fuchsia Linux SDK from 6tAcm4hdtXPE55GJP... to U-zlyIZrZRbr9I6gv... (flutter/flutter#164868)
2025-03-09 [email protected] Roll Skia from 345dc2d05dcd to 0f53870c7449 (1 revision) (flutter/flutter#164865)
2025-03-08 [email protected] Roll Skia from 916caa2f0102 to 345dc2d05dcd (1 revision) (flutter/flutter#164843)
2025-03-08 [email protected] Roll Fuchsia Linux SDK from ixl5bKWCqsRiYGvps... to 6tAcm4hdtXPE55GJP... (flutter/flutter#164838)
2025-03-08 [email protected] Roll Skia from b29851b2ada6 to 916caa2f0102 (1 revision) (flutter/flutter#164835)
2025-03-08 [email protected] [Impeller] add capability check for extended range formats. (flutter/flutter#164817)
2025-03-08 [email protected] Added calendar delegate to support custom calendar systems (flutter/flutter#161874)
2025-03-08 [email protected] RoundSuperellipse algorithm v3: Ultrawideband heuristic formula (flutter/flutter#164755)
2025-03-08 [email protected] Merge CHANGELOG for 3.29.1 stable release  (flutter/flutter#164743)
2025-03-08 [email protected] Add and link to `Infra-Triage.md`. (flutter/flutter#164673)
2025-03-07 [email protected] Roll Skia from cbc7e99d6c2f to b29851b2ada6 (10 revisions) (flutter/flutter#164812)
2025-03-07 [email protected] [Impeller] dont redundantly set stencil reference on vulkan backend. (flutter/flutter#164763)
2025-03-07 [email protected] content-aware-hash experiment update (flutter/flutter#164803)
2025-03-07 [email protected] [Widget Inspector] Handle null exceptions calling `renderObject` (flutter/flutter#163642)
2025-03-07 [email protected] Use Python 3.12 to run the yapf formatter if no lower version is available (flutter/flutter#164807)
2025-03-07 [email protected] Roll gn to 7a8aa3a08a13521336853a28c46537ec04338a2d (flutter/flutter#164806)
2025-03-07 [email protected] [Impeller] Store the TextureGLES cached framebuffer object as a reactor handle (flutter/flutter#164761)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@Jasperscheper
Copy link

Jasperscheper commented Apr 1, 2025

Hi Flutter team!
When will this fix become available in a stable release? 😄
We are blocked from upgrading to 3.29, due to the iPad Air2 crashing.

Thanks for all the effort so far!

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
a7e276a [Impeller] add capability check for extended range formats. (f…
91fb3a7 
…lutter/flutter#164817)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
a7e276a [Impeller] add capability check for extended range formats. (f…
458c4f0 
…lutter/flutter#164817)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
a7e276a [Impeller] add capability check for extended range formats. (f…
4175f3b 
…lutter/flutter#164817)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Roll Flutter from 6b93cf9 to b16430b (21 revisions) (flutter#8845)
4d4e0f7 
flutter/flutter@6b93cf9...b16430b

2025-03-10 [email protected] [macOS] Enable Impeller by default on macOS. (flutter/flutter#164572)
2025-03-10 [email protected] Roll Packages from 4c5a7ed to 464cea5 (5 revisions) (flutter/flutter#164904)
2025-03-10 [email protected] Roll Skia from f17d37ee0ac6 to 4ac86f17f2d4 (1 revision) (flutter/flutter#164893)
2025-03-10 [email protected] Roll Skia from 0f53870c7449 to f17d37ee0ac6 (1 revision) (flutter/flutter#164887)
2025-03-09 [email protected] Roll Fuchsia Linux SDK from 6tAcm4hdtXPE55GJP... to U-zlyIZrZRbr9I6gv... (flutter/flutter#164868)
2025-03-09 [email protected] Roll Skia from 345dc2d05dcd to 0f53870c7449 (1 revision) (flutter/flutter#164865)
2025-03-08 [email protected] Roll Skia from 916caa2f0102 to 345dc2d05dcd (1 revision) (flutter/flutter#164843)
2025-03-08 [email protected] Roll Fuchsia Linux SDK from ixl5bKWCqsRiYGvps... to 6tAcm4hdtXPE55GJP... (flutter/flutter#164838)
2025-03-08 [email protected] Roll Skia from b29851b2ada6 to 916caa2f0102 (1 revision) (flutter/flutter#164835)
2025-03-08 [email protected] [Impeller] add capability check for extended range formats. (flutter/flutter#164817)
2025-03-08 [email protected] Added calendar delegate to support custom calendar systems (flutter/flutter#161874)
2025-03-08 [email protected] RoundSuperellipse algorithm v3: Ultrawideband heuristic formula (flutter/flutter#164755)
2025-03-08 [email protected] Merge CHANGELOG for 3.29.1 stable release  (flutter/flutter#164743)
2025-03-08 [email protected] Add and link to `Infra-Triage.md`. (flutter/flutter#164673)
2025-03-07 [email protected] Roll Skia from cbc7e99d6c2f to b29851b2ada6 (10 revisions) (flutter/flutter#164812)
2025-03-07 [email protected] [Impeller] dont redundantly set stencil reference on vulkan backend. (flutter/flutter#164763)
2025-03-07 [email protected] content-aware-hash experiment update (flutter/flutter#164803)
2025-03-07 [email protected] [Widget Inspector] Handle null exceptions calling `renderObject` (flutter/flutter#163642)
2025-03-07 [email protected] Use Python 3.12 to run the yapf formatter if no lower version is available (flutter/flutter#164807)
2025-03-07 [email protected] Roll gn to 7a8aa3a08a13521336853a28c46537ec04338a2d (flutter/flutter#164806)
2025-03-07 [email protected] [Impeller] Store the TextureGLES cached framebuffer object as a reactor handle (flutter/flutter#164761)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Roll Flutter from 6b93cf9 to b16430b (21 revisions) (flutter#8845)
61c2196 
flutter/flutter@6b93cf9...b16430b

2025-03-10 [email protected] [macOS] Enable Impeller by default on macOS. (flutter/flutter#164572)
2025-03-10 [email protected] Roll Packages from 4c5a7ed to 464cea5 (5 revisions) (flutter/flutter#164904)
2025-03-10 [email protected] Roll Skia from f17d37ee0ac6 to 4ac86f17f2d4 (1 revision) (flutter/flutter#164893)
2025-03-10 [email protected] Roll Skia from 0f53870c7449 to f17d37ee0ac6 (1 revision) (flutter/flutter#164887)
2025-03-09 [email protected] Roll Fuchsia Linux SDK from 6tAcm4hdtXPE55GJP... to U-zlyIZrZRbr9I6gv... (flutter/flutter#164868)
2025-03-09 [email protected] Roll Skia from 345dc2d05dcd to 0f53870c7449 (1 revision) (flutter/flutter#164865)
2025-03-08 [email protected] Roll Skia from 916caa2f0102 to 345dc2d05dcd (1 revision) (flutter/flutter#164843)
2025-03-08 [email protected] Roll Fuchsia Linux SDK from ixl5bKWCqsRiYGvps... to 6tAcm4hdtXPE55GJP... (flutter/flutter#164838)
2025-03-08 [email protected] Roll Skia from b29851b2ada6 to 916caa2f0102 (1 revision) (flutter/flutter#164835)
2025-03-08 [email protected] [Impeller] add capability check for extended range formats. (flutter/flutter#164817)
2025-03-08 [email protected] Added calendar delegate to support custom calendar systems (flutter/flutter#161874)
2025-03-08 [email protected] RoundSuperellipse algorithm v3: Ultrawideband heuristic formula (flutter/flutter#164755)
2025-03-08 [email protected] Merge CHANGELOG for 3.29.1 stable release  (flutter/flutter#164743)
2025-03-08 [email protected] Add and link to `Infra-Triage.md`. (flutter/flutter#164673)
2025-03-07 [email protected] Roll Skia from cbc7e99d6c2f to b29851b2ada6 (10 revisions) (flutter/flutter#164812)
2025-03-07 [email protected] [Impeller] dont redundantly set stencil reference on vulkan backend. (flutter/flutter#164763)
2025-03-07 [email protected] content-aware-hash experiment update (flutter/flutter#164803)
2025-03-07 [email protected] [Widget Inspector] Handle null exceptions calling `renderObject` (flutter/flutter#163642)
2025-03-07 [email protected] Use Python 3.12 to run the yapf formatter if no lower version is available (flutter/flutter#164807)
2025-03-07 [email protected] Roll gn to 7a8aa3a08a13521336853a28c46537ec04338a2d (flutter/flutter#164806)
2025-03-07 [email protected] [Impeller] Store the TextureGLES cached framebuffer object as a reactor handle (flutter/flutter#164761)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@romanejaquez
[Impeller] add capability check for extended range formats. (flutter#…
900ba87 
…164817)

Fixes flutter#164794

We support devices that do not support XR formats. If we try to decode
to an XR format this will fail at runtime.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaaclarke gaaclarke gaaclarke approved these changes

Assignees

No one assigned

Labels

e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Impeller] Missing capability check for decoding image to wide pixel format / crash on iPad Air2.

3 participants

@jonahwilliams @Jasperscheper @gaaclarke