[DisplayList] DlPath supports generic path dispatching #164753

flar · 2025-03-07T00:16:37Z

There are different ways to iterate over an SkPath or an impeller::Path and various points in the engine source tree we have boilerplate duplicates of this code to transfer the contents of the DlPath wrapper object into some platform-specific path. This PR adds a dispatch/receiver mechanism to read back the contents of a DlPath - independent of whether it is backed by an SkPath or an impeller::Path - in a simpler form that avoids potential mistakes in the various conversion methods.

See DlPathReceiver and DlPath::Dispatch in the dl_path.h file

flar · 2025-03-07T07:41:09Z

~~I still have to change all of the path conversion methods sprinkled here and there to use the new mechanism.~~

Done. There were only 2 which seemed odd. I just went and looked at all of the code that handles clip mutators and noticed that most platforms either NOP a path clip or they just get the bounds and treat it like a clipRect. Well, at least now they have a simpler interface to deal with when we decide to add path support to the other platforms.

engine/src/flutter/display_list/geometry/dl_path.h

engine/src/flutter/shell/platform/android/platform_view_android_jni_impl.cc

engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm

engine/src/flutter/display_list/geometry/dl_path.cc

gaaclarke

I looked over the dispatching stuff, LGTM. I didn't do a full review since other people were looking at it before me. There isn't a test so this is just a refactor?

flar · 2025-03-08T01:42:41Z

I looked over the dispatching stuff, LGTM. I didn't do a full review since other people were looking at it before me. There isn't a test so this is just a refactor?

Pretty much a refactor, and well covered by other tests, but it does introduce a new public method so there probably should be tests. I'll work on some.

flar · 2025-03-08T06:28:50Z

Unit tests now added

flar · 2025-03-08T07:48:01Z

This PR should be in its final state now.

gaaclarke

Okay I gave it a complete look. I have 2 suggestions which you are free to ignore and one that should get fixed, the argument comments are in the wrong format.

gaaclarke · 2025-03-10T16:20:25Z

engine/src/flutter/display_list/geometry/dl_path.cc

        FML_DCHECK(contour != nullptr);
        if (subpath_needs_close) {
-          sk_path.close();
+          receiver.Close();


No action required: It's not in the c++ style guide but when calling virtual methods it's safer to use -> since if you accidentally get a value instead of a reference you'll get incorrect behavior.

How? -> doesn't even compile.

You have to switch from using references to using pointers.

That would add the burden of implicitly accepting null values which must be checked. I don't understand the "value vs reference" issue and the incorrect behavior it leads to.

When you have a reference in C++ it isn't guaranteed to not be null. You still technically have to consider null values, we just are ignoring that.

That's a big TIL. I see so many comments here and there that references cannot ever be null, but I'm guessing you can fudge it with *pointer_that_is_null?

Perhaps clang-tidy might complain (if it is run)?

but I'm guessing you can fudge it with *pointer_that_is_null?

Yep, exactly and we do this in our codebase all the time. A linter that disallowed references to anything on the heap would be nice, I don't think it exists. That's how I personally use them.

I'll file this under "wishing C++ would throw if you create a reference by dereferencing a nulllptr".

gaaclarke · 2025-03-10T16:24:13Z

engine/src/flutter/display_list/geometry/dl_path_unittests.cc

+  const DlScalar weight;
+};
+
+class TestPathReceiver : public DlPathReceiver {


no action required: This class should just be a gmock.

I took a quick look at gmock just now, but it seems focused on just asserting that methods are called whereas this class is checking the data they are called with.

There are hundreds of examples of using gmock to check the arguments of function calls in our codebase. Here is one example:

flutter/engine/src/flutter/shell/platform/android/external_view_embedder/external_view_embedder_unittests.cc

Line 288 in b16430b

EXPECT_CALL(*surface_mock, AcquireFrame(frame_size))

This is asserting that AcquireFrame with arguments that equal frame_size.

I don't understand the formatting used there, it looks like it is placing expectations on return values, but my methods are all void and I'm placing expectations on the data they receive. Again, maybe that's in there, but I'd need to study gmock further - likely worth the work.

Maybe this one is easier to see:

flutter/engine/src/flutter/impeller/renderer/backend/gles/unique_handle_gles_unittests.cc

Line 29 in b16430b

EXPECT_CALL(*mock_gles_impl, GenTextures(1, _)).Times(1);

This is asserting that GenTextures is being called with 2 arguments, the first one must be 1 the second can be anything ("_" is a wildcard matcher).

I think this would be a good opportunity to learn how to use gmock. It's a very useful skill and I'm happy to help.

There are so many similar classes I've written in the unit tests, time to look into that mechanism.

TIL-gmock. The tests are slightly more wordy, but the intent is outlined in the test itself and the mock receiver class was 100x simpler than the tester harness class.

See also #165336

engine/src/flutter/display_list/geometry/dl_path_unittests.cc

…er/flutter#164753)

This PR adds `Path.addRSuperellipse` to `dart:ui`. This is needed to implement a parity class to `RoundedRectangleBorder` as discussed [here](#164857 (comment)). <details> <summary> Obsolete description, no longer applicable </summary> I want to reuse the existing algorithm created for impeller stroking. The existing algorithm is moved from `path_builder.cc` to `round_superellipse_param.cc`, and a delegated is added so that the same algorithm can output for different path classes. I'm not 100% sure this is _the_ best way to implement this, but I've tried some methods in vain. * `DlPathReceiver` added in #164753 sounds like a similar concept as the delegate created in this PR. I tried to use that but not only are the methods private, they're neither in an accessible directory. * I also thought of converting an impeller `Path` to a skia path, but it seems that the impeller path isn't designed to be traversed. * Another possibility is that we refactor impeller stroking to be based on the triangles instead of path, a direction we agreed to eventually move toward, which allows avoiding code share at all. I've briefly read the code in `StrokePathGeometry` and have some ideas but also something uncertain, so I didn't choose this path for now. </details> ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…er/flutter#164753)

This PR adds `Path.addRSuperellipse` to `dart:ui`. This is needed to implement a parity class to `RoundedRectangleBorder` as discussed [here](flutter#164857 (comment)). <details> <summary> Obsolete description, no longer applicable </summary> I want to reuse the existing algorithm created for impeller stroking. The existing algorithm is moved from `path_builder.cc` to `round_superellipse_param.cc`, and a delegated is added so that the same algorithm can output for different path classes. I'm not 100% sure this is _the_ best way to implement this, but I've tried some methods in vain. * `DlPathReceiver` added in flutter#164753 sounds like a similar concept as the delegate created in this PR. I tried to use that but not only are the methods private, they're neither in an accessible directory. * I also thought of converting an impeller `Path` to a skia path, but it seems that the impeller path isn't designed to be traversed. * Another possibility is that we refactor impeller stroking to be based on the triangles instead of path, a direction we agreed to eventually move toward, which allows avoiding code share at all. I've briefly read the code in `StrokePathGeometry` and have some ideas but also something uncertain, so I didn't choose this path for now. </details> ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

There are different ways to iterate over an SkPath or an impeller::Path and various points in the engine source tree we have boilerplate duplicates of this code to transfer the contents of the DlPath wrapper object into some platform-specific path. This PR adds a dispatch/receiver mechanism to read back the contents of a DlPath - independent of whether it is backed by an SkPath or an impeller::Path - in a simpler form that avoids potential mistakes in the various conversion methods. See DlPathReceiver and DlPath::Dispatch in the dl_path.h file

This PR adds `Path.addRSuperellipse` to `dart:ui`. This is needed to implement a parity class to `RoundedRectangleBorder` as discussed [here](flutter#164857 (comment)). <details> <summary> Obsolete description, no longer applicable </summary> I want to reuse the existing algorithm created for impeller stroking. The existing algorithm is moved from `path_builder.cc` to `round_superellipse_param.cc`, and a delegated is added so that the same algorithm can output for different path classes. I'm not 100% sure this is _the_ best way to implement this, but I've tried some methods in vain. * `DlPathReceiver` added in flutter#164753 sounds like a similar concept as the delegate created in this PR. I tried to use that but not only are the methods private, they're neither in an accessible directory. * I also thought of converting an impeller `Path` to a skia path, but it seems that the impeller path isn't designed to be traversed. * Another possibility is that we refactor impeller stroking to be based on the triangles instead of path, a direction we agreed to eventually move toward, which allows avoiding code share at all. I've briefly read the code in `StrokePathGeometry` and have some ideas but also something uncertain, so I didn't choose this path for now. </details> ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

github-actions bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Mar 7, 2025

flar marked this pull request as ready for review March 7, 2025 07:40

flar requested a review from jonahwilliams March 7, 2025 07:40

flar force-pushed the path-consumer branch from ae8f777 to d9d6b27 Compare March 7, 2025 09:02

github-actions bot added platform-android Android applications specifically platform-ios iOS applications specifically team-ios Owned by iOS platform team labels Mar 7, 2025

flar commented Mar 7, 2025

View reviewed changes

engine/src/flutter/display_list/geometry/dl_path.h Outdated Show resolved Hide resolved

flar commented Mar 7, 2025

View reviewed changes

engine/src/flutter/shell/platform/android/platform_view_android_jni_impl.cc Outdated Show resolved Hide resolved

flar commented Mar 7, 2025

View reviewed changes

engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm Outdated Show resolved Hide resolved

flar commented Mar 7, 2025

View reviewed changes

engine/src/flutter/display_list/geometry/dl_path.cc Outdated Show resolved Hide resolved

gmackall mentioned this pull request Mar 7, 2025

[hcpp] Support fillType in ClipPath mutator #164808

Closed

flar mentioned this pull request Mar 7, 2025

Android PlatformView creates inaccurate path for RoundRect clips #164595

Open

flar requested a review from gaaclarke March 7, 2025 23:26

gaaclarke reviewed Mar 8, 2025

View reviewed changes

engine/src/flutter/display_list/geometry/dl_path.cc Outdated Show resolved Hide resolved

gaaclarke reviewed Mar 8, 2025

View reviewed changes

engine/src/flutter/display_list/geometry/dl_path.cc Outdated Show resolved Hide resolved

gaaclarke reviewed Mar 8, 2025

View reviewed changes

gaaclarke reviewed Mar 10, 2025

View reviewed changes

flar added 7 commits March 17, 2025 10:58

[DisplayList] DlPath supports generic path dispatching

5c16fe1

convert iOS/Android platform view code to use path dispatch

68ab295

add follow-on issue links and remove obsolete shift parameter

124f14b

switch to virtual class for receiver implementation

48391b2

anonymous namespace usage and undo virtual inheritance

7f52560

remove unnecessary friend declaration

2284ccf

unit tests for path receiver and field naming compliance

21d9fc2

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

c4d8870 [DisplayList] DlPath supports generic path dispatching (flutt…

2001670

…er/flutter#164753)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

c4d8870 [DisplayList] DlPath supports generic path dispatching (flutt…

0adb32a

…er/flutter#164753)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025

c4d8870 [DisplayList] DlPath supports generic path dispatching (flutt…

b828352

…er/flutter#164753)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025

c4d8870 [DisplayList] DlPath supports generic path dispatching (flutt…

7efa8e3

…er/flutter#164753)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025

c4d8870 [DisplayList] DlPath supports generic path dispatching (flutt…

c47a29e

…er/flutter#164753)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025

c4d8870 [DisplayList] DlPath supports generic path dispatching (flutt…

86e202c

…er/flutter#164753)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025

c4d8870 [DisplayList] DlPath supports generic path dispatching (flutt…

a306444

…er/flutter#164753)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025

c4d8870 [DisplayList] DlPath supports generic path dispatching (flutt…

cd348b7

…er/flutter#164753)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025

c4d8870 [DisplayList] DlPath supports generic path dispatching (flutt…

e81b615

…er/flutter#164753)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025

c4d8870 [DisplayList] DlPath supports generic path dispatching (flutt…

ea007e5

…er/flutter#164753)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

c4d8870 [DisplayList] DlPath supports generic path dispatching (flutt…

23e622d

…er/flutter#164753)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

c4d8870 [DisplayList] DlPath supports generic path dispatching (flutt…

09125a9

…er/flutter#164753)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

c4d8870 [DisplayList] DlPath supports generic path dispatching (flutt…

4377081

…er/flutter#164753)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

c4d8870 [DisplayList] DlPath supports generic path dispatching (flutt…

f4174b8

…er/flutter#164753)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

c4d8870 [DisplayList] DlPath supports generic path dispatching (flutt…

5513fc1

…er/flutter#164753)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

c4d8870 [DisplayList] DlPath supports generic path dispatching (flutt…

c3578d5

…er/flutter#164753)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

c4d8870 [DisplayList] DlPath supports generic path dispatching (flutt…

67ed76c

…er/flutter#164753)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025

c4d8870 [DisplayList] DlPath supports generic path dispatching (flutt…

2c0ea71

…er/flutter#164753)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025

c4d8870 [DisplayList] DlPath supports generic path dispatching (flutt…

d9bc9bd

…er/flutter#164753)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025

c4d8870 [DisplayList] DlPath supports generic path dispatching (flutt…

1eee1c8

…er/flutter#164753)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025

c4d8870 [DisplayList] DlPath supports generic path dispatching (flutt…

b01ff22

…er/flutter#164753)

flar mentioned this pull request Apr 2, 2025

[Impeller] Render conics without conversion from Flutter apps #166305

Merged

flar mentioned this pull request Apr 10, 2025

iOS platform view clip path: Find a better approximate for conic path #35062

Open

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

c4d8870 [DisplayList] DlPath supports generic path dispatching (flutt…

c514864

…er/flutter#164753)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

c4d8870 [DisplayList] DlPath supports generic path dispatching (flutt…

80814ac

…er/flutter#164753)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

c4d8870 [DisplayList] DlPath supports generic path dispatching (flutt…

74e2044

…er/flutter#164753)

[DisplayList] DlPath supports generic path dispatching #164753

[DisplayList] DlPath supports generic path dispatching #164753

Uh oh!

Conversation

flar commented Mar 7, 2025

Uh oh!

flar commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

flar commented Mar 8, 2025

Uh oh!

flar commented Mar 8, 2025

Uh oh!

flar commented Mar 8, 2025

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gaaclarke Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

flar Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

flar commented Mar 7, 2025 •

edited

Loading

gaaclarke Mar 10, 2025 •

edited

Loading

flar Mar 10, 2025 •

edited

Loading