Skip to content

Prevent explicit roles from merging #164732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Mar 13, 2025
Merged

Prevent explicit roles from merging #164732

auto-submit merged 3 commits into from
Mar 13, 2025

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Mar 6, 2025

If merging explicit roles, some of the information may be dropped.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) labels Mar 6, 2025
@chunhtai chunhtai requested a review from yjbanov March 6, 2025 19:12
yjbanov
yjbanov approved these changes Mar 6, 2025
View reviewed changes
packages/flutter/lib/src/semantics/semantics.dart
_hasFlag(SemanticsFlag.isLink) ||
_hasFlag(SemanticsFlag.scopesRoute) ||
_hasFlag(SemanticsFlag.isImage) ||
_hasFlag(SemanticsFlag.isKeyboardKey)) {
Copy link
Contributor

@yjbanov yjbanov Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also have isButton here?

Copy link
Contributor Author

@chunhtai chunhtai Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, an image can also be a button. same for keyboard key. button is more of a trait now...

now I think of it, there is also a searchBox/combobox which can be compatible with istextfield... it almost feels like the compatibility is per flag and role based..

Copy link
Contributor Author

@chunhtai chunhtai Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may need to make the role and enhance enum to be able to enter compatible flags

Copy link
Contributor Author

@chunhtai chunhtai Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed offline, for role that may be compatibile, we could (a) factor out some aspect of it to a semanticsproperty(e.g searchable) (b) comes up with a way to customize merging for each enum (e.g. an enhance enum that include other mergable roles).

we can deal with them case by case when these kind of problem raise up. For now, we will go ahead with this pr

@github-actions github-actions bot added the f: material design flutter/packages/flutter/material repository. label Mar 6, 2025
@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 6, 2025

autosubmit label was removed for flutter/flutter/164732, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2025
@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 6, 2025

autosubmit label was removed for flutter/flutter/164732, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 7, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 10, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 10, 2025

autosubmit label was removed for flutter/flutter/164732, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 13, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 13, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 13, 2025

autosubmit label was removed for flutter/flutter/164732, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 13, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Mar 13, 2025
Merged via the queue into flutter:master with commit c2bb3ac Mar 13, 2025
75 of 76 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 13, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
c2bb3ac Prevent explicit roles from merging (flutter/flutter#164732)
5675424
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
c2bb3ac Prevent explicit roles from merging (flutter/flutter#164732)
535b890
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
c2bb3ac Prevent explicit roles from merging (flutter/flutter#164732)
beec06e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
c2bb3ac Prevent explicit roles from merging (flutter/flutter#164732)
0e6ae30
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
c2bb3ac Prevent explicit roles from merging (flutter/flutter#164732)
328f911
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
c2bb3ac Prevent explicit roles from merging (flutter/flutter#164732)
2e09f3f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
c2bb3ac Prevent explicit roles from merging (flutter/flutter#164732)
8021bc8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
c2bb3ac Prevent explicit roles from merging (flutter/flutter#164732)
662ea11
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
c2bb3ac Prevent explicit roles from merging (flutter/flutter#164732)
c07f7d9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
c2bb3ac Prevent explicit roles from merging (flutter/flutter#164732)
62d777c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
c2bb3ac Prevent explicit roles from merging (flutter/flutter#164732)
7a6cdb3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
c2bb3ac Prevent explicit roles from merging (flutter/flutter#164732)
bac668f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
c2bb3ac Prevent explicit roles from merging (flutter/flutter#164732)
08fcf17
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
c2bb3ac Prevent explicit roles from merging (flutter/flutter#164732)
c65760e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
c2bb3ac Prevent explicit roles from merging (flutter/flutter#164732)
3368b61
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
c2bb3ac Prevent explicit roles from merging (flutter/flutter#164732)
c8e4955
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
c2bb3ac Prevent explicit roles from merging (flutter/flutter#164732)
3c8ca32
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
c2bb3ac Prevent explicit roles from merging (flutter/flutter#164732)
8b68b79
stuartmorgan-g pushed a commit to flutter/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
Manual roll Flutter from b16430b to 1d954f4 (114 revisions) (#8922)
a1b1cf1 
Manual roll Flutter from b16430b to 1d954f4 (114 revisions)

Manual roll requested by [email protected]

flutter/flutter@b16430b...1d954f4

2025-03-17 [email protected] Revert "[skwasm] Dynamic Threading
(#164748)" (flutter/flutter#165350)
2025-03-17 [email protected] Roll Skia from fa669e2e6d12
to 52130e5c3b34 (4 revisions) (flutter/flutter#165348)
2025-03-17 [email protected]
`OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal`
rebuilds. (flutter/flutter#165331)
2025-03-17 [email protected] [web][a11y]Delete
_childContainerElement (flutter/flutter#163662)
2025-03-17 [email protected] Roll Skia from e45207898e60
to fa669e2e6d12 (8 revisions) (flutter/flutter#165342)
2025-03-17 [email protected] Add documentation for Java test
filtering to plugins test document (flutter/flutter#165314)
2025-03-17 [email protected] Roll Fuchsia Linux SDK from
SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313)
2025-03-17 [email protected] Roll Dart SDK from
9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310)
2025-03-17 [email protected] feat(Tooltip): replace the height parameter
with constraints (flutter/flutter#163314)
2025-03-17 [email protected] Fix arrowHeadColor breaks differentiation
between states (flutter/flutter#165178)
2025-03-17 [email protected] Removes
assumption that basis scalar and rounded_scalar match
(flutter/flutter#165166)
2025-03-17 [email protected] Roll Skia from 69cf4c2c5db8
to e45207898e60 (1 revision) (flutter/flutter#165300)
2025-03-17 [email protected] Refactor: Move
sliders value indicator shape to seperate file (flutter/flutter#162858)
2025-03-17 [email protected] Roll Skia from 3931c31032c7
to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288)
2025-03-17 [email protected] Delete
`docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258)
2025-03-16 [email protected] Roll Skia from 3413a02d6fc8
to 3931c31032c7 (1 revision) (flutter/flutter#165277)
2025-03-16 [email protected] Roll Fuchsia Linux SDK from
LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275)
2025-03-16 [email protected] Roll Dart SDK from
067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269)
2025-03-16 [email protected] Roll Skia from f124daeb564d
to 3413a02d6fc8 (1 revision) (flutter/flutter#165263)
2025-03-15 [email protected] Roll Dart SDK from
40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262)
2025-03-15 [email protected] Roll Fuchsia Linux SDK from
efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252)
2025-03-15 [email protected] Roll Dart SDK from
f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250)
2025-03-15 [email protected] Roll Dart SDK from
8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246)
2025-03-15 [email protected] Roll Skia from 4568e766ed0a
to f124daeb564d (1 revision) (flutter/flutter#165245)
2025-03-15 [email protected] Revert "Prevent
explicit roles from merging (#164732)" (flutter/flutter#165222)
2025-03-15 [email protected] Roll Skia from bac6e76abfc7
to 4568e766ed0a (5 revisions) (flutter/flutter#165241)
2025-03-14 [email protected] Roll Dart SDK from
a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227)
2025-03-14 [email protected] Roll Skia from 98b6922deecf
to bac6e76abfc7 (5 revisions) (flutter/flutter#165225)
2025-03-14 [email protected] Point ktlint AS
docs to the `.editorconfig` that is actually used by ci, instead of
making a copy in the README (flutter/flutter#165213)
2025-03-14 [email protected] Add remaining dart fixes for Color
deprecations when importing painting.dart (flutter/flutter#162609)
2025-03-14 [email protected] [Accessibility]
Add required semantics flags (flutter/flutter#164585)
2025-03-14 [email protected] Roll Skia from f4467ff38f1f
to 98b6922deecf (5 revisions) (flutter/flutter#165215)
2025-03-14 [email protected] Convert `BaseFlutterTask` From Groovy
to Kotlin (flutter/flutter#163148)
2025-03-14 [email protected]
`OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034)
2025-03-14 [email protected] Remove redundant `useMaterial3: true`
(flutter/flutter#163376)
2025-03-14 [email protected] Roll Packages from
9cc6f37 to ff7724c (1 revision) (flutter/flutter#165197)
2025-03-14 [email protected] Changelog updates
from 3.29.2 (flutter/flutter#165194)
2025-03-14 [email protected] Roll Dart SDK from
576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191)
2025-03-14 [email protected] Roll Dart SDK from
ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180)
2025-03-14 [email protected] Roll Fuchsia Linux SDK from
qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175)
2025-03-14 [email protected] [Impeller] Enable mediatek on API
34+. (flutter/flutter#165156)
2025-03-14 [email protected] Roll Dart SDK from
cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159)
2025-03-13 [email protected] [FGP conversion]
Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143)
2025-03-13 [email protected] Prevent explicit
roles from merging (flutter/flutter#164732)
...
vashworth pushed a commit to vashworth/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll @vashworth
Manual roll Flutter from b16430b to 1d954f4 (114 revisions) (flutter#…
88d5013 
…8922)

Manual roll Flutter from b16430b to 1d954f4 (114 revisions)

Manual roll requested by [email protected]

flutter/flutter@b16430b...1d954f4

2025-03-17 [email protected] Revert "[skwasm] Dynamic Threading
(#164748)" (flutter/flutter#165350)
2025-03-17 [email protected] Roll Skia from fa669e2e6d12
to 52130e5c3b34 (4 revisions) (flutter/flutter#165348)
2025-03-17 [email protected]
`OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal`
rebuilds. (flutter/flutter#165331)
2025-03-17 [email protected] [web][a11y]Delete
_childContainerElement (flutter/flutter#163662)
2025-03-17 [email protected] Roll Skia from e45207898e60
to fa669e2e6d12 (8 revisions) (flutter/flutter#165342)
2025-03-17 [email protected] Add documentation for Java test
filtering to plugins test document (flutter/flutter#165314)
2025-03-17 [email protected] Roll Fuchsia Linux SDK from
SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313)
2025-03-17 [email protected] Roll Dart SDK from
9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310)
2025-03-17 [email protected] feat(Tooltip): replace the height parameter
with constraints (flutter/flutter#163314)
2025-03-17 [email protected] Fix arrowHeadColor breaks differentiation
between states (flutter/flutter#165178)
2025-03-17 [email protected] Removes
assumption that basis scalar and rounded_scalar match
(flutter/flutter#165166)
2025-03-17 [email protected] Roll Skia from 69cf4c2c5db8
to e45207898e60 (1 revision) (flutter/flutter#165300)
2025-03-17 [email protected] Refactor: Move
sliders value indicator shape to seperate file (flutter/flutter#162858)
2025-03-17 [email protected] Roll Skia from 3931c31032c7
to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288)
2025-03-17 [email protected] Delete
`docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258)
2025-03-16 [email protected] Roll Skia from 3413a02d6fc8
to 3931c31032c7 (1 revision) (flutter/flutter#165277)
2025-03-16 [email protected] Roll Fuchsia Linux SDK from
LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275)
2025-03-16 [email protected] Roll Dart SDK from
067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269)
2025-03-16 [email protected] Roll Skia from f124daeb564d
to 3413a02d6fc8 (1 revision) (flutter/flutter#165263)
2025-03-15 [email protected] Roll Dart SDK from
40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262)
2025-03-15 [email protected] Roll Fuchsia Linux SDK from
efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252)
2025-03-15 [email protected] Roll Dart SDK from
f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250)
2025-03-15 [email protected] Roll Dart SDK from
8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246)
2025-03-15 [email protected] Roll Skia from 4568e766ed0a
to f124daeb564d (1 revision) (flutter/flutter#165245)
2025-03-15 [email protected] Revert "Prevent
explicit roles from merging (#164732)" (flutter/flutter#165222)
2025-03-15 [email protected] Roll Skia from bac6e76abfc7
to 4568e766ed0a (5 revisions) (flutter/flutter#165241)
2025-03-14 [email protected] Roll Dart SDK from
a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227)
2025-03-14 [email protected] Roll Skia from 98b6922deecf
to bac6e76abfc7 (5 revisions) (flutter/flutter#165225)
2025-03-14 [email protected] Point ktlint AS
docs to the `.editorconfig` that is actually used by ci, instead of
making a copy in the README (flutter/flutter#165213)
2025-03-14 [email protected] Add remaining dart fixes for Color
deprecations when importing painting.dart (flutter/flutter#162609)
2025-03-14 [email protected] [Accessibility]
Add required semantics flags (flutter/flutter#164585)
2025-03-14 [email protected] Roll Skia from f4467ff38f1f
to 98b6922deecf (5 revisions) (flutter/flutter#165215)
2025-03-14 [email protected] Convert `BaseFlutterTask` From Groovy
to Kotlin (flutter/flutter#163148)
2025-03-14 [email protected]
`OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034)
2025-03-14 [email protected] Remove redundant `useMaterial3: true`
(flutter/flutter#163376)
2025-03-14 [email protected] Roll Packages from
9cc6f37 to ff7724c (1 revision) (flutter/flutter#165197)
2025-03-14 [email protected] Changelog updates
from 3.29.2 (flutter/flutter#165194)
2025-03-14 [email protected] Roll Dart SDK from
576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191)
2025-03-14 [email protected] Roll Dart SDK from
ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180)
2025-03-14 [email protected] Roll Fuchsia Linux SDK from
qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175)
2025-03-14 [email protected] [Impeller] Enable mediatek on API
34+. (flutter/flutter#165156)
2025-03-14 [email protected] Roll Dart SDK from
cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159)
2025-03-13 [email protected] [FGP conversion]
Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143)
2025-03-13 [email protected] Prevent explicit
roles from merging (flutter/flutter#164732)
...
CodixNinja pushed a commit to CodixNinja/packages that referenced this pull request May 15, 2025
@engine-flutter-autoroll
Manual roll Flutter from b16430b2fd57 to 1d954f4e96bd (114 revisions)…
b6536bc 
… (#8922)

Manual roll Flutter from b16430b2fd57 to 1d954f4e96bd (114 revisions)

Manual roll requested by [email protected]

flutter/flutter@b16430b...1d954f4

2025-03-17 [email protected] Revert "[skwasm] Dynamic Threading
(#164748)" (flutter/flutter#165350)
2025-03-17 [email protected] Roll Skia from fa669e2e6d12
to 52130e5c3b34 (4 revisions) (flutter/flutter#165348)
2025-03-17 [email protected]
`OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal`
rebuilds. (flutter/flutter#165331)
2025-03-17 [email protected] [web][a11y]Delete
_childContainerElement (flutter/flutter#163662)
2025-03-17 [email protected] Roll Skia from e45207898e60
to fa669e2e6d12 (8 revisions) (flutter/flutter#165342)
2025-03-17 [email protected] Add documentation for Java test
filtering to plugins test document (flutter/flutter#165314)
2025-03-17 [email protected] Roll Fuchsia Linux SDK from
SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313)
2025-03-17 [email protected] Roll Dart SDK from
9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310)
2025-03-17 [email protected] feat(Tooltip): replace the height parameter
with constraints (flutter/flutter#163314)
2025-03-17 [email protected] Fix arrowHeadColor breaks differentiation
between states (flutter/flutter#165178)
2025-03-17 [email protected] Removes
assumption that basis scalar and rounded_scalar match
(flutter/flutter#165166)
2025-03-17 [email protected] Roll Skia from 69cf4c2c5db8
to e45207898e60 (1 revision) (flutter/flutter#165300)
2025-03-17 [email protected] Refactor: Move
sliders value indicator shape to seperate file (flutter/flutter#162858)
2025-03-17 [email protected] Roll Skia from 3931c31032c7
to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288)
2025-03-17 [email protected] Delete
`docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258)
2025-03-16 [email protected] Roll Skia from 3413a02d6fc8
to 3931c31032c7 (1 revision) (flutter/flutter#165277)
2025-03-16 [email protected] Roll Fuchsia Linux SDK from
LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275)
2025-03-16 [email protected] Roll Dart SDK from
067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269)
2025-03-16 [email protected] Roll Skia from f124daeb564d
to 3413a02d6fc8 (1 revision) (flutter/flutter#165263)
2025-03-15 [email protected] Roll Dart SDK from
40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262)
2025-03-15 [email protected] Roll Fuchsia Linux SDK from
efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252)
2025-03-15 [email protected] Roll Dart SDK from
f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250)
2025-03-15 [email protected] Roll Dart SDK from
8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246)
2025-03-15 [email protected] Roll Skia from 4568e766ed0a
to f124daeb564d (1 revision) (flutter/flutter#165245)
2025-03-15 [email protected] Revert "Prevent
explicit roles from merging (#164732)" (flutter/flutter#165222)
2025-03-15 [email protected] Roll Skia from bac6e76abfc7
to 4568e766ed0a (5 revisions) (flutter/flutter#165241)
2025-03-14 [email protected] Roll Dart SDK from
a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227)
2025-03-14 [email protected] Roll Skia from 98b6922deecf
to bac6e76abfc7 (5 revisions) (flutter/flutter#165225)
2025-03-14 [email protected] Point ktlint AS
docs to the `.editorconfig` that is actually used by ci, instead of
making a copy in the README (flutter/flutter#165213)
2025-03-14 [email protected] Add remaining dart fixes for Color
deprecations when importing painting.dart (flutter/flutter#162609)
2025-03-14 [email protected] [Accessibility]
Add required semantics flags (flutter/flutter#164585)
2025-03-14 [email protected] Roll Skia from f4467ff38f1f
to 98b6922deecf (5 revisions) (flutter/flutter#165215)
2025-03-14 [email protected] Convert `BaseFlutterTask` From Groovy
to Kotlin (flutter/flutter#163148)
2025-03-14 [email protected]
`OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034)
2025-03-14 [email protected] Remove redundant `useMaterial3: true`
(flutter/flutter#163376)
2025-03-14 [email protected] Roll Packages from
bdb9c96 to d632936 (1 revision) (flutter/flutter#165197)
2025-03-14 [email protected] Changelog updates
from 3.29.2 (flutter/flutter#165194)
2025-03-14 [email protected] Roll Dart SDK from
576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191)
2025-03-14 [email protected] Roll Dart SDK from
ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180)
2025-03-14 [email protected] Roll Fuchsia Linux SDK from
qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175)
2025-03-14 [email protected] [Impeller] Enable mediatek on API
34+. (flutter/flutter#165156)
2025-03-14 [email protected] Roll Dart SDK from
cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159)
2025-03-13 [email protected] [FGP conversion]
Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143)
2025-03-13 [email protected] Prevent explicit
roles from merging (flutter/flutter#164732)
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
c2bb3ac Prevent explicit roles from merging (flutter/flutter#164732)
4b9a6d5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
c2bb3ac Prevent explicit roles from merging (flutter/flutter#164732)
c70dd58
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
c2bb3ac Prevent explicit roles from merging (flutter/flutter#164732)
4721cfa
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Manual roll Flutter from b16430b to 1d954f4 (114 revisions) (flutter#…
a06362c 
…8922)

Manual roll Flutter from b16430b to 1d954f4 (114 revisions)

Manual roll requested by [email protected]

flutter/flutter@b16430b...1d954f4

2025-03-17 [email protected] Revert "[skwasm] Dynamic Threading
(#164748)" (flutter/flutter#165350)
2025-03-17 [email protected] Roll Skia from fa669e2e6d12
to 52130e5c3b34 (4 revisions) (flutter/flutter#165348)
2025-03-17 [email protected]
`OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal`
rebuilds. (flutter/flutter#165331)
2025-03-17 [email protected] [web][a11y]Delete
_childContainerElement (flutter/flutter#163662)
2025-03-17 [email protected] Roll Skia from e45207898e60
to fa669e2e6d12 (8 revisions) (flutter/flutter#165342)
2025-03-17 [email protected] Add documentation for Java test
filtering to plugins test document (flutter/flutter#165314)
2025-03-17 [email protected] Roll Fuchsia Linux SDK from
SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313)
2025-03-17 [email protected] Roll Dart SDK from
9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310)
2025-03-17 [email protected] feat(Tooltip): replace the height parameter
with constraints (flutter/flutter#163314)
2025-03-17 [email protected] Fix arrowHeadColor breaks differentiation
between states (flutter/flutter#165178)
2025-03-17 [email protected] Removes
assumption that basis scalar and rounded_scalar match
(flutter/flutter#165166)
2025-03-17 [email protected] Roll Skia from 69cf4c2c5db8
to e45207898e60 (1 revision) (flutter/flutter#165300)
2025-03-17 [email protected] Refactor: Move
sliders value indicator shape to seperate file (flutter/flutter#162858)
2025-03-17 [email protected] Roll Skia from 3931c31032c7
to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288)
2025-03-17 [email protected] Delete
`docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258)
2025-03-16 [email protected] Roll Skia from 3413a02d6fc8
to 3931c31032c7 (1 revision) (flutter/flutter#165277)
2025-03-16 [email protected] Roll Fuchsia Linux SDK from
LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275)
2025-03-16 [email protected] Roll Dart SDK from
067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269)
2025-03-16 [email protected] Roll Skia from f124daeb564d
to 3413a02d6fc8 (1 revision) (flutter/flutter#165263)
2025-03-15 [email protected] Roll Dart SDK from
40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262)
2025-03-15 [email protected] Roll Fuchsia Linux SDK from
efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252)
2025-03-15 [email protected] Roll Dart SDK from
f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250)
2025-03-15 [email protected] Roll Dart SDK from
8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246)
2025-03-15 [email protected] Roll Skia from 4568e766ed0a
to f124daeb564d (1 revision) (flutter/flutter#165245)
2025-03-15 [email protected] Revert "Prevent
explicit roles from merging (#164732)" (flutter/flutter#165222)
2025-03-15 [email protected] Roll Skia from bac6e76abfc7
to 4568e766ed0a (5 revisions) (flutter/flutter#165241)
2025-03-14 [email protected] Roll Dart SDK from
a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227)
2025-03-14 [email protected] Roll Skia from 98b6922deecf
to bac6e76abfc7 (5 revisions) (flutter/flutter#165225)
2025-03-14 [email protected] Point ktlint AS
docs to the `.editorconfig` that is actually used by ci, instead of
making a copy in the README (flutter/flutter#165213)
2025-03-14 [email protected] Add remaining dart fixes for Color
deprecations when importing painting.dart (flutter/flutter#162609)
2025-03-14 [email protected] [Accessibility]
Add required semantics flags (flutter/flutter#164585)
2025-03-14 [email protected] Roll Skia from f4467ff38f1f
to 98b6922deecf (5 revisions) (flutter/flutter#165215)
2025-03-14 [email protected] Convert `BaseFlutterTask` From Groovy
to Kotlin (flutter/flutter#163148)
2025-03-14 [email protected]
`OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034)
2025-03-14 [email protected] Remove redundant `useMaterial3: true`
(flutter/flutter#163376)
2025-03-14 [email protected] Roll Packages from
9cc6f37 to ff7724c (1 revision) (flutter/flutter#165197)
2025-03-14 [email protected] Changelog updates
from 3.29.2 (flutter/flutter#165194)
2025-03-14 [email protected] Roll Dart SDK from
576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191)
2025-03-14 [email protected] Roll Dart SDK from
ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180)
2025-03-14 [email protected] Roll Fuchsia Linux SDK from
qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175)
2025-03-14 [email protected] [Impeller] Enable mediatek on API
34+. (flutter/flutter#165156)
2025-03-14 [email protected] Roll Dart SDK from
cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159)
2025-03-13 [email protected] [FGP conversion]
Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143)
2025-03-13 [email protected] Prevent explicit
roles from merging (flutter/flutter#164732)
...
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Manual roll Flutter from b16430b to 1d954f4 (114 revisions) (flutter#…
19d634b 
…8922)

Manual roll Flutter from b16430b to 1d954f4 (114 revisions)

Manual roll requested by [email protected]

flutter/flutter@b16430b...1d954f4

2025-03-17 [email protected] Revert "[skwasm] Dynamic Threading
(#164748)" (flutter/flutter#165350)
2025-03-17 [email protected] Roll Skia from fa669e2e6d12
to 52130e5c3b34 (4 revisions) (flutter/flutter#165348)
2025-03-17 [email protected]
`OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal`
rebuilds. (flutter/flutter#165331)
2025-03-17 [email protected] [web][a11y]Delete
_childContainerElement (flutter/flutter#163662)
2025-03-17 [email protected] Roll Skia from e45207898e60
to fa669e2e6d12 (8 revisions) (flutter/flutter#165342)
2025-03-17 [email protected] Add documentation for Java test
filtering to plugins test document (flutter/flutter#165314)
2025-03-17 [email protected] Roll Fuchsia Linux SDK from
SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313)
2025-03-17 [email protected] Roll Dart SDK from
9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310)
2025-03-17 [email protected] feat(Tooltip): replace the height parameter
with constraints (flutter/flutter#163314)
2025-03-17 [email protected] Fix arrowHeadColor breaks differentiation
between states (flutter/flutter#165178)
2025-03-17 [email protected] Removes
assumption that basis scalar and rounded_scalar match
(flutter/flutter#165166)
2025-03-17 [email protected] Roll Skia from 69cf4c2c5db8
to e45207898e60 (1 revision) (flutter/flutter#165300)
2025-03-17 [email protected] Refactor: Move
sliders value indicator shape to seperate file (flutter/flutter#162858)
2025-03-17 [email protected] Roll Skia from 3931c31032c7
to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288)
2025-03-17 [email protected] Delete
`docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258)
2025-03-16 [email protected] Roll Skia from 3413a02d6fc8
to 3931c31032c7 (1 revision) (flutter/flutter#165277)
2025-03-16 [email protected] Roll Fuchsia Linux SDK from
LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275)
2025-03-16 [email protected] Roll Dart SDK from
067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269)
2025-03-16 [email protected] Roll Skia from f124daeb564d
to 3413a02d6fc8 (1 revision) (flutter/flutter#165263)
2025-03-15 [email protected] Roll Dart SDK from
40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262)
2025-03-15 [email protected] Roll Fuchsia Linux SDK from
efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252)
2025-03-15 [email protected] Roll Dart SDK from
f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250)
2025-03-15 [email protected] Roll Dart SDK from
8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246)
2025-03-15 [email protected] Roll Skia from 4568e766ed0a
to f124daeb564d (1 revision) (flutter/flutter#165245)
2025-03-15 [email protected] Revert "Prevent
explicit roles from merging (#164732)" (flutter/flutter#165222)
2025-03-15 [email protected] Roll Skia from bac6e76abfc7
to 4568e766ed0a (5 revisions) (flutter/flutter#165241)
2025-03-14 [email protected] Roll Dart SDK from
a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227)
2025-03-14 [email protected] Roll Skia from 98b6922deecf
to bac6e76abfc7 (5 revisions) (flutter/flutter#165225)
2025-03-14 [email protected] Point ktlint AS
docs to the `.editorconfig` that is actually used by ci, instead of
making a copy in the README (flutter/flutter#165213)
2025-03-14 [email protected] Add remaining dart fixes for Color
deprecations when importing painting.dart (flutter/flutter#162609)
2025-03-14 [email protected] [Accessibility]
Add required semantics flags (flutter/flutter#164585)
2025-03-14 [email protected] Roll Skia from f4467ff38f1f
to 98b6922deecf (5 revisions) (flutter/flutter#165215)
2025-03-14 [email protected] Convert `BaseFlutterTask` From Groovy
to Kotlin (flutter/flutter#163148)
2025-03-14 [email protected]
`OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034)
2025-03-14 [email protected] Remove redundant `useMaterial3: true`
(flutter/flutter#163376)
2025-03-14 [email protected] Roll Packages from
9cc6f37 to ff7724c (1 revision) (flutter/flutter#165197)
2025-03-14 [email protected] Changelog updates
from 3.29.2 (flutter/flutter#165194)
2025-03-14 [email protected] Roll Dart SDK from
576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191)
2025-03-14 [email protected] Roll Dart SDK from
ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180)
2025-03-14 [email protected] Roll Fuchsia Linux SDK from
qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175)
2025-03-14 [email protected] [Impeller] Enable mediatek on API
34+. (flutter/flutter#165156)
2025-03-14 [email protected] Roll Dart SDK from
cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159)
2025-03-13 [email protected] [FGP conversion]
Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143)
2025-03-13 [email protected] Prevent explicit
roles from merging (flutter/flutter#164732)
...
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@chunhtai @romanejaquez
Prevent explicit roles from merging (flutter#164732)
9ad7924 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

If merging explicit roles, some of the information may be dropped.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@chunhtai @romanejaquez
Revert "Prevent explicit roles from merging (flutter#164732)" (flutte…
fa292ed 
…r#165222)

This reverts commit c2bb3ac.

<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

the previous pr may break some of the mobile a11y. some newly splitted
role can't be focus by mobile a11y focus, will need to fix some of the
engine code first

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yjbanov yjbanov yjbanov approved these changes

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chunhtai @yjbanov