Support launching a HTTPS URL #164720

Wdestroier · 2025-03-06T16:22:27Z

I setup a reverse proxy, but this piece of code only allows launching HTTP URLs. I'm submitting a patch to fix the error.

See issue comment Dart-Code/Dart-Code#5322 (comment) for context.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

flutter-dashboard · 2025-03-06T16:22:31Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

bkonyi · 2025-04-14T13:44:01Z

Hi @Wdestroier, thanks for your contribution!

We're going to need some tests in order to land this. Let me know if you have any questions and I'll be happy to help!

bkonyi · 2025-04-28T13:20:31Z

Hi @Wdestroier! Do you still intend to pick this back up?

Wdestroier · 2025-04-28T16:50:13Z

Hi, I will pick this today.

Wdestroier · 2025-04-28T18:35:49Z

Done, @bkonyi! Can you review it, please?

Wdestroier · 2025-05-23T15:26:15Z

@bkonyi, I updated my branch with upstream to fix the "ci.yaml validation" error.

bkonyi · 2025-05-26T16:08:14Z

Sorry for the delay @Wdestroier. LGTM!

matanlurey

This should be tested by asserting a tool exit is thrown, not by making the function @visibleForTesting (test the contract not the implementation details).

Once that change is made I will LGTM.

Piinks · 2025-07-29T22:44:27Z

Hey @Wdestroier do you have plans to return to this PR and address the above feedback?

Wdestroier · 2025-07-29T23:20:38Z

Hi, I will prioritize this today.

Wdestroier · 2025-07-30T00:27:14Z

Great idea, @matanlurey! Sorry for the delay. Can you review the changes, please?

packages/flutter_tools/test/general.shard/web/devices_test.dart

bkonyi · 2025-07-30T18:04:03Z

LGTM. @matanlurey is OOO this week, so I've added @jtmcdole for a rubber stamp.

It looks like you'll need to resolve some conflicts before this can land, however.

Wdestroier · 2025-07-30T18:14:50Z

Fine. I solved the merge conflicts. Thanks!

bkonyi · 2025-08-06T20:50:55Z

There's still a couple of failures that will block this from landing :-(

jtmcdole · 2025-08-07T01:28:08Z

Needs a format:

Found 1 Dart file which was formatted incorrectly.
To fix, run `dart format packages/flutter_tools/test/general.shard/web/devices_test.dart` or:

git apply <<DONE
diff --git a/packages/flutter_tools/test/general.shard/web/devices_test.dart b/packages/flutter_tools/test/general.shard/web/devices_test.dart
index ce6b23abc17..00000000000 100644
--- a/packages/flutter_tools/test/general.shard/web/devices_test.dart
+++ b/packages/flutter_tools/test/general.shard/web/devices_test.dart
@@ -246,8 +246,9 @@ void main() {
       processManager: processManager,
     );
 
-    final GoogleChromeDevice chromeDevice =
-        (await webDevices.pollingGetDevices()).whereType<GoogleChromeDevice>().first;
+    final GoogleChromeDevice chromeDevice = (await webDevices.pollingGetDevices())
+        .whereType<GoogleChromeDevice>()
+        .first;
 
     expect(await chromeDevice.isSupported(), true);
     expect(await chromeDevice.sdkNameAndVersion, 'ABC');
@@ -288,8 +289,9 @@ void main() {
       processManager: processManager,
     );
 
-    final GoogleChromeDevice chromeDevice =
-        (await webDevices.pollingGetDevices()).whereType<GoogleChromeDevice>().first;
+    final GoogleChromeDevice chromeDevice = (await webDevices.pollingGetDevices())
+        .whereType<GoogleChromeDevice>()
+        .first;
 
     expect(await chromeDevice.isSupported(), true);
     expect(await chromeDevice.sdkNameAndVersion, 'Google Chrome 74.0.0');
@@ -492,3 +494,4 @@ class _OnceClosableChromium extends Fake implements Chromium {
 }
 
 class _UnimplementedChromium extends Fake implements Chromium {}
DONE

auto-submit · 2025-08-07T19:04:59Z

autosubmit label was removed for flutter/flutter/164720, because This PR has not met approval requirements for merging. Changes were requested by {matanlurey}, please make the needed changes and resubmit this PR.
The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

OOO

flutter/flutter@92a6bfb...3821790 2025-08-08 [email protected] Use LLDB as the default debugging method for iOS 17+ and Xcode 26+ (flutter/flutter#173443) 2025-08-08 [email protected] Roll Fuchsia Linux SDK from i4vsuEGyP8Xeb5tiy... to HclTm0V8hgSpfqmtG... (flutter/flutter#173462) 2025-08-08 [email protected] Support launching a HTTPS URL (flutter/flutter#164720) 2025-08-08 [email protected] Roll Dart SDK from c48772a79e1f to 4b7b565eb468 (1 revision) (flutter/flutter#173454) 2025-08-08 [email protected] Roll Dart SDK from ba58b96a80d7 to c48772a79e1f (3 revisions) (flutter/flutter#173451) 2025-08-07 [email protected] Web dev proxy (flutter/flutter#172175) 2025-08-07 [email protected] Roll ICU from b929596baebf to 1b2e3e8a421e (7 revisions) (flutter/flutter#173436) 2025-08-07 [email protected] [A11y] TextField prefix icon and suffix icon create a sibling node' (flutter/flutter#173312) 2025-08-07 [email protected] [Android templates] Remove jetifier usage (flutter/flutter#173431) 2025-08-07 [email protected] Remove a couple of asserts from display_list_unittest (flutter/flutter#173381) 2025-08-07 [email protected] Fix ScaffoldGeometry null scale with noAnimation FAB (flutter/flutter#172914) 2025-08-07 [email protected] Prepare for iOS debugging with lldb and devicectl (flutter/flutter#173417) 2025-08-07 [email protected] Fix `ReorderableList` proxy animation for partial drag-back (flutter/flutter#172380) 2025-08-07 [email protected] [ios26]Do not report error for Info.plist key not found (flutter/flutter#172913) 2025-08-07 [email protected] Manual roll to 3.10.0-75.1.beta (flutter/flutter#173423) 2025-08-07 [email protected] [web] add --static-assets-url argument to build web (flutter/flutter#171638) 2025-08-07 [email protected] Adds deprecation for impeller opt out on android (flutter/flutter#173375) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Support launching a HTTPS URL

cad4268

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 6, 2025

bkonyi added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Apr 28, 2025

Web launch URL validation tests

a854b54

Merge remote-tracking branch 'upstream/master'

02eebab

bkonyi approved these changes May 26, 2025

View reviewed changes

bkonyi requested a review from matanlurey May 26, 2025 16:08

matanlurey previously requested changes May 26, 2025

View reviewed changes

Assert tool exit on invalid launch URL

888f7d5

bkonyi reviewed Jul 30, 2025

View reviewed changes

packages/flutter_tools/test/general.shard/web/devices_test.dart Show resolved Hide resolved

packages/flutter_tools/test/general.shard/web/devices_test.dart Outdated Show resolved Hide resolved

Change matcher class name

c0d11a9

bkonyi requested review from jtmcdole and matanlurey July 30, 2025 18:03

Merge branch 'master' into master

a96ff88

Wdestroier added 2 commits August 6, 2025 18:08

Merge remote-tracking branch 'upstream/master'

92d18f4

Omit a few type parameters

cb4267c

jtmcdole approved these changes Aug 7, 2025

View reviewed changes

Wdestroier added 2 commits August 7, 2025 05:01

Reformat devices_test.dart file

ee60079

Merge remote-tracking branch 'upstream/master'

99165e9

bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 7, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 7, 2025

bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 8, 2025

auto-submit bot added this pull request to the merge queue Aug 8, 2025

Merged via the queue into flutter:master with commit e4c07e8 Aug 8, 2025
143 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 8, 2025

engine-flutter-autoroll mentioned this pull request Aug 8, 2025

Roll Flutter from 92a6bfbfd6ef to aef15c12f410 (16 revisions) flutter/packages#9777

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 8, 2025

e4c07e8ab Support launching a HTTPS URL (flutter/flutter#164720)

78ccaec

engine-flutter-autoroll mentioned this pull request Aug 8, 2025

Roll Flutter from 92a6bfbfd6ef to 38217906e95c (17 revisions) flutter/packages#9778

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 8, 2025

e4c07e8ab Support launching a HTTPS URL (flutter/flutter#164720)

37b1828

Piinks mentioned this pull request Aug 8, 2025

Flutter Notable Commits - 2025 #161460

Open

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

e4c07e8ab Support launching a HTTPS URL (flutter/flutter#164720)

4a88f65

Support launching a HTTPS URL #164720

Support launching a HTTPS URL #164720

Uh oh!

Conversation

Wdestroier commented Mar 6, 2025

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Mar 6, 2025

Uh oh!

bkonyi commented Apr 14, 2025

Uh oh!

bkonyi commented Apr 28, 2025

Uh oh!

Wdestroier commented Apr 28, 2025

Uh oh!

Wdestroier commented Apr 28, 2025

Uh oh!

Wdestroier commented May 23, 2025

Uh oh!

bkonyi commented May 26, 2025

Uh oh!

matanlurey left a comment

Choose a reason for hiding this comment

Uh oh!

Piinks commented Jul 29, 2025

Uh oh!

Wdestroier commented Jul 29, 2025

Uh oh!

Wdestroier commented Jul 30, 2025

Uh oh!

Uh oh!

Uh oh!

bkonyi commented Jul 30, 2025

Uh oh!

Wdestroier commented Jul 30, 2025

Uh oh!

bkonyi commented Aug 6, 2025

Uh oh!

jtmcdole commented Aug 7, 2025

Uh oh!

auto-submit bot commented Aug 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants