Skip to content

Update Mac_mokey microbenchmarks with issue to the bringup: true in ci config for easier discovery #164694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jtmcdole merged 1 commit into from
Mar 12, 2025
Merged

Update Mac_mokey microbenchmarks with issue to the bringup: true in ci config for easier discovery #164694

jtmcdole merged 1 commit into from
Mar 12, 2025

Conversation

@harri35
Copy link
Contributor

@harri35 harri35 commented Mar 6, 2025

Update the comment in .ci.yaml with the issue link for easier discovery.
Related issue: #156506
Related discussion: #162000

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@harri35 harri35 self-assigned this Mar 6, 2025
@harri35 harri35 requested a review from jtmcdole March 6, 2025 09:03
This was referenced Mar 6, 2025
Closed
Merged
@harri35
Copy link
Contributor Author

harri35 commented Mar 12, 2025

@jtmcdole If you have a minute, please "review" this. Then it will be easier for others in the future to connect things :)

@jtmcdole jtmcdole changed the title Link the Mac_ios microbenchmarks_ios issue to the bringup: true in ci config for easier discovery Update Mac_mokey microbenchmarks with issue to the bringup: true in ci config for easier discovery Mar 12, 2025
@jtmcdole jtmcdole added this pull request to the merge queue Mar 12, 2025
Merged via the queue into flutter:master with commit eef31a1 Mar 12, 2025
151 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
b93db39 
…rue in ci config for easier discovery (flutter/flutter#164694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
d2961cc 
…rue in ci config for easier discovery (flutter/flutter#164694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
af57214 
…rue in ci config for easier discovery (flutter/flutter#164694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
3ae53b6 
…rue in ci config for easier discovery (flutter/flutter#164694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
f8b6238 
…rue in ci config for easier discovery (flutter/flutter#164694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
67742bd 
…rue in ci config for easier discovery (flutter/flutter#164694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
7aa3000 
…rue in ci config for easier discovery (flutter/flutter#164694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
e2055b0 
…rue in ci config for easier discovery (flutter/flutter#164694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 13, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
f1b86e1 
…rue in ci config for easier discovery (flutter/flutter#164694)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
b8632e1 
…rue in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
dd59862 
…rue in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
c9f1e94 
…rue in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
0724d54 
…rue in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
443c794 
…rue in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 17, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
c5f276d 
…rue in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 20, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
a2ae8f0 
…rue in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
5ede55b 
…rue in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
dca5092 
…rue in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
807af09 
…rue in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
ea646d5 
…rue in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
10bedc6 
…rue in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
5c3cbe5 
…rue in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
7d4a9a5 
…rue in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
b38f5dd 
…rue in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
ece55cd 
…rue in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
a63078e 
…rue in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
1e50bfe 
…rue in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
da2340d 
…rue in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
eef92d1 
…rue in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
43c2fcc 
…rue in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
22fb42f 
…rue in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
def4f56 
…rue in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
6252ba9 
…rue in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
b42d030 
…rue in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
5f9944c 
…rue in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
56eb5d6 
…rue in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
919b852 
…rue in ci config for easier discovery (flutter/flutter#164694)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
eef31a1 Update Mac_mokey microbenchmarks with issue to the bringup: t…
df7e94d 
…rue in ci config for easier discovery (flutter/flutter#164694)
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@harri35 @romanejaquez
Update Mac_mokey microbenchmarks with issue to the bringup: true in c…
9173960 
…i config for easier discovery (flutter#164694)

Update the comment in .ci.yaml with the issue link for easier discovery.
Related issue: flutter#156506
Related discussion: flutter#162000

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtmcdole jtmcdole jtmcdole approved these changes

Assignees

@harri35 harri35

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@harri35 @jtmcdole