Skip to content

Fix: DelegateTransition for cupertino sheet route #164675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Apr 2, 2025
Merged

Fix: DelegateTransition for cupertino sheet route #164675

auto-submit merged 1 commit into from
Apr 2, 2025

Conversation

@rkishan516
Copy link
Contributor

@rkishan516 rkishan516 commented Mar 6, 2025 •
edited
Loading

Fix: DelegateTransition for cupertino sheet route
fixes: #163954

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels Mar 6, 2025
justinmc
justinmc reviewed Mar 21, 2025
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll defer to @MitchellGoodwin on this. I think this probably needs a new test that covers this case at least though.

packages/flutter/test/cupertino/sheet_test.dart
Comment on lines -813 to +814
final Finder clipRRectFinder = find.byType(ClipRRect);
final Rect clipRect = tester.getRect(clipRRectFinder);
expect(clipRect.center, equals(const Offset(400, 300)));
expect(clipRRectFinder, findsNothing);
Copy link
Contributor

@justinmc justinmc Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this change exactly?

Ideally it would be nice if you could write a test that reproduces the error in #163954 and expect that it doesn't happen anymore.

Copy link
Contributor Author

@rkishan516 rkishan516 Mar 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since after popping this clipper doesn't exist anymore, that's why added this.
But yeah, it will make more sense to add another test which replicates error in #163954

packages/flutter/lib/src/cupertino/sheet.dart Outdated
Comment on lines 260 to 268
if (child != null && secondaryAnimation.isDismissed) {
return child;
}
Copy link
Contributor

@justinmc justinmc Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain why this fixes the bug for my own understanding?

Copy link
Contributor Author

@rkishan516 rkishan516 Mar 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After coming back from sheet, if it shows SlideTransition which internally uses RenderFractionalTranslation which doesn't have size because its just a proxy box. So, throws the error as seen in #163954.

Also, it makes sense to just return page, when we have fully popped of from sheet.

@rkishan516 rkishan516 force-pushed the cupertino-sheet-route-popup branch 2 times, most recently from f99e121 to 4f575b2 Compare March 26, 2025 03:00
@MitchellGoodwin
Copy link
Contributor

MitchellGoodwin commented Mar 26, 2025

Hi @rkishan516. Sorry it took me so long to respond to this, but I've been investigating this and related issues. I think the best place to fix this issue is actually in the delegatedTransition logic in the core routes file. If another route with an unusual transition like this is added, it is likely going to cause similar issues.

I was going to open a PR to do that, but it was similar enough to this PR, so I was going to ask if you wanted to do it. I wouldn't want to invalidate your work.

The change would be here, under _buildFlexibleTransitions:

flutter/packages/flutter/lib/src/widgets/routes.dart

Line 1586 in 8297e44

if (receivedTransition == null) {

We'd need to add the check for secondaryAnimation.isDismissed there, so it would look like:

    if (receivedTransition == null || secondaryAnimation.isDismissed) {
      return buildTransitions(context, animation, secondaryAnimation, child);
    }

A test would also have to be added to the routes test in widgets. If you don't want to do that, I can still open my PR, just let me know.

@rkishan516
Copy link
Contributor Author

rkishan516 commented Mar 27, 2025 •
edited
Loading

Hi @rkishan516. Sorry it took me so long to respond to this, but I've been investigating this and related issues. I think the best place to fix this issue is actually in the delegatedTransition logic in the core routes file. If another route with an unusual transition like this is added, it is likely going to cause similar issues.

I was going to open a PR to do that, but it was similar enough to this PR, so I was going to ask if you wanted to do it. I wouldn't want to invalidate your work.

The change would be here, under _buildFlexibleTransitions:

flutter/packages/flutter/lib/src/widgets/routes.dart

Line 1586 in 8297e44

if (receivedTransition == null) {

We'd need to add the check for secondaryAnimation.isDismissed there, so it would look like:

    if (receivedTransition == null || secondaryAnimation.isDismissed) {
      return buildTransitions(context, animation, secondaryAnimation, child);
    }

A test would also have to be added to the routes test in widgets. If you don't want to do that, I can still open my PR, just let me know.

Hey @MitchellGoodwin, No issues. Yaa, i think that's right approach. I will do the required change and let you know.
Edit :- I have pushed the change.

@rkishan516 rkishan516 force-pushed the cupertino-sheet-route-popup branch from 4f575b2 to b391de1 Compare March 27, 2025 01:05
@github-actions github-actions bot added the f: routes Navigator, Router, and related APIs. label Mar 27, 2025
@rkishan516 rkishan516 mentioned this pull request Mar 27, 2025
Merged
9 tasks
MitchellGoodwin
MitchellGoodwin reviewed Mar 27, 2025
View reviewed changes
Copy link
Contributor

@MitchellGoodwin MitchellGoodwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this will need a test in routes_test.dart as well.

@rkishan516 rkishan516 force-pushed the cupertino-sheet-route-popup branch from b391de1 to 0f597d8 Compare March 27, 2025 23:40
MitchellGoodwin
MitchellGoodwin approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@MitchellGoodwin MitchellGoodwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just left one nit on the comments.

packages/flutter/test/widgets/routes_test.dart Outdated
),
);

// Push first page with custom transition builder
Copy link
Contributor

@MitchellGoodwin MitchellGoodwin Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: prefer punctuation in comments, so :

Suggested change
// Push first page with custom transition builder
// Push first page with custom transition builder.

packages/flutter/test/widgets/routes_test.dart Outdated
navigator.currentState!.pop();
await tester.pumpAndSettle();

// Verify home is still visible without transitions
Copy link
Contributor

@MitchellGoodwin MitchellGoodwin Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here with needing the period.

packages/flutter/test/widgets/routes_test.dart Outdated
// Verify home is still visible without transitions
expect(find.text('home'), findsOneWidget);

// Verify the delegated transition is removed
Copy link
Contributor

@MitchellGoodwin MitchellGoodwin Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@rkishan516 rkishan516 force-pushed the cupertino-sheet-route-popup branch from 2ddfa25 to 83d8819 Compare April 2, 2025 00:25
justinmc
justinmc approved these changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for adding the other test, looks good.

@MitchellGoodwin MitchellGoodwin added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 2, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 2, 2025
@matanlurey matanlurey removed this pull request from the merge queue due to a manual request Apr 2, 2025
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 2, 2025
@MitchellGoodwin MitchellGoodwin added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 2, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 2, 2025
Merged via the queue into flutter:master with commit 4503f2f Apr 2, 2025
76 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 2, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
4503f2f Fix: DelegateTransition for cupertino sheet route (flutter/fl…
dad8a89 
…utter#164675)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
4503f2f Fix: DelegateTransition for cupertino sheet route (flutter/fl…
05f5df9 
…utter#164675)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
4503f2f Fix: DelegateTransition for cupertino sheet route (flutter/fl…
2b0183d 
…utter#164675)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
4503f2f Fix: DelegateTransition for cupertino sheet route (flutter/fl…
723f18b 
…utter#164675)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
4503f2f Fix: DelegateTransition for cupertino sheet route (flutter/fl…
c6bf64f 
…utter#164675)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
4503f2f Fix: DelegateTransition for cupertino sheet route (flutter/fl…
0ed735b 
…utter#164675)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
4503f2f Fix: DelegateTransition for cupertino sheet route (flutter/fl…
d0fbf27 
…utter#164675)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 3, 2025
Merged
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 3, 2025
@engine-flutter-autoroll
Roll Flutter from a0b1b32 to 02f13c3 (37 revisions) (#8996)
267ac7b 
Roll Flutter from a0b1b32 to 02f13c3 (37 revisions)

flutter/flutter@a0b1b32...02f13c3

2025-04-03 [email protected] Roll Packages from 07496eb to 4a36dc6 (3 revisions) (flutter/flutter#166542)
2025-04-03 [email protected] Roll Skia from b67e53719e78 to 5f65df75febd (2 revisions) (flutter/flutter#166538)
2025-04-03 [email protected] Update docs to debug the Android embedder (flutter/flutter#166170)
2025-04-03 [email protected] Roll Dart SDK from 72562ca93bb5 to d174ec16c3ea (1 revision) (flutter/flutter#166525)
2025-04-03 [email protected] [macOS] Implement merged UI and platform thread (flutter/flutter#162883)
2025-04-03 [email protected] Roll Skia from f91412f5d89d to b67e53719e78 (1 revision) (flutter/flutter#166527)
2025-04-03 [email protected] Roll Packages from 125c117 to 07496eb (31 revisions) (flutter/flutter#166457)
2025-04-03 [email protected] Roll Skia from 2be12bc2668b to f91412f5d89d (2 revisions) (flutter/flutter#166517)
2025-04-03 [email protected] Roll Dart SDK from 2a1a13cc3a91 to 72562ca93bb5 (2 revisions) (flutter/flutter#166514)
2025-04-03 [email protected] [native_assets] Roll dependencies (flutter/flutter#166282)
2025-04-03 [email protected] Fix read only TextField focus traversal on macOS (flutter/flutter#166056)
2025-04-03 [email protected] Roll Skia from c106d7831592 to 2be12bc2668b (1 revision) (flutter/flutter#166509)
2025-04-03 [email protected] Roll Fuchsia Linux SDK from v7PGvypiiWLO8PbsZ... to vYisSsIgqw0mqFRVJ... (flutter/flutter#166508)
2025-04-03 [email protected] Roll Dart SDK from b8b4076b1237 to 2a1a13cc3a91 (1 revision) (flutter/flutter#166504)
2025-04-03 [email protected] Roll Skia from 75a0ec473181 to c106d7831592 (1 revision) (flutter/flutter#166499)
2025-04-03 [email protected] Migrate to Theme.brightnessOf method (flutter/flutter#163950)
2025-04-03 [email protected] Fix: Range slider show overlay for both thumbs on hovering one (flutter/flutter#165393)
2025-04-03 [email protected] Deprecate ExpansionTileController (flutter/flutter#166368)
2025-04-03 [email protected] Add styling parameters in `PopupMenuDivider` (flutter/flutter#164790)
2025-04-03 [email protected] Fix ISSUE_TEMPLATE Ordering: `10 < 9`, but `10 > 09` (flutter/flutter#166455)
2025-04-03 [email protected] Skip flaking scheduler test (flutter/flutter#166471)
2025-04-02 [email protected] Roll pub packages (flutter/flutter#166043)
2025-04-02 [email protected] [a11y] add SemanticsValidationResult (flutter/flutter#165935)
2025-04-02 [email protected] Remove unnecessary cache busting mechanism in hot restart (flutter/flutter#166295)
2025-04-02 [email protected] Roll Skia from 52cbb917fffd to 75a0ec473181 (21 revisions) (flutter/flutter#166484)
2025-04-02 [email protected] Started pixel aligning hairlines (flutter/flutter#166351)
2025-04-02 [email protected] Adds semantics role and adjust semantics for navigation bar (flutter/flutter#162467)
2025-04-02 [email protected] Reland "[skwasm] Dynamic Threading" (flutter/flutter#166454)
2025-04-02 [email protected] [dart:ui] Add `Path.addRSuperellipse` (flutter/flutter#166045)
2025-04-02 [email protected] Fix: Hero animation for page transition (flutter/flutter#164469)
2025-04-02 [email protected] Fix: DelegateTransition for cupertino sheet route (flutter/flutter#164675)
2025-04-02 [email protected] Roll Fuchsia Test Scripts from AEdsljKmUiPk92Wvv... to FZdRtNwH7jmADecj6... (flutter/flutter#166383)
2025-04-02 [email protected] [Impeller] cache for text shadows. (flutter/flutter#166228)
2025-04-02 [email protected] Convert `AppPluginLoaderPlugin` to Kotlin, and add `NativePluginLoaderReflectionBridge` to expose it in Kotlin (flutter/flutter#166027)
2025-04-02 [email protected] Roll Dart SDK from 4e1f02bc704f to b8b4076b1237 (7 revisions) (flutter/flutter#166474)
2025-04-02 [email protected] Update Roadmap (flutter/flutter#166332)
2025-04-02 [email protected] Update `CODEOWNERS` (flutter/flutter#166444)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

...
This was referenced Apr 10, 2025
Closed
Closed
@Piinks Piinks mentioned this pull request Apr 18, 2025
Open
CodixNinja pushed a commit to CodixNinja/packages that referenced this pull request May 15, 2025
@engine-flutter-autoroll
Roll Flutter from a0b1b3253416 to 02f13c37841f (37 revisions) (#8996)
57f42e1 
Roll Flutter from a0b1b3253416 to 02f13c37841f (37 revisions)

flutter/flutter@a0b1b32...02f13c3

2025-04-03 [email protected] Roll Packages from d10d5af to 95f8e65 (3 revisions) (flutter/flutter#166542)
2025-04-03 [email protected] Roll Skia from b67e53719e78 to 5f65df75febd (2 revisions) (flutter/flutter#166538)
2025-04-03 [email protected] Update docs to debug the Android embedder (flutter/flutter#166170)
2025-04-03 [email protected] Roll Dart SDK from 72562ca93bb5 to d174ec16c3ea (1 revision) (flutter/flutter#166525)
2025-04-03 [email protected] [macOS] Implement merged UI and platform thread (flutter/flutter#162883)
2025-04-03 [email protected] Roll Skia from f91412f5d89d to b67e53719e78 (1 revision) (flutter/flutter#166527)
2025-04-03 [email protected] Roll Packages from 0d5d57b to d10d5af (31 revisions) (flutter/flutter#166457)
2025-04-03 [email protected] Roll Skia from 2be12bc2668b to f91412f5d89d (2 revisions) (flutter/flutter#166517)
2025-04-03 [email protected] Roll Dart SDK from 2a1a13cc3a91 to 72562ca93bb5 (2 revisions) (flutter/flutter#166514)
2025-04-03 [email protected] [native_assets] Roll dependencies (flutter/flutter#166282)
2025-04-03 [email protected] Fix read only TextField focus traversal on macOS (flutter/flutter#166056)
2025-04-03 [email protected] Roll Skia from c106d7831592 to 2be12bc2668b (1 revision) (flutter/flutter#166509)
2025-04-03 [email protected] Roll Fuchsia Linux SDK from v7PGvypiiWLO8PbsZ... to vYisSsIgqw0mqFRVJ... (flutter/flutter#166508)
2025-04-03 [email protected] Roll Dart SDK from b8b4076b1237 to 2a1a13cc3a91 (1 revision) (flutter/flutter#166504)
2025-04-03 [email protected] Roll Skia from 75a0ec473181 to c106d7831592 (1 revision) (flutter/flutter#166499)
2025-04-03 [email protected] Migrate to Theme.brightnessOf method (flutter/flutter#163950)
2025-04-03 [email protected] Fix: Range slider show overlay for both thumbs on hovering one (flutter/flutter#165393)
2025-04-03 [email protected] Deprecate ExpansionTileController (flutter/flutter#166368)
2025-04-03 [email protected] Add styling parameters in `PopupMenuDivider` (flutter/flutter#164790)
2025-04-03 [email protected] Fix ISSUE_TEMPLATE Ordering: `10 < 9`, but `10 > 09` (flutter/flutter#166455)
2025-04-03 [email protected] Skip flaking scheduler test (flutter/flutter#166471)
2025-04-02 [email protected] Roll pub packages (flutter/flutter#166043)
2025-04-02 [email protected] [a11y] add SemanticsValidationResult (flutter/flutter#165935)
2025-04-02 [email protected] Remove unnecessary cache busting mechanism in hot restart (flutter/flutter#166295)
2025-04-02 [email protected] Roll Skia from 52cbb917fffd to 75a0ec473181 (21 revisions) (flutter/flutter#166484)
2025-04-02 [email protected] Started pixel aligning hairlines (flutter/flutter#166351)
2025-04-02 [email protected] Adds semantics role and adjust semantics for navigation bar (flutter/flutter#162467)
2025-04-02 [email protected] Reland "[skwasm] Dynamic Threading" (flutter/flutter#166454)
2025-04-02 [email protected] [dart:ui] Add `Path.addRSuperellipse` (flutter/flutter#166045)
2025-04-02 [email protected] Fix: Hero animation for page transition (flutter/flutter#164469)
2025-04-02 [email protected] Fix: DelegateTransition for cupertino sheet route (flutter/flutter#164675)
2025-04-02 [email protected] Roll Fuchsia Test Scripts from AEdsljKmUiPk92Wvv... to FZdRtNwH7jmADecj6... (flutter/flutter#166383)
2025-04-02 [email protected] [Impeller] cache for text shadows. (flutter/flutter#166228)
2025-04-02 [email protected] Convert `AppPluginLoaderPlugin` to Kotlin, and add `NativePluginLoaderReflectionBridge` to expose it in Kotlin (flutter/flutter#166027)
2025-04-02 [email protected] Roll Dart SDK from 4e1f02bc704f to b8b4076b1237 (7 revisions) (flutter/flutter#166474)
2025-04-02 [email protected] Update Roadmap (flutter/flutter#166332)
2025-04-02 [email protected] Update `CODEOWNERS` (flutter/flutter#166444)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
4503f2f Fix: DelegateTransition for cupertino sheet route (flutter/fl…
6607eb6 
…utter#164675)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
4503f2f Fix: DelegateTransition for cupertino sheet route (flutter/fl…
164b91f 
…utter#164675)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
4503f2f Fix: DelegateTransition for cupertino sheet route (flutter/fl…
01c31e0 
…utter#164675)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Roll Flutter from a0b1b32 to 02f13c3 (37 revisions) (flutter#8996)
13118fd 
Roll Flutter from a0b1b32 to 02f13c3 (37 revisions)

flutter/flutter@a0b1b32...02f13c3

2025-04-03 [email protected] Roll Packages from 07496eb to 4a36dc6 (3 revisions) (flutter/flutter#166542)
2025-04-03 [email protected] Roll Skia from b67e53719e78 to 5f65df75febd (2 revisions) (flutter/flutter#166538)
2025-04-03 [email protected] Update docs to debug the Android embedder (flutter/flutter#166170)
2025-04-03 [email protected] Roll Dart SDK from 72562ca93bb5 to d174ec16c3ea (1 revision) (flutter/flutter#166525)
2025-04-03 [email protected] [macOS] Implement merged UI and platform thread (flutter/flutter#162883)
2025-04-03 [email protected] Roll Skia from f91412f5d89d to b67e53719e78 (1 revision) (flutter/flutter#166527)
2025-04-03 [email protected] Roll Packages from 125c117 to 07496eb (31 revisions) (flutter/flutter#166457)
2025-04-03 [email protected] Roll Skia from 2be12bc2668b to f91412f5d89d (2 revisions) (flutter/flutter#166517)
2025-04-03 [email protected] Roll Dart SDK from 2a1a13cc3a91 to 72562ca93bb5 (2 revisions) (flutter/flutter#166514)
2025-04-03 [email protected] [native_assets] Roll dependencies (flutter/flutter#166282)
2025-04-03 [email protected] Fix read only TextField focus traversal on macOS (flutter/flutter#166056)
2025-04-03 [email protected] Roll Skia from c106d7831592 to 2be12bc2668b (1 revision) (flutter/flutter#166509)
2025-04-03 [email protected] Roll Fuchsia Linux SDK from v7PGvypiiWLO8PbsZ... to vYisSsIgqw0mqFRVJ... (flutter/flutter#166508)
2025-04-03 [email protected] Roll Dart SDK from b8b4076b1237 to 2a1a13cc3a91 (1 revision) (flutter/flutter#166504)
2025-04-03 [email protected] Roll Skia from 75a0ec473181 to c106d7831592 (1 revision) (flutter/flutter#166499)
2025-04-03 [email protected] Migrate to Theme.brightnessOf method (flutter/flutter#163950)
2025-04-03 [email protected] Fix: Range slider show overlay for both thumbs on hovering one (flutter/flutter#165393)
2025-04-03 [email protected] Deprecate ExpansionTileController (flutter/flutter#166368)
2025-04-03 [email protected] Add styling parameters in `PopupMenuDivider` (flutter/flutter#164790)
2025-04-03 [email protected] Fix ISSUE_TEMPLATE Ordering: `10 < 9`, but `10 > 09` (flutter/flutter#166455)
2025-04-03 [email protected] Skip flaking scheduler test (flutter/flutter#166471)
2025-04-02 [email protected] Roll pub packages (flutter/flutter#166043)
2025-04-02 [email protected] [a11y] add SemanticsValidationResult (flutter/flutter#165935)
2025-04-02 [email protected] Remove unnecessary cache busting mechanism in hot restart (flutter/flutter#166295)
2025-04-02 [email protected] Roll Skia from 52cbb917fffd to 75a0ec473181 (21 revisions) (flutter/flutter#166484)
2025-04-02 [email protected] Started pixel aligning hairlines (flutter/flutter#166351)
2025-04-02 [email protected] Adds semantics role and adjust semantics for navigation bar (flutter/flutter#162467)
2025-04-02 [email protected] Reland "[skwasm] Dynamic Threading" (flutter/flutter#166454)
2025-04-02 [email protected] [dart:ui] Add `Path.addRSuperellipse` (flutter/flutter#166045)
2025-04-02 [email protected] Fix: Hero animation for page transition (flutter/flutter#164469)
2025-04-02 [email protected] Fix: DelegateTransition for cupertino sheet route (flutter/flutter#164675)
2025-04-02 [email protected] Roll Fuchsia Test Scripts from AEdsljKmUiPk92Wvv... to FZdRtNwH7jmADecj6... (flutter/flutter#166383)
2025-04-02 [email protected] [Impeller] cache for text shadows. (flutter/flutter#166228)
2025-04-02 [email protected] Convert `AppPluginLoaderPlugin` to Kotlin, and add `NativePluginLoaderReflectionBridge` to expose it in Kotlin (flutter/flutter#166027)
2025-04-02 [email protected] Roll Dart SDK from 4e1f02bc704f to b8b4076b1237 (7 revisions) (flutter/flutter#166474)
2025-04-02 [email protected] Update Roadmap (flutter/flutter#166332)
2025-04-02 [email protected] Update `CODEOWNERS` (flutter/flutter#166444)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

...
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
@rkishan516
Fix: DelegateTransition for cupertino sheet route (flutter#164675)
13ccbe5 
Fix: DelegateTransition for cupertino sheet route
fixes: flutter#163954 

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Roll Flutter from a0b1b32 to 02f13c3 (37 revisions) (flutter#8996)
174ab15 
Roll Flutter from a0b1b32 to 02f13c3 (37 revisions)

flutter/flutter@a0b1b32...02f13c3

2025-04-03 [email protected] Roll Packages from 07496eb to 4a36dc6 (3 revisions) (flutter/flutter#166542)
2025-04-03 [email protected] Roll Skia from b67e53719e78 to 5f65df75febd (2 revisions) (flutter/flutter#166538)
2025-04-03 [email protected] Update docs to debug the Android embedder (flutter/flutter#166170)
2025-04-03 [email protected] Roll Dart SDK from 72562ca93bb5 to d174ec16c3ea (1 revision) (flutter/flutter#166525)
2025-04-03 [email protected] [macOS] Implement merged UI and platform thread (flutter/flutter#162883)
2025-04-03 [email protected] Roll Skia from f91412f5d89d to b67e53719e78 (1 revision) (flutter/flutter#166527)
2025-04-03 [email protected] Roll Packages from 125c117 to 07496eb (31 revisions) (flutter/flutter#166457)
2025-04-03 [email protected] Roll Skia from 2be12bc2668b to f91412f5d89d (2 revisions) (flutter/flutter#166517)
2025-04-03 [email protected] Roll Dart SDK from 2a1a13cc3a91 to 72562ca93bb5 (2 revisions) (flutter/flutter#166514)
2025-04-03 [email protected] [native_assets] Roll dependencies (flutter/flutter#166282)
2025-04-03 [email protected] Fix read only TextField focus traversal on macOS (flutter/flutter#166056)
2025-04-03 [email protected] Roll Skia from c106d7831592 to 2be12bc2668b (1 revision) (flutter/flutter#166509)
2025-04-03 [email protected] Roll Fuchsia Linux SDK from v7PGvypiiWLO8PbsZ... to vYisSsIgqw0mqFRVJ... (flutter/flutter#166508)
2025-04-03 [email protected] Roll Dart SDK from b8b4076b1237 to 2a1a13cc3a91 (1 revision) (flutter/flutter#166504)
2025-04-03 [email protected] Roll Skia from 75a0ec473181 to c106d7831592 (1 revision) (flutter/flutter#166499)
2025-04-03 [email protected] Migrate to Theme.brightnessOf method (flutter/flutter#163950)
2025-04-03 [email protected] Fix: Range slider show overlay for both thumbs on hovering one (flutter/flutter#165393)
2025-04-03 [email protected] Deprecate ExpansionTileController (flutter/flutter#166368)
2025-04-03 [email protected] Add styling parameters in `PopupMenuDivider` (flutter/flutter#164790)
2025-04-03 [email protected] Fix ISSUE_TEMPLATE Ordering: `10 < 9`, but `10 > 09` (flutter/flutter#166455)
2025-04-03 [email protected] Skip flaking scheduler test (flutter/flutter#166471)
2025-04-02 [email protected] Roll pub packages (flutter/flutter#166043)
2025-04-02 [email protected] [a11y] add SemanticsValidationResult (flutter/flutter#165935)
2025-04-02 [email protected] Remove unnecessary cache busting mechanism in hot restart (flutter/flutter#166295)
2025-04-02 [email protected] Roll Skia from 52cbb917fffd to 75a0ec473181 (21 revisions) (flutter/flutter#166484)
2025-04-02 [email protected] Started pixel aligning hairlines (flutter/flutter#166351)
2025-04-02 [email protected] Adds semantics role and adjust semantics for navigation bar (flutter/flutter#162467)
2025-04-02 [email protected] Reland "[skwasm] Dynamic Threading" (flutter/flutter#166454)
2025-04-02 [email protected] [dart:ui] Add `Path.addRSuperellipse` (flutter/flutter#166045)
2025-04-02 [email protected] Fix: Hero animation for page transition (flutter/flutter#164469)
2025-04-02 [email protected] Fix: DelegateTransition for cupertino sheet route (flutter/flutter#164675)
2025-04-02 [email protected] Roll Fuchsia Test Scripts from AEdsljKmUiPk92Wvv... to FZdRtNwH7jmADecj6... (flutter/flutter#166383)
2025-04-02 [email protected] [Impeller] cache for text shadows. (flutter/flutter#166228)
2025-04-02 [email protected] Convert `AppPluginLoaderPlugin` to Kotlin, and add `NativePluginLoaderReflectionBridge` to expose it in Kotlin (flutter/flutter#166027)
2025-04-02 [email protected] Roll Dart SDK from 4e1f02bc704f to b8b4076b1237 (7 revisions) (flutter/flutter#166474)
2025-04-02 [email protected] Update Roadmap (flutter/flutter#166332)
2025-04-02 [email protected] Update `CODEOWNERS` (flutter/flutter#166444)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

...
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@engine-flutter-autoroll @Ortes
Roll Flutter from a0b1b32 to 02f13c3 (37 revisions) (flutter#8996)
eba64e6 
Roll Flutter from a0b1b32 to 02f13c3 (37 revisions)

flutter/flutter@a0b1b32...02f13c3

2025-04-03 [email protected] Roll Packages from 07496eb to 4a36dc6 (3 revisions) (flutter/flutter#166542)
2025-04-03 [email protected] Roll Skia from b67e53719e78 to 5f65df75febd (2 revisions) (flutter/flutter#166538)
2025-04-03 [email protected] Update docs to debug the Android embedder (flutter/flutter#166170)
2025-04-03 [email protected] Roll Dart SDK from 72562ca93bb5 to d174ec16c3ea (1 revision) (flutter/flutter#166525)
2025-04-03 [email protected] [macOS] Implement merged UI and platform thread (flutter/flutter#162883)
2025-04-03 [email protected] Roll Skia from f91412f5d89d to b67e53719e78 (1 revision) (flutter/flutter#166527)
2025-04-03 [email protected] Roll Packages from 125c117 to 07496eb (31 revisions) (flutter/flutter#166457)
2025-04-03 [email protected] Roll Skia from 2be12bc2668b to f91412f5d89d (2 revisions) (flutter/flutter#166517)
2025-04-03 [email protected] Roll Dart SDK from 2a1a13cc3a91 to 72562ca93bb5 (2 revisions) (flutter/flutter#166514)
2025-04-03 [email protected] [native_assets] Roll dependencies (flutter/flutter#166282)
2025-04-03 [email protected] Fix read only TextField focus traversal on macOS (flutter/flutter#166056)
2025-04-03 [email protected] Roll Skia from c106d7831592 to 2be12bc2668b (1 revision) (flutter/flutter#166509)
2025-04-03 [email protected] Roll Fuchsia Linux SDK from v7PGvypiiWLO8PbsZ... to vYisSsIgqw0mqFRVJ... (flutter/flutter#166508)
2025-04-03 [email protected] Roll Dart SDK from b8b4076b1237 to 2a1a13cc3a91 (1 revision) (flutter/flutter#166504)
2025-04-03 [email protected] Roll Skia from 75a0ec473181 to c106d7831592 (1 revision) (flutter/flutter#166499)
2025-04-03 [email protected] Migrate to Theme.brightnessOf method (flutter/flutter#163950)
2025-04-03 [email protected] Fix: Range slider show overlay for both thumbs on hovering one (flutter/flutter#165393)
2025-04-03 [email protected] Deprecate ExpansionTileController (flutter/flutter#166368)
2025-04-03 [email protected] Add styling parameters in `PopupMenuDivider` (flutter/flutter#164790)
2025-04-03 [email protected] Fix ISSUE_TEMPLATE Ordering: `10 < 9`, but `10 > 09` (flutter/flutter#166455)
2025-04-03 [email protected] Skip flaking scheduler test (flutter/flutter#166471)
2025-04-02 [email protected] Roll pub packages (flutter/flutter#166043)
2025-04-02 [email protected] [a11y] add SemanticsValidationResult (flutter/flutter#165935)
2025-04-02 [email protected] Remove unnecessary cache busting mechanism in hot restart (flutter/flutter#166295)
2025-04-02 [email protected] Roll Skia from 52cbb917fffd to 75a0ec473181 (21 revisions) (flutter/flutter#166484)
2025-04-02 [email protected] Started pixel aligning hairlines (flutter/flutter#166351)
2025-04-02 [email protected] Adds semantics role and adjust semantics for navigation bar (flutter/flutter#162467)
2025-04-02 [email protected] Reland "[skwasm] Dynamic Threading" (flutter/flutter#166454)
2025-04-02 [email protected] [dart:ui] Add `Path.addRSuperellipse` (flutter/flutter#166045)
2025-04-02 [email protected] Fix: Hero animation for page transition (flutter/flutter#164469)
2025-04-02 [email protected] Fix: DelegateTransition for cupertino sheet route (flutter/flutter#164675)
2025-04-02 [email protected] Roll Fuchsia Test Scripts from AEdsljKmUiPk92Wvv... to FZdRtNwH7jmADecj6... (flutter/flutter#166383)
2025-04-02 [email protected] [Impeller] cache for text shadows. (flutter/flutter#166228)
2025-04-02 [email protected] Convert `AppPluginLoaderPlugin` to Kotlin, and add `NativePluginLoaderReflectionBridge` to expose it in Kotlin (flutter/flutter#166027)
2025-04-02 [email protected] Roll Dart SDK from 4e1f02bc704f to b8b4076b1237 (7 revisions) (flutter/flutter#166474)
2025-04-02 [email protected] Update Roadmap (flutter/flutter#166332)
2025-04-02 [email protected] Update `CODEOWNERS` (flutter/flutter#166444)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

...
@LongCatIsLooong LongCatIsLooong mentioned this pull request Aug 7, 2025
Open
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@rkishan516 @romanejaquez
Fix: DelegateTransition for cupertino sheet route (flutter#164675)
8d863a6 
Fix: DelegateTransition for cupertino sheet route
fixes: flutter#163954 

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

@MitchellGoodwin MitchellGoodwin MitchellGoodwin approved these changes

Assignees

No one assigned

Labels

f: cupertino flutter/packages/flutter/cupertino repository f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CupertinoSheetRoute causes error when opening PopupMenuButton after closing the route

3 participants

@rkishan516 @MitchellGoodwin @justinmc