[hcpp] Add tests for transform mutator #164664

gmackall · 2025-03-05T23:33:10Z

Adds tests covering all transform cases (rotation, flipping, scaling, translation).

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gmackall · 2025-03-06T00:09:01Z

...ntegration_tests/android_engine_test/test_driver/hcpp/platform_view_transform_main_test.dart

+      await flutterDriver.tap(find.byValueKey('Rotate'));
+      await expectLater(
+        nativeDriver.screenshot(),
+        matchesGoldenFile('$goldenPrefix.no_transform.png'),


Is this a bad idea due to floating point innacuracy? Should I instead make the test rotate and then rotate back?

Skia gold allows us to have multiple correct matches. I think given this runs on the same emulator it should be OK, but we can find out :)

gmackall · 2025-03-06T00:11:26Z

From my testing this is actually working as implemented, the problems were due to using blue_orange_gradient_surface_view_platform_view which was not handling rotation. When I changed to blue_orange_gradient_platform_view, the rotation worked correctly.

jonahwilliams · 2025-03-06T00:13:19Z

Awesome!

jonahwilliams

LGTM

dev/integration_tests/android_engine_test/lib/hcpp/platform_view_transform_main.dart

flutter-dashboard · 2025-03-06T01:34:15Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #164664 at sha 5e7a3b6

jonahwilliams · 2025-03-06T01:41:48Z

It looks like the overflow indicator is triggering in the test harness. I would adjust the layout so that doesn't happen.

…is works?

flutter-dashboard · 2025-03-06T09:01:14Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #164664 at sha 7f6db9b

gmackall · 2025-03-06T17:57:23Z

Adjusted the layout slightly no longer seeing an overflow. Images look like expected

flutter/flutter@321fbc0...6b93cf9 2025-03-07 [email protected] Roll Skia from 32c1931117b8 to cbc7e99d6c2f (1 revision) (flutter/flutter#164788) 2025-03-07 [email protected] Roll Packages from fc9d5ca to 4c5a7ed (4 revisions) (flutter/flutter#164785) 2025-03-07 [email protected] Roll Skia from 79f8af105a61 to 32c1931117b8 (1 revision) (flutter/flutter#164782) 2025-03-07 [email protected] Roll Fuchsia Linux SDK from fhm5z889sA5T1AQao... to ixl5bKWCqsRiYGvps... (flutter/flutter#164780) 2025-03-07 [email protected] Roll Skia from 181d81920670 to 79f8af105a61 (1 revision) (flutter/flutter#164770) 2025-03-07 [email protected] Roll Skia from cc74d34e7e68 to 181d81920670 (1 revision) (flutter/flutter#164766) 2025-03-07 [email protected] Clip layers reduce rrects and paths to simpler shapes when possible (flutter/flutter#164693) 2025-03-07 [email protected] [Impeller] test empty snapshot and allocation failure. (flutter/flutter#164668) 2025-03-07 [email protected] Roll Skia from 263308ea4386 to cc74d34e7e68 (2 revisions) (flutter/flutter#164746) 2025-03-06 [email protected] Adds aria-controls support (flutter/flutter#163894) 2025-03-06 [email protected] Migrate Mutators to DisplayList/Impeller geometry (flutter/flutter#164258) 2025-03-06 [email protected] Add lldb init file (flutter/flutter#164344) 2025-03-06 [email protected] Use separate artifacts for arm64 and x64 versions of gen_snapshot on Apple platforms (flutter/flutter#164419) 2025-03-06 [email protected] Roll Skia from ccd8cc23aa94 to 263308ea4386 (1 revision) (flutter/flutter#164728) 2025-03-06 [email protected] [hcpp] Add tests for transform mutator (flutter/flutter#164664) 2025-03-06 [email protected] Roll pub packages (flutter/flutter#164721) 2025-03-06 [email protected] Roll Packages from abba683 to fc9d5ca (3 revisions) (flutter/flutter#164714) 2025-03-06 [email protected] Roll pub packages (flutter/flutter#164713) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Gray Mackall added 3 commits March 5, 2025 14:44

write the test app

037aa3c

add a test that rotates in a circle

4675a13

make the test more comprehensive

ebac9f8

gmackall changed the title ~~[hcpp] Add a test for transform mutator that rotates an app in a circle (by half pi increments)~~ [hcpp] Add tests for transform mutator Mar 6, 2025

gmackall marked this pull request as ready for review March 6, 2025 00:07

gmackall requested a review from matanlurey as a code owner March 6, 2025 00:07

Merge branch 'master' into transform_mutation_tests

beb80c3

gmackall requested a review from jonahwilliams March 6, 2025 00:08

gmackall commented Mar 6, 2025

View reviewed changes

jonahwilliams approved these changes Mar 6, 2025

View reviewed changes