Skip to content

Revert "Skip Xcode install on mac_mokey Android tests (#163685)" #164581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Mar 4, 2025
Merged

Revert "Skip Xcode install on mac_mokey Android tests (#163685)" #164581

auto-submit merged 1 commit into from
Mar 4, 2025

Conversation

@reidbaker
Copy link
Contributor

@reidbaker reidbaker commented Mar 4, 2025

This reverts commit 2a6b015.
Revert "Skip Xcode install on mac_mokey Android tests (#163685)"

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

camsim99
camsim99 approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Willing to try this out!

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 4, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Mar 4, 2025
Merged via the queue into flutter:master with commit 2578d97 Mar 4, 2025
150 of 151 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 4, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2025
@engine-flutter-autoroll
2578d97 Revert "Skip Xcode install on mac_mokey Android tests (#16368…
14a5f42 
…5)" (flutter/flutter#164581)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2025
@engine-flutter-autoroll
2578d97 Revert "Skip Xcode install on mac_mokey Android tests (#16368…
147527a 
…5)" (flutter/flutter#164581)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2025
@engine-flutter-autoroll
2578d97 Revert "Skip Xcode install on mac_mokey Android tests (#16368…
2d6c715 
…5)" (flutter/flutter#164581)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2025
@engine-flutter-autoroll
2578d97 Revert "Skip Xcode install on mac_mokey Android tests (#16368…
ddaf6e6 
…5)" (flutter/flutter#164581)
@reidbaker reidbaker deleted the i164570-revert-skip-xcode branch March 5, 2025 15:29
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2025
@engine-flutter-autoroll
2578d97 Revert "Skip Xcode install on mac_mokey Android tests (#16368…
78442ee 
…5)" (flutter/flutter#164581)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2025
@engine-flutter-autoroll
2578d97 Revert "Skip Xcode install on mac_mokey Android tests (#16368…
30514d3 
…5)" (flutter/flutter#164581)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2025
@engine-flutter-autoroll
2578d97 Revert "Skip Xcode install on mac_mokey Android tests (#16368…
38c40cc 
…5)" (flutter/flutter#164581)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2025
@engine-flutter-autoroll
2578d97 Revert "Skip Xcode install on mac_mokey Android tests (#16368…
2d946a5 
…5)" (flutter/flutter#164581)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2025
@engine-flutter-autoroll
2578d97 Revert "Skip Xcode install on mac_mokey Android tests (#16368…
4fd5aff 
…5)" (flutter/flutter#164581)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
2578d97 Revert "Skip Xcode install on mac_mokey Android tests (#16368…
0964ccd 
…5)" (flutter/flutter#164581)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
2578d97 Revert "Skip Xcode install on mac_mokey Android tests (#16368…
ea71b17 
…5)" (flutter/flutter#164581)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
2578d97 Revert "Skip Xcode install on mac_mokey Android tests (#16368…
e1b4430 
…5)" (flutter/flutter#164581)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtmcdole jtmcdole jtmcdole approved these changes

@camsim99 camsim99 camsim99 approved these changes

@jmagman jmagman Awaiting requested review from jmagman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reidbaker @jtmcdole @camsim99