[macos] prefer integrated GPU. #164569

jonahwilliams · 2025-03-04T19:13:52Z

Attempted fix for #163218

There are very few macOS devices with multiple GPUs and they were only brielfy sold. We seem to have a problem o the specific devices when choosing the dedicated GPU. INstead, lets try forcing the integrated GPU when its available.

loic-sharma · 2025-03-04T19:22:55Z

Not sure if you're aware, but on Windows we recently added an API so that users can set a GPU preference. If you add an API, ideally it should mirror the Windows API: #162490

knopp · 2025-03-04T19:23:53Z

Not sure if you're aware, but on Windows we recently added an API so that users can set a GPU preference. If you add an API, ideally it should mirror the Windows API: #162490

Yeah, the issue is that right now it crashes with the dedicated one :)

jonahwilliams · 2025-03-04T19:24:59Z

@loic-sharma I think if they were still making macbooks with multiple GPUs we'd probably support via enum like with windows, but support for multiple GPUs was removed with the arm mac so it seems like a dead end.

loic-sharma · 2025-03-04T19:25:46Z

Sounds good!

knopp

LGTM!

gaaclarke

The code looks fine to me. I'm still fuzzy on the premise. We want this because we've written the code to require unified memory and all integrated graphics cards we care about have unified memory? I'm not sure if that's going to be the case.

knopp · 2025-03-04T20:25:01Z

engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterRenderer.mm

+id<MTLDevice> SelectMetalDevice() {
+  NSArray<id<MTLDevice>>* devices = MTLCopyAllDevices();
+  for (id<MTLDevice> device in devices) {
+    if (!device.isRemovable && device.isLowPower) {


Shouldn't we use hasUnifiedMemory perhaps?

jonahwilliams · 2025-03-04T20:28:34Z

We don't actually need unified memory AFAIK. I can run on a much older macbook (2015) which I think doesn't have unified memory and it works fine 🤷

jonahwilliams · 2025-03-04T20:45:34Z

Let me double check on my 2015 Mac to see if it has unified memory.

jonahwilliams · 2025-03-05T00:57:21Z

Okay so looks like the 2015 macbook also has unified memory. So the crash seems to be specific to using GPUs without unified memory, which means a bug when using Shared memory types. I think as long as it works, its probably what we should prefer.

gaaclarke · 2025-03-05T16:21:04Z

So the crash seems to be specific to using GPUs without unified memory

Yay, glad to have gotten to the bottom of that. That was the most plausible explanation. It makes sense too since we have no test coverage from discrete gpus.

We should get this fixed since there are probably some android devices that don't have unified memory, like TVs, streaming boxes and cars.

flutter/flutter@2578d97...321fbc0 2025-03-06 [email protected] Roll Skia from fefecd49e03a to ccd8cc23aa94 (1 revision) (flutter/flutter#164712) 2025-03-06 [email protected] [web] Detect scrollable semantics nodes more reliably (flutter/flutter#164491) 2025-03-06 [email protected] [windows] wire the focus request and the focus events through the Windows platform (flutter/flutter#164296) 2025-03-06 [email protected] Roll Skia from 02897747c7d5 to fefecd49e03a (1 revision) (flutter/flutter#164701) 2025-03-06 [email protected] Roll Skia from e315b0ab7c84 to 02897747c7d5 (1 revision) (flutter/flutter#164677) 2025-03-06 [email protected] Roll Skia from 0c3880f94970 to e315b0ab7c84 (1 revision) (flutter/flutter#164669) 2025-03-06 [email protected] [Impeller] use device private on non-iOS devices. (flutter/flutter#164601) 2025-03-05 [email protected] Roll Skia from 43294a662fd0 to 0c3880f94970 (1 revision) (flutter/flutter#164661) 2025-03-05 [email protected] Add a workflow (only triggered from rest events) for hasing experiment (flutter/flutter#164657) 2025-03-05 [email protected] Roll Skia from 4cf9f0b77d41 to 43294a662fd0 (4 revisions) (flutter/flutter#164649) 2025-03-05 [email protected] Adds animateToItem to the CarouselController (flutter/flutter#162694) 2025-03-05 [email protected] Cleanup content context (flutter/flutter#164229) 2025-03-05 [email protected] Fix: Update CupertinoSheetRoute transition rounded corner (flutter/flutter#163700) 2025-03-05 [email protected] [Impeller] fix macOS managed memory. (flutter/flutter#164635) 2025-03-05 [email protected] [skwasm] Clear font collection cache when font is loaded manually. (flutter/flutter#164588) 2025-03-05 [email protected] Fix race condition causing crash when interacting with an animating scrollable (flutter/flutter#164392) 2025-03-05 [email protected] Use dwds 24.3.6 and pass uri for the reload scripts path to FrontendServerDdcLibraryBundleProvider (flutter/flutter#164582) 2025-03-05 [email protected] Roll Packages from 9e4684e to abba683 (8 revisions) (flutter/flutter#164630) 2025-03-05 [email protected] Roll Skia from 7e4323f72c9d to 4cf9f0b77d41 (1 revision) (flutter/flutter#164622) 2025-03-05 [email protected] Fix to Linux_pixel_7pro integration_ui_keyboard_resize test flakiness (flutter/flutter#162308) 2025-03-05 [email protected] Roll Skia from 03a3f653d64e to 7e4323f72c9d (1 revision) (flutter/flutter#164599) 2025-03-05 [email protected] Implement `clipPath` Mutator for hcpp (flutter/flutter#164525) 2025-03-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] use DeviceLocal textures for gifs on non-iOS devices. (#164573)" (flutter/flutter#164600) 2025-03-05 [email protected] [macos] prefer integrated GPU. (flutter/flutter#164569) 2025-03-05 [email protected] Enforce minSdk constraint for Android Flutter (flutter/flutter#164251) 2025-03-05 [email protected] Add `clipRSuperellipse`, and use them for dialogs (flutter/flutter#161111) 2025-03-05 [email protected] Roll Skia from 46705a22edc3 to 03a3f653d64e (1 revision) (flutter/flutter#164590) 2025-03-05 [email protected] when resetting FlutterPlatformViewsController, clear out some additional internal state to prevent it from carrying over across a Hot Restart (flutter/flutter#164456) 2025-03-05 [email protected] Roll Fuchsia Linux SDK from Rt6pxGFLVAJHduM0V... to fhm5z889sA5T1AQao... (flutter/flutter#164583) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

jonahwilliams added 2 commits March 4, 2025 11:10

[macos] prefer integrated GPU.

35146c3

++

7c66f50

github-actions bot added engine flutter/engine related. See also e: labels. a: desktop Running on desktop platform-macos labels Mar 4, 2025

jonahwilliams requested review from gaaclarke and knopp March 4, 2025 19:22

knopp approved these changes Mar 4, 2025

View reviewed changes

jonahwilliams marked this pull request as ready for review March 4, 2025 20:12

gaaclarke reviewed Mar 4, 2025

View reviewed changes

knopp reviewed Mar 4, 2025

View reviewed changes

Update FlutterRenderer.mm

283d23e

jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 5, 2025

auto-submit bot added this pull request to the merge queue Mar 5, 2025

Merged via the queue into flutter:master with commit ccf9922 Mar 5, 2025
175 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 5, 2025

jonahwilliams mentioned this pull request Mar 5, 2025

App crashes on macOS with Impeller enabled when using external GPU. #163218

Closed

engine-flutter-autoroll mentioned this pull request Mar 5, 2025

Manual roll Flutter from 04d39343a691 to ccf99229c76a (37 revisions) flutter/packages#8795

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2025

ccf9922 [macos] prefer integrated GPU. (flutter/flutter#164569)

19a5214

engine-flutter-autoroll mentioned this pull request Mar 5, 2025

Roll Flutter from 04d39343a691 to 296c54f7a001 (42 revisions) flutter/packages#8797

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2025

ccf9922 [macos] prefer integrated GPU. (flutter/flutter#164569)

622db4e

engine-flutter-autoroll mentioned this pull request Mar 5, 2025

Roll Flutter from 04d39343a691 to 5ca20d8d0e78 (43 revisions) flutter/packages#8798

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2025

ccf9922 [macos] prefer integrated GPU. (flutter/flutter#164569)

ea47bc0

engine-flutter-autoroll mentioned this pull request Mar 5, 2025

Roll Flutter from 04d39343a691 to 86e4c12a068a (44 revisions) flutter/packages#8799

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2025

ccf9922 [macos] prefer integrated GPU. (flutter/flutter#164569)

34b7ac6

engine-flutter-autoroll mentioned this pull request Mar 5, 2025

Manual roll Flutter from 04d39343a691 to 57cddce92438 (45 revisions) flutter/packages#8800

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2025

ccf9922 [macos] prefer integrated GPU. (flutter/flutter#164569)

3dfc7ae

engine-flutter-autoroll mentioned this pull request Mar 5, 2025

Roll Flutter from 04d39343a691 to 57cddce92438 (45 revisions) flutter/packages#8801

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2025

ccf9922 [macos] prefer integrated GPU. (flutter/flutter#164569)

ec01aca

engine-flutter-autoroll mentioned this pull request Mar 5, 2025

Roll Flutter from 04d39343a691 to 1e9676fc9527 (46 revisions) flutter/packages#8802

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2025

ccf9922 [macos] prefer integrated GPU. (flutter/flutter#164569)

96b47c2

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025

ccf9922 [macos] prefer integrated GPU. (flutter/flutter#164569)

5984c23

engine-flutter-autoroll mentioned this pull request Mar 6, 2025

Roll Flutter from 2578d97f32c8 to 099e6d39fe38 (27 revisions) flutter/packages#8806

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025

ccf9922 [macos] prefer integrated GPU. (flutter/flutter#164569)

9dbb936

engine-flutter-autoroll mentioned this pull request Mar 6, 2025

Roll Flutter from 2578d97f32c8 to d778ed25a485 (28 revisions) flutter/packages#8807

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025

ccf9922 [macos] prefer integrated GPU. (flutter/flutter#164569)

2233380

engine-flutter-autoroll mentioned this pull request Mar 6, 2025

Roll Flutter from 2578d97f32c8 to 321fbc0e7e81 (29 revisions) flutter/packages#8808

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

ccf9922 [macos] prefer integrated GPU. (flutter/flutter#164569)

1d4ccce

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

ccf9922 [macos] prefer integrated GPU. (flutter/flutter#164569)

951ddf9

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

ccf9922 [macos] prefer integrated GPU. (flutter/flutter#164569)

acc5de6

[macos] prefer integrated GPU. #164569

[macos] prefer integrated GPU. #164569

Uh oh!

Conversation

jonahwilliams commented Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

loic-sharma commented Mar 4, 2025

Uh oh!

knopp commented Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonahwilliams commented Mar 4, 2025

Uh oh!

loic-sharma commented Mar 4, 2025

Uh oh!

knopp left a comment

Choose a reason for hiding this comment

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

knopp Mar 4, 2025

Choose a reason for hiding this comment

Uh oh!

jonahwilliams Mar 5, 2025

Choose a reason for hiding this comment

Uh oh!

jonahwilliams commented Mar 4, 2025

Uh oh!

jonahwilliams commented Mar 4, 2025

Uh oh!

jonahwilliams commented Mar 5, 2025

Uh oh!

Uh oh!

gaaclarke commented Mar 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jonahwilliams commented Mar 4, 2025 •

edited

Loading

knopp commented Mar 4, 2025 •

edited

Loading