Overhaul update_engine_version.{sh|ps1} to reflect the new computation flow
#164513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtmcdole
reviewed
Mar 3, 2025
jtmcdole
approved these changes
Mar 3, 2025
matanlurey
added
autosubmit
This comment was marked as outdated.
This comment was marked as outdated.
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2025
…computation flow (flutter/flutter#164513)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2025
…computation flow (flutter/flutter#164513)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2025
…computation flow (flutter/flutter#164513)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2025
…computation flow (flutter/flutter#164513)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2025
…computation flow (flutter/flutter#164513)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2025
…computation flow (flutter/flutter#164513)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2025
…computation flow (flutter/flutter#164513)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2025
…computation flow (flutter/flutter#164513)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 4, 2025
…computation flow (flutter/flutter#164513)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 5, 2025
…computation flow (flutter/flutter#164513)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 5, 2025
…computation flow (flutter/flutter#164513)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 5, 2025
…computation flow (flutter/flutter#164513)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 5, 2025
…computation flow (flutter/flutter#164513)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 5, 2025
…computation flow (flutter/flutter#164513)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 5, 2025
…computation flow (flutter/flutter#164513)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 5, 2025
…computation flow (flutter/flutter#164513)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
…computation flow (flutter/flutter#164513)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
…computation flow (flutter/flutter#164513)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 21, 2025
…computation flow (flutter/flutter#164513)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #164030.
Closes #164315.
Towards #163896.
Significantly simplified! We removed:
LUCI_CONTEXT(LUCI takes care of itself now, see Roll forward #4254 with fixes/tests (always setFLUTTER_PREBUILT_ENGINE_VERSIONfrom framework tests) cocoon#4261)You can see the results first hand in the tests, which are now much simpler.
Canonical docs: https://github.com/flutter/flutter/blob/master/docs/tool/Engine-artifacts.md.