Skip to content

Fix: Update sheet route bottom padding with top padding #164473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Apr 15, 2025
Merged

Fix: Update sheet route bottom padding with top padding #164473

auto-submit merged 1 commit into from
Apr 15, 2025

Conversation

@rkishan516
Copy link
Contributor

@rkishan516 rkishan516 commented Mar 3, 2025

Fix: Update sheet route bottom padding with top padding
fixes: #163572
fixes: #164087

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels Mar 3, 2025
@rkishan516 rkishan516 force-pushed the cupertino-sheet-route-behaviour branch from a95ae7b to 22e535e Compare March 3, 2025 08:48
@rkishan516 rkishan516 force-pushed the cupertino-sheet-route-behaviour branch from 22e535e to 659309f Compare March 26, 2025 03:13
MitchellGoodwin
MitchellGoodwin reviewed Apr 1, 2025
View reviewed changes
Copy link
Contributor

@MitchellGoodwin MitchellGoodwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question about removing duplicate code.

@rkishan516 rkishan516 force-pushed the cupertino-sheet-route-behaviour branch from 659309f to 6bcae65 Compare April 2, 2025 17:33
MitchellGoodwin
MitchellGoodwin approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@MitchellGoodwin MitchellGoodwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for putting this together!

justinmc
justinmc approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 . Google testing is red but it looks like an infra problem. I've rerun it.

@MitchellGoodwin MitchellGoodwin force-pushed the cupertino-sheet-route-behaviour branch from 6bcae65 to 094bbb2 Compare April 10, 2025 21:34
@MitchellGoodwin MitchellGoodwin force-pushed the cupertino-sheet-route-behaviour branch from 094bbb2 to d110d9e Compare April 15, 2025 18:40
@MitchellGoodwin MitchellGoodwin added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 15, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 15, 2025
Merged via the queue into flutter:master with commit 2f30429 Apr 15, 2025
74 of 75 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 15, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 15, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
2f30429b9 Fix: Update sheet route bottom padding with top padding (fl…
118817a 
…utter/flutter#164473)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 16, 2025
@engine-flutter-autoroll
Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions) (#9092)
1f0a894 
Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions)

Manual roll requested by [email protected]

flutter/flutter@30e53b0...db68c95

2025-04-15 [email protected] [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212)
2025-04-15 [email protected] Roll Packages from f26b681 to 2fcc403 (4 revisions) (flutter/flutter#167218)
2025-04-15 [email protected] Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473)
2025-04-15 [email protected] Add Irish(ga) to Flutter (flutter/flutter#167129)
2025-04-15 [email protected] Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213)
2025-04-15 [email protected] Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639)
2025-04-15 [email protected] fix: Update time picker dialog input size (flutter/flutter#163184)
2025-04-15 [email protected] Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204)
2025-04-15 [email protected] [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001)
2025-04-15 [email protected] Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206)
2025-04-15 [email protected] Persistent CupertinoListTile leading and trailing (flutter/flutter#166799)
2025-04-15 [email protected] Add buildroot compatibility for HWASAN. (flutter/flutter#167133)
2025-04-15 [email protected] Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569)
2025-04-15 [email protected] Clip bottom widgets in nav bar transition (flutter/flutter#166705)
2025-04-14 [email protected] Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132)
2025-04-14 [email protected] [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929)
2025-04-14 [email protected] Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916)
2025-04-14 [email protected] Roll Packages from 465bcff to f26b681 (1 revision) (flutter/flutter#167122)
2025-04-14 [email protected] [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997)
2025-04-14 [email protected] Remove some unused third party library build scripts (flutter/flutter#166960)
2025-04-14 [email protected] [reland] Fix regression in NDK version checking (flutter/flutter#167011)
2025-04-14 [email protected] Add network permissions information to the dart doc of network image.  (flutter/flutter#167110)
2025-04-14 [email protected] Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994)
2025-04-12 [email protected] [Impeller] various iOS cleanups. (flutter/flutter#166859)
2025-04-11 [email protected] [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007)
2025-04-11 [email protected] Fix regression in NDK version checking (flutter/flutter#166998)
2025-04-11 [email protected] [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637)
2025-04-11 [email protected] [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957)
2025-04-11 [email protected] modify toggle mode style with DatePickerTheme (flutter/flutter#164102)
2025-04-11 [email protected] [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990)
2025-04-11 [email protected] Roll Packages from 431dc61 to 465bcff (2 revisions) (flutter/flutter#166982)
2025-04-11 [email protected] [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941)
2025-04-11 [email protected] Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877)
2025-04-11 [email protected] [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977)
2025-04-11 [email protected] [native assets] Roll dependencies (flutter/flutter#166969)
2025-04-11 [email protected] Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966)
2025-04-11 [email protected] Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963)
2025-04-11 [email protected] [native assets] Support user-defines in pubspec (flutter/flutter#166940)
2025-04-11 [email protected] [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892)
2025-04-11 [email protected] [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943)
2025-04-11 [email protected] Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889)
2025-04-11 [email protected] Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955)
...
mboetger pushed a commit to mboetger/flutter that referenced this pull request Apr 16, 2025
@rkishan516 @mboetger
Fix: Update sheet route bottom padding with top padding (flutter#164473)
6c6dbb2 
Fix: Update sheet route bottom padding with top padding
fixes: flutter#163572 
fixes: flutter#164087 

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
ash2moon pushed a commit to ash2moon/flutter that referenced this pull request Apr 21, 2025
@rkishan516 @ash2moon
Fix: Update sheet route bottom padding with top padding (flutter#164473)
b73d809 
Fix: Update sheet route bottom padding with top padding
fixes: flutter#163572 
fixes: flutter#164087 

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
CodixNinja pushed a commit to CodixNinja/packages that referenced this pull request May 15, 2025
@engine-flutter-autoroll
Manual roll Flutter from 30e53b0d9caa to db68c950c599 (98 revisions) …
fc4e794 
…(#9092)

Manual roll Flutter from 30e53b0d9caa to db68c950c599 (98 revisions)

Manual roll requested by [email protected]

flutter/flutter@30e53b0...db68c95

2025-04-15 [email protected] [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212)
2025-04-15 [email protected] Roll Packages from 853e96a to a5ed6cb (4 revisions) (flutter/flutter#167218)
2025-04-15 [email protected] Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473)
2025-04-15 [email protected] Add Irish(ga) to Flutter (flutter/flutter#167129)
2025-04-15 [email protected] Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213)
2025-04-15 [email protected] Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639)
2025-04-15 [email protected] fix: Update time picker dialog input size (flutter/flutter#163184)
2025-04-15 [email protected] Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204)
2025-04-15 [email protected] [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001)
2025-04-15 [email protected] Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206)
2025-04-15 [email protected] Persistent CupertinoListTile leading and trailing (flutter/flutter#166799)
2025-04-15 [email protected] Add buildroot compatibility for HWASAN. (flutter/flutter#167133)
2025-04-15 [email protected] Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569)
2025-04-15 [email protected] Clip bottom widgets in nav bar transition (flutter/flutter#166705)
2025-04-14 [email protected] Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132)
2025-04-14 [email protected] [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929)
2025-04-14 [email protected] Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916)
2025-04-14 [email protected] Roll Packages from 4808eff to 853e96a (1 revision) (flutter/flutter#167122)
2025-04-14 [email protected] [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997)
2025-04-14 [email protected] Remove some unused third party library build scripts (flutter/flutter#166960)
2025-04-14 [email protected] [reland] Fix regression in NDK version checking (flutter/flutter#167011)
2025-04-14 [email protected] Add network permissions information to the dart doc of network image.  (flutter/flutter#167110)
2025-04-14 [email protected] Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994)
2025-04-12 [email protected] [Impeller] various iOS cleanups. (flutter/flutter#166859)
2025-04-11 [email protected] [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007)
2025-04-11 [email protected] Fix regression in NDK version checking (flutter/flutter#166998)
2025-04-11 [email protected] [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637)
2025-04-11 [email protected] [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957)
2025-04-11 [email protected] modify toggle mode style with DatePickerTheme (flutter/flutter#164102)
2025-04-11 [email protected] [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990)
2025-04-11 [email protected] Roll Packages from b2c45f9 to 4808eff (2 revisions) (flutter/flutter#166982)
2025-04-11 [email protected] [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941)
2025-04-11 [email protected] Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877)
2025-04-11 [email protected] [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977)
2025-04-11 [email protected] [native assets] Roll dependencies (flutter/flutter#166969)
2025-04-11 [email protected] Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966)
2025-04-11 [email protected] Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963)
2025-04-11 [email protected] [native assets] Support user-defines in pubspec (flutter/flutter#166940)
2025-04-11 [email protected] [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892)
2025-04-11 [email protected] [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943)
2025-04-11 [email protected] Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889)
2025-04-11 [email protected] Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955)
...
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions) (flut…
b21d593 
…ter#9092)

Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions)

Manual roll requested by [email protected]

flutter/flutter@30e53b0...db68c95

2025-04-15 [email protected] [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212)
2025-04-15 [email protected] Roll Packages from f26b681 to 2fcc403 (4 revisions) (flutter/flutter#167218)
2025-04-15 [email protected] Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473)
2025-04-15 [email protected] Add Irish(ga) to Flutter (flutter/flutter#167129)
2025-04-15 [email protected] Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213)
2025-04-15 [email protected] Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639)
2025-04-15 [email protected] fix: Update time picker dialog input size (flutter/flutter#163184)
2025-04-15 [email protected] Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204)
2025-04-15 [email protected] [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001)
2025-04-15 [email protected] Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206)
2025-04-15 [email protected] Persistent CupertinoListTile leading and trailing (flutter/flutter#166799)
2025-04-15 [email protected] Add buildroot compatibility for HWASAN. (flutter/flutter#167133)
2025-04-15 [email protected] Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569)
2025-04-15 [email protected] Clip bottom widgets in nav bar transition (flutter/flutter#166705)
2025-04-14 [email protected] Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132)
2025-04-14 [email protected] [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929)
2025-04-14 [email protected] Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916)
2025-04-14 [email protected] Roll Packages from 465bcff to f26b681 (1 revision) (flutter/flutter#167122)
2025-04-14 [email protected] [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997)
2025-04-14 [email protected] Remove some unused third party library build scripts (flutter/flutter#166960)
2025-04-14 [email protected] [reland] Fix regression in NDK version checking (flutter/flutter#167011)
2025-04-14 [email protected] Add network permissions information to the dart doc of network image.  (flutter/flutter#167110)
2025-04-14 [email protected] Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994)
2025-04-12 [email protected] [Impeller] various iOS cleanups. (flutter/flutter#166859)
2025-04-11 [email protected] [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007)
2025-04-11 [email protected] Fix regression in NDK version checking (flutter/flutter#166998)
2025-04-11 [email protected] [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637)
2025-04-11 [email protected] [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957)
2025-04-11 [email protected] modify toggle mode style with DatePickerTheme (flutter/flutter#164102)
2025-04-11 [email protected] [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990)
2025-04-11 [email protected] Roll Packages from 431dc61 to 465bcff (2 revisions) (flutter/flutter#166982)
2025-04-11 [email protected] [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941)
2025-04-11 [email protected] Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877)
2025-04-11 [email protected] [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977)
2025-04-11 [email protected] [native assets] Roll dependencies (flutter/flutter#166969)
2025-04-11 [email protected] Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966)
2025-04-11 [email protected] Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963)
2025-04-11 [email protected] [native assets] Support user-defines in pubspec (flutter/flutter#166940)
2025-04-11 [email protected] [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892)
2025-04-11 [email protected] [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943)
2025-04-11 [email protected] Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889)
2025-04-11 [email protected] Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955)
...
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions) (flut…
9ee6018 
…ter#9092)

Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions)

Manual roll requested by [email protected]

flutter/flutter@30e53b0...db68c95

2025-04-15 [email protected] [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212)
2025-04-15 [email protected] Roll Packages from f26b681 to 2fcc403 (4 revisions) (flutter/flutter#167218)
2025-04-15 [email protected] Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473)
2025-04-15 [email protected] Add Irish(ga) to Flutter (flutter/flutter#167129)
2025-04-15 [email protected] Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213)
2025-04-15 [email protected] Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639)
2025-04-15 [email protected] fix: Update time picker dialog input size (flutter/flutter#163184)
2025-04-15 [email protected] Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204)
2025-04-15 [email protected] [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001)
2025-04-15 [email protected] Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206)
2025-04-15 [email protected] Persistent CupertinoListTile leading and trailing (flutter/flutter#166799)
2025-04-15 [email protected] Add buildroot compatibility for HWASAN. (flutter/flutter#167133)
2025-04-15 [email protected] Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569)
2025-04-15 [email protected] Clip bottom widgets in nav bar transition (flutter/flutter#166705)
2025-04-14 [email protected] Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132)
2025-04-14 [email protected] [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929)
2025-04-14 [email protected] Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916)
2025-04-14 [email protected] Roll Packages from 465bcff to f26b681 (1 revision) (flutter/flutter#167122)
2025-04-14 [email protected] [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997)
2025-04-14 [email protected] Remove some unused third party library build scripts (flutter/flutter#166960)
2025-04-14 [email protected] [reland] Fix regression in NDK version checking (flutter/flutter#167011)
2025-04-14 [email protected] Add network permissions information to the dart doc of network image.  (flutter/flutter#167110)
2025-04-14 [email protected] Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994)
2025-04-12 [email protected] [Impeller] various iOS cleanups. (flutter/flutter#166859)
2025-04-11 [email protected] [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007)
2025-04-11 [email protected] Fix regression in NDK version checking (flutter/flutter#166998)
2025-04-11 [email protected] [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637)
2025-04-11 [email protected] [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957)
2025-04-11 [email protected] modify toggle mode style with DatePickerTheme (flutter/flutter#164102)
2025-04-11 [email protected] [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990)
2025-04-11 [email protected] Roll Packages from 431dc61 to 465bcff (2 revisions) (flutter/flutter#166982)
2025-04-11 [email protected] [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941)
2025-04-11 [email protected] Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877)
2025-04-11 [email protected] [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977)
2025-04-11 [email protected] [native assets] Roll dependencies (flutter/flutter#166969)
2025-04-11 [email protected] Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966)
2025-04-11 [email protected] Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963)
2025-04-11 [email protected] [native assets] Support user-defines in pubspec (flutter/flutter#166940)
2025-04-11 [email protected] [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892)
2025-04-11 [email protected] [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943)
2025-04-11 [email protected] Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889)
2025-04-11 [email protected] Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955)
...
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@engine-flutter-autoroll @Ortes
Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions) (flut…
35ba046 
…ter#9092)

Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions)

Manual roll requested by [email protected]

flutter/flutter@30e53b0...db68c95

2025-04-15 [email protected] [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212)
2025-04-15 [email protected] Roll Packages from f26b681 to 2fcc403 (4 revisions) (flutter/flutter#167218)
2025-04-15 [email protected] Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473)
2025-04-15 [email protected] Add Irish(ga) to Flutter (flutter/flutter#167129)
2025-04-15 [email protected] Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213)
2025-04-15 [email protected] Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639)
2025-04-15 [email protected] fix: Update time picker dialog input size (flutter/flutter#163184)
2025-04-15 [email protected] Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204)
2025-04-15 [email protected] [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001)
2025-04-15 [email protected] Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206)
2025-04-15 [email protected] Persistent CupertinoListTile leading and trailing (flutter/flutter#166799)
2025-04-15 [email protected] Add buildroot compatibility for HWASAN. (flutter/flutter#167133)
2025-04-15 [email protected] Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569)
2025-04-15 [email protected] Clip bottom widgets in nav bar transition (flutter/flutter#166705)
2025-04-14 [email protected] Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132)
2025-04-14 [email protected] [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929)
2025-04-14 [email protected] Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916)
2025-04-14 [email protected] Roll Packages from 465bcff to f26b681 (1 revision) (flutter/flutter#167122)
2025-04-14 [email protected] [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997)
2025-04-14 [email protected] Remove some unused third party library build scripts (flutter/flutter#166960)
2025-04-14 [email protected] [reland] Fix regression in NDK version checking (flutter/flutter#167011)
2025-04-14 [email protected] Add network permissions information to the dart doc of network image.  (flutter/flutter#167110)
2025-04-14 [email protected] Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994)
2025-04-12 [email protected] [Impeller] various iOS cleanups. (flutter/flutter#166859)
2025-04-11 [email protected] [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007)
2025-04-11 [email protected] Fix regression in NDK version checking (flutter/flutter#166998)
2025-04-11 [email protected] [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637)
2025-04-11 [email protected] [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957)
2025-04-11 [email protected] modify toggle mode style with DatePickerTheme (flutter/flutter#164102)
2025-04-11 [email protected] [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990)
2025-04-11 [email protected] Roll Packages from 431dc61 to 465bcff (2 revisions) (flutter/flutter#166982)
2025-04-11 [email protected] [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941)
2025-04-11 [email protected] Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877)
2025-04-11 [email protected] [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977)
2025-04-11 [email protected] [native assets] Roll dependencies (flutter/flutter#166969)
2025-04-11 [email protected] Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966)
2025-04-11 [email protected] Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963)
2025-04-11 [email protected] [native assets] Support user-defines in pubspec (flutter/flutter#166940)
2025-04-11 [email protected] [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892)
2025-04-11 [email protected] [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943)
2025-04-11 [email protected] Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889)
2025-04-11 [email protected] Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955)
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
2f30429b9 Fix: Update sheet route bottom padding with top padding (fl…
41c9f6b 
…utter/flutter#164473)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
2f30429b9 Fix: Update sheet route bottom padding with top padding (fl…
3d636ff 
…utter/flutter#164473)
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@rkishan516 @romanejaquez
Fix: Update sheet route bottom padding with top padding (flutter#164473)
b0bcedb 
Fix: Update sheet route bottom padding with top padding
fixes: flutter#163572 
fixes: flutter#164087 

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
2f30429b9 Fix: Update sheet route bottom padding with top padding (fl…
c969cd8 
…utter/flutter#164473)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
2f30429b9 Fix: Update sheet route bottom padding with top padding (fl…
5f532d6 
…utter/flutter#164473)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
2f30429b9 Fix: Update sheet route bottom padding with top padding (fl…
47db2cf 
…utter/flutter#164473)
@MitchellGoodwin MitchellGoodwin mentioned this pull request Dec 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

@MitchellGoodwin MitchellGoodwin MitchellGoodwin approved these changes

Assignees

No one assigned

Labels

f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CupertinoSheetRoute content extends beyond screen & affects hero animation Weird SnackBar behavior in CupertinoSheet

3 participants

@rkishan516 @justinmc @MitchellGoodwin