Skip to content

[web_ui] move several uses of (deprecated) pkg:js to js_interop_unsafe #164264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Feb 27, 2025
Merged

[web_ui] move several uses of (deprecated) pkg:js to js_interop_unsafe #164264

auto-submit merged 1 commit into from
Feb 27, 2025

Conversation

@kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Feb 27, 2025

No description provided.

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. platform-web Web applications specifically labels Feb 27, 2025
harryterkelsen
harryterkelsen approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 27, 2025
Merged via the queue into flutter:master with commit 671bcbe Feb 27, 2025
174 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2025
@kevmoo kevmoo deleted the drop_js branch February 27, 2025 19:26
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2025
@engine-flutter-autoroll
671bcbe [web_ui] move several uses of (deprecated) pkg:js to js_inter…
7a73ea7 
…op_unsafe (flutter/flutter#164264)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2025
@engine-flutter-autoroll
671bcbe [web_ui] move several uses of (deprecated) pkg:js to js_inter…
2ee06be 
…op_unsafe (flutter/flutter#164264)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2025
@engine-flutter-autoroll
671bcbe [web_ui] move several uses of (deprecated) pkg:js to js_inter…
89002dd 
…op_unsafe (flutter/flutter#164264)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2025
@engine-flutter-autoroll
671bcbe [web_ui] move several uses of (deprecated) pkg:js to js_inter…
161df21 
…op_unsafe (flutter/flutter#164264)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2025
@engine-flutter-autoroll
671bcbe [web_ui] move several uses of (deprecated) pkg:js to js_inter…
6eecfe4 
…op_unsafe (flutter/flutter#164264)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2025
@engine-flutter-autoroll
671bcbe [web_ui] move several uses of (deprecated) pkg:js to js_inter…
e2a496d 
…op_unsafe (flutter/flutter#164264)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2025
@engine-flutter-autoroll
671bcbe [web_ui] move several uses of (deprecated) pkg:js to js_inter…
8578e16 
…op_unsafe (flutter/flutter#164264)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2025
@engine-flutter-autoroll
671bcbe [web_ui] move several uses of (deprecated) pkg:js to js_inter…
f25aa53 
…op_unsafe (flutter/flutter#164264)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2025
@engine-flutter-autoroll
671bcbe [web_ui] move several uses of (deprecated) pkg:js to js_inter…
794f990 
…op_unsafe (flutter/flutter#164264)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2025
@engine-flutter-autoroll
671bcbe [web_ui] move several uses of (deprecated) pkg:js to js_inter…
50b0408 
…op_unsafe (flutter/flutter#164264)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
671bcbe [web_ui] move several uses of (deprecated) pkg:js to js_inter…
00626da 
…op_unsafe (flutter/flutter#164264)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
671bcbe [web_ui] move several uses of (deprecated) pkg:js to js_inter…
c2da446 
…op_unsafe (flutter/flutter#164264)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
671bcbe [web_ui] move several uses of (deprecated) pkg:js to js_inter…
8cabe98 
…op_unsafe (flutter/flutter#164264)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harryterkelsen harryterkelsen harryterkelsen approved these changes

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels. platform-web Web applications specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kevmoo @harryterkelsen