Skip to content

android_host_app_v2_embedding update dependencies and documentation #164195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 2 commits into from
Feb 27, 2025
Merged

android_host_app_v2_embedding update dependencies and documentation #164195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b53566
Updates compileSdk 35 for android_host_app_v2_embedding, and document…
reidbaker Feb 26, 2025
0162d2d
Merge branch 'master' into i149836-api-35-update-part-9
reidbaker Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ntegration_tests/pure_android_host_apps/android_host_app_v2_embedding/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ Android host app for a Flutter module created using
$ flutter create -t module hello
```
and placed in a sibling folder to (a clone of) the host app.
Used by the `module_test.dart` device lab test.
Used by the `build_android_host_app_with_module_aar.dart` device lab test.
10 changes: 5 additions & 5 deletions dev/integration_tests/pure_android_host_apps/android_host_app_v2_embedding/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ apply plugin: 'com.android.application'

android {
namespace = "io.flutter.add2app"
compileSdk 34
compileSdk = 35

// Flutter's CI installs the NDK at a non-standard path.
// This non-standard structure is initially created by
Expand All @@ -18,14 +18,14 @@ android {
}

compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
sourceCompatibility JavaVersion.VERSION_17
targetCompatibility JavaVersion.VERSION_17
}

defaultConfig {
applicationId "io.flutter.add2app"
minSdkVersion 21
targetSdkVersion 34
minSdk = 21
targetSdk = 35
versionCode 1
versionName "1.0"
}
Expand Down
8 changes: 4 additions & 4 deletions docs/contributing/Android-API-And-Related-Versions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,14 @@ If the versions chosen are not known by [gradle_utils.dart](https://github.com/f
```
// OK
android {
compileSdk flutter.compileSdkVersion
compileSdk = flutter.compileSdkVersion
}
```

```
// OK if flutter.compileSdkVersion is not available like in an add to app example.
android {
compileSdk 35
compileSdk = 35
}
```

Expand All @@ -53,14 +53,14 @@ android {
```
// OK
defaultConfig {
targetSdk flutter.targetSdkVersion
targetSdk = flutter.targetSdkVersion
}
```

```
// OK if flutter.compileSdkVersion is not available like in an add to app example.
defaultConfig {
targetSdk 35
targetSdk = 35
}
```

Expand Down