[Impeller] make DLOG into LOG for startup errors. #164110

jonahwilliams · 2025-02-25T16:51:10Z

Make logs visible to help debug #163532 . Right now we can't see why context creation is failing.

It may be an EGL config issue.

flutter-dashboard · 2025-02-25T16:51:17Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

This reverts commit 22b6e92.

engine/src/flutter/shell/platform/android/flutter_main.cc

auto-submit · 2025-02-25T19:01:03Z

autosubmit label was removed for flutter/flutter/164110, because - The status or check suite Windows tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label.

The status or check suite Windows tool_integration_tests_9_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows tool_integration_tests_8_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows tool_integration_tests_7_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows tool_integration_tests_6_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows tool_integration_tests_3_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows tool_integration_tests_2_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows plugin_test_windows has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows build_android_host_app_with_module_aar has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows module_host_with_custom_build_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows module_custom_host_app_name_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows gradle_plugin_bundle_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows framework_tests_widgets_leak_tracking has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows framework_tests_libraries_leak_tracking has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows build_tests_8_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows build_tests_7_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows build_tests_6_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows build_tests_5_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows build_tests_4_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows build_tests_3_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows build_tests_2_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows build_tests_1_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac_arm64 run_debug_test_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac run_debug_test_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac channels_integration_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac_arm64 native_ui_tests_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac_x64 native_ui_tests_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac_x64 hot_mode_dev_cycle_macos_target__benchmark has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac web_tool_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac_arm64 tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac_x64 tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac tool_integration_tests_5_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac tool_integration_tests_4_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac tool_integration_tests_3_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac tool_integration_tests_2_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac tool_integration_tests_1_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac_arm64 tool_host_cross_arch_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac_x64 tool_host_cross_arch_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac plugin_test_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac plugin_test_ios has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac plugin_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac_x64 plugin_lint_mac has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac plugin_dependencies_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac_arm64 module_test_ios has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac build_android_host_app_with_module_aar has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac module_host_with_custom_build_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac module_custom_host_app_name_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac gradle_plugin_bundle_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac framework_tests_widgets has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac_arm64 framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac_x64 framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac framework_tests_impeller has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac dart_plugin_registry_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac_arm64 build_tests_4_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac_arm64 build_tests_3_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac_arm64 build_tests_2_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac build_ios_framework_module_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux tool_integration_tests_4_6 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux plugin_dependencies_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux module_host_with_custom_build_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux gradle_plugin_fat_apk_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux gradle_plugin_bundle_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux gradle_java8_compile_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux gradle_desugar_classes_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux framework_tests_widgets has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux framework_tests_slow has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux firebase_release_smoke_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux engine_dependency_proxy_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux docs_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux build_tests_5_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux build_tests_4_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux build_tests_3_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux build_tests_2_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux build_tests_1_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux build_aar_module_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Mac customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux test_ownership has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux skp_generator has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux flutter_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2025-02-25T21:47:05Z

autosubmit label was removed for flutter/flutter/164110, because - The status or check suite Windows windows_host_engine_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

The status or check suite Linux mac_clang_tidy has failed. Please fix the issues identified (or deflake) before re-applying this label.

jonahwilliams · 2025-02-26T00:37:37Z

Wat do? @matanlurey / @jtmcdole

…utter#164110)

Roll Flutter from 1659206 to 2e570ca (75 revisions) flutter/flutter@1659206...2e570ca 2025-02-27 [email protected] Roll Skia from ac08df9c8d82 to e5a33102401c (1 revision) (flutter/flutter#164288) 2025-02-27 [email protected] Roll Skia from 6018dff0233a to ac08df9c8d82 (1 revision) (flutter/flutter#164275) 2025-02-27 [email protected] Roll Dart SDK from 4a218fbffc80 to fcda71ce147b (1 revision) (flutter/flutter#164276) 2025-02-27 [email protected] Roll Skia from 0f2e106c9abc to 6018dff0233a (1 revision) (flutter/flutter#164266) 2025-02-27 [email protected] Add windowing channel support to Linux embedder (flutter/flutter#163180) 2025-02-27 [email protected] Roll Dart SDK from 7fa5901bd8a3 to 4a218fbffc80 (2 revisions) (flutter/flutter#164260) 2025-02-27 [email protected] Roll Skia from fdd97386193e to 0f2e106c9abc (4 revisions) (flutter/flutter#164259) 2025-02-27 [email protected] Run more builds faster (flutter/flutter#164125) 2025-02-27 [email protected] Increase customer test timeout to 60 minutes (flutter/flutter#164239) 2025-02-27 [email protected] Reland "Add a buildtools directory and move third_party/ninja to the project root in order to match the expectations of depot_tools" (flutter/flutter#164240) 2025-02-27 [email protected] Use the Dart isolate ownership API on the root isolate (flutter/flutter#163703) 2025-02-26 [email protected] Roll Fuchsia Linux SDK from g-2SJtblPjjaH7Egy... to 1elkOxihZuTEiTXzY... (flutter/flutter#164243) 2025-02-26 [email protected] Show Linux driver information in flutter doctor (flutter/flutter#163980) 2025-02-26 [email protected] Implement opacity `FlutterMutator` for hcpp (flutter/flutter#164147) 2025-02-26 [email protected] Roll Fuchsia Linux SDK from g-2SJtblPjjaH7Egy... to 1elkOxihZuTEiTXzY... (flutter/flutter#164232) 2025-02-26 [email protected] Roll Skia from 47b84f354604 to fdd97386193e (8 revisions) (flutter/flutter#164221) 2025-02-26 [email protected] [Impeller] Reland: move AHB check into Flutter main, don't disable ImageReader on 29. (flutter/flutter#164201) 2025-02-26 [email protected] Roll Dart SDK from 80865748abe0 to 7fa5901bd8a3 (3 revisions) (flutter/flutter#164226) 2025-02-26 [email protected] Update fuchsia_test_scripts_version to the latest version (flutter/flutter#164123) 2025-02-26 [email protected] Guard against zero item extent for carousel (flutter/flutter#163310) 2025-02-26 [email protected] [Impeller] work around for crashy Nexus 5 Driver. (flutter/flutter#164040) 2025-02-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add a buildtools directory and move third_party/ninja to the project root in order to match the expectations of depot_tools (#163890)" (flutter/flutter#164209) 2025-02-26 [email protected] Add localization for `Back` and `Cancel` buttons in CupertinoNavigationBar (flutter/flutter#162581) 2025-02-26 [email protected] Added compilation failure if a max ubo size is exceeded (flutter/flutter#164038) 2025-02-26 [email protected] Roll Skia from 5336e20498d9 to 47b84f354604 (2 revisions) (flutter/flutter#164188) 2025-02-26 [email protected] Add a buildtools directory and move third_party/ninja to the project root in order to match the expectations of depot_tools (flutter/flutter#163890) 2025-02-26 [email protected] Roll Skia from 3ce6f25dc13e to 5336e20498d9 (9 revisions) (flutter/flutter#164174) 2025-02-26 [email protected] Roll Dart SDK from b8292dfeaa67 to 80865748abe0 (9 revisions) (flutter/flutter#164168) 2025-02-26 [email protected] [Engine] Remove dead code for RoundedSuperellipse (flutter/flutter#164163) 2025-02-26 [email protected] [Impeller] detect mediatek soc and fall back to GLES. (flutter/flutter#164126) 2025-02-26 [email protected] [Impeller] make DLOG into LOG for startup errors. (flutter/flutter#164110) 2025-02-26 [email protected] Intercept error when iOS 18.4 crashes with JIT mode and give guided error (flutter/flutter#164072) 2025-02-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] move AHB check to Vulkan, use Vulkan surface on 29. (#164109)" (flutter/flutter#164166) 2025-02-26 [email protected] Run new gallery transition perf benchmark on Galaxy S24 (flutter/flutter#163665) 2025-02-26 [email protected] [Impeller] move AHB check to Vulkan, use Vulkan surface on 29. (flutter/flutter#164109) 2025-02-26 [email protected] [iOS] Add platform view to integration_test example (flutter/flutter#164144) 2025-02-26 [email protected] Fix minor issues in documentation of WidgetsApp (flutter/flutter#163942) 2025-02-26 [email protected] Fix extra numbers showing up when enabling VoiceControl (flutter/flutter#163593) 2025-02-26 [email protected] Set SliverResizingHeader's maxScrollObstructionExtent to minExtent (flutter/flutter#162955) 2025-02-26 [email protected] Roll Dart SDK from aea6fff33f06 to b8292dfeaa67 (1 revision) (flutter/flutter#163973) 2025-02-26 [email protected] [DisplayList] Delete all legacy Skia-oriented method overloads in DlCanvas (flutter/flutter#164054) 2025-02-25 [email protected] Clean up leak tracker instrumentation tech debt. (flutter/flutter#164070) 2025-02-25 [email protected] Revert "Marks Linux_pixel_7pro service_extensions_test to be flaky" (flutter/flutter#163882) 2025-02-25 [email protected] Check if simctl is installed before trying to list devices or runtimes (flutter/flutter#163895) 2025-02-25 [email protected] Update dragDevices doc to include default PointerDeviceKind.trackpad (flutter/flutter#163898) 2025-02-25 [email protected] Update multiple flutters benchmark test to latest gradle and agp and gradle defined dependencies (flutter/flutter#164029) ...

…utter#164110)

Roll Flutter from 1659206 to 2e570ca (75 revisions) flutter/flutter@1659206...2e570ca 2025-02-27 [email protected] Roll Skia from ac08df9c8d82 to e5a33102401c (1 revision) (flutter/flutter#164288) 2025-02-27 [email protected] Roll Skia from 6018dff0233a to ac08df9c8d82 (1 revision) (flutter/flutter#164275) 2025-02-27 [email protected] Roll Dart SDK from 4a218fbffc80 to fcda71ce147b (1 revision) (flutter/flutter#164276) 2025-02-27 [email protected] Roll Skia from 0f2e106c9abc to 6018dff0233a (1 revision) (flutter/flutter#164266) 2025-02-27 [email protected] Add windowing channel support to Linux embedder (flutter/flutter#163180) 2025-02-27 [email protected] Roll Dart SDK from 7fa5901bd8a3 to 4a218fbffc80 (2 revisions) (flutter/flutter#164260) 2025-02-27 [email protected] Roll Skia from fdd97386193e to 0f2e106c9abc (4 revisions) (flutter/flutter#164259) 2025-02-27 [email protected] Run more builds faster (flutter/flutter#164125) 2025-02-27 [email protected] Increase customer test timeout to 60 minutes (flutter/flutter#164239) 2025-02-27 [email protected] Reland "Add a buildtools directory and move third_party/ninja to the project root in order to match the expectations of depot_tools" (flutter/flutter#164240) 2025-02-27 [email protected] Use the Dart isolate ownership API on the root isolate (flutter/flutter#163703) 2025-02-26 [email protected] Roll Fuchsia Linux SDK from g-2SJtblPjjaH7Egy... to 1elkOxihZuTEiTXzY... (flutter/flutter#164243) 2025-02-26 [email protected] Show Linux driver information in flutter doctor (flutter/flutter#163980) 2025-02-26 [email protected] Implement opacity `FlutterMutator` for hcpp (flutter/flutter#164147) 2025-02-26 [email protected] Roll Fuchsia Linux SDK from g-2SJtblPjjaH7Egy... to 1elkOxihZuTEiTXzY... (flutter/flutter#164232) 2025-02-26 [email protected] Roll Skia from 47b84f354604 to fdd97386193e (8 revisions) (flutter/flutter#164221) 2025-02-26 [email protected] [Impeller] Reland: move AHB check into Flutter main, don't disable ImageReader on 29. (flutter/flutter#164201) 2025-02-26 [email protected] Roll Dart SDK from 80865748abe0 to 7fa5901bd8a3 (3 revisions) (flutter/flutter#164226) 2025-02-26 [email protected] Update fuchsia_test_scripts_version to the latest version (flutter/flutter#164123) 2025-02-26 [email protected] Guard against zero item extent for carousel (flutter/flutter#163310) 2025-02-26 [email protected] [Impeller] work around for crashy Nexus 5 Driver. (flutter/flutter#164040) 2025-02-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add a buildtools directory and move third_party/ninja to the project root in order to match the expectations of depot_tools (#163890)" (flutter/flutter#164209) 2025-02-26 [email protected] Add localization for `Back` and `Cancel` buttons in CupertinoNavigationBar (flutter/flutter#162581) 2025-02-26 [email protected] Added compilation failure if a max ubo size is exceeded (flutter/flutter#164038) 2025-02-26 [email protected] Roll Skia from 5336e20498d9 to 47b84f354604 (2 revisions) (flutter/flutter#164188) 2025-02-26 [email protected] Add a buildtools directory and move third_party/ninja to the project root in order to match the expectations of depot_tools (flutter/flutter#163890) 2025-02-26 [email protected] Roll Skia from 3ce6f25dc13e to 5336e20498d9 (9 revisions) (flutter/flutter#164174) 2025-02-26 [email protected] Roll Dart SDK from b8292dfeaa67 to 80865748abe0 (9 revisions) (flutter/flutter#164168) 2025-02-26 [email protected] [Engine] Remove dead code for RoundedSuperellipse (flutter/flutter#164163) 2025-02-26 [email protected] [Impeller] detect mediatek soc and fall back to GLES. (flutter/flutter#164126) 2025-02-26 [email protected] [Impeller] make DLOG into LOG for startup errors. (flutter/flutter#164110) 2025-02-26 [email protected] Intercept error when iOS 18.4 crashes with JIT mode and give guided error (flutter/flutter#164072) 2025-02-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] move AHB check to Vulkan, use Vulkan surface on 29. (#164109)" (flutter/flutter#164166) 2025-02-26 [email protected] Run new gallery transition perf benchmark on Galaxy S24 (flutter/flutter#163665) 2025-02-26 [email protected] [Impeller] move AHB check to Vulkan, use Vulkan surface on 29. (flutter/flutter#164109) 2025-02-26 [email protected] [iOS] Add platform view to integration_test example (flutter/flutter#164144) 2025-02-26 [email protected] Fix minor issues in documentation of WidgetsApp (flutter/flutter#163942) 2025-02-26 [email protected] Fix extra numbers showing up when enabling VoiceControl (flutter/flutter#163593) 2025-02-26 [email protected] Set SliverResizingHeader's maxScrollObstructionExtent to minExtent (flutter/flutter#162955) 2025-02-26 [email protected] Roll Dart SDK from aea6fff33f06 to b8292dfeaa67 (1 revision) (flutter/flutter#163973) 2025-02-26 [email protected] [DisplayList] Delete all legacy Skia-oriented method overloads in DlCanvas (flutter/flutter#164054) 2025-02-25 [email protected] Clean up leak tracker instrumentation tech debt. (flutter/flutter#164070) 2025-02-25 [email protected] Revert "Marks Linux_pixel_7pro service_extensions_test to be flaky" (flutter/flutter#163882) 2025-02-25 [email protected] Check if simctl is installed before trying to list devices or runtimes (flutter/flutter#163895) 2025-02-25 [email protected] Update dragDevices doc to include default PointerDeviceKind.trackpad (flutter/flutter#163898) 2025-02-25 [email protected] Update multiple flutters benchmark test to latest gradle and agp and gradle defined dependencies (flutter/flutter#164029) ...

[Impeller] make DLOG into LOG for startup errors.

8ceeb97

jonahwilliams requested review from jtmcdole and matanlurey February 25, 2025 16:51

github-actions bot added platform-android Android applications specifically engine flutter/engine related. See also e: labels. labels Feb 25, 2025

matanlurey approved these changes Feb 25, 2025

View reviewed changes

jtmcdole approved these changes Feb 25, 2025

View reviewed changes

jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 25, 2025

jonahwilliams added 2 commits February 25, 2025 10:12

[Impeller] mediatek eh.

22b6e92

Revert "[Impeller] mediatek eh."

886faf8

This reverts commit 22b6e92.

jtmcdole reviewed Feb 25, 2025

View reviewed changes

engine/src/flutter/shell/platform/android/flutter_main.cc Outdated Show resolved Hide resolved

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 25, 2025

Jonah Williams added 2 commits February 25, 2025 11:33

Merge branch 'master' into do_other_thing

c5ba9c3

Merge branch 'master' into do_other_thing

cf3daf1

jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 25, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 25, 2025

Jonah Williams added 2 commits February 25, 2025 17:16

Merge branch 'master' into do_other_thing

9bc5bc8

Merge branch 'master' into do_other_thing

847af28

jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 26, 2025

auto-submit bot added this pull request to the merge queue Feb 26, 2025

Merged via the queue into flutter:master with commit 8bb34f2 Feb 26, 2025
176 of 177 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 26, 2025

engine-flutter-autoroll mentioned this pull request Feb 26, 2025

Roll Flutter from 911aa7547ed7 to 80233283c31e (71 revisions) flutter/packages#8714

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025

8bb34f2 [Impeller] make DLOG into LOG for startup errors. (flutter/fl…

b711b55

…utter#164110)

engine-flutter-autoroll mentioned this pull request Feb 26, 2025

Roll Flutter from 911aa7547ed7 to 3d018b5924fe (72 revisions) flutter/packages#8717

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025

8bb34f2 [Impeller] make DLOG into LOG for startup errors. (flutter/fl…

8fc9604

…utter#164110)

engine-flutter-autoroll mentioned this pull request Feb 26, 2025

Roll Flutter from 911aa7547ed7 to e039a911c5e5 (73 revisions) flutter/packages#8719

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025

8bb34f2 [Impeller] make DLOG into LOG for startup errors. (flutter/fl…

baea0f0

…utter#164110)

engine-flutter-autoroll mentioned this pull request Feb 26, 2025

Roll Flutter from 911aa7547ed7 to 8b3f5f4a2f7d (74 revisions) flutter/packages#8720

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025

8bb34f2 [Impeller] make DLOG into LOG for startup errors. (flutter/fl…

3c1c6e9

…utter#164110)

engine-flutter-autoroll mentioned this pull request Feb 26, 2025

Roll Flutter from 911aa7547ed7 to af15a1eb7684 (75 revisions) flutter/packages#8721

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025

8bb34f2 [Impeller] make DLOG into LOG for startup errors. (flutter/fl…

5ed335d

…utter#164110)

engine-flutter-autoroll mentioned this pull request Feb 26, 2025

Roll Flutter from 911aa7547ed7 to 0b96fa88fd83 (77 revisions) flutter/packages#8722

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025

8bb34f2 [Impeller] make DLOG into LOG for startup errors. (flutter/fl…

443a6ad

…utter#164110)

engine-flutter-autoroll mentioned this pull request Feb 27, 2025

Manual roll Flutter from 16592066d70b to ac9f68b12da8 (46 revisions) flutter/packages#8729

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2025

8bb34f2 [Impeller] make DLOG into LOG for startup errors. (flutter/fl…

b78413f

…utter#164110)

engine-flutter-autoroll mentioned this pull request Feb 27, 2025

Roll Flutter from 16592066d70b to 2e570ca393c8 (75 revisions) flutter/packages#8731

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2025

8bb34f2 [Impeller] make DLOG into LOG for startup errors. (flutter/fl…

aef09fc

…utter#164110)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

8bb34f2 [Impeller] make DLOG into LOG for startup errors. (flutter/fl…

56f00df

…utter#164110)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

8bb34f2 [Impeller] make DLOG into LOG for startup errors. (flutter/fl…

e5cb108

…utter#164110)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

8bb34f2 [Impeller] make DLOG into LOG for startup errors. (flutter/fl…

2d6f25d

…utter#164110)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Impeller] make DLOG into LOG for startup errors. #164110

[Impeller] make DLOG into LOG for startup errors. #164110

Uh oh!

jonahwilliams commented Feb 25, 2025

Uh oh!

flutter-dashboard bot commented Feb 25, 2025

Uh oh!

Uh oh!

auto-submit bot commented Feb 25, 2025

Uh oh!

auto-submit bot commented Feb 25, 2025

Uh oh!

jonahwilliams commented Feb 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[Impeller] make DLOG into LOG for startup errors. #164110

[Impeller] make DLOG into LOG for startup errors. #164110

Uh oh!

Conversation

jonahwilliams commented Feb 25, 2025

Uh oh!

flutter-dashboard bot commented Feb 25, 2025

Uh oh!

Uh oh!

auto-submit bot commented Feb 25, 2025

Uh oh!

auto-submit bot commented Feb 25, 2025

Uh oh!

jonahwilliams commented Feb 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants