-
Notifications
You must be signed in to change notification settings - Fork 29.7k
modify toggle mode style with DatePickerTheme #164102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9d6a702 to
584b0a1
Compare
|
I implemented this new feature before seeing that issue #160591 requested a similar feature. That issue already has a linked PR (#161458), but that PR doesn't seem to have received updates since January 24, so my PR could be a valid implementation for both issues. |
QuncCccccc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! Overall this looks good to me! Just left some comments below.
| /// | ||
| /// The [TextStyle.color] of [toggleModeStyle] is not used, [toggleModeForegroundColor] | ||
| /// is used instead. | ||
| final TextStyle? toggleModeStyle; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think if toggleButtonTextStyle would be more straightforward to understand? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| /// Overrides the default color used for text labels and icons of toggle mode button. | ||
| /// | ||
| /// This is used instead of the [TextStyle.color] property of [toggleModeStyle]. | ||
| final Color? toggleModeForegroundColor; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To fix #160591, I think we'd better also apply this color to the month pick button. As for naming, I think subHeaderForegroundColor would be more straightforward to understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
QuncCccccc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! Left some comments below. Please let me know if there's any questions:)
| "md.comp.date-picker.modal.year-selection.year.unselected.hover.state-layer.color": "onSurfaceVariant", | ||
| "md.comp.date-picker.modal.year-selection.year.unselected.label-text.color": "onSurfaceVariant", | ||
| "md.comp.date-picker.modal.year-selection.year.unselected.pressed.state-layer.color": "onSurfaceVariant" | ||
| "md.comp.date-picker.modal.year-selection.year.unselected.pressed.state-layer.color": "onSurfaceVariant", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This json file is generated from internal google, please don't edit it manually:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
| Color? get backgroundColor => ${componentColor("md.comp.date-picker.modal.container")}; | ||
| @override | ||
| Color? get subHeaderForegroundColor => ${componentColor("md.comp.date-picker.modal.sub.header.foreground")}.withOpacity(0.60); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use the existing token instead of adding new tokens manually:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, that makes sense. This part was a bit confusing to me. So I should use something like md.comp.date-picker.modal.weekdays.label-text for subHeaderForegroundColor and md.comp.date-picker.modal.range-selection.month.subhead for toggleButtonTextStyle? Thats it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late reply. Yes, these tokens are exported from google internal token generator, we should just pick tokens instead of creating new ones ourselves:)
| widget.title, | ||
| overflow: TextOverflow.ellipsis, | ||
| style: textTheme.titleSmall?.copyWith(color: controlColor), | ||
| style: buttonTextStyle?.apply(color: toggleModeForegroundColor), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we provide a toggleButtonTextStyle with a custom text color in date picker theme, but don't provide a subHeaderForegroundColor in the date picker theme, this change will cause that the customized text color is not respected, and the text color always defaults to the default subHeaderForegroundColor .
For the text color here, ideally, I think we want to firstly check whether theme's toggleButtonTextStyle's color is empty, if not empty, we respect the color value; but if empty, then check whether theme's subheaderForegroundColor is empty, if not empty, text color should respect it; if empty, we should go to defaults.toggleButtonTextStyle, if still empty, we should check defaults.subHeaderForegroundColor. Does this make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeahh, it makes sense. I'm gonna implement it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! I think the check on defaults.subHeaderForegroundColor is redundant because defaults.toggleButtonTextStyle already gets it.
QuncCccccc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me! Can we add one more test to verify the datePickerTheme.toggleButtonTextStyle can override datePickerTheme.subHeaderForeground when they both have some custom color values:)
| final DatePickerThemeData defaults = DatePickerTheme.defaults(context); | ||
| final TextStyle? buttonTextStyle = | ||
| datePickerTheme.toggleButtonTextStyle ?? defaults.toggleButtonTextStyle; | ||
| final Color? toggleModeForegroundColor = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency,
| final Color? toggleModeForegroundColor = | |
| final Color? subHeaderForegroundColor = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@QuncCccccc About the test, I think I don't know exactly how to make it. Should I write a new test at date_picker_theme_test or edit one that already exists to verify this override?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @QuncCccccc. How is it going? I pushed the commit with two tests, verifying if the color of toggleButtonTextStyle is respected over subHeaderForegroundColor and also a test verifying if subHeaderForeground is used when toggleButtonTextStyle.color is not defined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests look good to me! Could you help fix the conflict and the failures, then we are good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, nice!!
Well, the conflict is fixed. But about the failures, I am unsure of what to do to fix them. Could you help me? @QuncCccccc
f20dbd6 to
e295484
Compare
QuncCccccc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for your contribution!
| /// picker. It defaults to the ambient locale provided by [Localizations]. | ||
| final Locale? locale; | ||
|
|
||
| /// Overrides the default text style used for the text of toggle mode button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
| /// Overrides the default text style used for the text of toggle mode button | |
| /// Overrides the default text style used for the text of toggle mode button. |
8129b55 to
c1e0fd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍. Thanks for jumping in to add this!
| ); | ||
| expect(day24Shape.side.width, datePickerTheme.todayBorder?.width); | ||
|
|
||
| // Test the toggle mode button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Period at the end.
|
autosubmit label was removed for flutter/flutter/164102, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions) Manual roll requested by [email protected] flutter/flutter@30e53b0...db68c95 2025-04-15 [email protected] [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212) 2025-04-15 [email protected] Roll Packages from f26b681 to 2fcc403 (4 revisions) (flutter/flutter#167218) 2025-04-15 [email protected] Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473) 2025-04-15 [email protected] Add Irish(ga) to Flutter (flutter/flutter#167129) 2025-04-15 [email protected] Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213) 2025-04-15 [email protected] Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639) 2025-04-15 [email protected] fix: Update time picker dialog input size (flutter/flutter#163184) 2025-04-15 [email protected] Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204) 2025-04-15 [email protected] [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001) 2025-04-15 [email protected] Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206) 2025-04-15 [email protected] Persistent CupertinoListTile leading and trailing (flutter/flutter#166799) 2025-04-15 [email protected] Add buildroot compatibility for HWASAN. (flutter/flutter#167133) 2025-04-15 [email protected] Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569) 2025-04-15 [email protected] Clip bottom widgets in nav bar transition (flutter/flutter#166705) 2025-04-14 [email protected] Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132) 2025-04-14 [email protected] [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929) 2025-04-14 [email protected] Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916) 2025-04-14 [email protected] Roll Packages from 465bcff to f26b681 (1 revision) (flutter/flutter#167122) 2025-04-14 [email protected] [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997) 2025-04-14 [email protected] Remove some unused third party library build scripts (flutter/flutter#166960) 2025-04-14 [email protected] [reland] Fix regression in NDK version checking (flutter/flutter#167011) 2025-04-14 [email protected] Add network permissions information to the dart doc of network image. (flutter/flutter#167110) 2025-04-14 [email protected] Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994) 2025-04-12 [email protected] [Impeller] various iOS cleanups. (flutter/flutter#166859) 2025-04-11 [email protected] [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000) 2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007) 2025-04-11 [email protected] Fix regression in NDK version checking (flutter/flutter#166998) 2025-04-11 [email protected] [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637) 2025-04-11 [email protected] [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957) 2025-04-11 [email protected] modify toggle mode style with DatePickerTheme (flutter/flutter#164102) 2025-04-11 [email protected] [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916) 2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990) 2025-04-11 [email protected] Roll Packages from 431dc61 to 465bcff (2 revisions) (flutter/flutter#166982) 2025-04-11 [email protected] [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941) 2025-04-11 [email protected] Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877) 2025-04-11 [email protected] [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977) 2025-04-11 [email protected] [native assets] Roll dependencies (flutter/flutter#166969) 2025-04-11 [email protected] Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966) 2025-04-11 [email protected] Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963) 2025-04-11 [email protected] [native assets] Support user-defines in pubspec (flutter/flutter#166940) 2025-04-11 [email protected] [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892) 2025-04-11 [email protected] [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943) 2025-04-11 [email protected] Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889) 2025-04-11 [email protected] Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955) ...
…(#9092) Manual roll Flutter from 30e53b0d9caa to db68c950c599 (98 revisions) Manual roll requested by [email protected] flutter/flutter@30e53b0...db68c95 2025-04-15 [email protected] [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212) 2025-04-15 [email protected] Roll Packages from 853e96a to a5ed6cb (4 revisions) (flutter/flutter#167218) 2025-04-15 [email protected] Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473) 2025-04-15 [email protected] Add Irish(ga) to Flutter (flutter/flutter#167129) 2025-04-15 [email protected] Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213) 2025-04-15 [email protected] Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639) 2025-04-15 [email protected] fix: Update time picker dialog input size (flutter/flutter#163184) 2025-04-15 [email protected] Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204) 2025-04-15 [email protected] [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001) 2025-04-15 [email protected] Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206) 2025-04-15 [email protected] Persistent CupertinoListTile leading and trailing (flutter/flutter#166799) 2025-04-15 [email protected] Add buildroot compatibility for HWASAN. (flutter/flutter#167133) 2025-04-15 [email protected] Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569) 2025-04-15 [email protected] Clip bottom widgets in nav bar transition (flutter/flutter#166705) 2025-04-14 [email protected] Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132) 2025-04-14 [email protected] [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929) 2025-04-14 [email protected] Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916) 2025-04-14 [email protected] Roll Packages from 4808eff to 853e96a (1 revision) (flutter/flutter#167122) 2025-04-14 [email protected] [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997) 2025-04-14 [email protected] Remove some unused third party library build scripts (flutter/flutter#166960) 2025-04-14 [email protected] [reland] Fix regression in NDK version checking (flutter/flutter#167011) 2025-04-14 [email protected] Add network permissions information to the dart doc of network image. (flutter/flutter#167110) 2025-04-14 [email protected] Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994) 2025-04-12 [email protected] [Impeller] various iOS cleanups. (flutter/flutter#166859) 2025-04-11 [email protected] [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000) 2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007) 2025-04-11 [email protected] Fix regression in NDK version checking (flutter/flutter#166998) 2025-04-11 [email protected] [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637) 2025-04-11 [email protected] [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957) 2025-04-11 [email protected] modify toggle mode style with DatePickerTheme (flutter/flutter#164102) 2025-04-11 [email protected] [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916) 2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990) 2025-04-11 [email protected] Roll Packages from b2c45f9 to 4808eff (2 revisions) (flutter/flutter#166982) 2025-04-11 [email protected] [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941) 2025-04-11 [email protected] Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877) 2025-04-11 [email protected] [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977) 2025-04-11 [email protected] [native assets] Roll dependencies (flutter/flutter#166969) 2025-04-11 [email protected] Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966) 2025-04-11 [email protected] Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963) 2025-04-11 [email protected] [native assets] Support user-defines in pubspec (flutter/flutter#166940) 2025-04-11 [email protected] [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892) 2025-04-11 [email protected] [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943) 2025-04-11 [email protected] Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889) 2025-04-11 [email protected] Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955) ...
…ter#9092) Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions) Manual roll requested by [email protected] flutter/flutter@30e53b0...db68c95 2025-04-15 [email protected] [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212) 2025-04-15 [email protected] Roll Packages from f26b681 to 2fcc403 (4 revisions) (flutter/flutter#167218) 2025-04-15 [email protected] Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473) 2025-04-15 [email protected] Add Irish(ga) to Flutter (flutter/flutter#167129) 2025-04-15 [email protected] Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213) 2025-04-15 [email protected] Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639) 2025-04-15 [email protected] fix: Update time picker dialog input size (flutter/flutter#163184) 2025-04-15 [email protected] Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204) 2025-04-15 [email protected] [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001) 2025-04-15 [email protected] Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206) 2025-04-15 [email protected] Persistent CupertinoListTile leading and trailing (flutter/flutter#166799) 2025-04-15 [email protected] Add buildroot compatibility for HWASAN. (flutter/flutter#167133) 2025-04-15 [email protected] Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569) 2025-04-15 [email protected] Clip bottom widgets in nav bar transition (flutter/flutter#166705) 2025-04-14 [email protected] Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132) 2025-04-14 [email protected] [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929) 2025-04-14 [email protected] Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916) 2025-04-14 [email protected] Roll Packages from 465bcff to f26b681 (1 revision) (flutter/flutter#167122) 2025-04-14 [email protected] [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997) 2025-04-14 [email protected] Remove some unused third party library build scripts (flutter/flutter#166960) 2025-04-14 [email protected] [reland] Fix regression in NDK version checking (flutter/flutter#167011) 2025-04-14 [email protected] Add network permissions information to the dart doc of network image. (flutter/flutter#167110) 2025-04-14 [email protected] Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994) 2025-04-12 [email protected] [Impeller] various iOS cleanups. (flutter/flutter#166859) 2025-04-11 [email protected] [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000) 2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007) 2025-04-11 [email protected] Fix regression in NDK version checking (flutter/flutter#166998) 2025-04-11 [email protected] [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637) 2025-04-11 [email protected] [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957) 2025-04-11 [email protected] modify toggle mode style with DatePickerTheme (flutter/flutter#164102) 2025-04-11 [email protected] [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916) 2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990) 2025-04-11 [email protected] Roll Packages from 431dc61 to 465bcff (2 revisions) (flutter/flutter#166982) 2025-04-11 [email protected] [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941) 2025-04-11 [email protected] Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877) 2025-04-11 [email protected] [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977) 2025-04-11 [email protected] [native assets] Roll dependencies (flutter/flutter#166969) 2025-04-11 [email protected] Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966) 2025-04-11 [email protected] Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963) 2025-04-11 [email protected] [native assets] Support user-defines in pubspec (flutter/flutter#166940) 2025-04-11 [email protected] [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892) 2025-04-11 [email protected] [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943) 2025-04-11 [email protected] Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889) 2025-04-11 [email protected] Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955) ...
…ter#9092) Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions) Manual roll requested by [email protected] flutter/flutter@30e53b0...db68c95 2025-04-15 [email protected] [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212) 2025-04-15 [email protected] Roll Packages from f26b681 to 2fcc403 (4 revisions) (flutter/flutter#167218) 2025-04-15 [email protected] Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473) 2025-04-15 [email protected] Add Irish(ga) to Flutter (flutter/flutter#167129) 2025-04-15 [email protected] Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213) 2025-04-15 [email protected] Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639) 2025-04-15 [email protected] fix: Update time picker dialog input size (flutter/flutter#163184) 2025-04-15 [email protected] Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204) 2025-04-15 [email protected] [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001) 2025-04-15 [email protected] Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206) 2025-04-15 [email protected] Persistent CupertinoListTile leading and trailing (flutter/flutter#166799) 2025-04-15 [email protected] Add buildroot compatibility for HWASAN. (flutter/flutter#167133) 2025-04-15 [email protected] Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569) 2025-04-15 [email protected] Clip bottom widgets in nav bar transition (flutter/flutter#166705) 2025-04-14 [email protected] Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132) 2025-04-14 [email protected] [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929) 2025-04-14 [email protected] Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916) 2025-04-14 [email protected] Roll Packages from 465bcff to f26b681 (1 revision) (flutter/flutter#167122) 2025-04-14 [email protected] [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997) 2025-04-14 [email protected] Remove some unused third party library build scripts (flutter/flutter#166960) 2025-04-14 [email protected] [reland] Fix regression in NDK version checking (flutter/flutter#167011) 2025-04-14 [email protected] Add network permissions information to the dart doc of network image. (flutter/flutter#167110) 2025-04-14 [email protected] Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994) 2025-04-12 [email protected] [Impeller] various iOS cleanups. (flutter/flutter#166859) 2025-04-11 [email protected] [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000) 2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007) 2025-04-11 [email protected] Fix regression in NDK version checking (flutter/flutter#166998) 2025-04-11 [email protected] [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637) 2025-04-11 [email protected] [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957) 2025-04-11 [email protected] modify toggle mode style with DatePickerTheme (flutter/flutter#164102) 2025-04-11 [email protected] [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916) 2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990) 2025-04-11 [email protected] Roll Packages from 431dc61 to 465bcff (2 revisions) (flutter/flutter#166982) 2025-04-11 [email protected] [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941) 2025-04-11 [email protected] Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877) 2025-04-11 [email protected] [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977) 2025-04-11 [email protected] [native assets] Roll dependencies (flutter/flutter#166969) 2025-04-11 [email protected] Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966) 2025-04-11 [email protected] Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963) 2025-04-11 [email protected] [native assets] Support user-defines in pubspec (flutter/flutter#166940) 2025-04-11 [email protected] [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892) 2025-04-11 [email protected] [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943) 2025-04-11 [email protected] Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889) 2025-04-11 [email protected] Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955) ...
…ter#9092) Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions) Manual roll requested by [email protected] flutter/flutter@30e53b0...db68c95 2025-04-15 [email protected] [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212) 2025-04-15 [email protected] Roll Packages from f26b681 to 2fcc403 (4 revisions) (flutter/flutter#167218) 2025-04-15 [email protected] Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473) 2025-04-15 [email protected] Add Irish(ga) to Flutter (flutter/flutter#167129) 2025-04-15 [email protected] Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213) 2025-04-15 [email protected] Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639) 2025-04-15 [email protected] fix: Update time picker dialog input size (flutter/flutter#163184) 2025-04-15 [email protected] Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204) 2025-04-15 [email protected] [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001) 2025-04-15 [email protected] Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206) 2025-04-15 [email protected] Persistent CupertinoListTile leading and trailing (flutter/flutter#166799) 2025-04-15 [email protected] Add buildroot compatibility for HWASAN. (flutter/flutter#167133) 2025-04-15 [email protected] Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569) 2025-04-15 [email protected] Clip bottom widgets in nav bar transition (flutter/flutter#166705) 2025-04-14 [email protected] Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132) 2025-04-14 [email protected] [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929) 2025-04-14 [email protected] Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916) 2025-04-14 [email protected] Roll Packages from 465bcff to f26b681 (1 revision) (flutter/flutter#167122) 2025-04-14 [email protected] [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997) 2025-04-14 [email protected] Remove some unused third party library build scripts (flutter/flutter#166960) 2025-04-14 [email protected] [reland] Fix regression in NDK version checking (flutter/flutter#167011) 2025-04-14 [email protected] Add network permissions information to the dart doc of network image. (flutter/flutter#167110) 2025-04-14 [email protected] Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994) 2025-04-12 [email protected] [Impeller] various iOS cleanups. (flutter/flutter#166859) 2025-04-11 [email protected] [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000) 2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007) 2025-04-11 [email protected] Fix regression in NDK version checking (flutter/flutter#166998) 2025-04-11 [email protected] [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637) 2025-04-11 [email protected] [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957) 2025-04-11 [email protected] modify toggle mode style with DatePickerTheme (flutter/flutter#164102) 2025-04-11 [email protected] [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916) 2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990) 2025-04-11 [email protected] Roll Packages from 431dc61 to 465bcff (2 revisions) (flutter/flutter#166982) 2025-04-11 [email protected] [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941) 2025-04-11 [email protected] Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877) 2025-04-11 [email protected] [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977) 2025-04-11 [email protected] [native assets] Roll dependencies (flutter/flutter#166969) 2025-04-11 [email protected] Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966) 2025-04-11 [email protected] Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963) 2025-04-11 [email protected] [native assets] Support user-defines in pubspec (flutter/flutter#166940) 2025-04-11 [email protected] [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892) 2025-04-11 [email protected] [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943) 2025-04-11 [email protected] Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889) 2025-04-11 [email protected] Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955) ...
- Add properties to DatePickerThemeData:
- `toggleModeStyle` allow customization on _DatePickerModeToggleButton
TextStyle;
- `toggleModeForegroundColor` allow changing the color of both button
and Icon with consistency;
- Compatible with existing code by the use of defaults;
- Adjust test to cover new properties
How to customize toggle mode style before:
```dart
showDatePicker(
context: context,
firstDate: DateTime(2025),
lastDate: DateTime(2026),
builder:
(context, child) => Theme(
data: ThemeData.light().copyWith(
textTheme: TextTheme(titleSmall: TextStyle(fontSize: 16)),
datePickerTheme: DatePickerThemeData(
dayStyle: TextStyle(fontSize: 12),
),
),
child: child!,
),
);
```
Now:
```dart
showDatePicker(
context: context,
firstDate: DateTime(2025),
lastDate: DateTime(2026),
builder:
(context, child) => DatePickerTheme(
data: DatePickerThemeData(
toggleModeStyle: TextStyle(fontSize: 16),
dayStyle: TextStyle(fontSize: 12),
),
child: child!,
),
);
```
Ref flutter#163866
Ref flutter#160591
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
toggleModeStyleallow customization on _DatePickerModeToggleButton TextStyle;toggleModeForegroundColorallow changing the color of both button and Icon with consistency;How to customize toggle mode style before:
Now:
Ref #163866
Ref #160591
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.