Skip to content

Enable luci_flags for faster builds #164069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jtmcdole merged 1 commit into from
Feb 25, 2025
Merged

Enable luci_flags for faster builds #164069

jtmcdole merged 1 commit into from
Feb 25, 2025

Conversation

@jtmcdole
Copy link
Member

@jtmcdole jtmcdole commented Feb 25, 2025

Experiment enable turning on faster builds.

  1. Moves collecting of builds till after we setup the orchestrator bot
  2. Downloads drone artifacts in parallel.

See: https://flutter-review.googlesource.com/c/recipes/+/63800

@jtmcdole jtmcdole requested a review from zanderso February 25, 2025 03:57
@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Feb 25, 2025
@jtmcdole jtmcdole requested a review from matanlurey February 25, 2025 03:58
@jtmcdole
Copy link
Member Author

jtmcdole commented Feb 25, 2025

We could update the recipe to use the future.spawn to collect builds and await it in the same spot we call it now. That would keep the timeline similar (e.g. builds take X minutes) and show the other tasks running at the same time. Something for another day.

@jtmcdole
Copy link
Member Author

jtmcdole commented Feb 25, 2025

Even with presubmits being RBE builds and faster than prod; you can see this completed much faster than the other builds:

17m vs 28~39m:
https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20mac_ios_engine

16m vs 25 to 30:m
https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20mac_host_engine

@zanderso
Copy link
Member

zanderso commented Feb 25, 2025

Nice speed up!

@jtmcdole jtmcdole added this pull request to the merge queue Feb 25, 2025
Merged via the queue into flutter:master with commit be1938a Feb 25, 2025
173 of 174 checks passed
@jtmcdole jtmcdole deleted the flagFasterBuilds branch February 25, 2025 16:47
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
be1938a Enable luci_flags for faster builds (flutter/flutter#164069)
410bc3d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
be1938a Enable luci_flags for faster builds (flutter/flutter#164069)
138157e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
be1938a Enable luci_flags for faster builds (flutter/flutter#164069)
fe2c0cc
@jtmcdole jtmcdole mentioned this pull request Feb 25, 2025
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
be1938a Enable luci_flags for faster builds (flutter/flutter#164069)
d5e4959
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
be1938a Enable luci_flags for faster builds (flutter/flutter#164069)
52d614c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
be1938a Enable luci_flags for faster builds (flutter/flutter#164069)
94b836b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
be1938a Enable luci_flags for faster builds (flutter/flutter#164069)
1a50256
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
be1938a Enable luci_flags for faster builds (flutter/flutter#164069)
998efd0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
be1938a Enable luci_flags for faster builds (flutter/flutter#164069)
3abe3af
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
be1938a Enable luci_flags for faster builds (flutter/flutter#164069)
e1d9726
github-merge-queue bot pushed a commit that referenced this pull request Feb 27, 2025
@jtmcdole
Run more builds faster (#164125)
4b65ead 
The following builds all download drone assets and run generators, and
thus could benefit from the flags.

- Linux linux_android_aot_engine
- Linux linux_android_debug_engine
- Linux linux_fuchsia
- Linux linux_host_engine

See #164069 for other builds
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2025
@engine-flutter-autoroll
be1938a Enable luci_flags for faster builds (flutter/flutter#164069)
2bf43d9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2025
@engine-flutter-autoroll
be1938a Enable luci_flags for faster builds (flutter/flutter#164069)
8712fd4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
be1938a Enable luci_flags for faster builds (flutter/flutter#164069)
dfb4a04
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
be1938a Enable luci_flags for faster builds (flutter/flutter#164069)
20d403d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
be1938a Enable luci_flags for faster builds (flutter/flutter#164069)
a039c59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanderso zanderso zanderso approved these changes

@matanlurey matanlurey Awaiting requested review from matanlurey

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jtmcdole @zanderso