[CP-stable]fix reorderable_list_test.dart #164050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix `reorderable_list_test.dart`
Author
|
@justinmc please fill out the PR description above, afterwards the release team will review this request. |
github-actions
bot
added
framework
justinmc
added
the
autosubmit
auto-submit
bot
merged commit f662dd5
into
flutter:flutter-3.29-candidate.0
156 checks passed
This was referenced Feb 25, 2025
auto-submit bot
pushed a commit
that referenced
this pull request
Feb 28, 2025
This PR updates the changelog for this cherry pick: #164050. If that cherry pick was successful, the presubmit test should not fail on this PR.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2025
Heng-code11
added a commit
to Heng-code11/untitled
that referenced
this pull request
Mar 12, 2025
This PR updates the changelog for this cherry pick: flutter/flutter#164050. If that cherry pick was successful, the presubmit test should not fail on this PR.
9 tasks
Fintasys
pushed a commit
to Fintasys/flutter
that referenced
this pull request
May 14, 2025
This PR updates the changelog for this cherry pick: flutter#164050. If that cherry pick was successful, the presubmit test should not fail on this PR.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
#164128
Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples
This cherry pick lands a fix to a test that is currently causing all presubmits to fail on the 3.29-candidate.0 stable release branch. The failure fixed in this test is dependent on the random ordering seed, which is why it didn't fail before. The current seed in which it fails is
--test-randomize-ordering-seed=20250221.Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
The only change is to reduce the flakiness of reorderable_list.test.dart.
Workaround:
Is there a workaround for this issue?
Change the seed?
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?