Wires up expanded state in web engine #164048

chunhtai · 2025-02-24T23:55:53Z

fixes #162141

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

chunhtai · 2025-02-24T23:56:18Z

cc @QuncCccccc this may have overlap with the your dropwdown menu pr

QuncCccccc · 2025-02-25T18:14:50Z

cc @QuncCccccc this may have overlap with the your dropwdown menu pr

Yes, #163638 included the expanded state:)

mdebbar

engine/src/flutter/lib/web_ui/lib/src/engine/semantics/expandable.dart

mdebbar · 2025-02-25T19:00:58Z

I believe this PR also closes #162141

auto-submit · 2025-02-25T21:11:51Z

autosubmit label was removed for flutter/flutter/164048, because - The status or check suite Windows windows_host_engine_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

…ble.dart Co-authored-by: Mouad Debbar <[email protected]>

auto-submit · 2025-02-27T22:12:50Z

autosubmit label was removed for flutter/flutter/164048, because - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

Roll Flutter from 2e570ca to 842db35 (59 revisions) flutter/flutter@2e570ca...842db35 2025-03-02 [email protected] Roll Skia from ad64415050aa to 101eee8fce59 (1 revision) (flutter/flutter#164449) 2025-03-02 [email protected] Roll Fuchsia Linux SDK from ln3joxJfRN2XGhvCv... to AO1KirSDI7-MVYNPN... (flutter/flutter#164440) 2025-03-02 [email protected] android: Clean up gen_snapshot artifact build (flutter/flutter#164418) 2025-03-02 [email protected] Start using `bin/cache/engine.{stamp|realm}` instead of `bin/internal/engine.{realm|version}`. (flutter/flutter#164352) 2025-03-01 [email protected] Add macos/android_debug_unopt to local_engine.json (flutter/flutter#164410) 2025-03-01 [email protected] Delete unused build archive targets (flutter/flutter#164414) 2025-03-01 [email protected] Roll Fuchsia Linux SDK from QMun2itYrV_zUYrvW... to ln3joxJfRN2XGhvCv... (flutter/flutter#164423) 2025-03-01 [email protected] Roll Skia from ac14158663ea to ad64415050aa (1 revision) (flutter/flutter#164413) 2025-03-01 [email protected] Update linux_host_engine.json ci/host_release description (flutter/flutter#164402) 2025-03-01 [email protected] In update_engine_version_test.dart, do not populate the test environment with the host platform environment (flutter/flutter#164395) 2025-03-01 [email protected] Roll-forward #164317: Use `bin/cache/engine.stamp` (flutter/flutter#164401) 2025-02-28 [email protected] Make pressing and moving on CupertinoButton closer to native behavior. (flutter/flutter#161731) 2025-02-28 [email protected] Roll Skia from 4005ba3ca7b6 to ac14158663ea (7 revisions) (flutter/flutter#164404) 2025-02-28 [email protected] [macOS] Prepare FlutterKeyboardManager for multi-view (flutter/flutter#163962) 2025-02-28 [email protected] Add PlatformDispatcher.engineId (flutter/flutter#163476) 2025-02-28 [email protected] Move `integration_test.FlutterDeviceScreenshotTest` to the framework slow shard (flutter/flutter#164398) 2025-02-28 [email protected] Fix: Update DelegatedTransition animation parameter correctly (flutter/flutter#163853) 2025-02-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Write an identical value to `bin/cache/engine.stamp` to prepare for migration (#164317)" (flutter/flutter#164396) 2025-02-28 [email protected] Add action for configuring default action of EditableText.onTapUpOutside (flutter/flutter#162575) 2025-02-28 [email protected] Align jvmTarget usages across codebase, while editing build.gradle files align them with android version documentation (flutter/flutter#164200) 2025-02-28 [email protected] Roll Packages from 01d3d5c to 70b41e1 (5 revisions) (flutter/flutter#164380) 2025-02-28 [email protected] [tool] Allow using archiveName in android bundle build (flutter/flutter#162390) 2025-02-28 [email protected] Fix incorrectly checking for invalid environment variables in the tool (flutter/flutter#164101) 2025-02-28 [email protected] Support forward and back buttons (flutter/flutter#164356) 2025-02-28 [email protected] Fix window creation callback for multi-window (flutter/flutter#164353) 2025-02-28 [email protected] Fix flutter doctor usage of eglinfo in failure cases. (flutter/flutter#164334) 2025-02-28 [email protected] Refactor writing of package config in tests (flutter/flutter#163734) 2025-02-28 [email protected] Fixed the issue that Slider's secondaryTrackValue is not updated. (flutter/flutter#163996) 2025-02-28 [email protected] Roll pub packages (flutter/flutter#164357) 2025-02-28 [email protected] Remove `Mac mac_unopt` presubmit retry count (flutter/flutter#164350) 2025-02-28 [email protected] Roll Fuchsia Linux SDK from 1elkOxihZuTEiTXzY... to QMun2itYrV_zUYrvW... (flutter/flutter#164351) 2025-02-28 [email protected] Drag handles only need to be tested on mobile platforms. (flutter/flutter#163723) 2025-02-28 [email protected] [Android] Use java for looking up Android API level. (flutter/flutter#163558) 2025-02-28 [email protected] Write an identical value to `bin/cache/engine.stamp` to prepare for migration (flutter/flutter#164317) 2025-02-27 [email protected] Wires up expanded state in web engine (flutter/flutter#164048) 2025-02-27 [email protected] Remove Cheserton's File (flutter/flutter#164340) 2025-02-27 [email protected] Replace update semantics handler with signal. (flutter/flutter#163583) 2025-02-27 [email protected] Split up the conical gradient fragment shader (flutter/flutter#164058) 2025-02-27 [email protected] Roll Skia from c16b145749d4 to 4005ba3ca7b6 (3 revisions) (flutter/flutter#164339) 2025-02-27 [email protected] Delete and update stale documentation regarding engine/engine hash. (flutter/flutter#164324) 2025-02-27 [email protected] Document how `engine.version` (is/will be) computed (flutter/flutter#164335) 2025-02-27 [email protected] Update conductor to write engine.version file (flutter/flutter#163350) 2025-02-27 [email protected] remove last usages of min/compile/target SdkVersion, align sourceCompatibility across repo and update android version documentation (flutter/flutter#164198) 2025-02-27 [email protected] Update links to the `flutter/engine` repository for the monorepo. (flutter/flutter#164328) 2025-02-27 [email protected] Add empty `io.flutter.app.FlutterApplication` to give deprecation notice, and un-break projects that have not migrated (flutter/flutter#164233) 2025-02-27 [email protected] Revert dart sdks that were causing dartaotruntime issues in g3 (flutter/flutter#164307) ...

github-actions bot added engine flutter/engine related. See also e: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) platform-web Web applications specifically labels Feb 24, 2025

chunhtai requested a review from mdebbar February 25, 2025 17:37

chunhtai force-pushed the issues/92040 branch from cef7548 to a2197f3 Compare February 25, 2025 17:45

mdebbar approved these changes Feb 25, 2025

View reviewed changes

engine/src/flutter/lib/web_ui/lib/src/engine/semantics/expandable.dart Outdated Show resolved Hide resolved

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 25, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 25, 2025

chunhtai force-pushed the issues/92040 branch from 9544d8c to 5e23012 Compare February 25, 2025 21:55

chunhtai and others added 4 commits February 27, 2025 12:53

Wires up expanded state in web engine

9625411

update

c6bae0f

Update engine/src/flutter/lib/web_ui/lib/src/engine/semantics/expanda…

823fb47

…ble.dart Co-authored-by: Mouad Debbar <[email protected]>

update

fc96d15

chunhtai force-pushed the issues/92040 branch from 5e23012 to fc96d15 Compare February 27, 2025 20:53

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2025

update

60f0cef

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2025

auto-submit bot added this pull request to the merge queue Feb 27, 2025

Merged via the queue into flutter:master with commit 37ff5a3 Feb 28, 2025
174 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 28, 2025

engine-flutter-autoroll mentioned this pull request Feb 28, 2025

Roll Flutter from 2e570ca393c8 to 25b3a4743a84 (35 revisions) flutter/packages#8755

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2025

37ff5a3 Wires up expanded state in web engine (flutter/flutter#164048)

06526ee

engine-flutter-autoroll mentioned this pull request Feb 28, 2025

Roll Flutter from 2e570ca393c8 to 933cb5da82c4 (36 revisions) flutter/packages#8756

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2025

37ff5a3 Wires up expanded state in web engine (flutter/flutter#164048)

8d940cf

engine-flutter-autoroll mentioned this pull request Feb 28, 2025

Roll Flutter from 2e570ca393c8 to b8902e6a1746 (38 revisions) flutter/packages#8759

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2025

37ff5a3 Wires up expanded state in web engine (flutter/flutter#164048)

826a520

engine-flutter-autoroll mentioned this pull request Feb 28, 2025

Roll Flutter from 2e570ca393c8 to 787adc75ed35 (39 revisions) flutter/packages#8762

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2025

37ff5a3 Wires up expanded state in web engine (flutter/flutter#164048)

dd36f97

engine-flutter-autoroll mentioned this pull request Feb 28, 2025

Roll Flutter from 2e570ca393c8 to 845c7779b802 (40 revisions) flutter/packages#8763

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2025

37ff5a3 Wires up expanded state in web engine (flutter/flutter#164048)

1130135

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2025

37ff5a3 Wires up expanded state in web engine (flutter/flutter#164048)

3e50ada

This was referenced Mar 1, 2025

Roll Flutter from 2e570ca393c8 to 0c055f2c508a (55 revisions) flutter/packages#8767

Closed

Roll Flutter from 2e570ca393c8 to 0c055f2c508a (55 revisions) flutter/packages#8768

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2025

37ff5a3 Wires up expanded state in web engine (flutter/flutter#164048)

354ad5e

engine-flutter-autoroll mentioned this pull request Mar 2, 2025

Roll Flutter from 2e570ca393c8 to 619d4248114d (58 revisions) flutter/packages#8769

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2025

37ff5a3 Wires up expanded state in web engine (flutter/flutter#164048)

9874aaf

engine-flutter-autoroll mentioned this pull request Mar 2, 2025

Roll Flutter from 2e570ca393c8 to 842db35d27b8 (59 revisions) flutter/packages#8770

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2025

37ff5a3 Wires up expanded state in web engine (flutter/flutter#164048)

b311250

engine-flutter-autoroll mentioned this pull request Mar 2, 2025

Roll Flutter from 2e570ca393c8 to 842db35d27b8 (59 revisions) flutter/packages#8771

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2025

37ff5a3 Wires up expanded state in web engine (flutter/flutter#164048)

3286d08

Piinks mentioned this pull request Mar 7, 2025

Flutter Notable Commits - 2025 #161460

Open

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

37ff5a3 Wires up expanded state in web engine (flutter/flutter#164048)

e30da30

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

37ff5a3 Wires up expanded state in web engine (flutter/flutter#164048)

9a23f26

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

37ff5a3 Wires up expanded state in web engine (flutter/flutter#164048)

8dafd33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Wires up expanded state in web engine #164048

Wires up expanded state in web engine #164048

Uh oh!

chunhtai commented Feb 24, 2025 •

edited

Loading

Uh oh!

chunhtai commented Feb 24, 2025

Uh oh!

QuncCccccc commented Feb 25, 2025

Uh oh!

mdebbar left a comment

Uh oh!

Uh oh!

mdebbar commented Feb 25, 2025

Uh oh!

auto-submit bot commented Feb 25, 2025

Uh oh!

auto-submit bot commented Feb 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Wires up expanded state in web engine #164048

Wires up expanded state in web engine #164048

Uh oh!

Conversation

chunhtai commented Feb 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

chunhtai commented Feb 24, 2025

Uh oh!

QuncCccccc commented Feb 25, 2025

Uh oh!

mdebbar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mdebbar commented Feb 25, 2025

Uh oh!

auto-submit bot commented Feb 25, 2025

Uh oh!

auto-submit bot commented Feb 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chunhtai commented Feb 24, 2025 •

edited

Loading