Skip to content

Remove the last vestiges of null-unsafety in flutter_tools. #164026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 4 commits into from
Feb 27, 2025
Merged

Remove the last vestiges of null-unsafety in flutter_tools. #164026

auto-submit merged 4 commits into from
Feb 27, 2025

Conversation

@matanlurey
Copy link
Contributor

@matanlurey matanlurey commented Feb 24, 2025

The internal code using this was deleted in cl/730558889.

@github-actions github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. team-ios Owned by iOS platform team labels Feb 24, 2025
jonahwilliams
jonahwilliams approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mdebbar
mdebbar approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yjbanov yjbanov changed the title Remove the last vestiges of null-safety in flutter_tools. Remove the last vestiges of null-unsafety in flutter_tools. Feb 24, 2025
srujzs
srujzs approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@srujzs srujzs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this had already landed - sorry for the late review! LGTM

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 26, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Feb 27, 2025

autosubmit label was removed for flutter/flutter/164026, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2025
@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 27, 2025
Merged via the queue into flutter:master with commit d8856b9 Feb 27, 2025
178 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2025
@engine-flutter-autoroll
d8856b9 Remove the last vestiges of null-unsafety in flutter_tools. (…
4c5f7c5 
…flutter/flutter#164026)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2025
@engine-flutter-autoroll
d8856b9 Remove the last vestiges of null-unsafety in flutter_tools. (…
37d474b 
…flutter/flutter#164026)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2025
@engine-flutter-autoroll
d8856b9 Remove the last vestiges of null-unsafety in flutter_tools. (…
26be683 
…flutter/flutter#164026)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2025
@engine-flutter-autoroll
d8856b9 Remove the last vestiges of null-unsafety in flutter_tools. (…
a1f7833 
…flutter/flutter#164026)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2025
@engine-flutter-autoroll
d8856b9 Remove the last vestiges of null-unsafety in flutter_tools. (…
ceae92e 
…flutter/flutter#164026)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2025
@engine-flutter-autoroll
d8856b9 Remove the last vestiges of null-unsafety in flutter_tools. (…
a73b3b7 
…flutter/flutter#164026)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2025
@engine-flutter-autoroll
d8856b9 Remove the last vestiges of null-unsafety in flutter_tools. (…
e82ff94 
…flutter/flutter#164026)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2025
@engine-flutter-autoroll
d8856b9 Remove the last vestiges of null-unsafety in flutter_tools. (…
26421a5 
…flutter/flutter#164026)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2025
@engine-flutter-autoroll
d8856b9 Remove the last vestiges of null-unsafety in flutter_tools. (…
1cff3a8 
…flutter/flutter#164026)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2025
@engine-flutter-autoroll
d8856b9 Remove the last vestiges of null-unsafety in flutter_tools. (…
df1c793 
…flutter/flutter#164026)
@jiahaog jiahaog mentioned this pull request Mar 3, 2025
Closed
9 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
d8856b9 Remove the last vestiges of null-unsafety in flutter_tools. (…
9134927 
…flutter/flutter#164026)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
d8856b9 Remove the last vestiges of null-unsafety in flutter_tools. (…
6adebb1 
…flutter/flutter#164026)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
d8856b9 Remove the last vestiges of null-unsafety in flutter_tools. (…
18e7ce1 
…flutter/flutter#164026)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdebbar mdebbar mdebbar approved these changes

@srujzs srujzs srujzs approved these changes

+1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

team-ios Owned by iOS platform team tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matanlurey @mdebbar @jonahwilliams @srujzs