Skip to content

[fuchsia] enable assets_unittests #164019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zijiehe-google-com merged 1 commit into from
Feb 25, 2025
Merged

[fuchsia] enable assets_unittests #164019

zijiehe-google-com merged 1 commit into from
Feb 25, 2025

Conversation

@zijiehe-google-com
Copy link
Contributor

@zijiehe-google-com zijiehe-google-com commented Feb 24, 2025 •
edited
Loading

It is an easy fix.

http://b/394632376

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Feb 24, 2025
@zijiehe-google-com zijiehe-google-com marked this pull request as ready for review February 24, 2025 19:26
jrwang
jrwang approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@jrwang jrwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zijiehe-google-com zijiehe-google-com added this pull request to the merge queue Feb 25, 2025
@zijiehe-google-com
Copy link
Contributor Author

zijiehe-google-com commented Feb 25, 2025

Thank you.

Merged via the queue into flutter:master with commit 70b7664 Feb 25, 2025
174 of 175 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
70b7664 [fuchsia] enable assets_unittests (flutter/flutter#164019)
43cbd81
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
70b7664 [fuchsia] enable assets_unittests (flutter/flutter#164019)
18d3c30
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
70b7664 [fuchsia] enable assets_unittests (flutter/flutter#164019)
835a928
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
70b7664 [fuchsia] enable assets_unittests (flutter/flutter#164019)
7d6fa27
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
70b7664 [fuchsia] enable assets_unittests (flutter/flutter#164019)
0b3ad0f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
70b7664 [fuchsia] enable assets_unittests (flutter/flutter#164019)
3c37b56
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
70b7664 [fuchsia] enable assets_unittests (flutter/flutter#164019)
37b2fde
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2025
@engine-flutter-autoroll
70b7664 [fuchsia] enable assets_unittests (flutter/flutter#164019)
f1c468b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2025
@engine-flutter-autoroll
70b7664 [fuchsia] enable assets_unittests (flutter/flutter#164019)
24501c3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
70b7664 [fuchsia] enable assets_unittests (flutter/flutter#164019)
44d2a00
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
70b7664 [fuchsia] enable assets_unittests (flutter/flutter#164019)
ebccca8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
70b7664 [fuchsia] enable assets_unittests (flutter/flutter#164019)
5e5dd4e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrwang jrwang jrwang approved these changes

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zijiehe-google-com @jrwang