Skip to content

Feat: Animate fill for material app bar #163913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 4 commits into from
May 7, 2025
Merged

Feat: Animate fill for material app bar #163913

auto-submit merged 4 commits into from
May 7, 2025

Conversation

@rkishan516
Copy link
Contributor

@rkishan516 rkishan516 commented Feb 22, 2025 •
edited
Loading

Feat: Animate fill for material app bar
fixes: #162988

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Feb 22, 2025
@flutter-dashboard
Copy link

flutter-dashboard bot commented Feb 22, 2025

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #163913 at sha a3352c9

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Feb 22, 2025
@dkwingsmt
Copy link
Contributor

dkwingsmt commented Feb 25, 2025

Thanks for the change. Although I do see how it's improving the fidelity, it probably shouldn't be implemented on Material, which controls all widgets, but instead should be in the app bar widget.

Also we'll need some tests to guarantee it's not broken after the merge.

@rkishan516
Copy link
Contributor Author

rkishan516 commented Mar 17, 2025

@dkwingsmt Its ready to review again.

dkwingsmt
dkwingsmt reviewed Mar 18, 2025
View reviewed changes
packages/flutter/test/material/app_bar_test.dart

expect(getAppBarAnimatedBackgroundColor(tester), defaultColor);
await tester.pumpAndSettle();
expect(getAppBarAnimatedBackgroundColor(tester), scrolledColor);
Copy link
Contributor

@dkwingsmt dkwingsmt Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this test case verifies the feature. It only verifies the starting color and ending color, while you're trying to verify that there's a smooth animation in between. I recommend going without pumpAndSettle but pumping a time instead, and it should result in a intermediate color.

Copy link
Contributor Author

@rkishan516 rkishan516 Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Let me do the change.

Copy link
Contributor Author

@rkishan516 rkishan516 Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have pushed changes for 2 intermediate color.

  1. At 50ms after animation start
  2. At 100ms after animation start

Animation duration is 200ms.

@rkishan516 rkishan516 force-pushed the animate-app-bar-fill branch 4 times, most recently from b1a60d1 to 5144d7a Compare March 18, 2025 10:07
@dkwingsmt
Copy link
Contributor

dkwingsmt commented Mar 18, 2025

The errors seem to be caused by comparing equality of the floating points. Try isSameColorAs, which allows tolerance. (Also therefore you don't need that much precision)

@rkishan516 rkishan516 force-pushed the animate-app-bar-fill branch from 5144d7a to a646e41 Compare March 18, 2025 22:06
@rkishan516
Copy link
Contributor Author

rkishan516 commented Mar 18, 2025

The errors seem to be caused by comparing equality of the floating points. Try isSameColorAs, which allows tolerance. (Also therefore you don't need that much precision)

Thanks, this worked very well.

@dkwingsmt dkwingsmt requested a review from QuncCccccc March 19, 2025 18:35
dkwingsmt
dkwingsmt approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

QuncCccccc
QuncCccccc reviewed Apr 2, 2025
View reviewed changes
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! This looks great to me. Just left one comment and then we are good to go:)

packages/flutter/test/material/app_bar_test.dart Outdated

testWidgets('backgroundColor animation', (WidgetTester tester) async {
await tester.pumpWidget(
buildAppBar(contentHeight: 1200.0, surfaceTintColor: Colors.transparent),
Copy link
Contributor

@QuncCccccc QuncCccccc Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

surfaceTintColor has been deprecated in specs, even though we haven't cleaned it up here. So I think it would be better if we don't introduce more use case like this. Instead of changing surfaceTintColor to transparent, I think assigning scrolledUnderElevation: 0 in appbar will also work for this test.

Copy link
Contributor Author

@rkishan516 rkishan516 Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let me push the change.

@rkishan516 rkishan516 force-pushed the animate-app-bar-fill branch from a646e41 to d90c3ff Compare April 2, 2025 01:42
@dkwingsmt dkwingsmt requested a review from QuncCccccc April 7, 2025 06:09
QuncCccccc
QuncCccccc reviewed Apr 9, 2025
View reviewed changes
packages/flutter/test/material/app_bar_test.dart Outdated
required double contentHeight,
bool reverse = false,
bool includeFlexibleSpace = false,
Color? surfaceTintColor,
Copy link
Contributor

@QuncCccccc QuncCccccc Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Color? surfaceTintColor,

packages/flutter/test/material/app_bar_test.dart Outdated
home: Scaffold(
appBar: AppBar(
elevation: 0,
surfaceTintColor: surfaceTintColor,
Copy link
Contributor

@QuncCccccc QuncCccccc Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
surfaceTintColor: surfaceTintColor,

@rkishan516 rkishan516 force-pushed the animate-app-bar-fill branch from d90c3ff to 6e290ab Compare April 9, 2025 14:52
@QuncCccccc
Copy link
Contributor

QuncCccccc commented Apr 9, 2025

I took a look at the failed Google testing yesterday, seems it breaks several tests and causes wrong background color for appbar. I'm still not sure the root cause.

@dkwingsmt dkwingsmt requested a review from QuncCccccc April 23, 2025 18:06
@QuncCccccc
Copy link
Contributor

QuncCccccc commented Apr 30, 2025

Just an update, I'm looking at the google failures today:)

@QuncCccccc
Copy link
Contributor

QuncCccccc commented May 1, 2025

I'm still very confused what caused the Scuba failures:( Might need to ask for some help from @dkwingsmt to see if he has any insights. It seems some failures show that the background color of the app bar just disappear.

I'm thinking if we can add an animateColor flag for app bar and defaults to false so we don't break the current apps?

@dkwingsmt
Copy link
Contributor

dkwingsmt commented May 1, 2025

It seems that the failures are real. I'm taking a look.

@rkishan516 rkishan516 force-pushed the animate-app-bar-fill branch from 6e290ab to da75dbd Compare May 1, 2025 00:41
@rkishan516
Copy link
Contributor Author

rkishan516 commented May 1, 2025

I have added animateColor property to AppBar.

@QuncCccccc
Copy link
Contributor

QuncCccccc commented May 1, 2025

I have added animateColor property to AppBar.

Ah so quick! I talked with @dkwingsmt offline just now. Can we still keep the original fix? I think we found the cause, so I'll provide a fix in g3.

@rkishan516 rkishan516 force-pushed the animate-app-bar-fill branch from d6c28c6 to db087ac Compare May 7, 2025 01:10
@rkishan516
Copy link
Contributor Author

rkishan516 commented May 7, 2025

Hi @rkishan516! We noticed that some failed tests in google testing are hard to reproduce. The failures might just come from how the tests are constructed instead of the change that this PR made. We still don't want users to directly accept the diffs, instead, can we provide a flag option animateColor or animateBackgroundColor for AppBar and make the default value to be false, so that for users who really wants the animation behavior can turn on the flag. Sorry for the back and forth discussion:)!

No, issue. I have pushed the change.

QuncCccccc
QuncCccccc approved these changes May 7, 2025
View reviewed changes
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution and quick response!

packages/flutter/lib/src/material/app_bar.dart
/// {@endtemplate}
final EdgeInsetsGeometry? actionsPadding;

/// Whether the color should be animated.
Copy link
Contributor

@QuncCccccc QuncCccccc May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Whether the color should be animated.
/// Whether the background color should be animated when scroll starts and ends.

@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label May 7, 2025
@auto-submit auto-submit bot added this pull request to the merge queue May 7, 2025
Merged via the queue into flutter:master with commit b0f5c8c May 7, 2025
74 of 75 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 7, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 7, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
b0f5c8ce0 Feat: Animate fill for material app bar (flutter/flutter#16…
7b7faba 
…3913)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
b0f5c8ce0 Feat: Animate fill for material app bar (flutter/flutter#16…
091046c 
…3913)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
b0f5c8ce0 Feat: Animate fill for material app bar (flutter/flutter#16…
8689c65 
…3913)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
b0f5c8ce0 Feat: Animate fill for material app bar (flutter/flutter#16…
eb54502 
…3913)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 8, 2025
@engine-flutter-autoroll
Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions) (#9223)
1392e8c 
Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions)

flutter/flutter@cfb887c...b0f5c8c

2025-05-07 [email protected] Feat: Animate fill for material app bar (flutter/flutter#163913)
2025-05-07 [email protected] Roll Packages from e800da7 to b2ce3b0 (3 revisions) (flutter/flutter#168483)
2025-05-07 [email protected] Allow iOS devicelab tests to run on macOS 15.1 (flutter/flutter#168234)
2025-05-07 [email protected] Roll Skia from c8f54c1bc565 to 14f3e3209b73 (1 revision) (flutter/flutter#168477)
2025-05-07 [email protected] Roll Skia from 55d98def951d to c8f54c1bc565 (1 revision) (flutter/flutter#168452)
2025-05-07 [email protected] Roll Fuchsia Test Scripts from TcALRG6cjvR6RVe4L... to xobrcSN07udKdXOq_... (flutter/flutter#168444)
2025-05-07 [email protected] Roll Skia from 32591be9cd3b to 55d98def951d (2 revisions) (flutter/flutter#168440)
2025-05-07 [email protected] macOS: trailing closures for FlutterRunLoop.perform* (flutter/flutter#168415)
2025-05-07 [email protected] Roll Fuchsia Linux SDK from SOlRUoAtzxSsarx-6... to _GJje-N2Jk51qtBs6... (flutter/flutter#168434)
2025-05-07 [email protected] iOS/macOS: Consistent Flutter copyright headers (flutter/flutter#168390)
2025-05-06 [email protected] Capture errors when running flutter_tools in the entrypoint_dart_registrant devicelab test (flutter/flutter#168411)
2025-05-06 [email protected] Extending timeouts for DDC macrobenchmarks (flutter/flutter#168409)
2025-05-06 [email protected] Roll Skia from 36d1445ad00b to 32591be9cd3b (1 revision) (flutter/flutter#168421)
2025-05-06 [email protected] Ignore pointer on the outgoing route (flutter/flutter#168425)
2025-05-06 [email protected] [skwasm] Dispose underlying picture recorder when ending recording. (flutter/flutter#168384)
2025-05-06 [email protected] [Impeller] libImpeller: Expose access to conservative path bounds. (flutter/flutter#168402)
2025-05-06 [email protected] Roll Skia from 5cf5d0ff46d9 to 36d1445ad00b (1 revision) (flutter/flutter#168401)
2025-05-06 [email protected] Add height and width aspects to MediaQuery. (flutter/flutter#167829)
2025-05-06 [email protected] Roll Packages from e064b04 to e800da7 (2 revisions) (flutter/flutter#168392)
2025-05-06 [email protected] Add `bin/internal/last_engine_commit.sh` and tests. (flutter/flutter#168387)
2025-05-06 [email protected] Update `mac_ios` tests to run on either arm64 or x86 (flutter/flutter#168341)
2025-05-06 [email protected] Roll Skia from 889c5b52227c to 5cf5d0ff46d9 (3 revisions) (flutter/flutter#168378)
2025-05-06 [email protected] Roll Skia from 646573154de6 to 889c5b52227c (1 revision) (flutter/flutter#168363)
2025-05-06 [email protected] Roll Skia from 65fd10118ec2 to 646573154de6 (3 revisions) (flutter/flutter#168360)
2025-05-06 [email protected] feat(SwitchListTile): ensure that 'isThreeLine' can be configured through the theme. (flutter/flutter#166820)
2025-05-06 [email protected] [tool] Refactor WebTemplate to be immutable (flutter/flutter#168201)
2025-05-06 [email protected] Upload `android-arm64-release` treemap to known location (flutter/flutter#168349)
2025-05-06 [email protected] feat(RadioListTile):ensure that 'isThreeLine' can be configured through the (flutter/flutter#166964)
2025-05-06 [email protected] Roll Fuchsia Linux SDK from hjXORaFgiSd6QjK3D... to SOlRUoAtzxSsarx-6... (flutter/flutter#168347)
2025-05-05 [email protected] Revert "Wire up `MenuAnchor`, `MenuBar`, `MenuItem`-related widgets to aria roles (#165596)" (flutter/flutter#168339)
2025-05-05 [email protected] Bumping framework Template Defaults to Android 16 (API 36) (flutter/flutter#166464)
2025-05-05 [email protected] Roll Skia from c0404ac7ea67 to 65fd10118ec2 (3 revisions) (flutter/flutter#168346)
2025-05-05 [email protected] macOS: Support writing Swift in the macOS embedder (flutter/flutter#168174)
2025-05-05 [email protected] Copy Dart SDK _internal/vm/bin sources into the sky_engine package (flutter/flutter#168238)
2025-05-05 [email protected] Using headless=new for Chrome macrobenchmarks (flutter/flutter#168256)
2025-05-05 [email protected] Roll Dart SDK from a1e1e2770c1e to 8dc0ecee5adc (1 revision) (flutter/flutter#168338)
2025-05-05 [email protected] Check for duplicate archive paths in the engine build configuration JSON files (flutter/flutter#168248)
2025-05-05 [email protected] [Widget Inspector] Add on-device button for changing default "tap" behavior  (flutter/flutter#167677)
2025-05-05 [email protected] Adding utf-8 encoding to hello world's html template (flutter/flutter#168162)
2025-05-05 [email protected] Update goldens.dart error to point to moved file (flutter/flutter#168319)
2025-05-05 [email protected] Skwasm heavy (flutter/flutter#166619)
2025-05-05 [email protected] Manual roll of Dart from 5c535a368799 to a1e1e2770c1e (flutter/flutter#168317)
2025-05-05 [email protected] Roll Skia from 9e23a55870e9 to c0404ac7ea67 (1 revision) (flutter/flutter#168321)
2025-05-05 [email protected] Cupertino sheet MediaQuery values (flutter/flutter#168041)
2025-05-05 [email protected] Change FGP unit test `expect` to match on process result instead of exit code (flutter/flutter#168278)
2025-05-05 [email protected] [Impeller] Use StrokeParameters anywhere stroke is described (flutter/flutter#168276)
...
@Piinks Piinks mentioned this pull request May 9, 2025
Open
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions) (flutt…
cf1d157 
…er#9223)

Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions)

flutter/flutter@cfb887c...b0f5c8c

2025-05-07 [email protected] Feat: Animate fill for material app bar (flutter/flutter#163913)
2025-05-07 [email protected] Roll Packages from e800da7 to b2ce3b0 (3 revisions) (flutter/flutter#168483)
2025-05-07 [email protected] Allow iOS devicelab tests to run on macOS 15.1 (flutter/flutter#168234)
2025-05-07 [email protected] Roll Skia from c8f54c1bc565 to 14f3e3209b73 (1 revision) (flutter/flutter#168477)
2025-05-07 [email protected] Roll Skia from 55d98def951d to c8f54c1bc565 (1 revision) (flutter/flutter#168452)
2025-05-07 [email protected] Roll Fuchsia Test Scripts from TcALRG6cjvR6RVe4L... to xobrcSN07udKdXOq_... (flutter/flutter#168444)
2025-05-07 [email protected] Roll Skia from 32591be9cd3b to 55d98def951d (2 revisions) (flutter/flutter#168440)
2025-05-07 [email protected] macOS: trailing closures for FlutterRunLoop.perform* (flutter/flutter#168415)
2025-05-07 [email protected] Roll Fuchsia Linux SDK from SOlRUoAtzxSsarx-6... to _GJje-N2Jk51qtBs6... (flutter/flutter#168434)
2025-05-07 [email protected] iOS/macOS: Consistent Flutter copyright headers (flutter/flutter#168390)
2025-05-06 [email protected] Capture errors when running flutter_tools in the entrypoint_dart_registrant devicelab test (flutter/flutter#168411)
2025-05-06 [email protected] Extending timeouts for DDC macrobenchmarks (flutter/flutter#168409)
2025-05-06 [email protected] Roll Skia from 36d1445ad00b to 32591be9cd3b (1 revision) (flutter/flutter#168421)
2025-05-06 [email protected] Ignore pointer on the outgoing route (flutter/flutter#168425)
2025-05-06 [email protected] [skwasm] Dispose underlying picture recorder when ending recording. (flutter/flutter#168384)
2025-05-06 [email protected] [Impeller] libImpeller: Expose access to conservative path bounds. (flutter/flutter#168402)
2025-05-06 [email protected] Roll Skia from 5cf5d0ff46d9 to 36d1445ad00b (1 revision) (flutter/flutter#168401)
2025-05-06 [email protected] Add height and width aspects to MediaQuery. (flutter/flutter#167829)
2025-05-06 [email protected] Roll Packages from e064b04 to e800da7 (2 revisions) (flutter/flutter#168392)
2025-05-06 [email protected] Add `bin/internal/last_engine_commit.sh` and tests. (flutter/flutter#168387)
2025-05-06 [email protected] Update `mac_ios` tests to run on either arm64 or x86 (flutter/flutter#168341)
2025-05-06 [email protected] Roll Skia from 889c5b52227c to 5cf5d0ff46d9 (3 revisions) (flutter/flutter#168378)
2025-05-06 [email protected] Roll Skia from 646573154de6 to 889c5b52227c (1 revision) (flutter/flutter#168363)
2025-05-06 [email protected] Roll Skia from 65fd10118ec2 to 646573154de6 (3 revisions) (flutter/flutter#168360)
2025-05-06 [email protected] feat(SwitchListTile): ensure that 'isThreeLine' can be configured through the theme. (flutter/flutter#166820)
2025-05-06 [email protected] [tool] Refactor WebTemplate to be immutable (flutter/flutter#168201)
2025-05-06 [email protected] Upload `android-arm64-release` treemap to known location (flutter/flutter#168349)
2025-05-06 [email protected] feat(RadioListTile):ensure that 'isThreeLine' can be configured through the (flutter/flutter#166964)
2025-05-06 [email protected] Roll Fuchsia Linux SDK from hjXORaFgiSd6QjK3D... to SOlRUoAtzxSsarx-6... (flutter/flutter#168347)
2025-05-05 [email protected] Revert "Wire up `MenuAnchor`, `MenuBar`, `MenuItem`-related widgets to aria roles (#165596)" (flutter/flutter#168339)
2025-05-05 [email protected] Bumping framework Template Defaults to Android 16 (API 36) (flutter/flutter#166464)
2025-05-05 [email protected] Roll Skia from c0404ac7ea67 to 65fd10118ec2 (3 revisions) (flutter/flutter#168346)
2025-05-05 [email protected] macOS: Support writing Swift in the macOS embedder (flutter/flutter#168174)
2025-05-05 [email protected] Copy Dart SDK _internal/vm/bin sources into the sky_engine package (flutter/flutter#168238)
2025-05-05 [email protected] Using headless=new for Chrome macrobenchmarks (flutter/flutter#168256)
2025-05-05 [email protected] Roll Dart SDK from a1e1e2770c1e to 8dc0ecee5adc (1 revision) (flutter/flutter#168338)
2025-05-05 [email protected] Check for duplicate archive paths in the engine build configuration JSON files (flutter/flutter#168248)
2025-05-05 [email protected] [Widget Inspector] Add on-device button for changing default "tap" behavior  (flutter/flutter#167677)
2025-05-05 [email protected] Adding utf-8 encoding to hello world's html template (flutter/flutter#168162)
2025-05-05 [email protected] Update goldens.dart error to point to moved file (flutter/flutter#168319)
2025-05-05 [email protected] Skwasm heavy (flutter/flutter#166619)
2025-05-05 [email protected] Manual roll of Dart from 5c535a368799 to a1e1e2770c1e (flutter/flutter#168317)
2025-05-05 [email protected] Roll Skia from 9e23a55870e9 to c0404ac7ea67 (1 revision) (flutter/flutter#168321)
2025-05-05 [email protected] Cupertino sheet MediaQuery values (flutter/flutter#168041)
2025-05-05 [email protected] Change FGP unit test `expect` to match on process result instead of exit code (flutter/flutter#168278)
2025-05-05 [email protected] [Impeller] Use StrokeParameters anywhere stroke is described (flutter/flutter#168276)
...
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions) (flutt…
aed46c7 
…er#9223)

Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions)

flutter/flutter@cfb887c...b0f5c8c

2025-05-07 [email protected] Feat: Animate fill for material app bar (flutter/flutter#163913)
2025-05-07 [email protected] Roll Packages from e800da7 to b2ce3b0 (3 revisions) (flutter/flutter#168483)
2025-05-07 [email protected] Allow iOS devicelab tests to run on macOS 15.1 (flutter/flutter#168234)
2025-05-07 [email protected] Roll Skia from c8f54c1bc565 to 14f3e3209b73 (1 revision) (flutter/flutter#168477)
2025-05-07 [email protected] Roll Skia from 55d98def951d to c8f54c1bc565 (1 revision) (flutter/flutter#168452)
2025-05-07 [email protected] Roll Fuchsia Test Scripts from TcALRG6cjvR6RVe4L... to xobrcSN07udKdXOq_... (flutter/flutter#168444)
2025-05-07 [email protected] Roll Skia from 32591be9cd3b to 55d98def951d (2 revisions) (flutter/flutter#168440)
2025-05-07 [email protected] macOS: trailing closures for FlutterRunLoop.perform* (flutter/flutter#168415)
2025-05-07 [email protected] Roll Fuchsia Linux SDK from SOlRUoAtzxSsarx-6... to _GJje-N2Jk51qtBs6... (flutter/flutter#168434)
2025-05-07 [email protected] iOS/macOS: Consistent Flutter copyright headers (flutter/flutter#168390)
2025-05-06 [email protected] Capture errors when running flutter_tools in the entrypoint_dart_registrant devicelab test (flutter/flutter#168411)
2025-05-06 [email protected] Extending timeouts for DDC macrobenchmarks (flutter/flutter#168409)
2025-05-06 [email protected] Roll Skia from 36d1445ad00b to 32591be9cd3b (1 revision) (flutter/flutter#168421)
2025-05-06 [email protected] Ignore pointer on the outgoing route (flutter/flutter#168425)
2025-05-06 [email protected] [skwasm] Dispose underlying picture recorder when ending recording. (flutter/flutter#168384)
2025-05-06 [email protected] [Impeller] libImpeller: Expose access to conservative path bounds. (flutter/flutter#168402)
2025-05-06 [email protected] Roll Skia from 5cf5d0ff46d9 to 36d1445ad00b (1 revision) (flutter/flutter#168401)
2025-05-06 [email protected] Add height and width aspects to MediaQuery. (flutter/flutter#167829)
2025-05-06 [email protected] Roll Packages from e064b04 to e800da7 (2 revisions) (flutter/flutter#168392)
2025-05-06 [email protected] Add `bin/internal/last_engine_commit.sh` and tests. (flutter/flutter#168387)
2025-05-06 [email protected] Update `mac_ios` tests to run on either arm64 or x86 (flutter/flutter#168341)
2025-05-06 [email protected] Roll Skia from 889c5b52227c to 5cf5d0ff46d9 (3 revisions) (flutter/flutter#168378)
2025-05-06 [email protected] Roll Skia from 646573154de6 to 889c5b52227c (1 revision) (flutter/flutter#168363)
2025-05-06 [email protected] Roll Skia from 65fd10118ec2 to 646573154de6 (3 revisions) (flutter/flutter#168360)
2025-05-06 [email protected] feat(SwitchListTile): ensure that 'isThreeLine' can be configured through the theme. (flutter/flutter#166820)
2025-05-06 [email protected] [tool] Refactor WebTemplate to be immutable (flutter/flutter#168201)
2025-05-06 [email protected] Upload `android-arm64-release` treemap to known location (flutter/flutter#168349)
2025-05-06 [email protected] feat(RadioListTile):ensure that 'isThreeLine' can be configured through the (flutter/flutter#166964)
2025-05-06 [email protected] Roll Fuchsia Linux SDK from hjXORaFgiSd6QjK3D... to SOlRUoAtzxSsarx-6... (flutter/flutter#168347)
2025-05-05 [email protected] Revert "Wire up `MenuAnchor`, `MenuBar`, `MenuItem`-related widgets to aria roles (#165596)" (flutter/flutter#168339)
2025-05-05 [email protected] Bumping framework Template Defaults to Android 16 (API 36) (flutter/flutter#166464)
2025-05-05 [email protected] Roll Skia from c0404ac7ea67 to 65fd10118ec2 (3 revisions) (flutter/flutter#168346)
2025-05-05 [email protected] macOS: Support writing Swift in the macOS embedder (flutter/flutter#168174)
2025-05-05 [email protected] Copy Dart SDK _internal/vm/bin sources into the sky_engine package (flutter/flutter#168238)
2025-05-05 [email protected] Using headless=new for Chrome macrobenchmarks (flutter/flutter#168256)
2025-05-05 [email protected] Roll Dart SDK from a1e1e2770c1e to 8dc0ecee5adc (1 revision) (flutter/flutter#168338)
2025-05-05 [email protected] Check for duplicate archive paths in the engine build configuration JSON files (flutter/flutter#168248)
2025-05-05 [email protected] [Widget Inspector] Add on-device button for changing default "tap" behavior  (flutter/flutter#167677)
2025-05-05 [email protected] Adding utf-8 encoding to hello world's html template (flutter/flutter#168162)
2025-05-05 [email protected] Update goldens.dart error to point to moved file (flutter/flutter#168319)
2025-05-05 [email protected] Skwasm heavy (flutter/flutter#166619)
2025-05-05 [email protected] Manual roll of Dart from 5c535a368799 to a1e1e2770c1e (flutter/flutter#168317)
2025-05-05 [email protected] Roll Skia from 9e23a55870e9 to c0404ac7ea67 (1 revision) (flutter/flutter#168321)
2025-05-05 [email protected] Cupertino sheet MediaQuery values (flutter/flutter#168041)
2025-05-05 [email protected] Change FGP unit test `expect` to match on process result instead of exit code (flutter/flutter#168278)
2025-05-05 [email protected] [Impeller] Use StrokeParameters anywhere stroke is described (flutter/flutter#168276)
...
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@engine-flutter-autoroll @Ortes
Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions) (flutt…
c32f7c3 
…er#9223)

Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions)

flutter/flutter@cfb887c...b0f5c8c

2025-05-07 [email protected] Feat: Animate fill for material app bar (flutter/flutter#163913)
2025-05-07 [email protected] Roll Packages from e800da7 to b2ce3b0 (3 revisions) (flutter/flutter#168483)
2025-05-07 [email protected] Allow iOS devicelab tests to run on macOS 15.1 (flutter/flutter#168234)
2025-05-07 [email protected] Roll Skia from c8f54c1bc565 to 14f3e3209b73 (1 revision) (flutter/flutter#168477)
2025-05-07 [email protected] Roll Skia from 55d98def951d to c8f54c1bc565 (1 revision) (flutter/flutter#168452)
2025-05-07 [email protected] Roll Fuchsia Test Scripts from TcALRG6cjvR6RVe4L... to xobrcSN07udKdXOq_... (flutter/flutter#168444)
2025-05-07 [email protected] Roll Skia from 32591be9cd3b to 55d98def951d (2 revisions) (flutter/flutter#168440)
2025-05-07 [email protected] macOS: trailing closures for FlutterRunLoop.perform* (flutter/flutter#168415)
2025-05-07 [email protected] Roll Fuchsia Linux SDK from SOlRUoAtzxSsarx-6... to _GJje-N2Jk51qtBs6... (flutter/flutter#168434)
2025-05-07 [email protected] iOS/macOS: Consistent Flutter copyright headers (flutter/flutter#168390)
2025-05-06 [email protected] Capture errors when running flutter_tools in the entrypoint_dart_registrant devicelab test (flutter/flutter#168411)
2025-05-06 [email protected] Extending timeouts for DDC macrobenchmarks (flutter/flutter#168409)
2025-05-06 [email protected] Roll Skia from 36d1445ad00b to 32591be9cd3b (1 revision) (flutter/flutter#168421)
2025-05-06 [email protected] Ignore pointer on the outgoing route (flutter/flutter#168425)
2025-05-06 [email protected] [skwasm] Dispose underlying picture recorder when ending recording. (flutter/flutter#168384)
2025-05-06 [email protected] [Impeller] libImpeller: Expose access to conservative path bounds. (flutter/flutter#168402)
2025-05-06 [email protected] Roll Skia from 5cf5d0ff46d9 to 36d1445ad00b (1 revision) (flutter/flutter#168401)
2025-05-06 [email protected] Add height and width aspects to MediaQuery. (flutter/flutter#167829)
2025-05-06 [email protected] Roll Packages from e064b04 to e800da7 (2 revisions) (flutter/flutter#168392)
2025-05-06 [email protected] Add `bin/internal/last_engine_commit.sh` and tests. (flutter/flutter#168387)
2025-05-06 [email protected] Update `mac_ios` tests to run on either arm64 or x86 (flutter/flutter#168341)
2025-05-06 [email protected] Roll Skia from 889c5b52227c to 5cf5d0ff46d9 (3 revisions) (flutter/flutter#168378)
2025-05-06 [email protected] Roll Skia from 646573154de6 to 889c5b52227c (1 revision) (flutter/flutter#168363)
2025-05-06 [email protected] Roll Skia from 65fd10118ec2 to 646573154de6 (3 revisions) (flutter/flutter#168360)
2025-05-06 [email protected] feat(SwitchListTile): ensure that 'isThreeLine' can be configured through the theme. (flutter/flutter#166820)
2025-05-06 [email protected] [tool] Refactor WebTemplate to be immutable (flutter/flutter#168201)
2025-05-06 [email protected] Upload `android-arm64-release` treemap to known location (flutter/flutter#168349)
2025-05-06 [email protected] feat(RadioListTile):ensure that 'isThreeLine' can be configured through the (flutter/flutter#166964)
2025-05-06 [email protected] Roll Fuchsia Linux SDK from hjXORaFgiSd6QjK3D... to SOlRUoAtzxSsarx-6... (flutter/flutter#168347)
2025-05-05 [email protected] Revert "Wire up `MenuAnchor`, `MenuBar`, `MenuItem`-related widgets to aria roles (#165596)" (flutter/flutter#168339)
2025-05-05 [email protected] Bumping framework Template Defaults to Android 16 (API 36) (flutter/flutter#166464)
2025-05-05 [email protected] Roll Skia from c0404ac7ea67 to 65fd10118ec2 (3 revisions) (flutter/flutter#168346)
2025-05-05 [email protected] macOS: Support writing Swift in the macOS embedder (flutter/flutter#168174)
2025-05-05 [email protected] Copy Dart SDK _internal/vm/bin sources into the sky_engine package (flutter/flutter#168238)
2025-05-05 [email protected] Using headless=new for Chrome macrobenchmarks (flutter/flutter#168256)
2025-05-05 [email protected] Roll Dart SDK from a1e1e2770c1e to 8dc0ecee5adc (1 revision) (flutter/flutter#168338)
2025-05-05 [email protected] Check for duplicate archive paths in the engine build configuration JSON files (flutter/flutter#168248)
2025-05-05 [email protected] [Widget Inspector] Add on-device button for changing default "tap" behavior  (flutter/flutter#167677)
2025-05-05 [email protected] Adding utf-8 encoding to hello world's html template (flutter/flutter#168162)
2025-05-05 [email protected] Update goldens.dart error to point to moved file (flutter/flutter#168319)
2025-05-05 [email protected] Skwasm heavy (flutter/flutter#166619)
2025-05-05 [email protected] Manual roll of Dart from 5c535a368799 to a1e1e2770c1e (flutter/flutter#168317)
2025-05-05 [email protected] Roll Skia from 9e23a55870e9 to c0404ac7ea67 (1 revision) (flutter/flutter#168321)
2025-05-05 [email protected] Cupertino sheet MediaQuery values (flutter/flutter#168041)
2025-05-05 [email protected] Change FGP unit test `expect` to match on process result instead of exit code (flutter/flutter#168278)
2025-05-05 [email protected] [Impeller] Use StrokeParameters anywhere stroke is described (flutter/flutter#168276)
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
b0f5c8ce0 Feat: Animate fill for material app bar (flutter/flutter#16…
988055d 
…3913)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
b0f5c8ce0 Feat: Animate fill for material app bar (flutter/flutter#16…
43f5015 
…3913)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
b0f5c8ce0 Feat: Animate fill for material app bar (flutter/flutter#16…
b30bd9d 
…3913)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
b0f5c8ce0 Feat: Animate fill for material app bar (flutter/flutter#16…
c906a9b 
…3913)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
b0f5c8ce0 Feat: Animate fill for material app bar (flutter/flutter#16…
f503b73 
…3913)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkwingsmt dkwingsmt dkwingsmt approved these changes

@QuncCccccc QuncCccccc QuncCccccc approved these changes

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. will affect goldens Changes to golden files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Material AppBar fill on scroll should be animated

3 participants

@rkishan516 @dkwingsmt @QuncCccccc