Skip to content

Fix and test an edge case in findPackageConfigFile. #163902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Feb 25, 2025
Merged

Fix and test an edge case in findPackageConfigFile. #163902

auto-submit merged 3 commits into from
Feb 25, 2025

Conversation

@matanlurey
Copy link
Contributor

@matanlurey matanlurey commented Feb 22, 2025

Closes #163901.

I'm not aware of a case where this causes user crashes, but it could, and seems easy to fix/test.

@matanlurey matanlurey requested a review from sigurdm February 22, 2025 00:29
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 22, 2025
sigurdm
sigurdm reviewed Feb 24, 2025
View reviewed changes
@matanlurey matanlurey requested a review from sigurdm February 24, 2025 18:29
@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 25, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 25, 2025
Merged via the queue into flutter:master with commit 5a8f23c Feb 25, 2025
140 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 25, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
5a8f23c Fix and test an edge case in findPackageConfigFile. (flutte…
58bff79 
…r/flutter#163902)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
5a8f23c Fix and test an edge case in findPackageConfigFile. (flutte…
6d8131e 
…r/flutter#163902)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
5a8f23c Fix and test an edge case in findPackageConfigFile. (flutte…
01b2ae6 
…r/flutter#163902)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
5a8f23c Fix and test an edge case in findPackageConfigFile. (flutte…
207e212 
…r/flutter#163902)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
5a8f23c Fix and test an edge case in findPackageConfigFile. (flutte…
e4a8531 
…r/flutter#163902)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
5a8f23c Fix and test an edge case in findPackageConfigFile. (flutte…
b0deec4 
…r/flutter#163902)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
5a8f23c Fix and test an edge case in findPackageConfigFile. (flutte…
8ef66ab 
…r/flutter#163902)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
5a8f23c Fix and test an edge case in findPackageConfigFile. (flutte…
63d7746 
…r/flutter#163902)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
5a8f23c Fix and test an edge case in findPackageConfigFile. (flutte…
a4d4322 
…r/flutter#163902)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
5a8f23c Fix and test an edge case in findPackageConfigFile. (flutte…
e04f99b 
…r/flutter#163902)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
5a8f23c Fix and test an edge case in findPackageConfigFile. (flutte…
4f049fc 
…r/flutter#163902)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
5a8f23c Fix and test an edge case in findPackageConfigFile. (flutte…
480ba95 
…r/flutter#163902)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2025
@engine-flutter-autoroll
5a8f23c Fix and test an edge case in findPackageConfigFile. (flutte…
3baa0c1 
…r/flutter#163902)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2025
@engine-flutter-autoroll
5a8f23c Fix and test an edge case in findPackageConfigFile. (flutte…
a39111d 
…r/flutter#163902)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
5a8f23c Fix and test an edge case in findPackageConfigFile. (flutte…
7b42036 
…r/flutter#163902)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
5a8f23c Fix and test an edge case in findPackageConfigFile. (flutte…
07b69f6 
…r/flutter#163902)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
5a8f23c Fix and test an edge case in findPackageConfigFile. (flutte…
a7df327 
…r/flutter#163902)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sigurdm sigurdm sigurdm approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

findPackageConfigFile crashes when given a missing or deleted Directory

2 participants

@matanlurey @sigurdm