Adds aria-controls support #163894

chunhtai · 2025-02-21T21:57:53Z

adding a new property in semantics properties called controlsVisibilityOfNodes, where developer can assign SemanticsProperties.identifier of other nodes to indicates which nodes' visibilities this node controls

fixes #162125

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2025-02-21T21:57:56Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

chunhtai · 2025-02-21T21:59:40Z

test will be added after we agree this is the approach we want to take

engine/src/flutter/lib/ui/semantics.dart

engine/src/flutter/lib/web_ui/lib/src/engine/semantics/semantics.dart

packages/flutter/lib/src/semantics/semantics.dart

packages/flutter/test/widgets/basic_test.dart

engine/src/flutter/lib/web_ui/lib/src/engine/semantics/semantics.dart

mdebbar

LGTM after addressing Yegor's questions/comments.

engine/src/flutter/lib/web_ui/lib/src/engine/semantics/semantics.dart

yjbanov · 2025-03-06T00:36:22Z

engine/src/flutter/lib/web_ui/lib/src/engine/semantics/semantics.dart

+  void _updateControls() {
+    if (semanticsObject.hasControlsNodes) {
+      semanticsObject.owner.addOneTimePostUpdateCallback(() {
+        final List<String> elementIds = <String>[];


Here and elsewhere, feel free to omit local variable types, such as final elementIds = <String>[] is just fine, especially in new code.

yjbanov · 2025-03-06T00:38:55Z

engine/src/flutter/lib/web_ui/lib/src/engine/util.dart

+    return false;
+  }
+  // They most both be non-null now.
+  if (a!.length != b!.length) {


Are null and empty list not equivalent?

will update

yjbanov · 2025-03-06T00:41:45Z

packages/flutter/test/widgets/basic_test.dart

+              key: key,
+              controlsNodes: const <String>{'abc', 'ghi'},
+              child: Semantics(
+                controlsNodes: const <String>{'abc', 'def'},


Now that I think about it, merging nodes that control different things feels wrong 🤔

I think they are fine, developer can compose controlsNodes. They may have different widget that provides different control information while another provide tap action

auto-submit · 2025-03-06T19:24:25Z

autosubmit label was removed for flutter/flutter/163894, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2025-03-06T20:10:08Z

autosubmit label was removed for flutter/flutter/163894, because - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

flutter/flutter@321fbc0...6b93cf9 2025-03-07 [email protected] Roll Skia from 32c1931117b8 to cbc7e99d6c2f (1 revision) (flutter/flutter#164788) 2025-03-07 [email protected] Roll Packages from fc9d5ca to 4c5a7ed (4 revisions) (flutter/flutter#164785) 2025-03-07 [email protected] Roll Skia from 79f8af105a61 to 32c1931117b8 (1 revision) (flutter/flutter#164782) 2025-03-07 [email protected] Roll Fuchsia Linux SDK from fhm5z889sA5T1AQao... to ixl5bKWCqsRiYGvps... (flutter/flutter#164780) 2025-03-07 [email protected] Roll Skia from 181d81920670 to 79f8af105a61 (1 revision) (flutter/flutter#164770) 2025-03-07 [email protected] Roll Skia from cc74d34e7e68 to 181d81920670 (1 revision) (flutter/flutter#164766) 2025-03-07 [email protected] Clip layers reduce rrects and paths to simpler shapes when possible (flutter/flutter#164693) 2025-03-07 [email protected] [Impeller] test empty snapshot and allocation failure. (flutter/flutter#164668) 2025-03-07 [email protected] Roll Skia from 263308ea4386 to cc74d34e7e68 (2 revisions) (flutter/flutter#164746) 2025-03-06 [email protected] Adds aria-controls support (flutter/flutter#163894) 2025-03-06 [email protected] Migrate Mutators to DisplayList/Impeller geometry (flutter/flutter#164258) 2025-03-06 [email protected] Add lldb init file (flutter/flutter#164344) 2025-03-06 [email protected] Use separate artifacts for arm64 and x64 versions of gen_snapshot on Apple platforms (flutter/flutter#164419) 2025-03-06 [email protected] Roll Skia from ccd8cc23aa94 to 263308ea4386 (1 revision) (flutter/flutter#164728) 2025-03-06 [email protected] [hcpp] Add tests for transform mutator (flutter/flutter#164664) 2025-03-06 [email protected] Roll pub packages (flutter/flutter#164721) 2025-03-06 [email protected] Roll Packages from abba683 to fc9d5ca (3 revisions) (flutter/flutter#164714) 2025-03-06 [email protected] Roll pub packages (flutter/flutter#164713) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) platform-web Web applications specifically labels Feb 21, 2025

chunhtai marked this pull request as draft February 21, 2025 21:58

chunhtai requested review from goderbauer and yjbanov February 21, 2025 21:59

chunhtai requested a review from mdebbar February 25, 2025 22:14

chunhtai force-pushed the issues/162125 branch from edef935 to 48aa9ba Compare March 3, 2025 18:05

yjbanov reviewed Mar 3, 2025

View reviewed changes

chunhtai force-pushed the issues/162125 branch from 48aa9ba to 8e73087 Compare March 4, 2025 21:03

mdebbar approved these changes Mar 4, 2025

View reviewed changes

engine/src/flutter/lib/web_ui/lib/src/engine/semantics/semantics.dart Outdated Show resolved Hide resolved

chunhtai marked this pull request as ready for review March 4, 2025 23:27

chunhtai requested a review from yjbanov March 4, 2025 23:28

github-actions bot added the a: tests "flutter test", flutter_test, or one of our tests label Mar 5, 2025

yjbanov approved these changes Mar 6, 2025

View reviewed changes

chunhtai added 12 commits March 6, 2025 10:30

Adds aria-controls support

d6dd3f0

update

2296139

update

33028fe

update

24534a9

Update

6988d1c

more test

99a6342

update

2a846d0

update

c5d89b8

update

7fe352e

update

b1f49c9

update

d5c817b

update

e86b143

chunhtai force-pushed the issues/162125 branch from 437ffde to e86b143 Compare March 6, 2025 18:32

chunhtai added 2 commits March 6, 2025 11:18

update

c9e51cc

omit type

044f865

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2025

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2025

update

30506d8

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2025

auto-submit bot added this pull request to the merge queue Mar 6, 2025

Merged via the queue into flutter:master with commit e0b9869 Mar 6, 2025
178 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025

e0b9869 Adds aria-controls support (flutter/flutter#163894)

d8f85f1

engine-flutter-autoroll mentioned this pull request Mar 7, 2025

Roll Flutter from 321fbc0e7e81 to e190868b71de (15 revisions) flutter/packages#8812

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025

e0b9869 Adds aria-controls support (flutter/flutter#163894)

0ccdb8e

engine-flutter-autoroll mentioned this pull request Mar 7, 2025

Roll Flutter from 321fbc0e7e81 to d9f48174fca6 (16 revisions) flutter/packages#8815

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025

e0b9869 Adds aria-controls support (flutter/flutter#163894)

5a6d4d8

engine-flutter-autoroll mentioned this pull request Mar 7, 2025

Roll Flutter from 321fbc0e7e81 to 1b14b0c11a5b (17 revisions) flutter/packages#8816

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025

e0b9869 Adds aria-controls support (flutter/flutter#163894)

400fd16

engine-flutter-autoroll mentioned this pull request Mar 7, 2025

Roll Flutter from 321fbc0e7e81 to 6b93cf93c100 (18 revisions) flutter/packages#8817

Merged

Piinks mentioned this pull request Mar 7, 2025

Flutter Notable Commits - 2025 #161460

Open

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

e0b9869 Adds aria-controls support (flutter/flutter#163894)

faaf824

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

e0b9869 Adds aria-controls support (flutter/flutter#163894)

d40e0b1

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

e0b9869 Adds aria-controls support (flutter/flutter#163894)

993eaf3

Adds aria-controls support #163894

Adds aria-controls support #163894

Uh oh!

Conversation

chunhtai commented Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Feb 21, 2025

Uh oh!

chunhtai commented Feb 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mdebbar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yjbanov Mar 6, 2025

Choose a reason for hiding this comment

Uh oh!

yjbanov Mar 6, 2025

Choose a reason for hiding this comment

Uh oh!

chunhtai Mar 6, 2025

Choose a reason for hiding this comment

Uh oh!

yjbanov Mar 6, 2025

Choose a reason for hiding this comment

Uh oh!

chunhtai Mar 6, 2025

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Mar 6, 2025

Uh oh!

auto-submit bot commented Mar 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chunhtai commented Feb 21, 2025 •

edited

Loading