Skip to content

Add a buildtools directory and move third_party/ninja to the project root in order to match the expectations of depot_tools #163890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Feb 26, 2025
Merged

Add a buildtools directory and move third_party/ninja to the project root in order to match the expectations of depot_tools #163890

auto-submit merged 3 commits into from
Feb 26, 2025

Conversation

@jason-simmons
Copy link
Member

@jason-simmons jason-simmons commented Feb 21, 2025

The depot_tools Ninja wrapper looks for Ninja at specific paths within the tree. The use of "name": "." in the engine's .gclient file is not expected by the depot_tools logic for locating the engine's source directory.

This PR creates an alternative layout that is supported by depot_tools. If the project root directory contains a "buildtools" subdirectory, then depot_tools will look for Ninja at "third_party/ninja" within the root.

Fixes #163487

@flutter-dashboard
Copy link

flutter-dashboard bot commented Feb 21, 2025

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Feb 21, 2025
@jason-simmons jason-simmons force-pushed the bug_163487 branch 2 times, most recently from b8f24d3 to 398a70f Compare February 25, 2025 18:38
@jason-simmons
Add a buildtools directory and move third_party/ninja to the project …
1819938 
…root in order to match the expectations of depot_tools

The depot_tools Ninja wrapper looks for Ninja at specific paths within the tree.  The use of "name": "." in the engine's .gclient file is not expected by the depot_tools logic for locating the engine's source directory.

This PR creates an alternative layout that is supported by depot_tools.  If the project root directory contains a "buildtools" subdirectory, then depot_tools will look for Ninja at "third_party/ninja" within the root.

Fixes flutter#163487
@jason-simmons
analyzer
d3416b6
@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 26, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 26, 2025
Merged via the queue into flutter:master with commit 3d018b5 Feb 26, 2025
177 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 26, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
3d018b5 Add a buildtools directory and move third_party/ninja to the …
91c478f 
…project root in order to match the expectations of depot_tools (flutter/flutter#163890)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
3d018b5 Add a buildtools directory and move third_party/ninja to the …
54e3d87 
…project root in order to match the expectations of depot_tools (flutter/flutter#163890)
@bdero
Copy link
Member

bdero commented Feb 26, 2025

et is broken for me after gclient sync -D on this patch because it's looking for ninja in the old directory.

❯ et build -c host_debug_unopt_arm64 --verbose --no-lto
[2025-02-26T08:55:40.834][macos/host_debug_unopt_arm64: GN]: STARTING: /Users/bdero/projects/flutter/flutter/engine/src/flutter/tools/gn --runtime-mode debug --unopt --mac-cpu arm64 --xcode-symlinks --rbe --no-goma --no-lto
[2025-02-26T08:55:41.372][macos/host_debug_unopt_arm64: GN]: OK
[2025-02-26T08:55:41.550][macos/host_debug_unopt_arm64: RBE startup]: STARTING: /Users/bdero/projects/flutter/flutter/engine/src/flutter/buildtools/mac-arm64/reclient/bootstrap --re_proxy=/Users/bdero/projects/flutter/flutter/engine/src/flutter/buildtools/mac-arm64/reclient/reproxy --use_application_default_credentials --cfg=/Users/bdero/projects/flutter/flutter/engine/src/flutter/build/rbe/reclient-mac.cfg
[2025-02-26T08:55:42.602][macos/host_debug_unopt_arm64: RBE startup]: Proxy started successfully.
[2025-02-26T08:55:42.602][macos/host_debug_unopt_arm64: ninja]: STARTING: /Users/bdero/projects/flutter/flutter/engine/src/flutter/third_party/ninja/ninja -C /Users/bdero/projects/flutter/flutter/engine/src/out/host_debug_unopt_arm64 -j 800 --verbose
[2025-02-26T08:55:42.603][macos/host_debug_unopt_arm64: RBE shutdown]: STARTING: /Users/bdero/projects/flutter/flutter/engine/src/flutter/buildtools/mac-arm64/reclient/bootstrap --re_proxy=/Users/bdero/projects/flutter/flutter/engine/src/flutter/buildtools/mac-arm64/reclient/reproxy --use_application_default_credentials --shutdown
[2025-02-26T08:55:42.895][macos/host_debug_unopt_arm64: RBE shutdown]: Actions completed: 0
Unhandled exception:
ProcessException: Failed to find "/Users/bdero/projects/flutter/flutter/engine/src/flutter/third_party/ninja/ninja" in the search path.
  Command: /Users/bdero/projects/flutter/flutter/engine/src/flutter/third_party/ninja/ninja
#0      LocalProcessManager.start (package:process/src/interface/local_process_manager.dart:58:7)
#1      BuildRunner._runNinja (package:engine_build_configs/src/build_config_runner.dart:615:71)
<asynchronous suspension>
#2      BuildRunner.run (package:engine_build_configs/src/build_config_runner.dart:340:12)
<asynchronous suspension>
#3      runBuild (package:engine_tool/src/build_utils.dart:138:28)
<asynchronous suspension>
#4      CommandRunner.runCommand (package:args/command_runner.dart:212:13)
<asynchronous suspension>
#5      ToolCommandRunner.run (package:engine_tool/src/commands/command_runner.dart:76:14)
<asynchronous suspension>
#6      main (package:engine_tool/main.dart:79:19)
<asynchronous suspension>

@bdero
Copy link
Member

bdero commented Feb 26, 2025

My unblocking workaround was a symlink 😅

ln -s /Users/bdero/projects/flutter/flutter/third_party/ninja /Users/bdero/projects/flutter/flutter/engine/src/flutter/third_party/ninja

@jason-simmons
Copy link
Member Author

jason-simmons commented Feb 26, 2025

Will revert and reland with an update to the engine tools packages

@jason-simmons jason-simmons added the revert Autorevert PR (with "Reason for revert:" comment) label Feb 26, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Feb 26, 2025

A reason for requesting a revert of flutter/flutter/163890 could
not be found or the reason was not properly formatted. Begin a comment with 'Reason for revert:' to tell the bot why
this issue is being reverted.

@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Feb 26, 2025
@jason-simmons
Copy link
Member Author

jason-simmons commented Feb 26, 2025

Reason for revert: et and related packages in https://github.com/flutter/flutter/tree/master/engine/src/flutter/tools need to be updated for the new Ninja path

@jason-simmons jason-simmons added the revert Autorevert PR (with "Reason for revert:" comment) label Feb 26, 2025
auto-submit bot pushed a commit that referenced this pull request Feb 26, 2025
Revert "Add a buildtools directory and move third_party/ninja to the …
4320d8a 
…project root in order to match the expectations of depot_tools (#163890)"

This reverts commit 3d018b5.
@auto-submit auto-submit bot mentioned this pull request Feb 26, 2025
Merged
@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Feb 26, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
3d018b5 Add a buildtools directory and move third_party/ninja to the …
2358d35 
…project root in order to match the expectations of depot_tools (flutter/flutter#163890)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
3d018b5 Add a buildtools directory and move third_party/ninja to the …
a7ea086 
…project root in order to match the expectations of depot_tools (flutter/flutter#163890)
github-merge-queue bot pushed a commit that referenced this pull request Feb 26, 2025
@auto-submit
Reverts "Add a buildtools directory and move third_party/ninja to the…
52876a0 
… project root in order to match the expectations of depot_tools (#163890)" (#164209)

<!-- start_original_pr_link -->
Reverts: #163890
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jason-simmons
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: et and related packages in
https://github.com/flutter/flutter/tree/master/engine/src/flutter/tools
need to be updated for the new Ninja path
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: jason-simmons
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {matanlurey, jtmcdole}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
The depot_tools Ninja wrapper looks for Ninja at specific paths within
the tree. The use of "name": "." in the engine's .gclient file is not
expected by the depot_tools logic for locating the engine's source
directory.

This PR creates an alternative layout that is supported by depot_tools.
If the project root directory contains a "buildtools" subdirectory, then
depot_tools will look for Ninja at "third_party/ninja" within the root.

Fixes #163487
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
3d018b5 Add a buildtools directory and move third_party/ninja to the …
adf7b83 
…project root in order to match the expectations of depot_tools (flutter/flutter#163890)
jason-simmons added a commit to jason-simmons/flutter that referenced this pull request Feb 26, 2025
@jason-simmons
Reland "Add a buildtools directory and move third_party/ninja to the …
737defc 
…project root in order to match the expectations of depot_tools"

Relands flutter#163890 and updates the Ninja path used by the engine tool
@jason-simmons jason-simmons mentioned this pull request Feb 26, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Feb 27, 2025
@jason-simmons
Reland "Add a buildtools directory and move third_party/ninja to the …
1d25f69 
…project root in order to match the expectations of depot_tools" (#164240)

Relands #163890 and updates the
Ninja path used by the engine tool
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2025
@engine-flutter-autoroll
3d018b5 Add a buildtools directory and move third_party/ninja to the …
bd0c657 
…project root in order to match the expectations of depot_tools (flutter/flutter#163890)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Feb 27, 2025
@engine-flutter-autoroll
Roll Flutter from 1659206 to 2e570ca (75 revisions) (#8731)
9744c9d 
Roll Flutter from 1659206 to 2e570ca (75 revisions)

flutter/flutter@1659206...2e570ca

2025-02-27 [email protected] Roll Skia from ac08df9c8d82 to e5a33102401c (1 revision) (flutter/flutter#164288)
2025-02-27 [email protected] Roll Skia from 6018dff0233a to ac08df9c8d82 (1 revision) (flutter/flutter#164275)
2025-02-27 [email protected] Roll Dart SDK from 4a218fbffc80 to fcda71ce147b (1 revision) (flutter/flutter#164276)
2025-02-27 [email protected] Roll Skia from 0f2e106c9abc to 6018dff0233a (1 revision) (flutter/flutter#164266)
2025-02-27 [email protected] Add windowing channel support to Linux embedder (flutter/flutter#163180)
2025-02-27 [email protected] Roll Dart SDK from 7fa5901bd8a3 to 4a218fbffc80 (2 revisions) (flutter/flutter#164260)
2025-02-27 [email protected] Roll Skia from fdd97386193e to 0f2e106c9abc (4 revisions) (flutter/flutter#164259)
2025-02-27 [email protected] Run more builds faster (flutter/flutter#164125)
2025-02-27 [email protected] Increase customer test timeout to 60 minutes (flutter/flutter#164239)
2025-02-27 [email protected] Reland "Add a buildtools directory and move third_party/ninja to the project root in order to match the expectations of depot_tools" (flutter/flutter#164240)
2025-02-27 [email protected] Use the Dart isolate ownership API on the root isolate (flutter/flutter#163703)
2025-02-26 [email protected] Roll Fuchsia Linux SDK from g-2SJtblPjjaH7Egy... to 1elkOxihZuTEiTXzY... (flutter/flutter#164243)
2025-02-26 [email protected] Show Linux driver information in flutter doctor (flutter/flutter#163980)
2025-02-26 [email protected] Implement opacity `FlutterMutator` for hcpp (flutter/flutter#164147)
2025-02-26 [email protected] Roll Fuchsia Linux SDK from g-2SJtblPjjaH7Egy... to 1elkOxihZuTEiTXzY... (flutter/flutter#164232)
2025-02-26 [email protected] Roll Skia from 47b84f354604 to fdd97386193e (8 revisions) (flutter/flutter#164221)
2025-02-26 [email protected] [Impeller] Reland: move AHB check into Flutter main, don't disable ImageReader on 29. (flutter/flutter#164201)
2025-02-26 [email protected] Roll Dart SDK from 80865748abe0 to 7fa5901bd8a3 (3 revisions) (flutter/flutter#164226)
2025-02-26 [email protected] Update fuchsia_test_scripts_version to the latest version (flutter/flutter#164123)
2025-02-26 [email protected] Guard against zero item extent for carousel (flutter/flutter#163310)
2025-02-26 [email protected] [Impeller] work around for crashy Nexus 5 Driver. (flutter/flutter#164040)
2025-02-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add a buildtools directory and move third_party/ninja to the project root in order to match the expectations of depot_tools (#163890)" (flutter/flutter#164209)
2025-02-26 [email protected] Add localization for `Back` and `Cancel` buttons in CupertinoNavigationBar (flutter/flutter#162581)
2025-02-26 [email protected] Added compilation failure if a max ubo size is exceeded (flutter/flutter#164038)
2025-02-26 [email protected] Roll Skia from 5336e20498d9 to 47b84f354604 (2 revisions) (flutter/flutter#164188)
2025-02-26 [email protected] Add a buildtools directory and move third_party/ninja to the project root in order to match the expectations of depot_tools (flutter/flutter#163890)
2025-02-26 [email protected] Roll Skia from 3ce6f25dc13e to 5336e20498d9 (9 revisions) (flutter/flutter#164174)
2025-02-26 [email protected] Roll Dart SDK from b8292dfeaa67 to 80865748abe0 (9 revisions) (flutter/flutter#164168)
2025-02-26 [email protected] [Engine] Remove dead code for RoundedSuperellipse (flutter/flutter#164163)
2025-02-26 [email protected] [Impeller] detect mediatek soc and fall back to GLES. (flutter/flutter#164126)
2025-02-26 [email protected] [Impeller] make DLOG into LOG for startup errors. (flutter/flutter#164110)
2025-02-26 [email protected] Intercept error when iOS 18.4 crashes with JIT mode and give guided error (flutter/flutter#164072)
2025-02-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] move AHB check to Vulkan, use Vulkan surface on 29. (#164109)" (flutter/flutter#164166)
2025-02-26 [email protected] Run new gallery transition perf benchmark on Galaxy S24 (flutter/flutter#163665)
2025-02-26 [email protected] [Impeller] move AHB check to Vulkan, use Vulkan surface on 29. (flutter/flutter#164109)
2025-02-26 [email protected] [iOS] Add platform view to integration_test example (flutter/flutter#164144)
2025-02-26 [email protected] Fix minor issues in documentation of WidgetsApp (flutter/flutter#163942)
2025-02-26 [email protected] Fix extra numbers showing up when enabling VoiceControl (flutter/flutter#163593)
2025-02-26 [email protected] Set SliverResizingHeader's maxScrollObstructionExtent to minExtent (flutter/flutter#162955)
2025-02-26 [email protected] Roll Dart SDK from aea6fff33f06 to b8292dfeaa67 (1 revision) (flutter/flutter#163973)
2025-02-26 [email protected] [DisplayList] Delete all legacy Skia-oriented method overloads in DlCanvas (flutter/flutter#164054)
2025-02-25 [email protected] Clean up leak tracker instrumentation tech debt. (flutter/flutter#164070)
2025-02-25 [email protected] Revert "Marks Linux_pixel_7pro service_extensions_test to be flaky" (flutter/flutter#163882)
2025-02-25 [email protected] Check if simctl is installed before trying to list devices or runtimes (flutter/flutter#163895)
2025-02-25 [email protected] Update dragDevices doc to include default PointerDeviceKind.trackpad (flutter/flutter#163898)
2025-02-25 [email protected] Update multiple flutters benchmark test to latest gradle and agp and gradle defined dependencies  (flutter/flutter#164029)
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
3d018b5 Add a buildtools directory and move third_party/ninja to the …
6013862 
…project root in order to match the expectations of depot_tools (flutter/flutter#163890)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
3d018b5 Add a buildtools directory and move third_party/ninja to the …
ffa46e9 
…project root in order to match the expectations of depot_tools (flutter/flutter#163890)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
3d018b5 Add a buildtools directory and move third_party/ninja to the …
3fa8cf3 
…project root in order to match the expectations of depot_tools (flutter/flutter#163890)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Roll Flutter from 1659206 to 2e570ca (75 revisions) (flutter#8731)
a592d50 
Roll Flutter from 1659206 to 2e570ca (75 revisions)

flutter/flutter@1659206...2e570ca

2025-02-27 [email protected] Roll Skia from ac08df9c8d82 to e5a33102401c (1 revision) (flutter/flutter#164288)
2025-02-27 [email protected] Roll Skia from 6018dff0233a to ac08df9c8d82 (1 revision) (flutter/flutter#164275)
2025-02-27 [email protected] Roll Dart SDK from 4a218fbffc80 to fcda71ce147b (1 revision) (flutter/flutter#164276)
2025-02-27 [email protected] Roll Skia from 0f2e106c9abc to 6018dff0233a (1 revision) (flutter/flutter#164266)
2025-02-27 [email protected] Add windowing channel support to Linux embedder (flutter/flutter#163180)
2025-02-27 [email protected] Roll Dart SDK from 7fa5901bd8a3 to 4a218fbffc80 (2 revisions) (flutter/flutter#164260)
2025-02-27 [email protected] Roll Skia from fdd97386193e to 0f2e106c9abc (4 revisions) (flutter/flutter#164259)
2025-02-27 [email protected] Run more builds faster (flutter/flutter#164125)
2025-02-27 [email protected] Increase customer test timeout to 60 minutes (flutter/flutter#164239)
2025-02-27 [email protected] Reland "Add a buildtools directory and move third_party/ninja to the project root in order to match the expectations of depot_tools" (flutter/flutter#164240)
2025-02-27 [email protected] Use the Dart isolate ownership API on the root isolate (flutter/flutter#163703)
2025-02-26 [email protected] Roll Fuchsia Linux SDK from g-2SJtblPjjaH7Egy... to 1elkOxihZuTEiTXzY... (flutter/flutter#164243)
2025-02-26 [email protected] Show Linux driver information in flutter doctor (flutter/flutter#163980)
2025-02-26 [email protected] Implement opacity `FlutterMutator` for hcpp (flutter/flutter#164147)
2025-02-26 [email protected] Roll Fuchsia Linux SDK from g-2SJtblPjjaH7Egy... to 1elkOxihZuTEiTXzY... (flutter/flutter#164232)
2025-02-26 [email protected] Roll Skia from 47b84f354604 to fdd97386193e (8 revisions) (flutter/flutter#164221)
2025-02-26 [email protected] [Impeller] Reland: move AHB check into Flutter main, don't disable ImageReader on 29. (flutter/flutter#164201)
2025-02-26 [email protected] Roll Dart SDK from 80865748abe0 to 7fa5901bd8a3 (3 revisions) (flutter/flutter#164226)
2025-02-26 [email protected] Update fuchsia_test_scripts_version to the latest version (flutter/flutter#164123)
2025-02-26 [email protected] Guard against zero item extent for carousel (flutter/flutter#163310)
2025-02-26 [email protected] [Impeller] work around for crashy Nexus 5 Driver. (flutter/flutter#164040)
2025-02-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add a buildtools directory and move third_party/ninja to the project root in order to match the expectations of depot_tools (#163890)" (flutter/flutter#164209)
2025-02-26 [email protected] Add localization for `Back` and `Cancel` buttons in CupertinoNavigationBar (flutter/flutter#162581)
2025-02-26 [email protected] Added compilation failure if a max ubo size is exceeded (flutter/flutter#164038)
2025-02-26 [email protected] Roll Skia from 5336e20498d9 to 47b84f354604 (2 revisions) (flutter/flutter#164188)
2025-02-26 [email protected] Add a buildtools directory and move third_party/ninja to the project root in order to match the expectations of depot_tools (flutter/flutter#163890)
2025-02-26 [email protected] Roll Skia from 3ce6f25dc13e to 5336e20498d9 (9 revisions) (flutter/flutter#164174)
2025-02-26 [email protected] Roll Dart SDK from b8292dfeaa67 to 80865748abe0 (9 revisions) (flutter/flutter#164168)
2025-02-26 [email protected] [Engine] Remove dead code for RoundedSuperellipse (flutter/flutter#164163)
2025-02-26 [email protected] [Impeller] detect mediatek soc and fall back to GLES. (flutter/flutter#164126)
2025-02-26 [email protected] [Impeller] make DLOG into LOG for startup errors. (flutter/flutter#164110)
2025-02-26 [email protected] Intercept error when iOS 18.4 crashes with JIT mode and give guided error (flutter/flutter#164072)
2025-02-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] move AHB check to Vulkan, use Vulkan surface on 29. (#164109)" (flutter/flutter#164166)
2025-02-26 [email protected] Run new gallery transition perf benchmark on Galaxy S24 (flutter/flutter#163665)
2025-02-26 [email protected] [Impeller] move AHB check to Vulkan, use Vulkan surface on 29. (flutter/flutter#164109)
2025-02-26 [email protected] [iOS] Add platform view to integration_test example (flutter/flutter#164144)
2025-02-26 [email protected] Fix minor issues in documentation of WidgetsApp (flutter/flutter#163942)
2025-02-26 [email protected] Fix extra numbers showing up when enabling VoiceControl (flutter/flutter#163593)
2025-02-26 [email protected] Set SliverResizingHeader's maxScrollObstructionExtent to minExtent (flutter/flutter#162955)
2025-02-26 [email protected] Roll Dart SDK from aea6fff33f06 to b8292dfeaa67 (1 revision) (flutter/flutter#163973)
2025-02-26 [email protected] [DisplayList] Delete all legacy Skia-oriented method overloads in DlCanvas (flutter/flutter#164054)
2025-02-25 [email protected] Clean up leak tracker instrumentation tech debt. (flutter/flutter#164070)
2025-02-25 [email protected] Revert "Marks Linux_pixel_7pro service_extensions_test to be flaky" (flutter/flutter#163882)
2025-02-25 [email protected] Check if simctl is installed before trying to list devices or runtimes (flutter/flutter#163895)
2025-02-25 [email protected] Update dragDevices doc to include default PointerDeviceKind.trackpad (flutter/flutter#163898)
2025-02-25 [email protected] Update multiple flutters benchmark test to latest gradle and agp and gradle defined dependencies  (flutter/flutter#164029)
...
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Roll Flutter from 1659206 to 2e570ca (75 revisions) (flutter#8731)
2bf47e4 
Roll Flutter from 1659206 to 2e570ca (75 revisions)

flutter/flutter@1659206...2e570ca

2025-02-27 [email protected] Roll Skia from ac08df9c8d82 to e5a33102401c (1 revision) (flutter/flutter#164288)
2025-02-27 [email protected] Roll Skia from 6018dff0233a to ac08df9c8d82 (1 revision) (flutter/flutter#164275)
2025-02-27 [email protected] Roll Dart SDK from 4a218fbffc80 to fcda71ce147b (1 revision) (flutter/flutter#164276)
2025-02-27 [email protected] Roll Skia from 0f2e106c9abc to 6018dff0233a (1 revision) (flutter/flutter#164266)
2025-02-27 [email protected] Add windowing channel support to Linux embedder (flutter/flutter#163180)
2025-02-27 [email protected] Roll Dart SDK from 7fa5901bd8a3 to 4a218fbffc80 (2 revisions) (flutter/flutter#164260)
2025-02-27 [email protected] Roll Skia from fdd97386193e to 0f2e106c9abc (4 revisions) (flutter/flutter#164259)
2025-02-27 [email protected] Run more builds faster (flutter/flutter#164125)
2025-02-27 [email protected] Increase customer test timeout to 60 minutes (flutter/flutter#164239)
2025-02-27 [email protected] Reland "Add a buildtools directory and move third_party/ninja to the project root in order to match the expectations of depot_tools" (flutter/flutter#164240)
2025-02-27 [email protected] Use the Dart isolate ownership API on the root isolate (flutter/flutter#163703)
2025-02-26 [email protected] Roll Fuchsia Linux SDK from g-2SJtblPjjaH7Egy... to 1elkOxihZuTEiTXzY... (flutter/flutter#164243)
2025-02-26 [email protected] Show Linux driver information in flutter doctor (flutter/flutter#163980)
2025-02-26 [email protected] Implement opacity `FlutterMutator` for hcpp (flutter/flutter#164147)
2025-02-26 [email protected] Roll Fuchsia Linux SDK from g-2SJtblPjjaH7Egy... to 1elkOxihZuTEiTXzY... (flutter/flutter#164232)
2025-02-26 [email protected] Roll Skia from 47b84f354604 to fdd97386193e (8 revisions) (flutter/flutter#164221)
2025-02-26 [email protected] [Impeller] Reland: move AHB check into Flutter main, don't disable ImageReader on 29. (flutter/flutter#164201)
2025-02-26 [email protected] Roll Dart SDK from 80865748abe0 to 7fa5901bd8a3 (3 revisions) (flutter/flutter#164226)
2025-02-26 [email protected] Update fuchsia_test_scripts_version to the latest version (flutter/flutter#164123)
2025-02-26 [email protected] Guard against zero item extent for carousel (flutter/flutter#163310)
2025-02-26 [email protected] [Impeller] work around for crashy Nexus 5 Driver. (flutter/flutter#164040)
2025-02-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add a buildtools directory and move third_party/ninja to the project root in order to match the expectations of depot_tools (#163890)" (flutter/flutter#164209)
2025-02-26 [email protected] Add localization for `Back` and `Cancel` buttons in CupertinoNavigationBar (flutter/flutter#162581)
2025-02-26 [email protected] Added compilation failure if a max ubo size is exceeded (flutter/flutter#164038)
2025-02-26 [email protected] Roll Skia from 5336e20498d9 to 47b84f354604 (2 revisions) (flutter/flutter#164188)
2025-02-26 [email protected] Add a buildtools directory and move third_party/ninja to the project root in order to match the expectations of depot_tools (flutter/flutter#163890)
2025-02-26 [email protected] Roll Skia from 3ce6f25dc13e to 5336e20498d9 (9 revisions) (flutter/flutter#164174)
2025-02-26 [email protected] Roll Dart SDK from b8292dfeaa67 to 80865748abe0 (9 revisions) (flutter/flutter#164168)
2025-02-26 [email protected] [Engine] Remove dead code for RoundedSuperellipse (flutter/flutter#164163)
2025-02-26 [email protected] [Impeller] detect mediatek soc and fall back to GLES. (flutter/flutter#164126)
2025-02-26 [email protected] [Impeller] make DLOG into LOG for startup errors. (flutter/flutter#164110)
2025-02-26 [email protected] Intercept error when iOS 18.4 crashes with JIT mode and give guided error (flutter/flutter#164072)
2025-02-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] move AHB check to Vulkan, use Vulkan surface on 29. (#164109)" (flutter/flutter#164166)
2025-02-26 [email protected] Run new gallery transition perf benchmark on Galaxy S24 (flutter/flutter#163665)
2025-02-26 [email protected] [Impeller] move AHB check to Vulkan, use Vulkan surface on 29. (flutter/flutter#164109)
2025-02-26 [email protected] [iOS] Add platform view to integration_test example (flutter/flutter#164144)
2025-02-26 [email protected] Fix minor issues in documentation of WidgetsApp (flutter/flutter#163942)
2025-02-26 [email protected] Fix extra numbers showing up when enabling VoiceControl (flutter/flutter#163593)
2025-02-26 [email protected] Set SliverResizingHeader's maxScrollObstructionExtent to minExtent (flutter/flutter#162955)
2025-02-26 [email protected] Roll Dart SDK from aea6fff33f06 to b8292dfeaa67 (1 revision) (flutter/flutter#163973)
2025-02-26 [email protected] [DisplayList] Delete all legacy Skia-oriented method overloads in DlCanvas (flutter/flutter#164054)
2025-02-25 [email protected] Clean up leak tracker instrumentation tech debt. (flutter/flutter#164070)
2025-02-25 [email protected] Revert "Marks Linux_pixel_7pro service_extensions_test to be flaky" (flutter/flutter#163882)
2025-02-25 [email protected] Check if simctl is installed before trying to list devices or runtimes (flutter/flutter#163895)
2025-02-25 [email protected] Update dragDevices doc to include default PointerDeviceKind.trackpad (flutter/flutter#163898)
2025-02-25 [email protected] Update multiple flutters benchmark test to latest gradle and agp and gradle defined dependencies  (flutter/flutter#164029)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matanlurey matanlurey matanlurey approved these changes

@jtmcdole jtmcdole jtmcdole approved these changes

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ninja not working to compile engine

4 participants

@jason-simmons @bdero @matanlurey @jtmcdole