pure_android_host_apps/android_host_app_v2_embedding multiple gradle and AGP versions #163849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…folder for assets
reidbaker
changed the title
9 tasks
reidbaker
force-pushed
the
i149836-api-35-update-part-4
branch
from
36f87df to
aa0faec
Compare
9 tasks
gmackall
reviewed
Feb 25, 2025
dev/devicelab/bin/tasks/build_android_host_app_with_module_aar.dart
Outdated
Show resolved
Hide resolved
gmackall
approved these changes
Feb 25, 2025
| section(topBuildContent); | ||
| await topBuildDotGradle.writeAsString(topBuildContent, flush: true); | ||
|
|
||
| final bool greaterThanGradle83 = agpVersion.compareTo(Version(8, 3, 0)) >= 0; |
Member
There was a problem hiding this comment.
nit: greaterThanOrEqualToGradle83, or change to be strictly >
reidbaker
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 25, 2025
…gradle defined dependencies (#164029) part of #149836 After this pr and #163849 are merged `find . -type f -name "build.gradle" | xargs grep -e "targetSdk" | tr -d '=' | tr -s ' ' | grep -v engine/src/flutter/third_party/ | grep -v 35 | grep -v flutter\.targetSdkVersion` will return no results. Marking everything migrated to 35. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 26, 2025
… gradle and AGP versions (flutter/flutter#163849)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 26, 2025
… gradle and AGP versions (flutter/flutter#163849)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 26, 2025
… gradle and AGP versions (flutter/flutter#163849)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 26, 2025
… gradle and AGP versions (flutter/flutter#163849)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 26, 2025
… gradle and AGP versions (flutter/flutter#163849)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 26, 2025
… gradle and AGP versions (flutter/flutter#163849)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 27, 2025
… gradle and AGP versions (flutter/flutter#163849)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 27, 2025
… gradle and AGP versions (flutter/flutter#163849)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
… gradle and AGP versions (flutter/flutter#163849)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
… gradle and AGP versions (flutter/flutter#163849)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 21, 2025
… gradle and AGP versions (flutter/flutter#163849)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #163750
Adds local.properties in any directory to the repo wide gitignore.
Test changes to make the test easier to debug, specifically identifying the difference between a debug and release failure.
Pre-launch Checklist
///).