Update gradle memory properties in example and test projects #163798

jmagman · 2025-02-20T23:49:10Z

Match the example and integration test apps to the the properties in the flutter create template, updated in #156201.

We discussed perhaps making this an auto-migration for existing Flutter apps (if they've never edited the template from the old values), but it probably makes sense for devs to manage this themselves depending on how beefy the machine they are running on is.

Filed #163801 to show a nicer message when the user hits this so they can manage java.lang.OutOfMemoryError: Java heap space errors themselves.

Speculatively hoping this helps with the Java heap space build test flakes #163121 (comment)

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

matanlurey

Makes sense to me! Thanks!

gmackall

Lgtm

I still find it odd that our ci hits this issue so frequently, but developers don't hit it locally (and didn't when our template matched the 4gb we are moving away from here). But regardless, our ci matching our templates makes sense

jmagman · 2025-02-21T21:06:29Z

I still find it odd that our ci hits this issue so frequently, but developers don't hit it locally (and didn't when our template matched the 4gb we are moving away from here).

@gmackall I also don't really understand why ReservedCodeCacheSize was needed.

our ci matching our templates makes sense

This is why I'm not looking into the details of the properties too closely, but we should probably do more due diligence to see if bumping actually makes sense for real Flutter apps when the templates are updated, going forward.

…lutter/flutter#163798)

Manual roll requested by [email protected] flutter/flutter@043b719...1659206 2025-02-24 [email protected] Roll Skia from 3dfb3fee52e1 to 28017200173a (2 revisions) (flutter/flutter#163981) 2025-02-24 [email protected] Add integration test for Gradle-initiated android builds with flavors (flutter/flutter#163737) 2025-02-23 [email protected] Roll Skia from 72f949950adb to 3dfb3fee52e1 (1 revision) (flutter/flutter#163959) 2025-02-23 [email protected] Roll Skia from 4bee660601de to 72f949950adb (1 revision) (flutter/flutter#163948) 2025-02-22 [email protected] Roll Skia from cca9328df6ca to 4bee660601de (1 revision) (flutter/flutter#163927) 2025-02-22 [email protected] Roll Dart SDK from bad289580d9b to aea6fff33f06 (3 revisions) (flutter/flutter#163912) 2025-02-22 [email protected] Roll Skia from 1d884bab8593 to cca9328df6ca (12 revisions) (flutter/flutter#163910) 2025-02-22 [email protected] [fuchsia] include more tests in the fuchsia builders (flutter/flutter#163800) 2025-02-21 [email protected] [Engine] Add RoundSuperellipse to drawing OP (flutter/flutter#160883) 2025-02-21 [email protected] [remake] Restore old back handling for FlutterFragmentActivity (flutter/flutter#161545) 2025-02-21 [email protected] Revert "Marks Mac_benchmark basic_material_app_macos__compile to be flaky" (flutter/flutter#163878) 2025-02-21 [email protected] Revert "Marks Mac_benchmark flutter_view_macos__start_up to be flaky" (flutter/flutter#163880) 2025-02-21 [email protected] Roll Dart SDK from c5e582f15b6c to bad289580d9b (1 revision) (flutter/flutter#163885) 2025-02-21 [email protected] Revert "Marks Windows_mokey native_assets_android to be flaky" (flutter/flutter#163881) 2025-02-21 [email protected] Mark platform_views_hcpp_scroll_perf__timeline_summary out of bringup (flutter/flutter#163883) 2025-02-21 [email protected] Roll Skia from 6da10829d017 to 1d884bab8593 (42 revisions) (flutter/flutter#163789) 2025-02-21 [email protected] Enable `linux_android_emulator_tests` on presubmit. (flutter/flutter#163879) 2025-02-21 [email protected] Update gradle memory properties in example and test projects (flutter/flutter#163798) 2025-02-21 [email protected] Secure paste milestone 2 (flutter/flutter#159013) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter/flutter#163798)

) Manual roll requested by [email protected] flutter/flutter@043b719...1659206 2025-02-24 [email protected] Roll Skia from 3dfb3fee52e1 to 28017200173a (2 revisions) (flutter/flutter#163981) 2025-02-24 [email protected] Add integration test for Gradle-initiated android builds with flavors (flutter/flutter#163737) 2025-02-23 [email protected] Roll Skia from 72f949950adb to 3dfb3fee52e1 (1 revision) (flutter/flutter#163959) 2025-02-23 [email protected] Roll Skia from 4bee660601de to 72f949950adb (1 revision) (flutter/flutter#163948) 2025-02-22 [email protected] Roll Skia from cca9328df6ca to 4bee660601de (1 revision) (flutter/flutter#163927) 2025-02-22 [email protected] Roll Dart SDK from bad289580d9b to aea6fff33f06 (3 revisions) (flutter/flutter#163912) 2025-02-22 [email protected] Roll Skia from 1d884bab8593 to cca9328df6ca (12 revisions) (flutter/flutter#163910) 2025-02-22 [email protected] [fuchsia] include more tests in the fuchsia builders (flutter/flutter#163800) 2025-02-21 [email protected] [Engine] Add RoundSuperellipse to drawing OP (flutter/flutter#160883) 2025-02-21 [email protected] [remake] Restore old back handling for FlutterFragmentActivity (flutter/flutter#161545) 2025-02-21 [email protected] Revert "Marks Mac_benchmark basic_material_app_macos__compile to be flaky" (flutter/flutter#163878) 2025-02-21 [email protected] Revert "Marks Mac_benchmark flutter_view_macos__start_up to be flaky" (flutter/flutter#163880) 2025-02-21 [email protected] Roll Dart SDK from c5e582f15b6c to bad289580d9b (1 revision) (flutter/flutter#163885) 2025-02-21 [email protected] Revert "Marks Windows_mokey native_assets_android to be flaky" (flutter/flutter#163881) 2025-02-21 [email protected] Mark platform_views_hcpp_scroll_perf__timeline_summary out of bringup (flutter/flutter#163883) 2025-02-21 [email protected] Roll Skia from 6da10829d017 to 1d884bab8593 (42 revisions) (flutter/flutter#163789) 2025-02-21 [email protected] Enable `linux_android_emulator_tests` on presubmit. (flutter/flutter#163879) 2025-02-21 [email protected] Update gradle memory properties in example and test projects (flutter/flutter#163798) 2025-02-21 [email protected] Secure paste milestone 2 (flutter/flutter#159013) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Update gradle memory properties in example and test projects

6bf0bce

jmagman requested a review from matanlurey as a code owner February 20, 2025 23:49

matanlurey approved these changes Feb 20, 2025

View reviewed changes

This was referenced Feb 21, 2025

Linux build_tests_1_5 is 3.19% flaky #163117

Closed

Windows build_tests_3_9 is 2.11% flaky #163121

Closed

Windows build_tests_2_9 is 2.13% flaky #163118

Closed

jmagman requested a review from gmackall February 21, 2025 18:33

gmackall approved these changes Feb 21, 2025

View reviewed changes

jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 21, 2025

auto-submit bot added this pull request to the merge queue Feb 21, 2025

Merged via the queue into flutter:master with commit 404655a Feb 21, 2025
176 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 21, 2025

engine-flutter-autoroll mentioned this pull request Feb 22, 2025

Roll Flutter from 39b4951f8f0b to 7f447ea98c1a (73 revisions) flutter/packages#8676

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2025

404655a Update gradle memory properties in example and test projects (f…

90e1bd0

…lutter/flutter#163798)

engine-flutter-autoroll mentioned this pull request Feb 22, 2025

Roll Flutter from 39b4951f8f0b to 7f447ea98c1a (73 revisions) flutter/packages#8677

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2025

404655a Update gradle memory properties in example and test projects (f…

786f884

…lutter/flutter#163798)

engine-flutter-autoroll mentioned this pull request Feb 22, 2025

Roll Flutter from 39b4951f8f0b to ff3b708e0fc8 (74 revisions) flutter/packages#8678

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2025

404655a Update gradle memory properties in example and test projects (f…

5e6b5d3

…lutter/flutter#163798)

engine-flutter-autoroll mentioned this pull request Feb 22, 2025

Manual roll Flutter from 39b4951f8f0b to ff3b708e0fc8 (74 revisions) flutter/packages#8679

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2025

404655a Update gradle memory properties in example and test projects (f…

bb88715

…lutter/flutter#163798)

engine-flutter-autoroll mentioned this pull request Feb 23, 2025

Roll Flutter from 39b4951f8f0b to 10644396b824 (76 revisions) flutter/packages#8680

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2025

404655a Update gradle memory properties in example and test projects (f…

2e7b83b

…lutter/flutter#163798)

engine-flutter-autoroll mentioned this pull request Feb 23, 2025

Roll Flutter from 39b4951f8f0b to 10644396b824 (76 revisions) flutter/packages#8681

Closed

engine-flutter-autoroll mentioned this pull request Feb 25, 2025

Roll Flutter from 911aa7547ed7 to 641765e283cf (42 revisions) flutter/packages#8699

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025

404655a Update gradle memory properties in example and test projects (f…

73276de

…lutter/flutter#163798)

engine-flutter-autoroll mentioned this pull request Feb 25, 2025

Roll Flutter from 911aa7547ed7 to 5a8f23c3dcf0 (43 revisions) flutter/packages#8701

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025

404655a Update gradle memory properties in example and test projects (f…

228e00a

…lutter/flutter#163798)

engine-flutter-autoroll mentioned this pull request Feb 25, 2025

Roll Flutter from 911aa7547ed7 to 73b518d0c36e (44 revisions) flutter/packages#8702

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025

404655a Update gradle memory properties in example and test projects (f…

d7245b5

…lutter/flutter#163798)

engine-flutter-autoroll mentioned this pull request Feb 25, 2025

Roll Flutter from 911aa7547ed7 to be1938aa1cbe (45 revisions) flutter/packages#8703

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025

404655a Update gradle memory properties in example and test projects (f…

0f811a1

…lutter/flutter#163798)

engine-flutter-autoroll mentioned this pull request Feb 25, 2025

Roll Flutter from 911aa7547ed7 to 289993ab8347 (46 revisions) flutter/packages#8704

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025

404655a Update gradle memory properties in example and test projects (f…

3fd92aa

…lutter/flutter#163798)

engine-flutter-autoroll mentioned this pull request Feb 25, 2025

Roll Flutter from 911aa7547ed7 to 940fb3c8b1ad (47 revisions) flutter/packages#8705

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025

404655a Update gradle memory properties in example and test projects (f…

5c1bc7b

…lutter/flutter#163798)

engine-flutter-autoroll mentioned this pull request Feb 25, 2025

Roll Flutter from 911aa7547ed7 to 70b7664ba297 (48 revisions) flutter/packages#8706

Closed

gnprice mentioned this pull request Feb 26, 2025

CI failing in Android build as out of memory zulip/zulip-flutter#1330

Closed

harri35 mentioned this pull request Feb 26, 2025

Find a way to profile Java memory use in CI #158889

Open

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025

404655a Update gradle memory properties in example and test projects (f…

889da00

…lutter/flutter#163798)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025

404655a Update gradle memory properties in example and test projects (f…

c96a649

…lutter/flutter#163798)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025

404655a Update gradle memory properties in example and test projects (f…

749f03f

…lutter/flutter#163798)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025

404655a Update gradle memory properties in example and test projects (f…

76eb872

…lutter/flutter#163798)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025

404655a Update gradle memory properties in example and test projects (f…

62882de

…lutter/flutter#163798)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025

404655a Update gradle memory properties in example and test projects (f…

160c0c4

…lutter/flutter#163798)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2025

404655a Update gradle memory properties in example and test projects (f…

caf182e

…lutter/flutter#163798)

engine-flutter-autoroll mentioned this pull request Feb 27, 2025

Manual roll Flutter from 043b71954ce7 to 16592066d70b (19 revisions) flutter/packages#8728

Merged

harri35 mentioned this pull request Mar 5, 2025

Windows module_host_with_custom_build_test is 2.13% flaky #164182

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

404655a Update gradle memory properties in example and test projects (f…

2d50afc

…lutter/flutter#163798)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

404655a Update gradle memory properties in example and test projects (f…

202870b

…lutter/flutter#163798)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

404655a Update gradle memory properties in example and test projects (f…

b2923b3

…lutter/flutter#163798)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update gradle memory properties in example and test projects #163798

Update gradle memory properties in example and test projects #163798

Uh oh!

jmagman commented Feb 20, 2025 •

edited

Loading

Uh oh!

matanlurey left a comment

Uh oh!

gmackall left a comment

Uh oh!

jmagman commented Feb 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Update gradle memory properties in example and test projects #163798

Update gradle memory properties in example and test projects #163798

Uh oh!

Conversation

jmagman commented Feb 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

matanlurey left a comment

Choose a reason for hiding this comment

Uh oh!

gmackall left a comment

Choose a reason for hiding this comment

Uh oh!

jmagman commented Feb 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jmagman commented Feb 20, 2025 •

edited

Loading