Move AndroidRenderingApi from common to shell/platform/android
#163796
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
bot
added
platform-android
| const flutter::TaskRunners& task_runners, | ||
| const std::shared_ptr<PlatformViewAndroidJNI>& jni_facade, | ||
| bool use_software_rendering) | ||
| AndroidRenderingAPI rendering_api) |
There was a problem hiding this comment.
Wait, if you don't store this - how is it getting here?
There was a problem hiding this comment.
Based on the failing test... it does not 😅.
There was a problem hiding this comment.
I think it has to go back to settings unfortunately. I may have run into the same problem that there is no where else to stash it.
There was a problem hiding this comment.
Uploaded an option.
It's not great, but it's not different than storing (and mutating) Settings.
More changes (potentially in follow-up PRs) could make this cleaner. Wdut?
| } | ||
|
|
||
| flutter::AndroidRenderingAPI FlutterMain::GetAndroidRenderingAPI() { | ||
| return android_rendering_api_; |
There was a problem hiding this comment.
Still not written anywhere?
There was a problem hiding this comment.
I have not mastered the arts of git push apparently
Co-authored-by: Jonah Williams <[email protected]>
|
Ok I think I stared at this long enough where it makes sense, the singleton nonsense is gross. |
matanlurey
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
2 participants
Towards #163792.
Major changes:
enum class AndroidRenderingAPIphysically moves toshell/platform/androidFlutterMain(as a result of::init), instead of inSettings