-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Roll Skia from 6da10829d017 to 1d884bab8593 (42 revisions) #163789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 2 commits into
flutter:master
from
engine-flutter-autoroll:skia-flutter-autoroll-6e0779a5-cd01-4278-a2bb-ec3312f3019c-1740087832
Feb 21, 2025
Merged
Roll Skia from 6da10829d017 to 1d884bab8593 (42 revisions) #163789
auto-submit
merged 2 commits into
flutter:master
from
engine-flutter-autoroll:skia-flutter-autoroll-6e0779a5-cd01-4278-a2bb-ec3312f3019c-1740087832
Feb 21, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://skia.googlesource.com/skia.git/+log/6da10829d017..1d884bab8593 2025-02-20 [email protected] Drawing hanging whitespaces in Paragraph 2025-02-20 [email protected] Roll vulkan-deps from 26efdfb4f31d to 126c9b378eb7 (5 revisions) 2025-02-20 [email protected] Update SkQPTestCases enforcement for 202504 vendor API bump (Android 16) 2025-02-20 [email protected] Split format calculation out of SkWorkingFormatColorFilter 2025-02-20 [email protected] Roll skottie-base from 7c51661ea28c to 7b44b80c0fac 2025-02-20 [email protected] [graphite] Remove TextureInfoData and TextureSpec in TextureInfo 2025-02-20 [email protected] [graphite] Prepend input attachment descriptor set to all Vulkan pipelines layouts 2025-02-20 [email protected] [graphite] Allow backends to define resource set/group indices for SkSL generation 2025-02-20 [email protected] [pdf] Developer build dump of input structure tree 2025-02-20 [email protected] [graphite] Use linked list for ClipAtlasManager. 2025-02-20 [email protected] Bump golang.org/x/crypto and golang.org/x/net 2025-02-20 [email protected] Manual roll Dawn from c77cb9bbcd29 to be5b722c82af (26 revisions) 2025-02-20 [email protected] [infra] Update to go 1.22.0 in go.mod 2025-02-20 [email protected] Updating license IDs to be spdx compliant 2025-02-20 [email protected] [graphite] Fix precomp tests involving picture shaders 2025-02-20 [email protected] [graphite] Re-enable BackendTextureTest on Vulkan (& fix protectedness) 2025-02-20 [email protected] Revert "[Graphite] Add dawn disable_lazy_clear_for_mapped_at_creation_buffer toggle" 2025-02-20 [email protected] [graphite] Update known runtime effect constants for user-defined known runtime effects 2025-02-20 [email protected] [graphite] Prevent default zero initializaiton for DrawList members. 2025-02-20 [email protected] [skif] Add build flag to avoid slow small sigma CPU blurs 2025-02-20 [email protected] [graphite] Shore up snippet ID error handling in preparation for user-defined known runtime effects 2025-02-20 [email protected] [graphite] Tinker w/ serialized pipeline keys a bit 2025-02-20 [email protected] Reland "Decouple PDF backend and JPEG encoding/decoding" 2025-02-20 [email protected] Roll ANGLE from bace6371e325 to 80093a7d8f85 (14 revisions) 2025-02-20 [email protected] Reland "Add some checks to avoid asserting deep in ImageFilter code" 2025-02-20 [email protected] Roll Dawn from 65cf97632f2a to c77cb9bbcd29 (16 revisions) 2025-02-20 [email protected] Roll SwiftShader from 720189cae847 to d7ed113c66ec (2 revisions) 2025-02-19 [email protected] [rust png] Add a new `SkCodec::isAnimated` API. 2025-02-19 [email protected] [infra] Update Go to 1.24.0 2025-02-19 [email protected] [infra] Use SkiaIOS pool for iOS devices 2025-02-19 [email protected] [skif] Relax assert in srcRelativeOutput 2025-02-19 [email protected] Revert "Decouple PDF backend and JPEG encoding/decoding" 2025-02-19 [email protected] Revert "[graphite] Enable BackendTextureTest on Vulkan" 2025-02-19 [email protected] Revert "Add some checks to avoid asserting deep in ImageFilter code" 2025-02-18 [email protected] [graphite] Move PipelineCallbackHandler to skiatools for reuse 2025-02-18 [email protected] Add some checks to avoid asserting deep in ImageFilter code 2025-02-18 [email protected] Roll vulkan-deps from 5d08bc0b0e23 to 26efdfb4f31d (8 revisions) 2025-02-18 [email protected] [SkQP] Create new AllSkQPTestCases module for Android framework builds 2025-02-18 [email protected] [graphite] Enable BackendTextureTest on Vulkan 2025-02-18 [email protected] Decouple PDF backend and JPEG encoding/decoding 2025-02-18 [email protected] [Fontations] Match FreeType antialiasing on unknown pixel geometry 2025-02-18 [email protected] Use SkSpans in BlurMask and related classes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
fluttergithubbot
approved these changes
Feb 20, 2025
…2bb-ec3312f3019c-1740087832
Contributor
Author
|
CL was modified by someone other than the roller. The roller will ignore this CL. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 22, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 22, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 22, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 22, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 23, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 23, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 24, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 24, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 24, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 25, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 25, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 25, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 25, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 25, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 25, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 25, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 27, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Feb 27, 2025
Manual roll requested by [email protected] flutter/flutter@043b719...1659206 2025-02-24 [email protected] Roll Skia from 3dfb3fee52e1 to 28017200173a (2 revisions) (flutter/flutter#163981) 2025-02-24 [email protected] Add integration test for Gradle-initiated android builds with flavors (flutter/flutter#163737) 2025-02-23 [email protected] Roll Skia from 72f949950adb to 3dfb3fee52e1 (1 revision) (flutter/flutter#163959) 2025-02-23 [email protected] Roll Skia from 4bee660601de to 72f949950adb (1 revision) (flutter/flutter#163948) 2025-02-22 [email protected] Roll Skia from cca9328df6ca to 4bee660601de (1 revision) (flutter/flutter#163927) 2025-02-22 [email protected] Roll Dart SDK from bad289580d9b to aea6fff33f06 (3 revisions) (flutter/flutter#163912) 2025-02-22 [email protected] Roll Skia from 1d884bab8593 to cca9328df6ca (12 revisions) (flutter/flutter#163910) 2025-02-22 [email protected] [fuchsia] include more tests in the fuchsia builders (flutter/flutter#163800) 2025-02-21 [email protected] [Engine] Add RoundSuperellipse to drawing OP (flutter/flutter#160883) 2025-02-21 [email protected] [remake] Restore old back handling for FlutterFragmentActivity (flutter/flutter#161545) 2025-02-21 [email protected] Revert "Marks Mac_benchmark basic_material_app_macos__compile to be flaky" (flutter/flutter#163878) 2025-02-21 [email protected] Revert "Marks Mac_benchmark flutter_view_macos__start_up to be flaky" (flutter/flutter#163880) 2025-02-21 [email protected] Roll Dart SDK from c5e582f15b6c to bad289580d9b (1 revision) (flutter/flutter#163885) 2025-02-21 [email protected] Revert "Marks Windows_mokey native_assets_android to be flaky" (flutter/flutter#163881) 2025-02-21 [email protected] Mark platform_views_hcpp_scroll_perf__timeline_summary out of bringup (flutter/flutter#163883) 2025-02-21 [email protected] Roll Skia from 6da10829d017 to 1d884bab8593 (42 revisions) (flutter/flutter#163789) 2025-02-21 [email protected] Enable `linux_android_emulator_tests` on presubmit. (flutter/flutter#163879) 2025-02-21 [email protected] Update gradle memory properties in example and test projects (flutter/flutter#163798) 2025-02-21 [email protected] Secure paste milestone 2 (flutter/flutter#159013) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 21, 2025
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
) Manual roll requested by [email protected] flutter/flutter@043b719...1659206 2025-02-24 [email protected] Roll Skia from 3dfb3fee52e1 to 28017200173a (2 revisions) (flutter/flutter#163981) 2025-02-24 [email protected] Add integration test for Gradle-initiated android builds with flavors (flutter/flutter#163737) 2025-02-23 [email protected] Roll Skia from 72f949950adb to 3dfb3fee52e1 (1 revision) (flutter/flutter#163959) 2025-02-23 [email protected] Roll Skia from 4bee660601de to 72f949950adb (1 revision) (flutter/flutter#163948) 2025-02-22 [email protected] Roll Skia from cca9328df6ca to 4bee660601de (1 revision) (flutter/flutter#163927) 2025-02-22 [email protected] Roll Dart SDK from bad289580d9b to aea6fff33f06 (3 revisions) (flutter/flutter#163912) 2025-02-22 [email protected] Roll Skia from 1d884bab8593 to cca9328df6ca (12 revisions) (flutter/flutter#163910) 2025-02-22 [email protected] [fuchsia] include more tests in the fuchsia builders (flutter/flutter#163800) 2025-02-21 [email protected] [Engine] Add RoundSuperellipse to drawing OP (flutter/flutter#160883) 2025-02-21 [email protected] [remake] Restore old back handling for FlutterFragmentActivity (flutter/flutter#161545) 2025-02-21 [email protected] Revert "Marks Mac_benchmark basic_material_app_macos__compile to be flaky" (flutter/flutter#163878) 2025-02-21 [email protected] Revert "Marks Mac_benchmark flutter_view_macos__start_up to be flaky" (flutter/flutter#163880) 2025-02-21 [email protected] Roll Dart SDK from c5e582f15b6c to bad289580d9b (1 revision) (flutter/flutter#163885) 2025-02-21 [email protected] Revert "Marks Windows_mokey native_assets_android to be flaky" (flutter/flutter#163881) 2025-02-21 [email protected] Mark platform_views_hcpp_scroll_perf__timeline_summary out of bringup (flutter/flutter#163883) 2025-02-21 [email protected] Roll Skia from 6da10829d017 to 1d884bab8593 (42 revisions) (flutter/flutter#163789) 2025-02-21 [email protected] Enable `linux_android_emulator_tests` on presubmit. (flutter/flutter#163879) 2025-02-21 [email protected] Update gradle memory properties in example and test projects (flutter/flutter#163798) 2025-02-21 [email protected] Secure paste milestone 2 (flutter/flutter#159013) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
) Manual roll requested by [email protected] flutter/flutter@043b719...1659206 2025-02-24 [email protected] Roll Skia from 3dfb3fee52e1 to 28017200173a (2 revisions) (flutter/flutter#163981) 2025-02-24 [email protected] Add integration test for Gradle-initiated android builds with flavors (flutter/flutter#163737) 2025-02-23 [email protected] Roll Skia from 72f949950adb to 3dfb3fee52e1 (1 revision) (flutter/flutter#163959) 2025-02-23 [email protected] Roll Skia from 4bee660601de to 72f949950adb (1 revision) (flutter/flutter#163948) 2025-02-22 [email protected] Roll Skia from cca9328df6ca to 4bee660601de (1 revision) (flutter/flutter#163927) 2025-02-22 [email protected] Roll Dart SDK from bad289580d9b to aea6fff33f06 (3 revisions) (flutter/flutter#163912) 2025-02-22 [email protected] Roll Skia from 1d884bab8593 to cca9328df6ca (12 revisions) (flutter/flutter#163910) 2025-02-22 [email protected] [fuchsia] include more tests in the fuchsia builders (flutter/flutter#163800) 2025-02-21 [email protected] [Engine] Add RoundSuperellipse to drawing OP (flutter/flutter#160883) 2025-02-21 [email protected] [remake] Restore old back handling for FlutterFragmentActivity (flutter/flutter#161545) 2025-02-21 [email protected] Revert "Marks Mac_benchmark basic_material_app_macos__compile to be flaky" (flutter/flutter#163878) 2025-02-21 [email protected] Revert "Marks Mac_benchmark flutter_view_macos__start_up to be flaky" (flutter/flutter#163880) 2025-02-21 [email protected] Roll Dart SDK from c5e582f15b6c to bad289580d9b (1 revision) (flutter/flutter#163885) 2025-02-21 [email protected] Revert "Marks Windows_mokey native_assets_android to be flaky" (flutter/flutter#163881) 2025-02-21 [email protected] Mark platform_views_hcpp_scroll_perf__timeline_summary out of bringup (flutter/flutter#163883) 2025-02-21 [email protected] Roll Skia from 6da10829d017 to 1d884bab8593 (42 revisions) (flutter/flutter#163789) 2025-02-21 [email protected] Enable `linux_android_emulator_tests` on presubmit. (flutter/flutter#163879) 2025-02-21 [email protected] Update gradle memory properties in example and test projects (flutter/flutter#163798) 2025-02-21 [email protected] Secure paste milestone 2 (flutter/flutter#159013) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roll Skia from 6da10829d017 to 1d884bab8593 (42 revisions)
https://skia.googlesource.com/skia.git/+log/6da10829d017..1d884bab8593
2025-02-20 [email protected] Drawing hanging whitespaces in Paragraph
2025-02-20 [email protected] Roll vulkan-deps from 26efdfb4f31d to 126c9b378eb7 (5 revisions)
2025-02-20 [email protected] Update SkQPTestCases enforcement for 202504 vendor API bump (Android 16)
2025-02-20 [email protected] Split format calculation out of SkWorkingFormatColorFilter
2025-02-20 [email protected] Roll skottie-base from 7c51661ea28c to 7b44b80c0fac
2025-02-20 [email protected] [graphite] Remove TextureInfoData and TextureSpec in TextureInfo
2025-02-20 [email protected] [graphite] Prepend input attachment descriptor set to all Vulkan pipelines layouts
2025-02-20 [email protected] [graphite] Allow backends to define resource set/group indices for SkSL generation
2025-02-20 [email protected] [pdf] Developer build dump of input structure tree
2025-02-20 [email protected] [graphite] Use linked list for ClipAtlasManager.
2025-02-20 [email protected] Bump golang.org/x/crypto and golang.org/x/net
2025-02-20 [email protected] Manual roll Dawn from c77cb9bbcd29 to be5b722c82af (26 revisions)
2025-02-20 [email protected] [infra] Update to go 1.22.0 in go.mod
2025-02-20 [email protected] Updating license IDs to be spdx compliant
2025-02-20 [email protected] [graphite] Fix precomp tests involving picture shaders
2025-02-20 [email protected] [graphite] Re-enable BackendTextureTest on Vulkan (& fix protectedness)
2025-02-20 [email protected] Revert "[Graphite] Add dawn disable_lazy_clear_for_mapped_at_creation_buffer toggle"
2025-02-20 [email protected] [graphite] Update known runtime effect constants for user-defined known runtime effects
2025-02-20 [email protected] [graphite] Prevent default zero initializaiton for DrawList members.
2025-02-20 [email protected] [skif] Add build flag to avoid slow small sigma CPU blurs
2025-02-20 [email protected] [graphite] Shore up snippet ID error handling in preparation for user-defined known runtime effects
2025-02-20 [email protected] [graphite] Tinker w/ serialized pipeline keys a bit
2025-02-20 [email protected] Reland "Decouple PDF backend and JPEG encoding/decoding"
2025-02-20 [email protected] Roll ANGLE from bace6371e325 to 80093a7d8f85 (14 revisions)
2025-02-20 [email protected] Reland "Add some checks to avoid asserting deep in ImageFilter code"
2025-02-20 [email protected] Roll Dawn from 65cf97632f2a to c77cb9bbcd29 (16 revisions)
2025-02-20 [email protected] Roll SwiftShader from 720189cae847 to d7ed113c66ec (2 revisions)
2025-02-19 [email protected] [rust png] Add a new
SkCodec::isAnimatedAPI.2025-02-19 [email protected] [infra] Update Go to 1.24.0
2025-02-19 [email protected] [infra] Use SkiaIOS pool for iOS devices
2025-02-19 [email protected] [skif] Relax assert in srcRelativeOutput
2025-02-19 [email protected] Revert "Decouple PDF backend and JPEG encoding/decoding"
2025-02-19 [email protected] Revert "[graphite] Enable BackendTextureTest on Vulkan"
2025-02-19 [email protected] Revert "Add some checks to avoid asserting deep in ImageFilter code"
2025-02-18 [email protected] [graphite] Move PipelineCallbackHandler to skiatools for reuse
2025-02-18 [email protected] Add some checks to avoid asserting deep in ImageFilter code
2025-02-18 [email protected] Roll vulkan-deps from 5d08bc0b0e23 to 26efdfb4f31d (8 revisions)
2025-02-18 [email protected] [SkQP] Create new AllSkQPTestCases module for Android framework builds
2025-02-18 [email protected] [graphite] Enable BackendTextureTest on Vulkan
2025-02-18 [email protected] Decouple PDF backend and JPEG encoding/decoding
2025-02-18 [email protected] [Fontations] Match FreeType antialiasing on unknown pixel geometry
2025-02-18 [email protected] Use SkSpans in BlurMask and related classes
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
...