Skip to content

Suppress stderr during Xcode command line installation check #163785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Feb 21, 2025
Merged

Suppress stderr during Xcode command line installation check #163785

auto-submit merged 3 commits into from
Feb 21, 2025

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Feb 20, 2025 •
edited
Loading

Xcode is in some kind of half-installed state (missing a cert? unknown) on some devicelab Macs #161655. As of #163685 Xcode cipd installation isn't requested as part of the builder configuration, so it seems like Xcode is just hanging out on that devicelab bot quasi-installed, unrelated to the recipe.

In any case, the tool is actually doing the right thing and detecting that Xcode isn't in a good state and continuing as if it isn't installed, but is logging a wall of error text about it to stderr, which that Android test doesn't like. Instead of updating the test to allow stderr, instead swap the Xcode installation path to exitsHappySync to only check the exit code (or exception), which is the original intention behind the Xcode command line checks.

flutter/packages/flutter_tools/lib/src/base/process.dart

Lines 596 to 601 in e673061

try {
return _processManager.runSync(cli, environment: environment).exitCode == 0;
} on Exception catch (error) {
_logger.printTrace('$cli failed with $error');
return false;
}

Fixes #161655

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. a: desktop Running on desktop team-ios Owned by iOS platform team labels Feb 20, 2025
jmagman
jmagman commented Feb 20, 2025
View reviewed changes
@jmagman jmagman requested a review from vashworth February 20, 2025 22:37
vashworth
vashworth approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@vashworth vashworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 21, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 21, 2025
Merged via the queue into flutter:master with commit bb306c5 Feb 21, 2025
139 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 21, 2025
This was referenced Feb 21, 2025
Closed
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2025
@engine-flutter-autoroll
bb306c5 Suppress stderr during Xcode command line installation check (f…
519fd8b 
…lutter/flutter#163785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2025
@engine-flutter-autoroll
bb306c5 Suppress stderr during Xcode command line installation check (f…
7334b93 
…lutter/flutter#163785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2025
@engine-flutter-autoroll
bb306c5 Suppress stderr during Xcode command line installation check (f…
3e62ddf 
…lutter/flutter#163785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2025
@engine-flutter-autoroll
bb306c5 Suppress stderr during Xcode command line installation check (f…
5d6a181 
…lutter/flutter#163785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2025
@engine-flutter-autoroll
bb306c5 Suppress stderr during Xcode command line installation check (f…
91f17ef 
…lutter/flutter#163785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2025
@engine-flutter-autoroll
bb306c5 Suppress stderr during Xcode command line installation check (f…
fdfea20 
…lutter/flutter#163785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2025
@engine-flutter-autoroll
bb306c5 Suppress stderr during Xcode command line installation check (f…
5b7076f 
…lutter/flutter#163785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2025
@engine-flutter-autoroll
bb306c5 Suppress stderr during Xcode command line installation check (f…
ef82e49 
…lutter/flutter#163785)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2025
@engine-flutter-autoroll
bb306c5 Suppress stderr during Xcode command line installation check (f…
5ca6bd4 
…lutter/flutter#163785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2025
@engine-flutter-autoroll
bb306c5 Suppress stderr during Xcode command line installation check (f…
00ec8d7 
…lutter/flutter#163785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2025
@engine-flutter-autoroll
bb306c5 Suppress stderr during Xcode command line installation check (f…
4288aad 
…lutter/flutter#163785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
bb306c5 Suppress stderr during Xcode command line installation check (f…
df8f0f7 
…lutter/flutter#163785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
bb306c5 Suppress stderr during Xcode command line installation check (f…
9d7b395 
…lutter/flutter#163785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
bb306c5 Suppress stderr during Xcode command line installation check (f…
3244345 
…lutter/flutter#163785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
bb306c5 Suppress stderr during Xcode command line installation check (f…
3d1d41c 
…lutter/flutter#163785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
bb306c5 Suppress stderr during Xcode command line installation check (f…
10a47b5 
…lutter/flutter#163785)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
bb306c5 Suppress stderr during Xcode command line installation check (f…
963261d 
…lutter/flutter#163785)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
bb306c5 Suppress stderr during Xcode command line installation check (f…
0f93030 
…lutter/flutter#163785)
github-merge-queue bot pushed a commit that referenced this pull request Feb 25, 2025
@jmagman
Check if simctl is installed before trying to list devices or runtimes (
898ab24 
#163895)

After #163785 there was still an
unexpected `xcrun simctl` output on a machine with Xcode only half
installed #161655.

Check `simctl` is installed before trying to list booted simulator
devices or runtimes.

Should address #161655.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
bb306c5 Suppress stderr during Xcode command line installation check (f…
0702040 
…lutter/flutter#163785)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
bb306c5 Suppress stderr during Xcode command line installation check (f…
0b05697 
…lutter/flutter#163785)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
bb306c5 Suppress stderr during Xcode command line installation check (f…
c305cd6 
…lutter/flutter#163785)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
bb306c5 Suppress stderr during Xcode command line installation check (f…
4c11940 
…lutter/flutter#163785)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
bb306c5 Suppress stderr during Xcode command line installation check (f…
b69a77d 
…lutter/flutter#163785)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
bb306c5 Suppress stderr during Xcode command line installation check (f…
066ba37 
…lutter/flutter#163785)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
bb306c5 Suppress stderr during Xcode command line installation check (f…
e23ffc0 
…lutter/flutter#163785)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
bb306c5 Suppress stderr during Xcode command line installation check (f…
9683a8a 
…lutter/flutter#163785)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
bb306c5 Suppress stderr during Xcode command line installation check (f…
61dc705 
…lutter/flutter#163785)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vashworth vashworth vashworth approved these changes

Assignees

No one assigned

Labels

a: desktop Running on desktop team-ios Owned by iOS platform team tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mac_mokey run_debug_test_android is 10.42% flaky

2 participants

@jmagman @vashworth