Skip to content

[CP][Impeller] Fix text glitch when returning to foreground. #163754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Feb 20, 2025
Merged

[CP][Impeller] Fix text glitch when returning to foreground. #163754

auto-submit merged 3 commits into from
Feb 20, 2025
+8 −3

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Feb 20, 2025

Fixes #163730
Fixes #163452

@jonahwilliams jonahwilliams added cp: review Cherry-picks in the review queue cp: stable cherry pick this pull request to stable release candidate branch labels Feb 20, 2025
@github-actions github-actions bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Feb 20, 2025
@eyebrowsoffire eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 20, 2025
@auto-submit auto-submit bot merged commit 7253c79 into flutter:flutter-3.29-candidate.0 Feb 20, 2025
156 checks passed
This was referenced Feb 22, 2025
Merged
Closed
github-merge-queue bot pushed a commit that referenced this pull request Feb 24, 2025
[Impeller] Disable text cache. (#163906)
0102da9 
I forgot to make a master branch version of the cherry pick here:
#163754
@mit-mit mit-mit mentioned this pull request Feb 27, 2025
Closed
@RafiqCR7
Copy link

RafiqCR7 commented Feb 27, 2025

Great work but what happens to this fix now? Will it be released as part of a 3.29.1 release?

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
@engine-flutter-autoroll
7253c79e2 [CP][Impeller] Fix text glitch when returning to foreground. (
2525eac 
flutter/flutter#163754)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
7253c79e2 [CP][Impeller] Fix text glitch when returning to foreground. (
4c45290 
flutter/flutter#163754)
@WyvernPirate WyvernPirate mentioned this pull request Apr 3, 2025
Merged
@reidbaker reidbaker mentioned this pull request Apr 4, 2025
Merged
9 tasks
Fintasys pushed a commit to Fintasys/flutter that referenced this pull request May 14, 2025
@Fintasys
[CP][Impeller] Fix text glitch when returning to foreground. (flutter…
745af68 
…#163754)

Fixes flutter#163730
Fixes flutter#163452
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtmcdole jtmcdole jtmcdole approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App cp: review Cherry-picks in the review queue cp: stable cherry pick this pull request to stable release candidate branch e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jonahwilliams @RafiqCR7 @jtmcdole @eyebrowsoffire