[CP][Stable] Check for tracked engine.version before overriding #163741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and in some cases flutter#162251 Flutter tool respects tracked `engine.version` Non `master`, `stable`, and `beta` branches will respect tracked versions of `engine.version` and not download incorrect engine artifacts. Deleting `engine/src/.gn` will trick the tools into thinking this is a non-monorepo. What is the risk level of this cherry-pick? - [X] Low - [ ] Medium - [ ] High Are you confident that your fix is well-tested by automated tests? - [X] Yes - at master. - [ ] No 1. Switch to the branch / tag this is checked out to (i.e. `3.29.0`) 2. Examine `bin/internal/engine.version` 2. Run `flutter doctor` 3. See that it downloads the correct hash and `engine.version` hasn't been modified.
jtmcdole
added
cp: review
eyebrowsoffire
added
the
autosubmit
auto-submit
bot
merged commit 7d0f4d9
into
flutter:flutter-3.29-candidate.0
156 checks passed
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2025
9 tasks
Fintasys
pushed a commit
to Fintasys/flutter
that referenced
this pull request
May 14, 2025
…ter#163741) and in some cases flutter#162251 Flutter tool respects tracked `engine.version` Non `master`, `stable`, and `beta` branches will respect tracked versions of `engine.version` and not download incorrect engine artifacts. Deleting `engine/src/.gn` will trick the tools into thinking this is a non-monorepo. What is the risk level of this cherry-pick? Are you confident that your fix is well-tested by automated tests? 1. Switch to the branch / tag this is checked out to (i.e. `3.29.0`) 2. Examine `bin/internal/engine.version` 2. Run `flutter doctor` 3. See that it downloads the correct hash and `engine.version` hasn't been modified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link:
#163308
#163691
and in some cases #162251
Changelog Description:
Flutter tool respects tracked
engine.versionImpact Description:
Non
master,stable, andbetabranches will respect tracked versions ofengine.versionand not download incorrect engine artifacts.Workaround:
Deleting
engine/src/.gnwill trick the tools into thinking this is a non-monorepo.Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
3.29.0)bin/internal/engine.versionflutter doctorengine.versionhasn't been modified.