Add integration test for Gradle-initiated android builds with flavors #163737

Sameri11 · 2025-02-20T16:13:38Z

This request is a subset of #157871 and follows up #162907.

#162907 actually fixed behaviour of building with native tooling not only for iOS/macOS, but also for Android builds too: now on master, if you start build with gradle instead of flutter build ... – you also get the correct behaviour and appFlavor won't be null in runtime. Tests in this PR will check exactly this behavior.

Another diff is the change in the method of obtaining flavor at runtime inside test project. Before this change, method channels were used for this, after – appFlavor constant. Both methods do more or less the same thing right now, but they may diverge in future, so I guess this is the right way to check correctness here. Also, this change was requested and approved by Andrew in #157871 (comment)

issue for checklist: #155951

New test was tested here: https://ci.chromium.org/ui/p/flutter/builders/try/Linux_pixel_7pro%20flavors_test/63/overview

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Sameri11 · 2025-02-24T04:30:35Z

@matanlurey @reidbaker Thanks for the reviews, guys! Since I have 2 LGTM now, could you please add the autosubmit label here?

matanlurey · 2025-02-24T04:39:18Z

You got it

Sameri11 · 2025-02-24T04:41:21Z

@matanlurey thanks! 💙

… flavors (flutter/flutter#163737)

Manual roll requested by [email protected] flutter/flutter@043b719...1659206 2025-02-24 [email protected] Roll Skia from 3dfb3fee52e1 to 28017200173a (2 revisions) (flutter/flutter#163981) 2025-02-24 [email protected] Add integration test for Gradle-initiated android builds with flavors (flutter/flutter#163737) 2025-02-23 [email protected] Roll Skia from 72f949950adb to 3dfb3fee52e1 (1 revision) (flutter/flutter#163959) 2025-02-23 [email protected] Roll Skia from 4bee660601de to 72f949950adb (1 revision) (flutter/flutter#163948) 2025-02-22 [email protected] Roll Skia from cca9328df6ca to 4bee660601de (1 revision) (flutter/flutter#163927) 2025-02-22 [email protected] Roll Dart SDK from bad289580d9b to aea6fff33f06 (3 revisions) (flutter/flutter#163912) 2025-02-22 [email protected] Roll Skia from 1d884bab8593 to cca9328df6ca (12 revisions) (flutter/flutter#163910) 2025-02-22 [email protected] [fuchsia] include more tests in the fuchsia builders (flutter/flutter#163800) 2025-02-21 [email protected] [Engine] Add RoundSuperellipse to drawing OP (flutter/flutter#160883) 2025-02-21 [email protected] [remake] Restore old back handling for FlutterFragmentActivity (flutter/flutter#161545) 2025-02-21 [email protected] Revert "Marks Mac_benchmark basic_material_app_macos__compile to be flaky" (flutter/flutter#163878) 2025-02-21 [email protected] Revert "Marks Mac_benchmark flutter_view_macos__start_up to be flaky" (flutter/flutter#163880) 2025-02-21 [email protected] Roll Dart SDK from c5e582f15b6c to bad289580d9b (1 revision) (flutter/flutter#163885) 2025-02-21 [email protected] Revert "Marks Windows_mokey native_assets_android to be flaky" (flutter/flutter#163881) 2025-02-21 [email protected] Mark platform_views_hcpp_scroll_perf__timeline_summary out of bringup (flutter/flutter#163883) 2025-02-21 [email protected] Roll Skia from 6da10829d017 to 1d884bab8593 (42 revisions) (flutter/flutter#163789) 2025-02-21 [email protected] Enable `linux_android_emulator_tests` on presubmit. (flutter/flutter#163879) 2025-02-21 [email protected] Update gradle memory properties in example and test projects (flutter/flutter#163798) 2025-02-21 [email protected] Secure paste milestone 2 (flutter/flutter#159013) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

… flavors (flutter/flutter#163737)

) Manual roll requested by [email protected] flutter/flutter@043b719...1659206 2025-02-24 [email protected] Roll Skia from 3dfb3fee52e1 to 28017200173a (2 revisions) (flutter/flutter#163981) 2025-02-24 [email protected] Add integration test for Gradle-initiated android builds with flavors (flutter/flutter#163737) 2025-02-23 [email protected] Roll Skia from 72f949950adb to 3dfb3fee52e1 (1 revision) (flutter/flutter#163959) 2025-02-23 [email protected] Roll Skia from 4bee660601de to 72f949950adb (1 revision) (flutter/flutter#163948) 2025-02-22 [email protected] Roll Skia from cca9328df6ca to 4bee660601de (1 revision) (flutter/flutter#163927) 2025-02-22 [email protected] Roll Dart SDK from bad289580d9b to aea6fff33f06 (3 revisions) (flutter/flutter#163912) 2025-02-22 [email protected] Roll Skia from 1d884bab8593 to cca9328df6ca (12 revisions) (flutter/flutter#163910) 2025-02-22 [email protected] [fuchsia] include more tests in the fuchsia builders (flutter/flutter#163800) 2025-02-21 [email protected] [Engine] Add RoundSuperellipse to drawing OP (flutter/flutter#160883) 2025-02-21 [email protected] [remake] Restore old back handling for FlutterFragmentActivity (flutter/flutter#161545) 2025-02-21 [email protected] Revert "Marks Mac_benchmark basic_material_app_macos__compile to be flaky" (flutter/flutter#163878) 2025-02-21 [email protected] Revert "Marks Mac_benchmark flutter_view_macos__start_up to be flaky" (flutter/flutter#163880) 2025-02-21 [email protected] Roll Dart SDK from c5e582f15b6c to bad289580d9b (1 revision) (flutter/flutter#163885) 2025-02-21 [email protected] Revert "Marks Windows_mokey native_assets_android to be flaky" (flutter/flutter#163881) 2025-02-21 [email protected] Mark platform_views_hcpp_scroll_perf__timeline_summary out of bringup (flutter/flutter#163883) 2025-02-21 [email protected] Roll Skia from 6da10829d017 to 1d884bab8593 (42 revisions) (flutter/flutter#163789) 2025-02-21 [email protected] Enable `linux_android_emulator_tests` on presubmit. (flutter/flutter#163879) 2025-02-21 [email protected] Update gradle memory properties in example and test projects (flutter/flutter#163798) 2025-02-21 [email protected] Secure paste milestone 2 (flutter/flutter#159013) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Sameri11 force-pushed the test-gradle-flavors-build branch 3 times, most recently from dcee6cf to 76dc50d Compare February 20, 2025 18:13

Sameri11 changed the title ~~[Draft] Add integration test for Gradle-initiated android builds with flavors~~ Add integration test for Gradle-initiated android builds with flavors Feb 20, 2025

add integration test for build with flavors from gradle

04b0c2e

Sameri11 force-pushed the test-gradle-flavors-build branch from 76dc50d to 04b0c2e Compare February 21, 2025 04:58

Sameri11 marked this pull request as ready for review February 21, 2025 06:02

Sameri11 requested a review from matanlurey as a code owner February 21, 2025 06:02

matanlurey requested a review from a team February 21, 2025 07:25

reidbaker approved these changes Feb 21, 2025

View reviewed changes

matanlurey approved these changes Feb 23, 2025

View reviewed changes

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 24, 2025

auto-submit bot added this pull request to the merge queue Feb 24, 2025

Merged via the queue into flutter:master with commit 937965f Feb 24, 2025
148 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 24, 2025

engine-flutter-autoroll mentioned this pull request Feb 24, 2025

Roll Flutter from 39b4951f8f0b to 39dd5a0897cf (79 revisions) flutter/packages#8684

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2025

937965f Add integration test for Gradle-initiated android builds with…

01e9bd3

… flavors (flutter/flutter#163737)

engine-flutter-autoroll mentioned this pull request Feb 24, 2025

Roll Flutter from 39b4951f8f0b to 9a13fd785f2b (80 revisions) flutter/packages#8686

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2025

937965f Add integration test for Gradle-initiated android builds with…

d20da3f

… flavors (flutter/flutter#163737)

engine-flutter-autoroll mentioned this pull request Feb 24, 2025

Roll Flutter from 39b4951f8f0b to 0102da95cd20 (81 revisions) flutter/packages#8688

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2025

937965f Add integration test for Gradle-initiated android builds with…

c24569a

… flavors (flutter/flutter#163737)

engine-flutter-autoroll mentioned this pull request Feb 24, 2025

Roll Flutter from 39b4951f8f0b to e2c4ba31b83e (82 revisions) flutter/packages#8689

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2025

937965f Add integration test for Gradle-initiated android builds with…

e08eb59

… flavors (flutter/flutter#163737)

engine-flutter-autoroll mentioned this pull request Feb 24, 2025

Roll Flutter from 911aa7547ed7 to de72d1c6427c (27 revisions) flutter/packages#8690

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2025

937965f Add integration test for Gradle-initiated android builds with…

53c106f

… flavors (flutter/flutter#163737)

engine-flutter-autoroll mentioned this pull request Feb 25, 2025

Roll Flutter from 911aa7547ed7 to 641765e283cf (42 revisions) flutter/packages#8699

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025

937965f Add integration test for Gradle-initiated android builds with…

b335491

… flavors (flutter/flutter#163737)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025

937965f Add integration test for Gradle-initiated android builds with…

13b0f94

… flavors (flutter/flutter#163737)

This was referenced Feb 25, 2025

Roll Flutter from 911aa7547ed7 to 5a8f23c3dcf0 (43 revisions) flutter/packages#8701

Closed

Roll Flutter from 911aa7547ed7 to 73b518d0c36e (44 revisions) flutter/packages#8702

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025

937965f Add integration test for Gradle-initiated android builds with…

1c2728a

… flavors (flutter/flutter#163737)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025

937965f Add integration test for Gradle-initiated android builds with…

b357e2b

… flavors (flutter/flutter#163737)

This was referenced Feb 25, 2025

Roll Flutter from 911aa7547ed7 to be1938aa1cbe (45 revisions) flutter/packages#8703

Closed

Roll Flutter from 911aa7547ed7 to 289993ab8347 (46 revisions) flutter/packages#8704

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025

937965f Add integration test for Gradle-initiated android builds with…

024f5ee

… flavors (flutter/flutter#163737)

engine-flutter-autoroll mentioned this pull request Feb 25, 2025

Roll Flutter from 911aa7547ed7 to 940fb3c8b1ad (47 revisions) flutter/packages#8705

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025

937965f Add integration test for Gradle-initiated android builds with…

d510c51

… flavors (flutter/flutter#163737)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025

937965f Add integration test for Gradle-initiated android builds with…

f3a2c41

… flavors (flutter/flutter#163737)

engine-flutter-autoroll mentioned this pull request Feb 25, 2025

Roll Flutter from 911aa7547ed7 to 70b7664ba297 (48 revisions) flutter/packages#8706

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025

937965f Add integration test for Gradle-initiated android builds with…

9aa7b00

… flavors (flutter/flutter#163737)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025

937965f Add integration test for Gradle-initiated android builds with…

f9ae5d0

… flavors (flutter/flutter#163737)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025

937965f Add integration test for Gradle-initiated android builds with…

f95e560

… flavors (flutter/flutter#163737)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025

937965f Add integration test for Gradle-initiated android builds with…

6ea7f87

… flavors (flutter/flutter#163737)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025

937965f Add integration test for Gradle-initiated android builds with…

9ba073d

… flavors (flutter/flutter#163737)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025

937965f Add integration test for Gradle-initiated android builds with…

b4f1aa8

… flavors (flutter/flutter#163737)

engine-flutter-autoroll mentioned this pull request Feb 27, 2025

Manual roll Flutter from 043b71954ce7 to 16592066d70b (19 revisions) flutter/packages#8728

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2025

937965f Add integration test for Gradle-initiated android builds with…

b135176

… flavors (flutter/flutter#163737)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

937965f Add integration test for Gradle-initiated android builds with…

0ab2b63

… flavors (flutter/flutter#163737)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

937965f Add integration test for Gradle-initiated android builds with…

bcb6748

… flavors (flutter/flutter#163737)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

937965f Add integration test for Gradle-initiated android builds with…

d8adce4

… flavors (flutter/flutter#163737)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add integration test for Gradle-initiated android builds with flavors #163737

Add integration test for Gradle-initiated android builds with flavors #163737

Uh oh!

Sameri11 commented Feb 20, 2025 •

edited

Loading

Uh oh!

Sameri11 commented Feb 24, 2025

Uh oh!

matanlurey commented Feb 24, 2025

Uh oh!

Sameri11 commented Feb 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add integration test for Gradle-initiated android builds with flavors #163737

Add integration test for Gradle-initiated android builds with flavors #163737

Uh oh!

Conversation

Sameri11 commented Feb 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Sameri11 commented Feb 24, 2025

Uh oh!

matanlurey commented Feb 24, 2025

Uh oh!

Sameri11 commented Feb 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sameri11 commented Feb 20, 2025 •

edited

Loading