[web][a11y]Delete _childContainerElement #163662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
added
engine
9 tasks
hannah-hyj
changed the title
hannah-hyj
force-pushed
the
deletewebcontainer2
branch
2 times, most recently
from
819734c to
ea98f32
Compare
hannah-hyj
changed the title
hannah-hyj
changed the title
yjbanov
reviewed
Mar 8, 2025
Contributor
yjbanov
left a comment
yjbanov
left a comment
There was a problem hiding this comment.
Sending some preliminary comments. I still need to wrap my head around the lifecycle of parent-child position updates. I will review that aspect next.
|
|
||
| /// Computes the size and position of [element] and, if this element | ||
| /// [hasChildren], of [getOrCreateChildContainer]. | ||
| /// [hasChildren], Computes the parent adjustment for each child. |
| _clearSemanticElementTransform(containerElement); | ||
| /// Computes the size and position of children. | ||
| void updateChildrenPositionAndSize() { | ||
| for (var childOrder in _childrenInTraversalOrder!) { |
Contributor
There was a problem hiding this comment.
nit: s/var childOrder/final childIndex/
| semantics().semanticsEnabled = false; | ||
| }); | ||
|
|
||
| test('container nodes are transparent and leaf children are opaque hit-test wise', () async { |
Contributor
There was a problem hiding this comment.
I think we still need this test. The "container nodes" in the description does not refer to the intermediate container elements that you are removing. It refers to SemanticsNode whose only purpose is to contain children and affect their transforms. We want those nodes to be transparent hit-test wise, and we should continue testing for that.
| semantics().semanticsEnabled = false; | ||
| }); | ||
|
|
||
| test('containers can be opaque if tappable', () async { |
Contributor
There was a problem hiding this comment.
This test is still useful for the same reason.
| semantics().semanticsEnabled = false; | ||
| }); | ||
|
|
||
| test('container can be opaque if it is a text field', () async { |
yjbanov
reviewed
Mar 12, 2025
| if (_currentChildrenInRenderOrder == null || _currentChildrenInRenderOrder!.isEmpty) { | ||
| for (final SemanticsObject child in childrenInRenderOrder) { | ||
| containerElement!.append(child.element); | ||
| element!.append(child.element); |
Contributor
There was a problem hiding this comment.
Without the container element could we have a problem with _scrollOverflowElement used by scrollables? This algorithm assumes that it controls all the children of the container. However, SemanticScrollable appends _scrollOverflowElement that this algorithm is unaware of. I think we're OK, since here we only use containerElement.append/insertBefore. For example, we don't use containerElement.children or containerElement.firstChild. However, it might be worth paying attention to. Previously, it was OK, because all children went into the container, and _scrollOverflowElement went into the root element.
Member
Author
There was a problem hiding this comment.
So _scrollOverflowElement was previously a sibling of containerElement and is now a sibling of children.
I think this is OK since, as you said, we are only using containerElement.append/insertBefore but not containerElement.children.
hannah-hyj
force-pushed
the
deletewebcontainer2
branch
2 times, most recently
from
c7265ef to
e0b4cc3
Compare
yjbanov
approved these changes
Mar 14, 2025
hannah-hyj
force-pushed
the
deletewebcontainer2
branch
from
fe49219 to
0950aef
Compare
github-actions
bot
added
the
a: text input
hannah-hyj
force-pushed
the
deletewebcontainer2
branch
from
52fb340 to
c829e2b
Compare
add back tests
update tests Update semantics_test.dart Update semantics_text_test.dart lint
hannah-hyj
force-pushed
the
deletewebcontainer2
branch
from
c829e2b to
35fdfb9
Compare
hannah-hyj
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 28, 2025
stuartmorgan-g
pushed a commit
to flutter/packages
that referenced
this pull request
Mar 28, 2025
Manual roll Flutter from b16430b to 1d954f4 (114 revisions) Manual roll requested by [email protected] flutter/flutter@b16430b...1d954f4 2025-03-17 [email protected] Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutter#165350) 2025-03-17 [email protected] Roll Skia from fa669e2e6d12 to 52130e5c3b34 (4 revisions) (flutter/flutter#165348) 2025-03-17 [email protected] `OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal` rebuilds. (flutter/flutter#165331) 2025-03-17 [email protected] [web][a11y]Delete _childContainerElement (flutter/flutter#163662) 2025-03-17 [email protected] Roll Skia from e45207898e60 to fa669e2e6d12 (8 revisions) (flutter/flutter#165342) 2025-03-17 [email protected] Add documentation for Java test filtering to plugins test document (flutter/flutter#165314) 2025-03-17 [email protected] Roll Fuchsia Linux SDK from SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313) 2025-03-17 [email protected] Roll Dart SDK from 9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310) 2025-03-17 [email protected] feat(Tooltip): replace the height parameter with constraints (flutter/flutter#163314) 2025-03-17 [email protected] Fix arrowHeadColor breaks differentiation between states (flutter/flutter#165178) 2025-03-17 [email protected] Removes assumption that basis scalar and rounded_scalar match (flutter/flutter#165166) 2025-03-17 [email protected] Roll Skia from 69cf4c2c5db8 to e45207898e60 (1 revision) (flutter/flutter#165300) 2025-03-17 [email protected] Refactor: Move sliders value indicator shape to seperate file (flutter/flutter#162858) 2025-03-17 [email protected] Roll Skia from 3931c31032c7 to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288) 2025-03-17 [email protected] Delete `docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258) 2025-03-16 [email protected] Roll Skia from 3413a02d6fc8 to 3931c31032c7 (1 revision) (flutter/flutter#165277) 2025-03-16 [email protected] Roll Fuchsia Linux SDK from LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275) 2025-03-16 [email protected] Roll Dart SDK from 067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269) 2025-03-16 [email protected] Roll Skia from f124daeb564d to 3413a02d6fc8 (1 revision) (flutter/flutter#165263) 2025-03-15 [email protected] Roll Dart SDK from 40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262) 2025-03-15 [email protected] Roll Fuchsia Linux SDK from efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252) 2025-03-15 [email protected] Roll Dart SDK from f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250) 2025-03-15 [email protected] Roll Dart SDK from 8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246) 2025-03-15 [email protected] Roll Skia from 4568e766ed0a to f124daeb564d (1 revision) (flutter/flutter#165245) 2025-03-15 [email protected] Revert "Prevent explicit roles from merging (#164732)" (flutter/flutter#165222) 2025-03-15 [email protected] Roll Skia from bac6e76abfc7 to 4568e766ed0a (5 revisions) (flutter/flutter#165241) 2025-03-14 [email protected] Roll Dart SDK from a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227) 2025-03-14 [email protected] Roll Skia from 98b6922deecf to bac6e76abfc7 (5 revisions) (flutter/flutter#165225) 2025-03-14 [email protected] Point ktlint AS docs to the `.editorconfig` that is actually used by ci, instead of making a copy in the README (flutter/flutter#165213) 2025-03-14 [email protected] Add remaining dart fixes for Color deprecations when importing painting.dart (flutter/flutter#162609) 2025-03-14 [email protected] [Accessibility] Add required semantics flags (flutter/flutter#164585) 2025-03-14 [email protected] Roll Skia from f4467ff38f1f to 98b6922deecf (5 revisions) (flutter/flutter#165215) 2025-03-14 [email protected] Convert `BaseFlutterTask` From Groovy to Kotlin (flutter/flutter#163148) 2025-03-14 [email protected] `OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034) 2025-03-14 [email protected] Remove redundant `useMaterial3: true` (flutter/flutter#163376) 2025-03-14 [email protected] Roll Packages from 9cc6f37 to ff7724c (1 revision) (flutter/flutter#165197) 2025-03-14 [email protected] Changelog updates from 3.29.2 (flutter/flutter#165194) 2025-03-14 [email protected] Roll Dart SDK from 576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191) 2025-03-14 [email protected] Roll Dart SDK from ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180) 2025-03-14 [email protected] Roll Fuchsia Linux SDK from qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175) 2025-03-14 [email protected] [Impeller] Enable mediatek on API 34+. (flutter/flutter#165156) 2025-03-14 [email protected] Roll Dart SDK from cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159) 2025-03-13 [email protected] [FGP conversion] Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143) 2025-03-13 [email protected] Prevent explicit roles from merging (flutter/flutter#164732) ...
vashworth
pushed a commit
to vashworth/packages
that referenced
this pull request
Mar 31, 2025
…8922) Manual roll Flutter from b16430b to 1d954f4 (114 revisions) Manual roll requested by [email protected] flutter/flutter@b16430b...1d954f4 2025-03-17 [email protected] Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutter#165350) 2025-03-17 [email protected] Roll Skia from fa669e2e6d12 to 52130e5c3b34 (4 revisions) (flutter/flutter#165348) 2025-03-17 [email protected] `OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal` rebuilds. (flutter/flutter#165331) 2025-03-17 [email protected] [web][a11y]Delete _childContainerElement (flutter/flutter#163662) 2025-03-17 [email protected] Roll Skia from e45207898e60 to fa669e2e6d12 (8 revisions) (flutter/flutter#165342) 2025-03-17 [email protected] Add documentation for Java test filtering to plugins test document (flutter/flutter#165314) 2025-03-17 [email protected] Roll Fuchsia Linux SDK from SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313) 2025-03-17 [email protected] Roll Dart SDK from 9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310) 2025-03-17 [email protected] feat(Tooltip): replace the height parameter with constraints (flutter/flutter#163314) 2025-03-17 [email protected] Fix arrowHeadColor breaks differentiation between states (flutter/flutter#165178) 2025-03-17 [email protected] Removes assumption that basis scalar and rounded_scalar match (flutter/flutter#165166) 2025-03-17 [email protected] Roll Skia from 69cf4c2c5db8 to e45207898e60 (1 revision) (flutter/flutter#165300) 2025-03-17 [email protected] Refactor: Move sliders value indicator shape to seperate file (flutter/flutter#162858) 2025-03-17 [email protected] Roll Skia from 3931c31032c7 to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288) 2025-03-17 [email protected] Delete `docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258) 2025-03-16 [email protected] Roll Skia from 3413a02d6fc8 to 3931c31032c7 (1 revision) (flutter/flutter#165277) 2025-03-16 [email protected] Roll Fuchsia Linux SDK from LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275) 2025-03-16 [email protected] Roll Dart SDK from 067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269) 2025-03-16 [email protected] Roll Skia from f124daeb564d to 3413a02d6fc8 (1 revision) (flutter/flutter#165263) 2025-03-15 [email protected] Roll Dart SDK from 40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262) 2025-03-15 [email protected] Roll Fuchsia Linux SDK from efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252) 2025-03-15 [email protected] Roll Dart SDK from f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250) 2025-03-15 [email protected] Roll Dart SDK from 8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246) 2025-03-15 [email protected] Roll Skia from 4568e766ed0a to f124daeb564d (1 revision) (flutter/flutter#165245) 2025-03-15 [email protected] Revert "Prevent explicit roles from merging (#164732)" (flutter/flutter#165222) 2025-03-15 [email protected] Roll Skia from bac6e76abfc7 to 4568e766ed0a (5 revisions) (flutter/flutter#165241) 2025-03-14 [email protected] Roll Dart SDK from a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227) 2025-03-14 [email protected] Roll Skia from 98b6922deecf to bac6e76abfc7 (5 revisions) (flutter/flutter#165225) 2025-03-14 [email protected] Point ktlint AS docs to the `.editorconfig` that is actually used by ci, instead of making a copy in the README (flutter/flutter#165213) 2025-03-14 [email protected] Add remaining dart fixes for Color deprecations when importing painting.dart (flutter/flutter#162609) 2025-03-14 [email protected] [Accessibility] Add required semantics flags (flutter/flutter#164585) 2025-03-14 [email protected] Roll Skia from f4467ff38f1f to 98b6922deecf (5 revisions) (flutter/flutter#165215) 2025-03-14 [email protected] Convert `BaseFlutterTask` From Groovy to Kotlin (flutter/flutter#163148) 2025-03-14 [email protected] `OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034) 2025-03-14 [email protected] Remove redundant `useMaterial3: true` (flutter/flutter#163376) 2025-03-14 [email protected] Roll Packages from 9cc6f37 to ff7724c (1 revision) (flutter/flutter#165197) 2025-03-14 [email protected] Changelog updates from 3.29.2 (flutter/flutter#165194) 2025-03-14 [email protected] Roll Dart SDK from 576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191) 2025-03-14 [email protected] Roll Dart SDK from ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180) 2025-03-14 [email protected] Roll Fuchsia Linux SDK from qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175) 2025-03-14 [email protected] [Impeller] Enable mediatek on API 34+. (flutter/flutter#165156) 2025-03-14 [email protected] Roll Dart SDK from cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159) 2025-03-13 [email protected] [FGP conversion] Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143) 2025-03-13 [email protected] Prevent explicit roles from merging (flutter/flutter#164732) ...
CodixNinja
pushed a commit
to CodixNinja/packages
that referenced
this pull request
May 15, 2025
… (#8922) Manual roll Flutter from b16430b2fd57 to 1d954f4e96bd (114 revisions) Manual roll requested by [email protected] flutter/flutter@b16430b...1d954f4 2025-03-17 [email protected] Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutter#165350) 2025-03-17 [email protected] Roll Skia from fa669e2e6d12 to 52130e5c3b34 (4 revisions) (flutter/flutter#165348) 2025-03-17 [email protected] `OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal` rebuilds. (flutter/flutter#165331) 2025-03-17 [email protected] [web][a11y]Delete _childContainerElement (flutter/flutter#163662) 2025-03-17 [email protected] Roll Skia from e45207898e60 to fa669e2e6d12 (8 revisions) (flutter/flutter#165342) 2025-03-17 [email protected] Add documentation for Java test filtering to plugins test document (flutter/flutter#165314) 2025-03-17 [email protected] Roll Fuchsia Linux SDK from SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313) 2025-03-17 [email protected] Roll Dart SDK from 9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310) 2025-03-17 [email protected] feat(Tooltip): replace the height parameter with constraints (flutter/flutter#163314) 2025-03-17 [email protected] Fix arrowHeadColor breaks differentiation between states (flutter/flutter#165178) 2025-03-17 [email protected] Removes assumption that basis scalar and rounded_scalar match (flutter/flutter#165166) 2025-03-17 [email protected] Roll Skia from 69cf4c2c5db8 to e45207898e60 (1 revision) (flutter/flutter#165300) 2025-03-17 [email protected] Refactor: Move sliders value indicator shape to seperate file (flutter/flutter#162858) 2025-03-17 [email protected] Roll Skia from 3931c31032c7 to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288) 2025-03-17 [email protected] Delete `docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258) 2025-03-16 [email protected] Roll Skia from 3413a02d6fc8 to 3931c31032c7 (1 revision) (flutter/flutter#165277) 2025-03-16 [email protected] Roll Fuchsia Linux SDK from LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275) 2025-03-16 [email protected] Roll Dart SDK from 067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269) 2025-03-16 [email protected] Roll Skia from f124daeb564d to 3413a02d6fc8 (1 revision) (flutter/flutter#165263) 2025-03-15 [email protected] Roll Dart SDK from 40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262) 2025-03-15 [email protected] Roll Fuchsia Linux SDK from efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252) 2025-03-15 [email protected] Roll Dart SDK from f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250) 2025-03-15 [email protected] Roll Dart SDK from 8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246) 2025-03-15 [email protected] Roll Skia from 4568e766ed0a to f124daeb564d (1 revision) (flutter/flutter#165245) 2025-03-15 [email protected] Revert "Prevent explicit roles from merging (#164732)" (flutter/flutter#165222) 2025-03-15 [email protected] Roll Skia from bac6e76abfc7 to 4568e766ed0a (5 revisions) (flutter/flutter#165241) 2025-03-14 [email protected] Roll Dart SDK from a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227) 2025-03-14 [email protected] Roll Skia from 98b6922deecf to bac6e76abfc7 (5 revisions) (flutter/flutter#165225) 2025-03-14 [email protected] Point ktlint AS docs to the `.editorconfig` that is actually used by ci, instead of making a copy in the README (flutter/flutter#165213) 2025-03-14 [email protected] Add remaining dart fixes for Color deprecations when importing painting.dart (flutter/flutter#162609) 2025-03-14 [email protected] [Accessibility] Add required semantics flags (flutter/flutter#164585) 2025-03-14 [email protected] Roll Skia from f4467ff38f1f to 98b6922deecf (5 revisions) (flutter/flutter#165215) 2025-03-14 [email protected] Convert `BaseFlutterTask` From Groovy to Kotlin (flutter/flutter#163148) 2025-03-14 [email protected] `OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034) 2025-03-14 [email protected] Remove redundant `useMaterial3: true` (flutter/flutter#163376) 2025-03-14 [email protected] Roll Packages from bdb9c96 to d632936 (1 revision) (flutter/flutter#165197) 2025-03-14 [email protected] Changelog updates from 3.29.2 (flutter/flutter#165194) 2025-03-14 [email protected] Roll Dart SDK from 576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191) 2025-03-14 [email protected] Roll Dart SDK from ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180) 2025-03-14 [email protected] Roll Fuchsia Linux SDK from qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175) 2025-03-14 [email protected] [Impeller] Enable mediatek on API 34+. (flutter/flutter#165156) 2025-03-14 [email protected] Roll Dart SDK from cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159) 2025-03-13 [email protected] [FGP conversion] Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143) 2025-03-13 [email protected] Prevent explicit roles from merging (flutter/flutter#164732) ...
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 21, 2025
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
…8922) Manual roll Flutter from b16430b to 1d954f4 (114 revisions) Manual roll requested by [email protected] flutter/flutter@b16430b...1d954f4 2025-03-17 [email protected] Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutter#165350) 2025-03-17 [email protected] Roll Skia from fa669e2e6d12 to 52130e5c3b34 (4 revisions) (flutter/flutter#165348) 2025-03-17 [email protected] `OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal` rebuilds. (flutter/flutter#165331) 2025-03-17 [email protected] [web][a11y]Delete _childContainerElement (flutter/flutter#163662) 2025-03-17 [email protected] Roll Skia from e45207898e60 to fa669e2e6d12 (8 revisions) (flutter/flutter#165342) 2025-03-17 [email protected] Add documentation for Java test filtering to plugins test document (flutter/flutter#165314) 2025-03-17 [email protected] Roll Fuchsia Linux SDK from SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313) 2025-03-17 [email protected] Roll Dart SDK from 9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310) 2025-03-17 [email protected] feat(Tooltip): replace the height parameter with constraints (flutter/flutter#163314) 2025-03-17 [email protected] Fix arrowHeadColor breaks differentiation between states (flutter/flutter#165178) 2025-03-17 [email protected] Removes assumption that basis scalar and rounded_scalar match (flutter/flutter#165166) 2025-03-17 [email protected] Roll Skia from 69cf4c2c5db8 to e45207898e60 (1 revision) (flutter/flutter#165300) 2025-03-17 [email protected] Refactor: Move sliders value indicator shape to seperate file (flutter/flutter#162858) 2025-03-17 [email protected] Roll Skia from 3931c31032c7 to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288) 2025-03-17 [email protected] Delete `docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258) 2025-03-16 [email protected] Roll Skia from 3413a02d6fc8 to 3931c31032c7 (1 revision) (flutter/flutter#165277) 2025-03-16 [email protected] Roll Fuchsia Linux SDK from LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275) 2025-03-16 [email protected] Roll Dart SDK from 067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269) 2025-03-16 [email protected] Roll Skia from f124daeb564d to 3413a02d6fc8 (1 revision) (flutter/flutter#165263) 2025-03-15 [email protected] Roll Dart SDK from 40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262) 2025-03-15 [email protected] Roll Fuchsia Linux SDK from efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252) 2025-03-15 [email protected] Roll Dart SDK from f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250) 2025-03-15 [email protected] Roll Dart SDK from 8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246) 2025-03-15 [email protected] Roll Skia from 4568e766ed0a to f124daeb564d (1 revision) (flutter/flutter#165245) 2025-03-15 [email protected] Revert "Prevent explicit roles from merging (#164732)" (flutter/flutter#165222) 2025-03-15 [email protected] Roll Skia from bac6e76abfc7 to 4568e766ed0a (5 revisions) (flutter/flutter#165241) 2025-03-14 [email protected] Roll Dart SDK from a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227) 2025-03-14 [email protected] Roll Skia from 98b6922deecf to bac6e76abfc7 (5 revisions) (flutter/flutter#165225) 2025-03-14 [email protected] Point ktlint AS docs to the `.editorconfig` that is actually used by ci, instead of making a copy in the README (flutter/flutter#165213) 2025-03-14 [email protected] Add remaining dart fixes for Color deprecations when importing painting.dart (flutter/flutter#162609) 2025-03-14 [email protected] [Accessibility] Add required semantics flags (flutter/flutter#164585) 2025-03-14 [email protected] Roll Skia from f4467ff38f1f to 98b6922deecf (5 revisions) (flutter/flutter#165215) 2025-03-14 [email protected] Convert `BaseFlutterTask` From Groovy to Kotlin (flutter/flutter#163148) 2025-03-14 [email protected] `OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034) 2025-03-14 [email protected] Remove redundant `useMaterial3: true` (flutter/flutter#163376) 2025-03-14 [email protected] Roll Packages from 9cc6f37 to ff7724c (1 revision) (flutter/flutter#165197) 2025-03-14 [email protected] Changelog updates from 3.29.2 (flutter/flutter#165194) 2025-03-14 [email protected] Roll Dart SDK from 576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191) 2025-03-14 [email protected] Roll Dart SDK from ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180) 2025-03-14 [email protected] Roll Fuchsia Linux SDK from qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175) 2025-03-14 [email protected] [Impeller] Enable mediatek on API 34+. (flutter/flutter#165156) 2025-03-14 [email protected] Roll Dart SDK from cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159) 2025-03-13 [email protected] [FGP conversion] Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143) 2025-03-13 [email protected] Prevent explicit roles from merging (flutter/flutter#164732) ...
zhangyuang
pushed a commit
to zhangyuang/flutter-fork
that referenced
this pull request
Jun 9, 2025
…er#165434) Reland flutter#163662 with some changes 1. when a node's role changes and reparenting it, append children to it 2. Merge optimization from flutter/pull/165352 fix: flutter#45205 ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
…8922) Manual roll Flutter from b16430b to 1d954f4 (114 revisions) Manual roll requested by [email protected] flutter/flutter@b16430b...1d954f4 2025-03-17 [email protected] Revert "[skwasm] Dynamic Threading (#164748)" (flutter/flutter#165350) 2025-03-17 [email protected] Roll Skia from fa669e2e6d12 to 52130e5c3b34 (4 revisions) (flutter/flutter#165348) 2025-03-17 [email protected] `OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal` rebuilds. (flutter/flutter#165331) 2025-03-17 [email protected] [web][a11y]Delete _childContainerElement (flutter/flutter#163662) 2025-03-17 [email protected] Roll Skia from e45207898e60 to fa669e2e6d12 (8 revisions) (flutter/flutter#165342) 2025-03-17 [email protected] Add documentation for Java test filtering to plugins test document (flutter/flutter#165314) 2025-03-17 [email protected] Roll Fuchsia Linux SDK from SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313) 2025-03-17 [email protected] Roll Dart SDK from 9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310) 2025-03-17 [email protected] feat(Tooltip): replace the height parameter with constraints (flutter/flutter#163314) 2025-03-17 [email protected] Fix arrowHeadColor breaks differentiation between states (flutter/flutter#165178) 2025-03-17 [email protected] Removes assumption that basis scalar and rounded_scalar match (flutter/flutter#165166) 2025-03-17 [email protected] Roll Skia from 69cf4c2c5db8 to e45207898e60 (1 revision) (flutter/flutter#165300) 2025-03-17 [email protected] Refactor: Move sliders value indicator shape to seperate file (flutter/flutter#162858) 2025-03-17 [email protected] Roll Skia from 3931c31032c7 to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288) 2025-03-17 [email protected] Delete `docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258) 2025-03-16 [email protected] Roll Skia from 3413a02d6fc8 to 3931c31032c7 (1 revision) (flutter/flutter#165277) 2025-03-16 [email protected] Roll Fuchsia Linux SDK from LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275) 2025-03-16 [email protected] Roll Dart SDK from 067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269) 2025-03-16 [email protected] Roll Skia from f124daeb564d to 3413a02d6fc8 (1 revision) (flutter/flutter#165263) 2025-03-15 [email protected] Roll Dart SDK from 40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262) 2025-03-15 [email protected] Roll Fuchsia Linux SDK from efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252) 2025-03-15 [email protected] Roll Dart SDK from f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250) 2025-03-15 [email protected] Roll Dart SDK from 8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246) 2025-03-15 [email protected] Roll Skia from 4568e766ed0a to f124daeb564d (1 revision) (flutter/flutter#165245) 2025-03-15 [email protected] Revert "Prevent explicit roles from merging (#164732)" (flutter/flutter#165222) 2025-03-15 [email protected] Roll Skia from bac6e76abfc7 to 4568e766ed0a (5 revisions) (flutter/flutter#165241) 2025-03-14 [email protected] Roll Dart SDK from a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227) 2025-03-14 [email protected] Roll Skia from 98b6922deecf to bac6e76abfc7 (5 revisions) (flutter/flutter#165225) 2025-03-14 [email protected] Point ktlint AS docs to the `.editorconfig` that is actually used by ci, instead of making a copy in the README (flutter/flutter#165213) 2025-03-14 [email protected] Add remaining dart fixes for Color deprecations when importing painting.dart (flutter/flutter#162609) 2025-03-14 [email protected] [Accessibility] Add required semantics flags (flutter/flutter#164585) 2025-03-14 [email protected] Roll Skia from f4467ff38f1f to 98b6922deecf (5 revisions) (flutter/flutter#165215) 2025-03-14 [email protected] Convert `BaseFlutterTask` From Groovy to Kotlin (flutter/flutter#163148) 2025-03-14 [email protected] `OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034) 2025-03-14 [email protected] Remove redundant `useMaterial3: true` (flutter/flutter#163376) 2025-03-14 [email protected] Roll Packages from 9cc6f37 to ff7724c (1 revision) (flutter/flutter#165197) 2025-03-14 [email protected] Changelog updates from 3.29.2 (flutter/flutter#165194) 2025-03-14 [email protected] Roll Dart SDK from 576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191) 2025-03-14 [email protected] Roll Dart SDK from ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180) 2025-03-14 [email protected] Roll Fuchsia Linux SDK from qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175) 2025-03-14 [email protected] [Impeller] Enable mediatek on API 34+. (flutter/flutter#165156) 2025-03-14 [email protected] Roll Dart SDK from cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159) 2025-03-13 [email protected] [FGP conversion] Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143) 2025-03-13 [email protected] Prevent explicit roles from merging (flutter/flutter#164732) ...
romanejaquez
pushed a commit
to romanejaquez/flutter
that referenced
this pull request
Aug 14, 2025
delete _childContainerElement , add the rect compensate and scrolling adjustment to the children ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
romanejaquez
pushed a commit
to romanejaquez/flutter
that referenced
this pull request
Aug 14, 2025
…lutter#165416) <!-- start_original_pr_link --> Reverts: flutter#163662 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: hannah-hyj <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: google 3 failure <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: hannah-hyj <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {yjbanov} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: delete _childContainerElement , add the rect compensate and scrolling adjustment to the children ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <[email protected]>
romanejaquez
pushed a commit
to romanejaquez/flutter
that referenced
this pull request
Aug 14, 2025
…er#165434) Reland flutter#163662 with some changes 1. when a node's role changes and reparenting it, append children to it 2. Merge optimization from flutter/pull/165352 fix: flutter#45205 ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delete _childContainerElement , add the rect compensate and scrolling adjustment to the children
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.