[CP][Impeller] Fix crash when using BackdropFilters in certain GLES drivers. #163581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 18, 2025 18:37
…res as single sampled. (flutter#163345) I noticed this causes crashes when doing readback, but only on some deivces. I suspect that this is the more correct binding choice, and other drivers are just more lenient.
github-actions
bot
added
engine
jonahwilliams
added
cp: review
jtmcdole
approved these changes
Feb 19, 2025
eyebrowsoffire
added
the
autosubmit
auto-submit
bot
merged commit 383d56e
into
flutter:flutter-3.29-candidate.0
156 checks passed
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2025
9 tasks
Fintasys
pushed a commit
to Fintasys/flutter
that referenced
this pull request
May 14, 2025
…rivers. (flutter#163581) This is a cherry picked of flutter#163345 and flutter#163327 combined, as they both are parts of the same bug. The issues are: flutter#163304 flutter#163421 And potentially others, though we don't have clear repros or stack traces for all of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry picked of #163345 and #163327 combined, as they both are parts of the same bug.
The issues are:
#163304
#163421
And potentially others, though we don't have clear repros or stack traces for all of them.