Skip to content

Roll pub packages #163567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Feb 27, 2025
Merged

Roll pub packages #163567

auto-submit merged 2 commits into from
Feb 27, 2025

Conversation

@flutter-pub-roller-bot
Copy link
Contributor

@flutter-pub-roller-bot flutter-pub-roller-bot commented Feb 18, 2025

This PR was generated by flutter update-packages --force-upgrade.

@flutter-pub-roller-bot flutter-pub-roller-bot added tool Affects the "flutter" command-line tool. See also t: labels. autosubmit Merge PR when tree becomes green via auto submit App labels Feb 18, 2025
@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin labels Feb 18, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 18, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Feb 18, 2025

autosubmit label was removed for flutter/flutter/163567, because - The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

@goderbauer
Copy link
Member

goderbauer commented Feb 19, 2025 •
edited
Loading

cc @LongCatIsLooong it looks like the custom_rules thingy needs to be updated for this new analyzer version:

dev/bots/custom_rules/render_box_intrinsics.dart:118:78: Error: The getter 'enclosingElement' isn't defined for the class 'Element'.
 - 'Element' is from 'package:analyzer/dart/element/element.dart' ('../.pub-cache/hosted/pub.dev/analyzer-7.3.0/lib/dart/element/element.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named 'enclosingElement'.
    final Element? declaredInClassElement = node.staticElement?.declaration?.enclosingElement;
                                                                             ^^^^^^^^^^^^^^^^

See also https://github.com/dart-lang/sdk/blob/main/pkg/analyzer/CHANGELOG.md#690

@LongCatIsLooong LongCatIsLooong mentioned this pull request Feb 19, 2025
Merged
9 tasks
github-merge-queue bot pushed a commit that referenced this pull request Feb 20, 2025
@LongCatIsLooong
enclosingElement -> enclosingElement3 (#163681)
98fe867 
#163567 (comment)

The old name is deprecated and removed.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
@matanlurey matanlurey removed their request for review February 23, 2025 20:38
@goderbauer goderbauer force-pushed the packages-autoroller-branch-184 branch from 2089471 to 95b4562 Compare February 25, 2025 18:57
@goderbauer goderbauer force-pushed the packages-autoroller-branch-184 branch from 95b4562 to 3bda026 Compare February 25, 2025 23:45
@goderbauer
Copy link
Member

goderbauer commented Feb 26, 2025

@LongCatIsLooong Can you review the changes to the dart file? It's removing overrides for methods that no longer exist (see also https://pub.dev/packages/analyzer/changelog#700).

LongCatIsLooong
LongCatIsLooong approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't seem to find the deprecation corresponds toRemove deprecated File.changes and Folder.changes. in the changelog

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 27, 2025
Merged via the queue into flutter:master with commit 0e91905 Feb 27, 2025
175 of 176 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2025
@engine-flutter-autoroll
0e91905 Roll pub packages (flutter/flutter#163567)
b3d7fa2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2025
@engine-flutter-autoroll
0e91905 Roll pub packages (flutter/flutter#163567)
eb565bb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2025
@engine-flutter-autoroll
0e91905 Roll pub packages (flutter/flutter#163567)
f620dc7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2025
@engine-flutter-autoroll
0e91905 Roll pub packages (flutter/flutter#163567)
541aa00
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2025
@engine-flutter-autoroll
0e91905 Roll pub packages (flutter/flutter#163567)
fa4fa56
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2025
@engine-flutter-autoroll
0e91905 Roll pub packages (flutter/flutter#163567)
98d4db0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2025
@engine-flutter-autoroll
0e91905 Roll pub packages (flutter/flutter#163567)
e2ff0c7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2025
@engine-flutter-autoroll
0e91905 Roll pub packages (flutter/flutter#163567)
6d2a570
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2025
@engine-flutter-autoroll
0e91905 Roll pub packages (flutter/flutter#163567)
5f2f4a0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2025
@engine-flutter-autoroll
0e91905 Roll pub packages (flutter/flutter#163567)
69623ad
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
0e91905 Roll pub packages (flutter/flutter#163567)
93b1d69
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
0e91905 Roll pub packages (flutter/flutter#163567)
82ffbdd
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
0e91905 Roll pub packages (flutter/flutter#163567)
a8b0b4e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LongCatIsLooong LongCatIsLooong LongCatIsLooong approved these changes

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@flutter-pub-roller-bot @goderbauer @LongCatIsLooong @fluttergithubbot