Skip to content

SliverMainAxisGroup multiple PinnedHeaderSliver children #163528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Feb 25, 2025
Merged

SliverMainAxisGroup multiple PinnedHeaderSliver children #163528

auto-submit merged 1 commit into from
Feb 25, 2025

Conversation

@yiiim
Copy link
Member

@yiiim yiiim commented Feb 18, 2025

Fixes: #155758

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Feb 18, 2025
@yiiim yiiim mentioned this pull request Feb 18, 2025
Closed
9 tasks
@yiiim yiiim requested a review from Piinks February 18, 2025 11:02
Piinks
Piinks approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a new PR, and for fixing the original blocking bug! 🎊
This LGTM!

@yiiim yiiim added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 25, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 25, 2025
Merged via the queue into flutter:master with commit 4e39d13 Feb 25, 2025
74 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 25, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
4e39d13 SliverMainAxisGroup multiple PinnedHeaderSliver children (flu…
211545f 
…tter/flutter#163528)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
4e39d13 SliverMainAxisGroup multiple PinnedHeaderSliver children (flu…
1f49061 
…tter/flutter#163528)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
4e39d13 SliverMainAxisGroup multiple PinnedHeaderSliver children (flu…
cc9de46 
…tter/flutter#163528)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
4e39d13 SliverMainAxisGroup multiple PinnedHeaderSliver children (flu…
42cf546 
…tter/flutter#163528)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
4e39d13 SliverMainAxisGroup multiple PinnedHeaderSliver children (flu…
f04e6c9 
…tter/flutter#163528)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
4e39d13 SliverMainAxisGroup multiple PinnedHeaderSliver children (flu…
0ef37a3 
…tter/flutter#163528)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
4e39d13 SliverMainAxisGroup multiple PinnedHeaderSliver children (flu…
6cc662b 
…tter/flutter#163528)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
4e39d13 SliverMainAxisGroup multiple PinnedHeaderSliver children (flu…
4be84bc 
…tter/flutter#163528)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
4e39d13 SliverMainAxisGroup multiple PinnedHeaderSliver children (flu…
d0e0a20 
…tter/flutter#163528)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
4e39d13 SliverMainAxisGroup multiple PinnedHeaderSliver children (flu…
240055c 
…tter/flutter#163528)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
4e39d13 SliverMainAxisGroup multiple PinnedHeaderSliver children (flu…
aa12713 
…tter/flutter#163528)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
4e39d13 SliverMainAxisGroup multiple PinnedHeaderSliver children (flu…
afc1f5d 
…tter/flutter#163528)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
4e39d13 SliverMainAxisGroup multiple PinnedHeaderSliver children (flu…
c107dbd 
…tter/flutter#163528)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2025
@engine-flutter-autoroll
4e39d13 SliverMainAxisGroup multiple PinnedHeaderSliver children (flu…
c51b02b 
…tter/flutter#163528)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2025
@engine-flutter-autoroll
4e39d13 SliverMainAxisGroup multiple PinnedHeaderSliver children (flu…
59edec2 
…tter/flutter#163528)
@Piinks Piinks mentioned this pull request Mar 7, 2025
Open
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
4e39d13 SliverMainAxisGroup multiple PinnedHeaderSliver children (flu…
924797f 
…tter/flutter#163528)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
4e39d13 SliverMainAxisGroup multiple PinnedHeaderSliver children (flu…
1b4c07a 
…tter/flutter#163528)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
4e39d13 SliverMainAxisGroup multiple PinnedHeaderSliver children (flu…
5c932c1 
…tter/flutter#163528)
@HeinrichJanzing HeinrichJanzing mentioned this pull request Jul 23, 2025
Closed
2 tasks
@tirth-patel-nc tirth-patel-nc mentioned this pull request Aug 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Multiple Pinned headers should work within a SliverMainAxisGroup

2 participants

@yiiim @Piinks