Add BorderRadiusGeometry to Divider Widget for Customisable Border Radius #163414
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
github-actions
bot
added
framework
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
dkwingsmt
left a comment
dkwingsmt
left a comment
There was a problem hiding this comment.
LGTM! Sorry for the late review.
no problem. it was my first PR so I was a bit excited to merge it as well 😊 |
|
Nice to hear! I'll let a 2nd reviewer review and if approved we'll add the autosubmit label. |
MitchellGoodwin
left a comment
MitchellGoodwin
left a comment
There was a problem hiding this comment.
LGTM! Just needs some documentation adjustments.
| /// also null, then this defaults to 0.0. | ||
| final double? endIndent; | ||
|
|
||
| /// The amount of radius for the border of the divider |
There was a problem hiding this comment.
Nit: Documentation should have punctuation. So this needs a period.
There was a problem hiding this comment.
Done. please check.
|
|
||
| /// The amount of radius for the border of the divider | ||
| /// | ||
| /// if this is null, then the default radius of [BoxDecoration] will be used |
There was a problem hiding this comment.
Nit: "if" -> "If" and add a period.
|
|
||
| /// The amount of radius for the border of the divider | ||
| /// | ||
| /// if this is null, then the default radius of [BoxDecoration] will be used |
There was a problem hiding this comment.
Thanks. Please check now
MitchellGoodwin
left a comment
MitchellGoodwin
left a comment
There was a problem hiding this comment.
LGTM! Thank you for taking the time to make this fix.
|
@dkwingsmt sorry. I accidentally clicked Re-request review on you! |
dkwingsmt
added
the
autosubmit
|
autosubmit label was removed for flutter/flutter/163414, because - The status or check suite Linux customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
4 participants
This PR fixes #162239 . Now, you can add border radius to divider. It is needed when you have a thick divider and almost all the thick dividers need a radius.
Example Usage:
Divider( height: 20, thickness: 5, color: Colors.blue, + radius: BorderRadius.all(Radius.circular(20)), );VerticalDivider( height: 20, thickness: 5, color: Colors.blue, + radius: BorderRadius.all(Radius.circular(20)), );Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.