Skip to content

Add a test to run on Galaxy S24 #163357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Feb 19, 2025
Merged

Add a test to run on Galaxy S24 #163357

auto-submit merged 2 commits into from
Feb 19, 2025

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Feb 15, 2025 •
edited
Loading

S24 is only hooked up in the try pool at the moment, so this will fail in the staging pool after landing, following which we can run the test in a second PR in presubmit by changing presubmit to true.

For #162639

jonahwilliams
jonahwilliams approved these changes Feb 15, 2025
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso
Add a test to run on Galaxy S24
cc496b6 
S24 is only hooked up in the try pool at the moment, so this will fail after landing, following which we can run the test in a second PR in presubmit by removing changing `presubmit` to `true.
@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 18, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 18, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Feb 18, 2025

autosubmit label was removed for flutter/flutter/163357, because - The status or check suite Windows tool_integration_tests_2_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 18, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 19, 2025
Merged via the queue into master with commit 41d3fa7 Feb 19, 2025
154 of 155 checks passed
@auto-submit auto-submit bot deleted the zanderso-patch-2 branch February 19, 2025 21:26
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 19, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 20, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
41d3fa7 Add a test to run on Galaxy S24 (flutter/flutter#163357)
c13a54c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 20, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
41d3fa7 Add a test to run on Galaxy S24 (flutter/flutter#163357)
b1c5e45
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 20, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
41d3fa7 Add a test to run on Galaxy S24 (flutter/flutter#163357)
dcc2ac8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 20, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
41d3fa7 Add a test to run on Galaxy S24 (flutter/flutter#163357)
6e7e0a5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 21, 2025
@engine-flutter-autoroll
41d3fa7 Add a test to run on Galaxy S24 (flutter/flutter#163357)
ee174f8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 21, 2025
@engine-flutter-autoroll
41d3fa7 Add a test to run on Galaxy S24 (flutter/flutter#163357)
16c6e48
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 21, 2025
@engine-flutter-autoroll
41d3fa7 Add a test to run on Galaxy S24 (flutter/flutter#163357)
094786c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 21, 2025
@engine-flutter-autoroll
41d3fa7 Add a test to run on Galaxy S24 (flutter/flutter#163357)
c662ccd
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 21, 2025
@engine-flutter-autoroll
41d3fa7 Add a test to run on Galaxy S24 (flutter/flutter#163357)
f93082c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2025
@engine-flutter-autoroll
41d3fa7 Add a test to run on Galaxy S24 (flutter/flutter#163357)
0dde77c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2025
@engine-flutter-autoroll
41d3fa7 Add a test to run on Galaxy S24 (flutter/flutter#163357)
e5e20a1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2025
@engine-flutter-autoroll
41d3fa7 Add a test to run on Galaxy S24 (flutter/flutter#163357)
db3a5e4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2025
@engine-flutter-autoroll
41d3fa7 Add a test to run on Galaxy S24 (flutter/flutter#163357)
5b4ad53
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2025
@engine-flutter-autoroll
41d3fa7 Add a test to run on Galaxy S24 (flutter/flutter#163357)
841bcc4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2025
@engine-flutter-autoroll
41d3fa7 Add a test to run on Galaxy S24 (flutter/flutter#163357)
258effd
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2025
@engine-flutter-autoroll
41d3fa7 Add a test to run on Galaxy S24 (flutter/flutter#163357)
9914d65
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2025
@engine-flutter-autoroll
41d3fa7 Add a test to run on Galaxy S24 (flutter/flutter#163357)
3bbcbf3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2025
@engine-flutter-autoroll
41d3fa7 Add a test to run on Galaxy S24 (flutter/flutter#163357)
87dbcd5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2025
@engine-flutter-autoroll
41d3fa7 Add a test to run on Galaxy S24 (flutter/flutter#163357)
6d4c5f7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2025
@engine-flutter-autoroll
41d3fa7 Add a test to run on Galaxy S24 (flutter/flutter#163357)
e5b75be
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
41d3fa7 Add a test to run on Galaxy S24 (flutter/flutter#163357)
88393df
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
41d3fa7 Add a test to run on Galaxy S24 (flutter/flutter#163357)
434066c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
41d3fa7 Add a test to run on Galaxy S24 (flutter/flutter#163357)
dfbc4e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zanderso @jonahwilliams