Skip to content

[ui] Fix ImageFilter.shader equality to consider uniform values. #163348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Feb 24, 2025
Merged

[ui] Fix ImageFilter.shader equality to consider uniform values. #163348

auto-submit merged 2 commits into from
Feb 24, 2025

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Feb 14, 2025 •
edited
Loading

Fixes #163302

Framework widgets check for ImageFIlter.== to determine whether to mark themselves dirty. The filter obejct needs to delegate its equality to the underlying native filter so that uniform values are considered.

@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Feb 14, 2025
@jonahwilliams jonahwilliams changed the title [ui] treat ImageFilter.shader as not being equal to itself. [ui] Fix ImageFilter.shader equality to consider uniform values. Feb 24, 2025
@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 24, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 24, 2025
Merged via the queue into flutter:master with commit 1e2583e Feb 24, 2025
175 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 24, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
1e2583e [ui] Fix ImageFilter.shader equality to consider uniform valu…
12f4663 
…es. (flutter/flutter#163348)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
1e2583e [ui] Fix ImageFilter.shader equality to consider uniform valu…
7cca6c2 
…es. (flutter/flutter#163348)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
1e2583e [ui] Fix ImageFilter.shader equality to consider uniform valu…
f6b18dd 
…es. (flutter/flutter#163348)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
1e2583e [ui] Fix ImageFilter.shader equality to consider uniform valu…
7f8f9e7 
…es. (flutter/flutter#163348)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
1e2583e [ui] Fix ImageFilter.shader equality to consider uniform valu…
20801d6 
…es. (flutter/flutter#163348)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
1e2583e [ui] Fix ImageFilter.shader equality to consider uniform valu…
63737f6 
…es. (flutter/flutter#163348)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2025
@engine-flutter-autoroll
1e2583e [ui] Fix ImageFilter.shader equality to consider uniform valu…
3af8bd7 
…es. (flutter/flutter#163348)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
1e2583e [ui] Fix ImageFilter.shader equality to consider uniform valu…
157117f 
…es. (flutter/flutter#163348)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
1e2583e [ui] Fix ImageFilter.shader equality to consider uniform valu…
c38982b 
…es. (flutter/flutter#163348)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
1e2583e [ui] Fix ImageFilter.shader equality to consider uniform valu…
33d43bd 
…es. (flutter/flutter#163348)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
1e2583e [ui] Fix ImageFilter.shader equality to consider uniform valu…
3fc2cb5 
…es. (flutter/flutter#163348)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
1e2583e [ui] Fix ImageFilter.shader equality to consider uniform valu…
dab45d3 
…es. (flutter/flutter#163348)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2025
@engine-flutter-autoroll
1e2583e [ui] Fix ImageFilter.shader equality to consider uniform valu…
92c3198 
…es. (flutter/flutter#163348)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2025
@engine-flutter-autoroll
1e2583e [ui] Fix ImageFilter.shader equality to consider uniform valu…
df35921 
…es. (flutter/flutter#163348)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2025
@engine-flutter-autoroll
1e2583e [ui] Fix ImageFilter.shader equality to consider uniform valu…
705fa2f 
…es. (flutter/flutter#163348)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
1e2583e [ui] Fix ImageFilter.shader equality to consider uniform valu…
f4488ed 
…es. (flutter/flutter#163348)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
1e2583e [ui] Fix ImageFilter.shader equality to consider uniform valu…
f1790f0 
…es. (flutter/flutter#163348)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
1e2583e [ui] Fix ImageFilter.shader equality to consider uniform valu…
af3ea86 
…es. (flutter/flutter#163348)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matanlurey matanlurey matanlurey approved these changes

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ImageFiltered with a ImageFilter.shader does not update when updating the passed shader (e.g. shader.setFloat())

2 participants

@jonahwilliams @matanlurey