-
Notifications
You must be signed in to change notification settings - Fork 29.7k
[ Widget Preview ] Invalidate scaffold project if SDK changes and regenerate pubspec on change #163343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… code `flutter widget-preview start` will now look for functions annotated with `@Preview()` within the developer's project. These functions will be used to generate `.dart_tool/widget_preview_scaffold/lib/generated_preview.dart`, which inserts the returned value from each preview function into a `List<WidgetPreview>` returned from a `previews()` method that is invoked by the widget preview scaffold root.
…preview scaffold This also wires up the preview detector to trigger hot reloads when new previews are detected or previews are removed. Note: while this change results in lib/generated_preview.dart being generated and updated, it's not currently referenced by lib/main.dart and the preview environment will render a black screen.
… preview rendering With this change, `flutter widget-preview start` will launch a working widget preview environment that can render previews from a target project. Also fixes an issue where `--offline` wasn't being respected by some pub operations.
…enerated pubspec on change
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 20, 2025
… and regenerate pubspec on change (flutter/flutter#163343)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 20, 2025
… and regenerate pubspec on change (flutter/flutter#163343)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 20, 2025
… and regenerate pubspec on change (flutter/flutter#163343)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 20, 2025
… and regenerate pubspec on change (flutter/flutter#163343)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 21, 2025
… and regenerate pubspec on change (flutter/flutter#163343)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 21, 2025
… and regenerate pubspec on change (flutter/flutter#163343)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 21, 2025
… and regenerate pubspec on change (flutter/flutter#163343)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 21, 2025
… and regenerate pubspec on change (flutter/flutter#163343)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 21, 2025
… and regenerate pubspec on change (flutter/flutter#163343)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 22, 2025
… and regenerate pubspec on change (flutter/flutter#163343)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 22, 2025
… and regenerate pubspec on change (flutter/flutter#163343)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 22, 2025
… and regenerate pubspec on change (flutter/flutter#163343)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 22, 2025
… and regenerate pubspec on change (flutter/flutter#163343)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 23, 2025
… and regenerate pubspec on change (flutter/flutter#163343)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 23, 2025
… and regenerate pubspec on change (flutter/flutter#163343)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 24, 2025
… and regenerate pubspec on change (flutter/flutter#163343)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 24, 2025
… and regenerate pubspec on change (flutter/flutter#163343)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 24, 2025
… and regenerate pubspec on change (flutter/flutter#163343)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 24, 2025
… and regenerate pubspec on change (flutter/flutter#163343)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 24, 2025
… and regenerate pubspec on change (flutter/flutter#163343)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
… and regenerate pubspec on change (flutter/flutter#163343)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
… and regenerate pubspec on change (flutter/flutter#163343)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 21, 2025
… and regenerate pubspec on change (flutter/flutter#163343)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the Flutter SDK is updated we need to invalidate the widget preview scaffold project to, at the very least, rebuild the precompiled application. Similarly, if the root project's
pubspec.yamlis updated, the scaffold project's pubspec should be regenerated.This change adds a
preview_manifest.jsonto the scaffold project which contains information related to:This information is used to determine whether or not the scaffold project needs to be regenerated or the scaffold pubspec needs to be updated to reflect changes to the root project's pubspec since the previewer was last run.