Skip to content

feat(Tooltip): replace the height parameter with constraints #163314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Mar 17, 2025
Merged

feat(Tooltip): replace the height parameter with constraints #163314

auto-submit merged 1 commit into from
Mar 17, 2025

Conversation

@kszczek
Copy link
Contributor

@kszczek kszczek commented Feb 14, 2025

Introduce a new constraints parameter, which constrains the size of the tooltip's message and deprecate the now obsolete height parameter. Do the same for the theme data, while also making some minor changes to the docs to clear up some misconceptions about which properties apply to the tooltip's message and which to the tooltip's child.

To make the transition from height to constraints as easy as possible for our users, introduce fix data to do this replacement automatically in the IDE.

Closes: #163313

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos c: tech-debt Technical debt, code quality, testing, etc. labels Feb 14, 2025
@kszczek kszczek force-pushed the tooltip-constraints branch 2 times, most recently from e9327ea to 40ae181 Compare February 14, 2025 16:32
chunhtai
chunhtai reviewed Feb 14, 2025
View reviewed changes
@kszczek kszczek force-pushed the tooltip-constraints branch 4 times, most recently from 9590a8a to 054c46f Compare February 20, 2025 11:11
@kszczek

This comment was marked as resolved.

Sign in to view
@Piinks
Copy link
Contributor

Piinks commented Feb 25, 2025

Hey @kszczek I think where you have 'null' in the fix yaml, it should be ''. In dart fix I don't think it will evaluate these arguments as null, they will just be blank.

@Piinks
Copy link
Contributor

Piinks commented Feb 25, 2025

Also, I am not sure some of this is written in the way we expect the code to be

 - if: "height == 'null'"
        changes:
          - kind: "removeParameter"
            name: "height"

Does this mean if no height is provided, we should remove height? I think maybe the if here should be height != '', to remove it if it is provided in the users code.
Although, this would also be incorrect since is it oneOf. That would mean the fix would apply only one if and then ignore the rest.

@kszczek
Copy link
Contributor Author

kszczek commented Feb 25, 2025

Hi, thanks for taking a look!

I think where you have 'null' in the fix yaml, it should be ''. In dart fix I don't think it will evaluate these arguments as null, they will just be blank.

Yes, when the height parameter is missing then it will be reported as blank.

Does this mean if no height is provided, we should remove height? I think maybe the if here should be height != '', to remove it if it is provided in the users code.
Although, this would also be incorrect since is it oneOf. That would mean the fix would apply only one if and then ignore the rest.

There are three scenarios in which we want to take action:

  1. if: "height == 'null'" - this condition is not meant to represent "if height was not provided", but rather "user explicitly placed a height: null parameter". This is quite unlikely though, as null is the default value anyway so setting it to null explicitly is basically a no-op, but in case someone has this dead code then let's clean up by simply removing it.

Now the ordering of those fixes is important, because if the first condition was not met, then in the remaining two conditionals we can assume that height is either not present or not null.

  1. if: "constraints == '' && height != ''" - constraints are not provided, but height is and we know it's not null. In this case we simply add constraints and remove height.
  2. if: "constraints == 'null' && height != ''" - user explicitly set constraints: null, and set some non-null height. In this case, we first remove the constraints: null, add constraints with the height's value, and remove height.

Let me know if I unnecessarily overcomplicated this fix 😄

@kszczek kszczek force-pushed the tooltip-constraints branch from 054c46f to 129ab89 Compare February 25, 2025 23:37
@kszczek
Copy link
Contributor Author

kszczek commented Feb 25, 2025

It turns out I forgot to mark the height parameter of the TooltipThemeData.copyWith as deprecated and that is the reason why dart fix wouldn't make the substitution.

This is now properly ready for review.

@kszczek
Copy link
Contributor Author

kszczek commented Feb 25, 2025

Also - a few of the existing tests use the height parameter. Should I refactor those tests in this PR along with the deprecation, or is this something that should be done when the parameter is going to be removed?

@kszczek kszczek force-pushed the tooltip-constraints branch 3 times, most recently from d66f209 to 9fb508b Compare February 26, 2025 09:53
@Piinks
Copy link
Contributor

Piinks commented Mar 5, 2025

Also - a few of the existing tests use the height parameter. Should I refactor those tests in this PR along with the deprecation, or is this something that should be done when the parameter is going to be removed?

No, having them in place during the deprecation period ensures we do not break anyone during the deprecation period. :)

Piinks
Piinks reviewed Mar 5, 2025
View reviewed changes
@kszczek kszczek force-pushed the tooltip-constraints branch from 9fb508b to 6c6ac91 Compare March 5, 2025 22:52
@kszczek
feat(Tooltip): replace the height parameter with constraints
a8d0b7a 
Introduce a new `constraints` parameter, which constrains the size of
the tooltip's message and deprecate the now obsolete `height` parameter.
Do the same for the theme data, while also making some minor changes to
the docs to clear up some misconceptions about which properties apply
to the tooltip's message and which to the tooltip's child.

To make the transition from `height` to `constraints` as easy as
possible for our users, introduce fix data to do this replacement
automatically in the IDE.
@kszczek kszczek force-pushed the tooltip-constraints branch from 6c6ac91 to a8d0b7a Compare March 6, 2025 09:26
@dkwingsmt
Copy link
Contributor

dkwingsmt commented Mar 12, 2025

@Piinks @chunhtai Seems like comments have been addressed. Can you take a look?

@chunhtai chunhtai self-requested a review March 12, 2025 18:58
Piinks
Piinks approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thank you!

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
9d2b6da feat(Tooltip): replace the height parameter with constraints (f…
72ed67b 
…lutter/flutter#163314)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
9d2b6da feat(Tooltip): replace the height parameter with constraints (f…
22201d9 
…lutter/flutter#163314)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
9d2b6da feat(Tooltip): replace the height parameter with constraints (f…
88304b0 
…lutter/flutter#163314)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
9d2b6da feat(Tooltip): replace the height parameter with constraints (f…
90157d8 
…lutter/flutter#163314)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
9d2b6da feat(Tooltip): replace the height parameter with constraints (f…
2267678 
…lutter/flutter#163314)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
9d2b6da feat(Tooltip): replace the height parameter with constraints (f…
50aff19 
…lutter/flutter#163314)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
9d2b6da feat(Tooltip): replace the height parameter with constraints (f…
ca078a9 
…lutter/flutter#163314)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
9d2b6da feat(Tooltip): replace the height parameter with constraints (f…
45de5f5 
…lutter/flutter#163314)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
9d2b6da feat(Tooltip): replace the height parameter with constraints (f…
aaf46b0 
…lutter/flutter#163314)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
9d2b6da feat(Tooltip): replace the height parameter with constraints (f…
7440c9c 
…lutter/flutter#163314)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
9d2b6da feat(Tooltip): replace the height parameter with constraints (f…
3c53a35 
…lutter/flutter#163314)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
9d2b6da feat(Tooltip): replace the height parameter with constraints (f…
b1c99ea 
…lutter/flutter#163314)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
9d2b6da feat(Tooltip): replace the height parameter with constraints (f…
98847df 
…lutter/flutter#163314)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
9d2b6da feat(Tooltip): replace the height parameter with constraints (f…
8f06463 
…lutter/flutter#163314)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
9d2b6da feat(Tooltip): replace the height parameter with constraints (f…
390c126 
…lutter/flutter#163314)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
9d2b6da feat(Tooltip): replace the height parameter with constraints (f…
d033aaa 
…lutter/flutter#163314)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
9d2b6da feat(Tooltip): replace the height parameter with constraints (f…
73e7cf9 
…lutter/flutter#163314)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
9d2b6da feat(Tooltip): replace the height parameter with constraints (f…
9f71fc7 
…lutter/flutter#163314)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
9d2b6da feat(Tooltip): replace the height parameter with constraints (f…
6ba3874 
…lutter/flutter#163314)
stuartmorgan-g pushed a commit to flutter/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
Manual roll Flutter from b16430b to 1d954f4 (114 revisions) (#8922)
a1b1cf1 
Manual roll Flutter from b16430b to 1d954f4 (114 revisions)

Manual roll requested by [email protected]

flutter/flutter@b16430b...1d954f4

2025-03-17 [email protected] Revert "[skwasm] Dynamic Threading
(#164748)" (flutter/flutter#165350)
2025-03-17 [email protected] Roll Skia from fa669e2e6d12
to 52130e5c3b34 (4 revisions) (flutter/flutter#165348)
2025-03-17 [email protected]
`OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal`
rebuilds. (flutter/flutter#165331)
2025-03-17 [email protected] [web][a11y]Delete
_childContainerElement (flutter/flutter#163662)
2025-03-17 [email protected] Roll Skia from e45207898e60
to fa669e2e6d12 (8 revisions) (flutter/flutter#165342)
2025-03-17 [email protected] Add documentation for Java test
filtering to plugins test document (flutter/flutter#165314)
2025-03-17 [email protected] Roll Fuchsia Linux SDK from
SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313)
2025-03-17 [email protected] Roll Dart SDK from
9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310)
2025-03-17 [email protected] feat(Tooltip): replace the height parameter
with constraints (flutter/flutter#163314)
2025-03-17 [email protected] Fix arrowHeadColor breaks differentiation
between states (flutter/flutter#165178)
2025-03-17 [email protected] Removes
assumption that basis scalar and rounded_scalar match
(flutter/flutter#165166)
2025-03-17 [email protected] Roll Skia from 69cf4c2c5db8
to e45207898e60 (1 revision) (flutter/flutter#165300)
2025-03-17 [email protected] Refactor: Move
sliders value indicator shape to seperate file (flutter/flutter#162858)
2025-03-17 [email protected] Roll Skia from 3931c31032c7
to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288)
2025-03-17 [email protected] Delete
`docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258)
2025-03-16 [email protected] Roll Skia from 3413a02d6fc8
to 3931c31032c7 (1 revision) (flutter/flutter#165277)
2025-03-16 [email protected] Roll Fuchsia Linux SDK from
LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275)
2025-03-16 [email protected] Roll Dart SDK from
067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269)
2025-03-16 [email protected] Roll Skia from f124daeb564d
to 3413a02d6fc8 (1 revision) (flutter/flutter#165263)
2025-03-15 [email protected] Roll Dart SDK from
40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262)
2025-03-15 [email protected] Roll Fuchsia Linux SDK from
efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252)
2025-03-15 [email protected] Roll Dart SDK from
f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250)
2025-03-15 [email protected] Roll Dart SDK from
8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246)
2025-03-15 [email protected] Roll Skia from 4568e766ed0a
to f124daeb564d (1 revision) (flutter/flutter#165245)
2025-03-15 [email protected] Revert "Prevent
explicit roles from merging (#164732)" (flutter/flutter#165222)
2025-03-15 [email protected] Roll Skia from bac6e76abfc7
to 4568e766ed0a (5 revisions) (flutter/flutter#165241)
2025-03-14 [email protected] Roll Dart SDK from
a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227)
2025-03-14 [email protected] Roll Skia from 98b6922deecf
to bac6e76abfc7 (5 revisions) (flutter/flutter#165225)
2025-03-14 [email protected] Point ktlint AS
docs to the `.editorconfig` that is actually used by ci, instead of
making a copy in the README (flutter/flutter#165213)
2025-03-14 [email protected] Add remaining dart fixes for Color
deprecations when importing painting.dart (flutter/flutter#162609)
2025-03-14 [email protected] [Accessibility]
Add required semantics flags (flutter/flutter#164585)
2025-03-14 [email protected] Roll Skia from f4467ff38f1f
to 98b6922deecf (5 revisions) (flutter/flutter#165215)
2025-03-14 [email protected] Convert `BaseFlutterTask` From Groovy
to Kotlin (flutter/flutter#163148)
2025-03-14 [email protected]
`OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034)
2025-03-14 [email protected] Remove redundant `useMaterial3: true`
(flutter/flutter#163376)
2025-03-14 [email protected] Roll Packages from
9cc6f37 to ff7724c (1 revision) (flutter/flutter#165197)
2025-03-14 [email protected] Changelog updates
from 3.29.2 (flutter/flutter#165194)
2025-03-14 [email protected] Roll Dart SDK from
576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191)
2025-03-14 [email protected] Roll Dart SDK from
ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180)
2025-03-14 [email protected] Roll Fuchsia Linux SDK from
qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175)
2025-03-14 [email protected] [Impeller] Enable mediatek on API
34+. (flutter/flutter#165156)
2025-03-14 [email protected] Roll Dart SDK from
cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159)
2025-03-13 [email protected] [FGP conversion]
Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143)
2025-03-13 [email protected] Prevent explicit
roles from merging (flutter/flutter#164732)
...
vashworth pushed a commit to vashworth/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll @vashworth
Manual roll Flutter from b16430b to 1d954f4 (114 revisions) (flutter#…
88d5013 
…8922)

Manual roll Flutter from b16430b to 1d954f4 (114 revisions)

Manual roll requested by [email protected]

flutter/flutter@b16430b...1d954f4

2025-03-17 [email protected] Revert "[skwasm] Dynamic Threading
(#164748)" (flutter/flutter#165350)
2025-03-17 [email protected] Roll Skia from fa669e2e6d12
to 52130e5c3b34 (4 revisions) (flutter/flutter#165348)
2025-03-17 [email protected]
`OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal`
rebuilds. (flutter/flutter#165331)
2025-03-17 [email protected] [web][a11y]Delete
_childContainerElement (flutter/flutter#163662)
2025-03-17 [email protected] Roll Skia from e45207898e60
to fa669e2e6d12 (8 revisions) (flutter/flutter#165342)
2025-03-17 [email protected] Add documentation for Java test
filtering to plugins test document (flutter/flutter#165314)
2025-03-17 [email protected] Roll Fuchsia Linux SDK from
SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313)
2025-03-17 [email protected] Roll Dart SDK from
9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310)
2025-03-17 [email protected] feat(Tooltip): replace the height parameter
with constraints (flutter/flutter#163314)
2025-03-17 [email protected] Fix arrowHeadColor breaks differentiation
between states (flutter/flutter#165178)
2025-03-17 [email protected] Removes
assumption that basis scalar and rounded_scalar match
(flutter/flutter#165166)
2025-03-17 [email protected] Roll Skia from 69cf4c2c5db8
to e45207898e60 (1 revision) (flutter/flutter#165300)
2025-03-17 [email protected] Refactor: Move
sliders value indicator shape to seperate file (flutter/flutter#162858)
2025-03-17 [email protected] Roll Skia from 3931c31032c7
to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288)
2025-03-17 [email protected] Delete
`docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258)
2025-03-16 [email protected] Roll Skia from 3413a02d6fc8
to 3931c31032c7 (1 revision) (flutter/flutter#165277)
2025-03-16 [email protected] Roll Fuchsia Linux SDK from
LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275)
2025-03-16 [email protected] Roll Dart SDK from
067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269)
2025-03-16 [email protected] Roll Skia from f124daeb564d
to 3413a02d6fc8 (1 revision) (flutter/flutter#165263)
2025-03-15 [email protected] Roll Dart SDK from
40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262)
2025-03-15 [email protected] Roll Fuchsia Linux SDK from
efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252)
2025-03-15 [email protected] Roll Dart SDK from
f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250)
2025-03-15 [email protected] Roll Dart SDK from
8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246)
2025-03-15 [email protected] Roll Skia from 4568e766ed0a
to f124daeb564d (1 revision) (flutter/flutter#165245)
2025-03-15 [email protected] Revert "Prevent
explicit roles from merging (#164732)" (flutter/flutter#165222)
2025-03-15 [email protected] Roll Skia from bac6e76abfc7
to 4568e766ed0a (5 revisions) (flutter/flutter#165241)
2025-03-14 [email protected] Roll Dart SDK from
a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227)
2025-03-14 [email protected] Roll Skia from 98b6922deecf
to bac6e76abfc7 (5 revisions) (flutter/flutter#165225)
2025-03-14 [email protected] Point ktlint AS
docs to the `.editorconfig` that is actually used by ci, instead of
making a copy in the README (flutter/flutter#165213)
2025-03-14 [email protected] Add remaining dart fixes for Color
deprecations when importing painting.dart (flutter/flutter#162609)
2025-03-14 [email protected] [Accessibility]
Add required semantics flags (flutter/flutter#164585)
2025-03-14 [email protected] Roll Skia from f4467ff38f1f
to 98b6922deecf (5 revisions) (flutter/flutter#165215)
2025-03-14 [email protected] Convert `BaseFlutterTask` From Groovy
to Kotlin (flutter/flutter#163148)
2025-03-14 [email protected]
`OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034)
2025-03-14 [email protected] Remove redundant `useMaterial3: true`
(flutter/flutter#163376)
2025-03-14 [email protected] Roll Packages from
9cc6f37 to ff7724c (1 revision) (flutter/flutter#165197)
2025-03-14 [email protected] Changelog updates
from 3.29.2 (flutter/flutter#165194)
2025-03-14 [email protected] Roll Dart SDK from
576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191)
2025-03-14 [email protected] Roll Dart SDK from
ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180)
2025-03-14 [email protected] Roll Fuchsia Linux SDK from
qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175)
2025-03-14 [email protected] [Impeller] Enable mediatek on API
34+. (flutter/flutter#165156)
2025-03-14 [email protected] Roll Dart SDK from
cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159)
2025-03-13 [email protected] [FGP conversion]
Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143)
2025-03-13 [email protected] Prevent explicit
roles from merging (flutter/flutter#164732)
...
CodixNinja pushed a commit to CodixNinja/packages that referenced this pull request May 15, 2025
@engine-flutter-autoroll
Manual roll Flutter from b16430b2fd57 to 1d954f4e96bd (114 revisions)…
b6536bc 
… (#8922)

Manual roll Flutter from b16430b2fd57 to 1d954f4e96bd (114 revisions)

Manual roll requested by [email protected]

flutter/flutter@b16430b...1d954f4

2025-03-17 [email protected] Revert "[skwasm] Dynamic Threading
(#164748)" (flutter/flutter#165350)
2025-03-17 [email protected] Roll Skia from fa669e2e6d12
to 52130e5c3b34 (4 revisions) (flutter/flutter#165348)
2025-03-17 [email protected]
`OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal`
rebuilds. (flutter/flutter#165331)
2025-03-17 [email protected] [web][a11y]Delete
_childContainerElement (flutter/flutter#163662)
2025-03-17 [email protected] Roll Skia from e45207898e60
to fa669e2e6d12 (8 revisions) (flutter/flutter#165342)
2025-03-17 [email protected] Add documentation for Java test
filtering to plugins test document (flutter/flutter#165314)
2025-03-17 [email protected] Roll Fuchsia Linux SDK from
SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313)
2025-03-17 [email protected] Roll Dart SDK from
9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310)
2025-03-17 [email protected] feat(Tooltip): replace the height parameter
with constraints (flutter/flutter#163314)
2025-03-17 [email protected] Fix arrowHeadColor breaks differentiation
between states (flutter/flutter#165178)
2025-03-17 [email protected] Removes
assumption that basis scalar and rounded_scalar match
(flutter/flutter#165166)
2025-03-17 [email protected] Roll Skia from 69cf4c2c5db8
to e45207898e60 (1 revision) (flutter/flutter#165300)
2025-03-17 [email protected] Refactor: Move
sliders value indicator shape to seperate file (flutter/flutter#162858)
2025-03-17 [email protected] Roll Skia from 3931c31032c7
to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288)
2025-03-17 [email protected] Delete
`docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258)
2025-03-16 [email protected] Roll Skia from 3413a02d6fc8
to 3931c31032c7 (1 revision) (flutter/flutter#165277)
2025-03-16 [email protected] Roll Fuchsia Linux SDK from
LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275)
2025-03-16 [email protected] Roll Dart SDK from
067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269)
2025-03-16 [email protected] Roll Skia from f124daeb564d
to 3413a02d6fc8 (1 revision) (flutter/flutter#165263)
2025-03-15 [email protected] Roll Dart SDK from
40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262)
2025-03-15 [email protected] Roll Fuchsia Linux SDK from
efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252)
2025-03-15 [email protected] Roll Dart SDK from
f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250)
2025-03-15 [email protected] Roll Dart SDK from
8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246)
2025-03-15 [email protected] Roll Skia from 4568e766ed0a
to f124daeb564d (1 revision) (flutter/flutter#165245)
2025-03-15 [email protected] Revert "Prevent
explicit roles from merging (#164732)" (flutter/flutter#165222)
2025-03-15 [email protected] Roll Skia from bac6e76abfc7
to 4568e766ed0a (5 revisions) (flutter/flutter#165241)
2025-03-14 [email protected] Roll Dart SDK from
a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227)
2025-03-14 [email protected] Roll Skia from 98b6922deecf
to bac6e76abfc7 (5 revisions) (flutter/flutter#165225)
2025-03-14 [email protected] Point ktlint AS
docs to the `.editorconfig` that is actually used by ci, instead of
making a copy in the README (flutter/flutter#165213)
2025-03-14 [email protected] Add remaining dart fixes for Color
deprecations when importing painting.dart (flutter/flutter#162609)
2025-03-14 [email protected] [Accessibility]
Add required semantics flags (flutter/flutter#164585)
2025-03-14 [email protected] Roll Skia from f4467ff38f1f
to 98b6922deecf (5 revisions) (flutter/flutter#165215)
2025-03-14 [email protected] Convert `BaseFlutterTask` From Groovy
to Kotlin (flutter/flutter#163148)
2025-03-14 [email protected]
`OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034)
2025-03-14 [email protected] Remove redundant `useMaterial3: true`
(flutter/flutter#163376)
2025-03-14 [email protected] Roll Packages from
bdb9c96 to d632936 (1 revision) (flutter/flutter#165197)
2025-03-14 [email protected] Changelog updates
from 3.29.2 (flutter/flutter#165194)
2025-03-14 [email protected] Roll Dart SDK from
576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191)
2025-03-14 [email protected] Roll Dart SDK from
ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180)
2025-03-14 [email protected] Roll Fuchsia Linux SDK from
qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175)
2025-03-14 [email protected] [Impeller] Enable mediatek on API
34+. (flutter/flutter#165156)
2025-03-14 [email protected] Roll Dart SDK from
cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159)
2025-03-13 [email protected] [FGP conversion]
Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143)
2025-03-13 [email protected] Prevent explicit
roles from merging (flutter/flutter#164732)
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
9d2b6da feat(Tooltip): replace the height parameter with constraints (f…
b4796e8 
…lutter/flutter#163314)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
9d2b6da feat(Tooltip): replace the height parameter with constraints (f…
f3ace18 
…lutter/flutter#163314)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
9d2b6da feat(Tooltip): replace the height parameter with constraints (f…
ab51528 
…lutter/flutter#163314)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Manual roll Flutter from b16430b to 1d954f4 (114 revisions) (flutter#…
a06362c 
…8922)

Manual roll Flutter from b16430b to 1d954f4 (114 revisions)

Manual roll requested by [email protected]

flutter/flutter@b16430b...1d954f4

2025-03-17 [email protected] Revert "[skwasm] Dynamic Threading
(#164748)" (flutter/flutter#165350)
2025-03-17 [email protected] Roll Skia from fa669e2e6d12
to 52130e5c3b34 (4 revisions) (flutter/flutter#165348)
2025-03-17 [email protected]
`OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal`
rebuilds. (flutter/flutter#165331)
2025-03-17 [email protected] [web][a11y]Delete
_childContainerElement (flutter/flutter#163662)
2025-03-17 [email protected] Roll Skia from e45207898e60
to fa669e2e6d12 (8 revisions) (flutter/flutter#165342)
2025-03-17 [email protected] Add documentation for Java test
filtering to plugins test document (flutter/flutter#165314)
2025-03-17 [email protected] Roll Fuchsia Linux SDK from
SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313)
2025-03-17 [email protected] Roll Dart SDK from
9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310)
2025-03-17 [email protected] feat(Tooltip): replace the height parameter
with constraints (flutter/flutter#163314)
2025-03-17 [email protected] Fix arrowHeadColor breaks differentiation
between states (flutter/flutter#165178)
2025-03-17 [email protected] Removes
assumption that basis scalar and rounded_scalar match
(flutter/flutter#165166)
2025-03-17 [email protected] Roll Skia from 69cf4c2c5db8
to e45207898e60 (1 revision) (flutter/flutter#165300)
2025-03-17 [email protected] Refactor: Move
sliders value indicator shape to seperate file (flutter/flutter#162858)
2025-03-17 [email protected] Roll Skia from 3931c31032c7
to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288)
2025-03-17 [email protected] Delete
`docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258)
2025-03-16 [email protected] Roll Skia from 3413a02d6fc8
to 3931c31032c7 (1 revision) (flutter/flutter#165277)
2025-03-16 [email protected] Roll Fuchsia Linux SDK from
LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275)
2025-03-16 [email protected] Roll Dart SDK from
067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269)
2025-03-16 [email protected] Roll Skia from f124daeb564d
to 3413a02d6fc8 (1 revision) (flutter/flutter#165263)
2025-03-15 [email protected] Roll Dart SDK from
40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262)
2025-03-15 [email protected] Roll Fuchsia Linux SDK from
efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252)
2025-03-15 [email protected] Roll Dart SDK from
f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250)
2025-03-15 [email protected] Roll Dart SDK from
8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246)
2025-03-15 [email protected] Roll Skia from 4568e766ed0a
to f124daeb564d (1 revision) (flutter/flutter#165245)
2025-03-15 [email protected] Revert "Prevent
explicit roles from merging (#164732)" (flutter/flutter#165222)
2025-03-15 [email protected] Roll Skia from bac6e76abfc7
to 4568e766ed0a (5 revisions) (flutter/flutter#165241)
2025-03-14 [email protected] Roll Dart SDK from
a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227)
2025-03-14 [email protected] Roll Skia from 98b6922deecf
to bac6e76abfc7 (5 revisions) (flutter/flutter#165225)
2025-03-14 [email protected] Point ktlint AS
docs to the `.editorconfig` that is actually used by ci, instead of
making a copy in the README (flutter/flutter#165213)
2025-03-14 [email protected] Add remaining dart fixes for Color
deprecations when importing painting.dart (flutter/flutter#162609)
2025-03-14 [email protected] [Accessibility]
Add required semantics flags (flutter/flutter#164585)
2025-03-14 [email protected] Roll Skia from f4467ff38f1f
to 98b6922deecf (5 revisions) (flutter/flutter#165215)
2025-03-14 [email protected] Convert `BaseFlutterTask` From Groovy
to Kotlin (flutter/flutter#163148)
2025-03-14 [email protected]
`OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034)
2025-03-14 [email protected] Remove redundant `useMaterial3: true`
(flutter/flutter#163376)
2025-03-14 [email protected] Roll Packages from
9cc6f37 to ff7724c (1 revision) (flutter/flutter#165197)
2025-03-14 [email protected] Changelog updates
from 3.29.2 (flutter/flutter#165194)
2025-03-14 [email protected] Roll Dart SDK from
576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191)
2025-03-14 [email protected] Roll Dart SDK from
ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180)
2025-03-14 [email protected] Roll Fuchsia Linux SDK from
qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175)
2025-03-14 [email protected] [Impeller] Enable mediatek on API
34+. (flutter/flutter#165156)
2025-03-14 [email protected] Roll Dart SDK from
cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159)
2025-03-13 [email protected] [FGP conversion]
Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143)
2025-03-13 [email protected] Prevent explicit
roles from merging (flutter/flutter#164732)
...
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Manual roll Flutter from b16430b to 1d954f4 (114 revisions) (flutter#…
19d634b 
…8922)

Manual roll Flutter from b16430b to 1d954f4 (114 revisions)

Manual roll requested by [email protected]

flutter/flutter@b16430b...1d954f4

2025-03-17 [email protected] Revert "[skwasm] Dynamic Threading
(#164748)" (flutter/flutter#165350)
2025-03-17 [email protected] Roll Skia from fa669e2e6d12
to 52130e5c3b34 (4 revisions) (flutter/flutter#165348)
2025-03-17 [email protected]
`OverlayPortal.childLayoutBuilder` should rebuild when `OverlayPortal`
rebuilds. (flutter/flutter#165331)
2025-03-17 [email protected] [web][a11y]Delete
_childContainerElement (flutter/flutter#163662)
2025-03-17 [email protected] Roll Skia from e45207898e60
to fa669e2e6d12 (8 revisions) (flutter/flutter#165342)
2025-03-17 [email protected] Add documentation for Java test
filtering to plugins test document (flutter/flutter#165314)
2025-03-17 [email protected] Roll Fuchsia Linux SDK from
SDNQgVXxHbbd0qsVw... to mPniqXmPpXqMMpM8z... (flutter/flutter#165313)
2025-03-17 [email protected] Roll Dart SDK from
9283d47199b7 to 725172afbc42 (1 revision) (flutter/flutter#165310)
2025-03-17 [email protected] feat(Tooltip): replace the height parameter
with constraints (flutter/flutter#163314)
2025-03-17 [email protected] Fix arrowHeadColor breaks differentiation
between states (flutter/flutter#165178)
2025-03-17 [email protected] Removes
assumption that basis scalar and rounded_scalar match
(flutter/flutter#165166)
2025-03-17 [email protected] Roll Skia from 69cf4c2c5db8
to e45207898e60 (1 revision) (flutter/flutter#165300)
2025-03-17 [email protected] Refactor: Move
sliders value indicator shape to seperate file (flutter/flutter#162858)
2025-03-17 [email protected] Roll Skia from 3931c31032c7
to 69cf4c2c5db8 (1 revision) (flutter/flutter#165288)
2025-03-17 [email protected] Delete
`docs/infra/Infra-Ticket-Queue.md` (flutter/flutter#165258)
2025-03-16 [email protected] Roll Skia from 3413a02d6fc8
to 3931c31032c7 (1 revision) (flutter/flutter#165277)
2025-03-16 [email protected] Roll Fuchsia Linux SDK from
LPz5j18JDsms41r3T... to SDNQgVXxHbbd0qsVw... (flutter/flutter#165275)
2025-03-16 [email protected] Roll Dart SDK from
067560bcd521 to 9283d47199b7 (1 revision) (flutter/flutter#165269)
2025-03-16 [email protected] Roll Skia from f124daeb564d
to 3413a02d6fc8 (1 revision) (flutter/flutter#165263)
2025-03-15 [email protected] Roll Dart SDK from
40bb66a945e4 to 067560bcd521 (1 revision) (flutter/flutter#165262)
2025-03-15 [email protected] Roll Fuchsia Linux SDK from
efdpJgW4DIV6j1mO1... to LPz5j18JDsms41r3T... (flutter/flutter#165252)
2025-03-15 [email protected] Roll Dart SDK from
f23d496f0585 to 40bb66a945e4 (1 revision) (flutter/flutter#165250)
2025-03-15 [email protected] Roll Dart SDK from
8814749ec6a4 to f23d496f0585 (1 revision) (flutter/flutter#165246)
2025-03-15 [email protected] Roll Skia from 4568e766ed0a
to f124daeb564d (1 revision) (flutter/flutter#165245)
2025-03-15 [email protected] Revert "Prevent
explicit roles from merging (#164732)" (flutter/flutter#165222)
2025-03-15 [email protected] Roll Skia from bac6e76abfc7
to 4568e766ed0a (5 revisions) (flutter/flutter#165241)
2025-03-14 [email protected] Roll Dart SDK from
a51f1bfa0f6a to 8814749ec6a4 (2 revisions) (flutter/flutter#165227)
2025-03-14 [email protected] Roll Skia from 98b6922deecf
to bac6e76abfc7 (5 revisions) (flutter/flutter#165225)
2025-03-14 [email protected] Point ktlint AS
docs to the `.editorconfig` that is actually used by ci, instead of
making a copy in the README (flutter/flutter#165213)
2025-03-14 [email protected] Add remaining dart fixes for Color
deprecations when importing painting.dart (flutter/flutter#162609)
2025-03-14 [email protected] [Accessibility]
Add required semantics flags (flutter/flutter#164585)
2025-03-14 [email protected] Roll Skia from f4467ff38f1f
to 98b6922deecf (5 revisions) (flutter/flutter#165215)
2025-03-14 [email protected] Convert `BaseFlutterTask` From Groovy
to Kotlin (flutter/flutter#163148)
2025-03-14 [email protected]
`OverlayPortal.overlayChildLayoutBuilder` (flutter/flutter#164034)
2025-03-14 [email protected] Remove redundant `useMaterial3: true`
(flutter/flutter#163376)
2025-03-14 [email protected] Roll Packages from
9cc6f37 to ff7724c (1 revision) (flutter/flutter#165197)
2025-03-14 [email protected] Changelog updates
from 3.29.2 (flutter/flutter#165194)
2025-03-14 [email protected] Roll Dart SDK from
576514b2bfce to a51f1bfa0f6a (1 revision) (flutter/flutter#165191)
2025-03-14 [email protected] Roll Dart SDK from
ceb58442306e to 576514b2bfce (2 revisions) (flutter/flutter#165180)
2025-03-14 [email protected] Roll Fuchsia Linux SDK from
qXOLczyRJadxMW0PK... to efdpJgW4DIV6j1mO1... (flutter/flutter#165175)
2025-03-14 [email protected] [Impeller] Enable mediatek on API
34+. (flutter/flutter#165156)
2025-03-14 [email protected] Roll Dart SDK from
cd06d4ba4fec to ceb58442306e (5 revisions) (flutter/flutter#165159)
2025-03-13 [email protected] [FGP conversion]
Port `FlutterExtension` from Groovy to Kotlin (flutter/flutter#165143)
2025-03-13 [email protected] Prevent explicit
roles from merging (flutter/flutter#164732)
...
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@kszczek @romanejaquez
feat(Tooltip): replace the height parameter with constraints (flutter…
6fd5a73 
…#163314)

Introduce a new `constraints` parameter, which constrains the size of
the tooltip's message and deprecate the now obsolete `height` parameter.
Do the same for the theme data, while also making some minor changes to
the docs to clear up some misconceptions about which properties apply to
the tooltip's message and which to the tooltip's child.

To make the transition from `height` to `constraints` as easy as
possible for our users, introduce fix data to do this replacement
automatically in the IDE.

Closes: flutter#163313

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

@Piinks Piinks Piinks approved these changes

@chunhtai chunhtai Awaiting requested review from chunhtai

Assignees

No one assigned

Labels

c: tech-debt Technical debt, code quality, testing, etc. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tooltips should have customizable constraints

5 participants

@kszczek @Piinks @dkwingsmt @gspencergoog @chunhtai