Skip to content

[flutter_tools] remove SkSL target for iOS builds. #163144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Feb 13, 2025
Merged

[flutter_tools] remove SkSL target for iOS builds. #163144

auto-submit merged 1 commit into from
Feb 13, 2025

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Feb 12, 2025 •
edited
Loading

Skia is no longer supported on iOS targets, so runtime shaders don't need to bundle SkSL.

Fixes #138919

@jonahwilliams jonahwilliams requested a review from bkonyi February 12, 2025 17:51
@github-actions github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. team-ios Owned by iOS platform team labels Feb 12, 2025
@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 13, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 13, 2025
Merged via the queue into flutter:master with commit a7c6cc1 Feb 13, 2025
140 of 141 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 13, 2025
@jonahwilliams jonahwilliams deleted the remove_sksl_2 branch February 13, 2025 01:46
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
a7c6cc1 [flutter_tools] remove SkSL target for iOS builds. (flutter/f…
392c1f9 
…lutter#163144)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
a7c6cc1 [flutter_tools] remove SkSL target for iOS builds. (flutter/f…
5cc78f2 
…lutter#163144)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
a7c6cc1 [flutter_tools] remove SkSL target for iOS builds. (flutter/f…
64139b2 
…lutter#163144)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
a7c6cc1 [flutter_tools] remove SkSL target for iOS builds. (flutter/f…
538293a 
…lutter#163144)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
a7c6cc1 [flutter_tools] remove SkSL target for iOS builds. (flutter/f…
80935cd 
…lutter#163144)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
a7c6cc1 [flutter_tools] remove SkSL target for iOS builds. (flutter/f…
c084b1a 
…lutter#163144)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
a7c6cc1 [flutter_tools] remove SkSL target for iOS builds. (flutter/f…
8b0c33f 
…lutter#163144)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
a7c6cc1 [flutter_tools] remove SkSL target for iOS builds. (flutter/f…
7f1a0e7 
…lutter#163144)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025
@engine-flutter-autoroll
a7c6cc1 [flutter_tools] remove SkSL target for iOS builds. (flutter/f…
cced819 
…lutter#163144)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025
@engine-flutter-autoroll
a7c6cc1 [flutter_tools] remove SkSL target for iOS builds. (flutter/f…
cc8c89c 
…lutter#163144)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025
@engine-flutter-autoroll
a7c6cc1 [flutter_tools] remove SkSL target for iOS builds. (flutter/f…
4a7e235 
…lutter#163144)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025
@engine-flutter-autoroll
a7c6cc1 [flutter_tools] remove SkSL target for iOS builds. (flutter/f…
22e4cc1 
…lutter#163144)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
a7c6cc1 [flutter_tools] remove SkSL target for iOS builds. (flutter/f…
97a9302 
…lutter#163144)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
a7c6cc1 [flutter_tools] remove SkSL target for iOS builds. (flutter/f…
1be2580 
…lutter#163144)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
a7c6cc1 [flutter_tools] remove SkSL target for iOS builds. (flutter/f…
7aaf4d7 
…lutter#163144)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025
@engine-flutter-autoroll
a7c6cc1 [flutter_tools] remove SkSL target for iOS builds. (flutter/f…
a4d780f 
…lutter#163144)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025
@engine-flutter-autoroll
a7c6cc1 [flutter_tools] remove SkSL target for iOS builds. (flutter/f…
3598af7 
…lutter#163144)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025
@engine-flutter-autoroll
a7c6cc1 [flutter_tools] remove SkSL target for iOS builds. (flutter/f…
949f650 
…lutter#163144)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025
@engine-flutter-autoroll
a7c6cc1 [flutter_tools] remove SkSL target for iOS builds. (flutter/f…
4e9c638 
…lutter#163144)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025
@engine-flutter-autoroll
a7c6cc1 [flutter_tools] remove SkSL target for iOS builds. (flutter/f…
3e5fb15 
…lutter#163144)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025
@engine-flutter-autoroll
a7c6cc1 [flutter_tools] remove SkSL target for iOS builds. (flutter/f…
78d7eb5 
…lutter#163144)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
a7c6cc1 [flutter_tools] remove SkSL target for iOS builds. (flutter/f…
2f9c48c 
…lutter#163144)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
a7c6cc1 [flutter_tools] remove SkSL target for iOS builds. (flutter/f…
de004a4 
…lutter#163144)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
a7c6cc1 [flutter_tools] remove SkSL target for iOS builds. (flutter/f…
ed7b6b9 
…lutter#163144)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
a7c6cc1 [flutter_tools] remove SkSL target for iOS builds. (flutter/f…
73f4c87 
…lutter#163144)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
a7c6cc1 [flutter_tools] remove SkSL target for iOS builds. (flutter/f…
b368321 
…lutter#163144)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
a7c6cc1 [flutter_tools] remove SkSL target for iOS builds. (flutter/f…
7a35a7b 
…lutter#163144)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
a7c6cc1 [flutter_tools] remove SkSL target for iOS builds. (flutter/f…
6dc266a 
…lutter#163144)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkonyi bkonyi bkonyi approved these changes

Assignees

No one assigned

Labels

team-ios Owned by iOS platform team tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Impeller] impellerc should make it opt-in to bundle SkSL for platforms that do not have a Skia fallback

2 participants

@jonahwilliams @bkonyi