Skip to content

[Impeller] In Paint::CreateContents, do not set a color source size if the size is empty #163099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Feb 12, 2025
Merged

[Impeller] In Paint::CreateContents, do not set a color source size if the size is empty #163099

auto-submit merged 2 commits into from
Feb 12, 2025

Conversation

@jason-simmons
Copy link
Member

@jason-simmons jason-simmons commented Feb 12, 2025

The Canvas::DrawVertices lazy texture function will be unable to create a snapshot based on an empty color source size.

See #162969

@jason-simmons
[Impeller] In Paint::CreateContents, do not set a color source size i…
7a4b9c0 
…f the size is empty

The Canvas::DrawVertices lazy texture function will be unable to create a
snapshot based on an empty color source size.

See flutter#162969
@github-actions github-actions bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Feb 12, 2025
jonahwilliams
jonahwilliams approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This change is necessary, but I suspect we should also update the color source size logic. I think every gradient (at least) should be forced to have a min dimension of 1x1. That can be done separately.

@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 12, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 12, 2025
Merged via the queue into flutter:master with commit 0f801f8 Feb 12, 2025
179 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 12, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
0f801f8 [Impeller] In Paint::CreateContents, do not set a color sourc…
94a8c3b 
…e size if the size is empty (flutter/flutter#163099)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
0f801f8 [Impeller] In Paint::CreateContents, do not set a color sourc…
b38dfcc 
…e size if the size is empty (flutter/flutter#163099)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
0f801f8 [Impeller] In Paint::CreateContents, do not set a color sourc…
87b31fe 
…e size if the size is empty (flutter/flutter#163099)
jason-simmons added a commit to jason-simmons/flutter that referenced this pull request Feb 13, 2025
@jason-simmons
[CP] Fixes for Impeller DrawVertices issues involving snapshots with …
0a5f7d5 
…empty sizes

See flutter#162969

Includes flutter#163099 and flutter#163177
@jason-simmons jason-simmons mentioned this pull request Feb 13, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
0f801f8 [Impeller] In Paint::CreateContents, do not set a color sourc…
4bec57a 
…e size if the size is empty (flutter/flutter#163099)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
0f801f8 [Impeller] In Paint::CreateContents, do not set a color sourc…
795a613 
…e size if the size is empty (flutter/flutter#163099)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
0f801f8 [Impeller] In Paint::CreateContents, do not set a color sourc…
d91c34e 
…e size if the size is empty (flutter/flutter#163099)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
0f801f8 [Impeller] In Paint::CreateContents, do not set a color sourc…
4ee326f 
…e size if the size is empty (flutter/flutter#163099)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2025
@engine-flutter-autoroll
0f801f8 [Impeller] In Paint::CreateContents, do not set a color sourc…
451ef69 
…e size if the size is empty (flutter/flutter#163099)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025
@engine-flutter-autoroll
0f801f8 [Impeller] In Paint::CreateContents, do not set a color sourc…
c0fc6fa 
…e size if the size is empty (flutter/flutter#163099)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2025
@engine-flutter-autoroll
0f801f8 [Impeller] In Paint::CreateContents, do not set a color sourc…
f8edf81 
…e size if the size is empty (flutter/flutter#163099)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025
@engine-flutter-autoroll
0f801f8 [Impeller] In Paint::CreateContents, do not set a color sourc…
f1bbe37 
…e size if the size is empty (flutter/flutter#163099)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2025
@engine-flutter-autoroll
0f801f8 [Impeller] In Paint::CreateContents, do not set a color sourc…
a83e947 
…e size if the size is empty (flutter/flutter#163099)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
0f801f8 [Impeller] In Paint::CreateContents, do not set a color sourc…
dc7ab56 
…e size if the size is empty (flutter/flutter#163099)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
0f801f8 [Impeller] In Paint::CreateContents, do not set a color sourc…
fe4339e 
…e size if the size is empty (flutter/flutter#163099)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 17, 2025
@engine-flutter-autoroll
0f801f8 [Impeller] In Paint::CreateContents, do not set a color sourc…
aa6b880 
…e size if the size is empty (flutter/flutter#163099)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025
@engine-flutter-autoroll
0f801f8 [Impeller] In Paint::CreateContents, do not set a color sourc…
a634375 
…e size if the size is empty (flutter/flutter#163099)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025
@engine-flutter-autoroll
0f801f8 [Impeller] In Paint::CreateContents, do not set a color sourc…
d608e4d 
…e size if the size is empty (flutter/flutter#163099)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 18, 2025
@engine-flutter-autoroll
0f801f8 [Impeller] In Paint::CreateContents, do not set a color sourc…
2728dd4 
…e size if the size is empty (flutter/flutter#163099)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025
@engine-flutter-autoroll
0f801f8 [Impeller] In Paint::CreateContents, do not set a color sourc…
4be05ac 
…e size if the size is empty (flutter/flutter#163099)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025
@engine-flutter-autoroll
0f801f8 [Impeller] In Paint::CreateContents, do not set a color sourc…
763b6f0 
…e size if the size is empty (flutter/flutter#163099)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 19, 2025
@engine-flutter-autoroll
0f801f8 [Impeller] In Paint::CreateContents, do not set a color sourc…
68e2d16 
…e size if the size is empty (flutter/flutter#163099)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
0f801f8 [Impeller] In Paint::CreateContents, do not set a color sourc…
8e7ac23 
…e size if the size is empty (flutter/flutter#163099)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
0f801f8 [Impeller] In Paint::CreateContents, do not set a color sourc…
c5694bf 
…e size if the size is empty (flutter/flutter#163099)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
0f801f8 [Impeller] In Paint::CreateContents, do not set a color sourc…
caaff69 
…e size if the size is empty (flutter/flutter#163099)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
0f801f8 [Impeller] In Paint::CreateContents, do not set a color sourc…
378266d 
…e size if the size is empty (flutter/flutter#163099)
auto-submit bot pushed a commit that referenced this pull request Feb 26, 2025
@jason-simmons
[CP] Fixes for Impeller DrawVertices issues involving snapshots with …
836b6fd 
…empty sizes (#163261)

See #162969

Includes #163099 and #163177
Fintasys pushed a commit to Fintasys/flutter that referenced this pull request May 14, 2025
@jason-simmons @Fintasys
[CP] Fixes for Impeller DrawVertices issues involving snapshots with …
de61a34 
…empty sizes (flutter#163261)

See flutter#162969

Includes flutter#163099 and flutter#163177
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
0f801f8 [Impeller] In Paint::CreateContents, do not set a color sourc…
105c913 
…e size if the size is empty (flutter/flutter#163099)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
0f801f8 [Impeller] In Paint::CreateContents, do not set a color sourc…
63c73b4 
…e size if the size is empty (flutter/flutter#163099)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
0f801f8 [Impeller] In Paint::CreateContents, do not set a color sourc…
18a8ac7 
…e size if the size is empty (flutter/flutter#163099)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jason-simmons @jonahwilliams